Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-31 Thread Rainer Orth
Hi Jeff, > On 3/26/19 4:49 PM, Rainer Orth wrote: >> Hi Jakub, >> >>> On Mon, Mar 25, 2019 at 11:41:35AM -0600, Jeff Law wrote: > PR c/89812 - incorrect maximum in error: requested alignment > ‘536870912’ exceeds maximum 2147483648 > > gcc/c-family/ChangeLog: > > PR

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-29 Thread Jeff Law
On 3/26/19 4:49 PM, Rainer Orth wrote: > Hi Jakub, > >> On Mon, Mar 25, 2019 at 11:41:35AM -0600, Jeff Law wrote: PR c/89812 - incorrect maximum in error: requested alignment ‘536870912’ exceeds maximum 2147483648 gcc/c-family/ChangeLog: PR c/89812 * c-

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-29 Thread Jeff Law
On 3/26/19 9:29 AM, Jakub Jelinek wrote: > On Mon, Mar 25, 2019 at 11:41:35AM -0600, Jeff Law wrote: >>> PR c/89812 - incorrect maximum in error: requested alignment >>> ‘536870912’ exceeds maximum 2147483648 >>> >>> gcc/c-family/ChangeLog: >>> >>> PR c/89812 >>> * c-common.c (check_us

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-26 Thread Rainer Orth
Hi Jakub, > On Mon, Mar 25, 2019 at 11:41:35AM -0600, Jeff Law wrote: >> > PR c/89812 - incorrect maximum in error: requested alignment >> > ‘536870912’ exceeds maximum 2147483648 >> > >> > gcc/c-family/ChangeLog: >> > >> >PR c/89812 >> >* c-common.c (check_user_alignment): Rename lo

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-26 Thread Jakub Jelinek
On Mon, Mar 25, 2019 at 11:41:35AM -0600, Jeff Law wrote: > > PR c/89812 - incorrect maximum in error: requested alignment > > ‘536870912’ exceeds maximum 2147483648 > > > > gcc/c-family/ChangeLog: > > > > PR c/89812 > > * c-common.c (check_user_alignment): Rename local. Correct max

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-25 Thread Martin Sebor
On 3/25/19 11:14 AM, Jeff Law wrote: On 3/25/19 11:04 AM, Martin Sebor wrote: On 3/25/19 10:07 AM, Jeff Law wrote: On 3/24/19 6:21 PM, Martin Sebor wrote: The error issued when the aligned attribute argument is too big to be represented is incorrect: it says the maximum alignment is 1U << 31 w

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-25 Thread Jeff Law
On 3/24/19 6:21 PM, Martin Sebor wrote: > The error issued when the aligned attribute argument is too big > to be represented is incorrect: it says the maximum alignment > is 1U << 31 when it should actually be 1 << 28.  This was a typo > introduced when the error message was enhanced earlier in GC

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-25 Thread Jeff Law
On 3/25/19 11:04 AM, Martin Sebor wrote: > On 3/25/19 10:07 AM, Jeff Law wrote: >> On 3/24/19 6:21 PM, Martin Sebor wrote: >>> The error issued when the aligned attribute argument is too big >>> to be represented is incorrect: it says the maximum alignment >>> is 1U << 31 when it should actually be

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-25 Thread Martin Sebor
On 3/25/19 10:07 AM, Jeff Law wrote: On 3/24/19 6:21 PM, Martin Sebor wrote: The error issued when the aligned attribute argument is too big to be represented is incorrect: it says the maximum alignment is 1U << 31 when it should actually be 1 << 28.  This was a typo introduced when the error me

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-25 Thread Paul Koning
> On Mar 25, 2019, at 12:07 PM, Jeff Law wrote: > >> ... >> 1) Does GCC support building with compilers where int is not 32 >>bits wide, or where BITS_PER_UNIT is not 3? (I.e., either is >>less or more?) > We've certainly supported 16 bit ints in the past. H8/300 would be an > example

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-25 Thread Jeff Law
On 3/24/19 6:21 PM, Martin Sebor wrote: > The error issued when the aligned attribute argument is too big > to be represented is incorrect: it says the maximum alignment > is 1U << 31 when it should actually be 1 << 28.  This was a typo > introduced when the error message was enhanced earlier in GC

Re: [PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-25 Thread Paul Koning
> On Mar 24, 2019, at 8:21 PM, Martin Sebor wrote: > > ... > PS I have a couple of questions related to the affected code: > 1) Does GCC support building with compilers where int is not 32 > bits wide, or where BITS_PER_UNIT is not 3? (I.e., either is > less or more?) Yes. pdp11 int can

[PATCH] correct maximum valid alignment in error message (PR 89812)

2019-03-24 Thread Martin Sebor
The error issued when the aligned attribute argument is too big to be represented is incorrect: it says the maximum alignment is 1U << 31 when it should actually be 1 << 28. This was a typo introduced when the error message was enhanced earlier in GCC 9. The test I added to verify the fix for th