Re: [PATCH] cobol: Avoid conflict with OVERFLOW in system headers [PR119217]

2025-04-13 Thread Rainer Orth
Hi Simon, > >> Shouldn't that be >> >> --- a/gcc/cobol/parse.y >> +++ b/gcc/cobol/parse.y >> @@ -337,7 +337,7 @@ >> %token INVALID >> %token NUMBER NEGATIVE >> %token NUMSTR"numeric literal" >> -%token OVERFLOW >> +%token OVERFLOW_kw "OVERFLOW" >>

Re: [PATCH] cobol: Avoid conflict with OVERFLOW in system headers [PR119217]

2025-04-11 Thread Rainer Orth
Hi Simon, > Shouldn't that be > > --- a/gcc/cobol/parse.y > +++ b/gcc/cobol/parse.y > @@ -337,7 +337,7 @@ > %token INVALID > %token NUMBER NEGATIVE > %token NUMSTR"numeric literal" > -%token OVERFLOW > +%token OVERFLOW_kw "OVERFLOW" > %token C

Re: [PATCH] cobol: Avoid conflict with OVERFLOW in system headers [PR119217]

2025-04-11 Thread Simon Sobisch
Shouldn't that be --- a/gcc/cobol/parse.y +++ b/gcc/cobol/parse.y @@ -337,7 +337,7 @@ %token INVALID %token NUMBER NEGATIVE %token NUMSTR"numeric literal" -%token OVERFLOW +%token OVERFLOW_kw "OVERFLOW" %token COMPUTATIONAL ? Otherwise biso

Re: [PATCH] cobol: Avoid conflict with OVERFLOW in system headers [PR119217]

2025-04-11 Thread Richard Biener
On Fri, Apr 11, 2025 at 11:03 AM Rainer Orth wrote: > > parse.h causes the COBOL build to break on Solaris: > > cobol/parse.h:356:5: error: expected identifier before numeric constant > 356 | OVERFLOW = 305,/* OVERFLOW */ > | ^~~~ > > The problem is that has >

[PATCH] cobol: Avoid conflict with OVERFLOW in system headers [PR119217]

2025-04-11 Thread Rainer Orth
parse.h causes the COBOL build to break on Solaris: cobol/parse.h:356:5: error: expected identifier before numeric constant 356 | OVERFLOW = 305,/* OVERFLOW */ | ^~~~ The problem is that has #define OVERFLOW3 To avoid the conflict, this patch renam