Re: [PATCH] c++: Fix self-mapping in map_arguments [PR96531, PR97103]

2020-09-18 Thread Jason Merrill via Gcc-patches
MPLATE_PARM_P handling, which allows us to simply pass 'p' to template_parm_to_arg from map_arguments. Bootstrapped and regtested on x86_64-pc-linux-gnu and tested on cmcstl2 and range-v3. OK, thanks. -- >8 -- Subject: [PATCH] c++: Fix self-mapping in map_arguments [PR96531, PR97103

Re: [PATCH] c++: Fix self-mapping in map_arguments [PR96531, PR97103]

2020-09-18 Thread Patrick Palka via Gcc-patches
gt; > > Doesn't passing 'p' to template_parm_to_arg work? > > Unfortunately not, template_parm_to_arg expects a TREE_LIST node whose > TREE_VALUE is the corresponding *_DECL for the template parm (i.e. it > expects node from current_template_parms), an

Re: [PATCH] c++: Fix self-mapping in map_arguments [PR96531, PR97103]

2020-09-18 Thread Patrick Palka via Gcc-patches
On Fri, 18 Sep 2020, Jason Merrill wrote: > On 9/18/20 4:07 PM, Patrick Palka wrote: > > With r10-8077 we stopped passing the argified current_template_parms to > > normalize_constraint_expression from finish_nested_requirement, and > > instead tweaked map_arguments to perform a self-mapping of pa

Re: [PATCH] c++: Fix self-mapping in map_arguments [PR96531, PR97103]

2020-09-18 Thread Jason Merrill via Gcc-patches
On 9/18/20 4:07 PM, Patrick Palka wrote: With r10-8077 we stopped passing the argified current_template_parms to normalize_constraint_expression from finish_nested_requirement, and instead tweaked map_arguments to perform a self-mapping of parameters when args is NULL. We're currently not handli

[PATCH] c++: Fix self-mapping in map_arguments [PR96531, PR97103]

2020-09-18 Thread Patrick Palka via Gcc-patches
With r10-8077 we stopped passing the argified current_template_parms to normalize_constraint_expression from finish_nested_requirement, and instead tweaked map_arguments to perform a self-mapping of parameters when args is NULL. We're currently not handling parameter packs and BOUND_TEMPLATE_TEMPL