Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-22 Thread Philipp Tomsich
After reviewing the entire dependencies to get this enabled by default, our current plan is as follows: 1. Send a v2 (there still were outstanding comments against some testcases) of the "turn on by default for -O2" patch. 2. Address PR118873, PR119862, and PR119884 before merging the patch that tu

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-21 Thread Richard Biener
On Fri, Apr 18, 2025 at 4:51 PM Jeff Law wrote: > > > > On 4/18/25 2:43 AM, Philipp Tomsich wrote: > > Applied to trunk (16.0.0), thank you! > > Should this be backported to the GCC-15 release branch as well? > We don't have this on by default on the branch and it's a new option, so > one could ma

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-19 Thread Jeff Law
On 4/18/25 4:37 PM, Sam James wrote: Philipp Tomsich writes: Applied to trunk (16.0.0), thank you! Should this be backported to the GCC-15 release branch as well? BTW, what's the plan for enabling this on trunk now by default? (I don't recall if some other issues were left.) There's alr

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-18 Thread Sam James
Philipp Tomsich writes: > Applied to trunk (16.0.0), thank you! > Should this be backported to the GCC-15 release branch as well? BTW, what's the plan for enabling this on trunk now by default? (I don't recall if some other issues were left.)

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-18 Thread Jeff Law
On 4/18/25 2:43 AM, Philipp Tomsich wrote: Applied to trunk (16.0.0), thank you! Should this be backported to the GCC-15 release branch as well? We don't have this on by default on the branch and it's a new option, so one could make the argument it's not a regression and inappropriate. But o

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-18 Thread Philipp Tomsich
Applied to trunk (16.0.0), thank you! Should this be backported to the GCC-15 release branch as well? --Philipp. On Mon, 31 Mar 2025 at 10:10, Philipp Tomsich wrote: > > Jeff, > > > On Sun, 30 Mar 2025 at 01:48, Jeff Law wrote: > > > > > > > > On 3/28/25 5:12 AM, Konstantinos Eleftheriou wrote:

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-05 Thread Philipp Tomsich
Jeff, On Sun, 30 Mar 2025 at 01:48, Jeff Law wrote: > > > > On 3/28/25 5:12 AM, Konstantinos Eleftheriou wrote: > > In the case that we are eliminating the load instruction, we use zero_extend > > for the initialization of the base register for the zero-offset store. > > This causes issues when

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-03-29 Thread Jeff Law
On 3/28/25 5:12 AM, Konstantinos Eleftheriou wrote: In the case that we are eliminating the load instruction, we use zero_extend for the initialization of the base register for the zero-offset store. This causes issues when the store and the load use the same mode, as we are trying to generate

[PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-03-28 Thread Konstantinos Eleftheriou
In the case that we are eliminating the load instruction, we use zero_extend for the initialization of the base register for the zero-offset store. This causes issues when the store and the load use the same mode, as we are trying to generate a zero_extend with the same inner and outer modes. This