RE: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-12 Thread Li, Pan2 via Gcc-patches
Committed, thanks Jeff. Pan -Original Message- From: Gcc-patches On Behalf Of Jeff Law via Gcc-patches Sent: Tuesday, June 13, 2023 3:54 AM To: juzhe.zh...@rivai.ai; Robin Dapp ; gcc-patches Cc: Kito.cheng ; palmer Subject: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT

Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-12 Thread Jeff Law via Gcc-patches
On 6/12/23 03:58, juzhe.zh...@rivai.ai wrote: I'd like you to defer to you commit my patch with your test (Jeff has approved my patch, just feel free to commit). Then let's go with that. Juzhe's patch + Robin's test. jeff

Re: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-12 Thread Kito Cheng via Gcc-patches
; juzhe.zh...@rivai.ai > > From: Robin Dapp > Date: 2023-06-12 17:51 > To: 钟居哲; gcc-patches > CC: rdapp.gcc; kito.cheng; palmer; Jeff Law > Subject: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement > > + (VNx16QI "TARGET_MIN_VLEN <= 128") &

Re: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-12 Thread juzhe.zh...@rivai.ai
/2023-February/612574.html juzhe.zh...@rivai.ai From: Robin Dapp Date: 2023-06-12 17:51 To: 钟居哲; gcc-patches CC: rdapp.gcc; kito.cheng; palmer; Jeff Law Subject: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement > + (VNx16QI "TARGET_MIN_VLEN <= 128

Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-12 Thread Robin Dapp via Gcc-patches
> +  (VNx16QI "TARGET_MIN_VLEN <= 128") > +  (VNx32QI "TARGET_MIN_VLEN <= 256") > +  (VNx64QI "TARGET_MIN_VLEN >= 64 && TARGET_MIN_VLEN <= 512") > +  (VNx128QI "TARGET_MIN_VLEN >= 128 && TARGET_MIN_VLEN <= 1024") > > This not correct, we always use VNx16QI as LMUL = m1 for min_vlen >= 128. > Requi

Re: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-09 Thread 钟居哲
2:37 To: juzhe.zhong; gcc-patches CC: rdapp.gcc; kito.cheng; palmer; jeffreyalaw Subject: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement On 6/9/23 16:32, juzhe.zh...@rivai.ai wrote: > From: Juzhe-Zhong > > This patch fixes the requirement of V_WHOLE and V_FRACT.

Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-09 Thread Jeff Law via Gcc-patches
On 6/9/23 08:37, Robin Dapp wrote: On 6/9/23 16:32, juzhe.zh...@rivai.ai wrote: From: Juzhe-Zhong This patch fixes the requirement of V_WHOLE and V_FRACT. E.g. VNx8QI in V_WHOLE has no requirement which is incorrect. Actually, VNx8QI should be whole(full) mode when TARGET_MIN_VLEN < 1

Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-09 Thread Robin Dapp via Gcc-patches
> I think it shouldn't be with vec_set patch. > Instead, it obviously should be the separate patch. Yes, I didn't mean in the actual same patch. Regards Robin

Re: Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-09 Thread 钟居哲
PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement On 6/9/23 16:32, juzhe.zh...@rivai.ai wrote: > From: Juzhe-Zhong > > This patch fixes the requirement of V_WHOLE and V_FRACT. > E.g. VNx8QI in V_WHOLE has no requirement which is incorrect. > Actually, VNx8QI sho

Re: [PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-09 Thread Robin Dapp via Gcc-patches
On 6/9/23 16:32, juzhe.zh...@rivai.ai wrote: > From: Juzhe-Zhong > > This patch fixes the requirement of V_WHOLE and V_FRACT. > E.g. VNx8QI in V_WHOLE has no requirement which is incorrect. > Actually, VNx8QI should be whole(full) mode when TARGET_MIN_VLEN < 128 > since when TARGET_MIN_

[PATCH] RISC-V: Fix V_WHOLE && V_FRACT iterator requirement

2023-06-09 Thread juzhe . zhong
From: Juzhe-Zhong This patch fixes the requirement of V_WHOLE and V_FRACT. E.g. VNx8QI in V_WHOLE has no requirement which is incorrect. Actually, VNx8QI should be whole(full) mode when TARGET_MIN_VLEN < 128 since when TARGET_MIN_VLEN == 128, VNx8QI is e8mf2 which is fractional vec