Re: [PATCH] RISC-V: Fix .cfi_offset directive when push pop in zc

2025-02-24 Thread Kito Cheng
Pushed with minor coding style fix: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=4dcd3c7749734133f7f59509b1a118f3a13de4ee On Mon, Feb 24, 2025 at 4:00 PM Kito Cheng wrote: > > Thanks, will push after verified on my hand :) > > On Mon, Feb 24, 2025 at 3:20 PM Hsing Yu Peng wrote: > > > > Address

Re: [PATCH] RISC-V: Fix .cfi_offset directive when push pop in zc

2025-02-24 Thread Kito Cheng
Thanks, will push after verified on my hand :) On Mon, Feb 24, 2025 at 3:20 PM Hsing Yu Peng wrote: > > Address Fei's comment. > > Thanks > Lino > > Fei Gao 於 2025年2月24日 週一 下午2:20寫道: > > > > The case you hit is s2 set in frame mask but s1 not. So you're trying to > > set s1 bit manually. > > If

Re: [PATCH] RISC-V: Fix .cfi_offset directive when push pop in zc

2025-02-23 Thread Hsing Yu Peng
Address Fei's comment. Thanks Lino Fei Gao 於 2025年2月24日 週一 下午2:20寫道: > > The case you hit is s2 set in frame mask but s1 not. So you're trying to set > s1 bit manually. > If so, riscv_adjust_multi_push_cfi_prologue seems the better place for your > change. > > static rtx > riscv_adjust_multi_p

Re: [PATCH] RISC-V: Fix .cfi_offset directive when push pop in zc

2025-02-23 Thread Fei Gao
The case you hit is s2 set in frame mask but s1 not. So you're trying to set s1 bit manually. If so, riscv_adjust_multi_push_cfi_prologue seems the better place for your change. static rtx riscv_adjust_multi_push_cfi_prologue (int saved_size) {   rtx dwarf = NULL_RTX;   rtx adjust_sp_rtx, reg, m

[PATCH] RISC-V: Fix .cfi_offset directive when push pop in zc

2025-02-21 Thread 彭新佑
From 7cca6e23b293bdf47280997df87a0cda70d2f91d Mon Sep 17 00:00:00 2001 From: Lino Hsing-Yu Peng Date: Thu, 20 Feb 2025 17:09:22 +0800 Subject: [PATCH] RISC-V: Fix .cfi_offset directive when push/pop in zcmp The incorrect cfi directive info breaks stack unwind in try/catch/cxa. Before patch: c