Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

On Thu, Jan 21, 2021 at 10:49 PM Kito Cheng wrote: > I think this patch is small enough to accept without FSF copyright > assignment, and he is also on the way of the process, what do you > think? > I see the copyright assignments on file at the FSF when I checked today. Jim

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Pushed, thanks :) On Mon, Feb 1, 2021 at 4:58 PM Xing GUO wrote: > > Hi, > > I've reproduced the failure. It's because my gcc is configured as a > bare-metal toolchain and built with binutils that supports RISC-V > attribute. That is to say, my gcc emits RISC-V attributes by default. > Below is t

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Hi, I've reproduced the failure. It's because my gcc is configured as a bare-metal toolchain and built with binutils that supports RISC-V attribute. That is to say, my gcc emits RISC-V attributes by default. Below is the patch that should fix the failure. Sorry for the inconvenience. diff --git a

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Hi Andreas and Kito, I haven't reproduced this failure, but it looks that I forget to append `-mriscv-attribute` to dg-options in attribute-18.c. I'll reply to this thread ASAP. Thanks, Xing On 2/1/21, Andreas Schwab wrote: > FAIL: gcc.target/riscv/attribute-18.c scan-assembler .attribute arch,

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

FAIL: gcc.target/riscv/attribute-18.c scan-assembler .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c2p0_p" $ grep -c 'attribute arch' attribute-18.s 0 Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for somet

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Thanks! committed to master :) On Wed, Jan 27, 2021 at 1:58 PM Xing GUO via Gcc-patches wrote: > > Sorry, I forgot to remove the line '*explicit_version_p = true;' in my > previous patch. > > This is an updated patch. > > Thanks! > > --- > gcc/ChangeLog: > > * common/config/riscv/riscv-co

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Sorry, I forgot to remove the line '*explicit_version_p = true;' in my previous patch. This is an updated patch. Thanks! --- gcc/ChangeLog: * common/config/riscv/riscv-common.c (riscv_subset_list::parsing_subset_version): Fix -march option parsing when `p` extension exists. gcc

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Hi Jim: I think this patch is small enough to accept without FSF copyright assignment, and he is also on the way of the process, what do you think? On Fri, Jan 22, 2021 at 2:44 PM Xing GUO wrote: > > Hi Kito, > > I’ve sent my assignments and my school’s disclaimer to ass...@gnu.org > ([gnu.org

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Hi Kito, I’ve sent my assignments and my school’s disclaimer to ass...@gnu.org ([gnu.org #1673033] Xing GUO), but I haven’t got response so far. Not sure if this patch can be accepted as a small bugfix patch. If not, I’m happy to wait until FSF prove it. Best Regards,

Re: [PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

Hi Xing: Thanks for your patch, but I would like to know did you have the copyright assignment for FSF? or your employee/company has signed that? On Thu, Jan 21, 2021 at 8:48 PM Xing GUO via Gcc-patches wrote: > > This patch fixes -march option parsing when `p` extension exists, > e.g., -march=r

[PATCH] RISC-V: Fix -march option parsing when `p` extension exists.

This patch fixes -march option parsing when `p` extension exists, e.g., -march=rv64imafdcp should produce .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c2p0_p" rather than .attribute arch, "rv64i2p0_m2p0_a2p0_f2p0_d2p0_c_p" --- gcc/ChangeLog: * common/config/riscv/riscv-common.c (risc