> Thanks, pushed to git master.
Thanks, Nicolas.
On 6/12/20 12:19 AM, JonY wrote:
> On 6/11/20 10:02 PM, Nicolas Bértolo wrote:
>> Hi,
>>
>> On 6/7/20 11:12 PM, JonY wrote:
>>> Ideally, libtool is used so we get libgccjit-0.dll, unfortunately it is
>>> not. So the only way to ABI version the dll would be to use Unix style
>>> soname to mark when
On 6/11/20 10:02 PM, Nicolas Bértolo wrote:
> Hi,
>
> On 6/7/20 11:12 PM, JonY wrote:
>> Ideally, libtool is used so we get libgccjit-0.dll, unfortunately it is
>> not. So the only way to ABI version the dll would be to use Unix style
>> soname to mark when an ABI has changed.
>
> I tried generat
Hi,
On 6/7/20 11:12 PM, JonY wrote:
> Ideally, libtool is used so we get libgccjit-0.dll, unfortunately it is
> not. So the only way to ABI version the dll would be to use Unix style
> soname to mark when an ABI has changed.
I tried generating the library as libgccjit-0.dll and naming its import
On 6/7/20 4:03 PM, Nicolas Bértolo wrote:
> Hi,
>
> Sorry for the super late reply.
>
>> 1. Using .so on Windows for DLLs is fine.
>
> I know, but using the standard suffix for the platform seems better, IMHO.
>
It doesn't prevent applications from actually loading it.
>> 2. The DLL name on W
Hi,
Sorry for the super late reply.
> 1. Using .so on Windows for DLLs is fine.
I know, but using the standard suffix for the platform seems better, IMHO.
> 2. The DLL name on Windows should use LIBGCCJIT_SONAME rather than
> LIBGCCJIT_LINKER_NAME, so applications would load libgccjit.so.0 inst
On 5/28/20 8:46 PM, David Malcolm via Gcc-patches wrote:
> On Thu, 2020-05-28 at 16:51 -0300, Nicolas Bértolo wrote:
>>> I'm going to have to trust your Windows expertise here; the tempdir
>>> code looks convoluted to me, but perhaps that's the only way to do
>> it.
>>> (Microsoft's docs for "SECUR
On 5/28/20 8:46 PM, David Malcolm via Gcc-patches wrote:
>>> I was able to successfully bootstrap and regression test with
>>> your patch on x86_64-pc-linux-gnu. I also verified that the
>>> result of
>> "make
>>> install" was not affected for my configuration.
>>
>> Great.
>>
>>> I've pushed yo
On Thu, May 28, 2020, 4:25 PM David Malcolm via Gcc-patches <
gcc-patches@gcc.gnu.org> wrote:
> On Wed, 2020-05-27 at 22:27 -0300, Nicolas Bértolo wrote:
> > > New C++ source files should have a .cc extension.
> > > I hope that at some point we'll rename all the existing .c ones
> > > accordingly.
On Thu, 2020-05-28 at 16:51 -0300, Nicolas Bértolo wrote:
> > I'm going to have to trust your Windows expertise here; the tempdir
> > code looks convoluted to me, but perhaps that's the only way to do
> it.
> > (Microsoft's docs for "SECURITY_ATTRIBUTES" suggest to me that if
> > lpSecurityDescript
> I'm going to have to trust your Windows expertise here; the tempdir
> code looks convoluted to me, but perhaps that's the only way to do it.
> (Microsoft's docs for "SECURITY_ATTRIBUTES" suggest to me that if
> lpSecurityDescriptor is NULL, then the directory gets a default
> security descriptor,
On Wed, 2020-05-27 at 22:27 -0300, Nicolas Bértolo wrote:
> Hi,
>
> > Do you have commit/push access to the gcc repository?
>
> No I don't.
>
> > BTW, why isn't it necessary to use --enable-host-shared in Windows?
> > Can we document that?
>
> That's because all code is position independent in
Hi,
> Do you have commit/push access to the gcc repository?
No I don't.
> BTW, why isn't it necessary to use --enable-host-shared in Windows?
> Can we document that?
That's because all code is position independent in Windows.
> On the subject of nitpicking, I find myself getting distracted by
cs, and it takes care of this for me. I haven't used it, but
there's a contrib/clang-format file in the gcc source tree which
presumably describes GCC's coding conventions, if that helps for the
new code.
> Here is a new version.
Thanks. More review comments inline below...
> Nico.
Hi Dave,
Thanks for your feedback.
> Do you have copyright assignment paperwork on file?
> https://gcc.gnu.org/contribute.html#legal
My paperwork is done.
> The autotools are not my strongest suit.
> In a previous life I was a Windows developer, but I think it's been
> about 18 years since I'v
On Sun, 2020-05-24 at 17:02 -0300, Nicolas Bértolo via Gcc-patches wrote:
> Hello gcc devs.
Hi Nicolas.
> I have ported libgccjit to Windows. I have tested it with the
> native-compilation branch of Emacs so I'm confident that it works well.
Excellent - thanks for doing this work.
Do you have
Hello gcc devs.
I have ported libgccjit to Windows. I have tested it with the
native-compilation branch of Emacs so I'm confident that it works well.
The work is not finished though, I could use some help with these two
points:
I have had to concede defeat to libtool and Automake. I could not ge
17 matches
Mail list logo
