Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-06-05 Thread Joseph Myers
On Tue, 5 Jun 2018, Richard Biener wrote: > Are there other targets with similar kind of (FP) modes or is ppc the > only one with this 'legacy'? Also keep in mind that you intended to > backport this... Well, ia64 RFmode probably isn't a sensible mode to include in widening either (it's specif

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-06-05 Thread Richard Biener
On June 5, 2018 6:50:22 PM GMT+02:00, Segher Boessenkool wrote: >On Fri, Jun 01, 2018 at 04:36:54PM -0400, Michael Meissner wrote: >> As I mentioned previously, the initialization process needs to go >through all >> of the widening tables in order to initialize all FP types, so we >can't just >>

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-06-05 Thread Segher Boessenkool
On Fri, Jun 01, 2018 at 04:36:54PM -0400, Michael Meissner wrote: > As I mentioned previously, the initialization process needs to go through all > of the widening tables in order to initialize all FP types, so we can't just > arbitrarily eliminate IFmode from the widening table. Or change the ini

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-06-04 Thread Michael Meissner
On Mon, Jun 04, 2018 at 08:46:42AM +0200, Richard Biener wrote: > On Fri, 1 Jun 2018, Joseph Myers wrote: > > > On Fri, 1 Jun 2018, Michael Meissner wrote: > > > > > I'm wondering if there are other suggestions to make this patch > > > acceptable. > > > > > > As I mentioned previously, the init

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-06-03 Thread Richard Biener
On Fri, 1 Jun 2018, Joseph Myers wrote: > On Fri, 1 Jun 2018, Michael Meissner wrote: > > > I'm wondering if there are other suggestions to make this patch acceptable. > > > > As I mentioned previously, the initialization process needs to go through > > all > > of the widening tables in order t

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-06-01 Thread Joseph Myers
On Fri, 1 Jun 2018, Michael Meissner wrote: > I'm wondering if there are other suggestions to make this patch acceptable. > > As I mentioned previously, the initialization process needs to go through all > of the widening tables in order to initialize all FP types, so we can't just > arbitrarily

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-06-01 Thread Michael Meissner
I'm wondering if there are other suggestions to make this patch acceptable. As I mentioned previously, the initialization process needs to go through all of the widening tables in order to initialize all FP types, so we can't just arbitrarily eliminate IFmode from the widening table. I could imag

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Michael Meissner
On Wed, May 23, 2018 at 08:38:21PM +, Joseph Myers wrote: > On Wed, 23 May 2018, Richard Biener wrote: > > > Yeah. Not sure if we need sth other than FLOAT_MODE or if avoiding the > > chaining in wider mode and friends is enough. I guess one could also > > change IFmode to be a non-scalar, c

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Joseph Myers
On Thu, 24 May 2018, Segher Boessenkool wrote: > Which semantics doesn't it have? (Other than the lack of non-default > rounding modes, or is that what you meant?) It has problems with rounding modes, exceptions and various operations involving large or small arguments or results. Some of thes

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Segher Boessenkool
Hi, On Wed, May 23, 2018 at 08:35:49PM +, Joseph Myers wrote: > On Wed, 23 May 2018, Michael Meissner wrote: > > > One of the problems I've faced over the years is the assumption that there > > is > > only one type for a given size, and that isn't true for IF/KF/TFmode. > > I think that's a

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Joseph Myers
On Wed, 23 May 2018, Richard Biener wrote: > Yeah. Not sure if we need sth other than FLOAT_MODE or if avoiding the > chaining in wider mode and friends is enough. I guess one could also > change IFmode to be a non-scalar, composite mode - a different 'kind' of > complex mode maybe... I'm pret

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Joseph Myers
On Wed, 23 May 2018, Michael Meissner wrote: > One of the problems I've faced over the years is the assumption that there is > only one type for a given size, and that isn't true for IF/KF/TFmode. I think that's a different problem. The problem here is that "wider" is only a partial ordering bet

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Richard Biener
On May 23, 2018 7:53:01 PM GMT+02:00, Michael Meissner wrote: >On Wed, May 23, 2018 at 11:41:49AM +0200, Richard Biener wrote: >> Just a question for clarification - _is_ KFmode strictly a wider mode >> than IFmode? That is, can it represent all values that IFmode can? > >No. IFmode consists of

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Michael Meissner
On Wed, May 23, 2018 at 11:41:49AM +0200, Richard Biener wrote: > Just a question for clarification - _is_ KFmode strictly a wider mode > than IFmode? That is, can it represent all values that IFmode can? No. IFmode consists of a pair of doubles. I'm sure there are corner cases IFmode can repre

Re: [PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-23 Thread Richard Biener
On Tue, 22 May 2018, Michael Meissner wrote: > I posted this patch at the end of GCC 8 as a RFC. Now that we are in GCC 9, I > would like to repose it. Sorry to spam some of you. It is unclear whom the > reviewers for things like target hooks and basic mode handling are. > > Here is the origin

[PATCH] PR target/85358: Add target hook to prevent default widening

2018-05-22 Thread Michael Meissner
I posted this patch at the end of GCC 8 as a RFC. Now that we are in GCC 9, I would like to repose it. Sorry to spam some of you. It is unclear whom the reviewers for things like target hooks and basic mode handling are. Here is the original patch. https://gcc.gnu.org/ml/gcc-patches/2018-04/msg