Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-13 Thread Richard Biener
On Thu, Nov 13, 2014 at 2:07 PM, Jakub Jelinek wrote: > On Thu, Nov 13, 2014 at 01:08:44PM +0100, Richard Biener wrote: >> On Thu, Nov 13, 2014 at 12:17 PM, Jakub Jelinek wrote: >> > On Thu, Nov 13, 2014 at 12:08:01PM +0100, Richard Biener wrote: >> >> Btw, I have nothing against changing TRANSLA

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 01:08:44PM +0100, Richard Biener wrote: > On Thu, Nov 13, 2014 at 12:17 PM, Jakub Jelinek wrote: > > On Thu, Nov 13, 2014 at 12:08:01PM +0100, Richard Biener wrote: > >> Btw, I have nothing against changing TRANSLATION_UNIT_LANGUAGE > >> to DW_LANG_* directly - we only use

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-13 Thread Richard Biener
On Thu, Nov 13, 2014 at 12:17 PM, Jakub Jelinek wrote: > On Thu, Nov 13, 2014 at 12:08:01PM +0100, Richard Biener wrote: >> Btw, I have nothing against changing TRANSLATION_UNIT_LANGUAGE >> to DW_LANG_* directly - we only use it for choosing the language >> of the dwarf unit. This would of course

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-13 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 12:08:01PM +0100, Richard Biener wrote: > Btw, I have nothing against changing TRANSLATION_UNIT_LANGUAGE > to DW_LANG_* directly - we only use it for choosing the language > of the dwarf unit. This would of course mean to change its initialization > from > > TRANSLATION_

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-13 Thread Richard Biener
On Wed, Nov 12, 2014 at 5:31 PM, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 04:46:39PM +0100, Mark Wielaard wrote: >> I don't mind changing the language hook to return the actual DW_LANG_* >> constant directly, that seems like a nice cleanup. >> >> But I don't think we can just replace TRANSLA

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 04:46:39PM +0100, Mark Wielaard wrote: > I don't mind changing the language hook to return the actual DW_LANG_* > constant directly, that seems like a nice cleanup. > > But I don't think we can just replace TRANSLATION_UNIT_LANGUAGE and > lang_hooks.name. The name is (expli

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-12 Thread Mark Wielaard
On Wed, 2014-11-12 at 16:33 +0100, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 04:21:09PM +0100, Richard Biener wrote: > > On Wed, Nov 12, 2014 at 3:54 PM, Jakub Jelinek wrote: > > > I think we want this (also extended for C11/C++11/C++14 afterwards), even > > > when the early debug bits won't

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 04:21:09PM +0100, Richard Biener wrote: > On Wed, Nov 12, 2014 at 3:54 PM, Jakub Jelinek wrote: > > On Wed, Nov 12, 2014 at 03:50:19PM +0100, Mark Wielaard wrote: > >> On Mon, 2014-10-13 at 10:33 +0200, Mark Wielaard wrote: > >> > On Wed, 2014-10-08 at 12:13 +0200, Mark Wie

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-12 Thread Richard Biener
On Wed, Nov 12, 2014 at 3:54 PM, Jakub Jelinek wrote: > On Wed, Nov 12, 2014 at 03:50:19PM +0100, Mark Wielaard wrote: >> On Mon, 2014-10-13 at 10:33 +0200, Mark Wielaard wrote: >> > On Wed, 2014-10-08 at 12:13 +0200, Mark Wielaard wrote: >> > > This patch was written a long time ago by Jakub and

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-12 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 03:50:19PM +0100, Mark Wielaard wrote: > On Mon, 2014-10-13 at 10:33 +0200, Mark Wielaard wrote: > > On Wed, 2014-10-08 at 12:13 +0200, Mark Wielaard wrote: > > > This patch was written a long time ago by Jakub and has been in Fedora > > > gcc for some time. All I did was re

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-11-12 Thread Mark Wielaard
On Mon, 2014-10-13 at 10:33 +0200, Mark Wielaard wrote: > On Wed, 2014-10-08 at 12:13 +0200, Mark Wielaard wrote: > > This patch was written a long time ago by Jakub and has been in Fedora > > gcc for some time. All I did was rebase it to current gcc trunk > > and add a testcase. Back when it was o

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-13 Thread Mark Wielaard
On Wed, 2014-10-08 at 12:13 +0200, Mark Wielaard wrote: > This patch was written a long time ago by Jakub and has been in Fedora > gcc for some time. All I did was rebase it to current gcc trunk > and add a testcase. Back when it was originally proposed the issue was > that because DWARF was genera

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Mark Wielaard
On Wed, 2014-10-08 at 12:35 +0200, Jakub Jelinek wrote: > On Wed, Oct 08, 2014 at 12:29:38PM +0200, Mark Wielaard wrote: > > On Wed, 2014-10-08 at 12:17 +0200, Marek Polacek wrote: > > > On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > > > > This lang hook will be more useful when D

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Jakub Jelinek
On Wed, Oct 08, 2014 at 12:29:38PM +0200, Mark Wielaard wrote: > On Wed, 2014-10-08 at 12:17 +0200, Marek Polacek wrote: > > On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > > > This lang hook will be more useful when DWARFv5 gets out, which is > > > supposed to define language iden

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Mark Wielaard
On Wed, 2014-10-08 at 12:17 +0200, Marek Polacek wrote: > On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > > This lang hook will be more useful when DWARFv5 gets out, which is > > supposed to define language identifiers for newer C and C++ versions. > > It might have been discusse

Re: [PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Marek Polacek
On Wed, Oct 08, 2014 at 12:13:55PM +0200, Mark Wielaard wrote: > Hi, > > This patch was written a long time ago by Jakub and has been in Fedora > gcc for some time. All I did was rebase it to current gcc trunk > and add a testcase. Back when it was originally proposed the issue was > that because

[PATCH] PR debug/38757 gcc does not emit DW_LANG_C99

2014-10-08 Thread Mark Wielaard
Hi, This patch was written a long time ago by Jakub and has been in Fedora gcc for some time. All I did was rebase it to current gcc trunk and add a testcase. Back when it was originally proposed the issue was that because DWARF was generated late adding new lang hooks for this was problematic for