Re: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-12-05 Thread Richard Sandiford
Matthew Fortune writes: > Richard Sandiford writes: >> "Maciej W. Rozycki" writes: >> > 2014-11-17 Maciej W. Rozycki >> > >> >gcc/ >> >* gcc/config/mips/mips.md (*jump_absolute): Use a branch when in >> >range, a jump otherwise. >> > >> > Maciej >> > >> > gcc-mips-jump-branch.di

RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-12-05 Thread Matthew Fortune
Richard Sandiford writes: > "Maciej W. Rozycki" writes: > > 2014-11-17 Maciej W. Rozycki > > > > gcc/ > > * gcc/config/mips/mips.md (*jump_absolute): Use a branch when in > > range, a jump otherwise. > > > > Maciej > > > > gcc-mips-jump-branch.diff > > Index: gcc-fsf-trunk-quilt/

Re: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-12-05 Thread Richard Sandiford
"Maciej W. Rozycki" writes: > 2014-11-17 Maciej W. Rozycki > > gcc/ > * gcc/config/mips/mips.md (*jump_absolute): Use a branch when in > range, a jump otherwise. > > Maciej > > gcc-mips-jump-branch.diff > Index: gcc-fsf-trunk-quilt/gcc/config/mips/mips.md > =

RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-11-19 Thread Maciej W. Rozycki
On Tue, 18 Nov 2014, Matthew Fortune wrote: > > > I admit to being a bit more nervous about 4.9 but the test coverage > > > seems thorough enough. I guess I would have been less concerned if the > > > optimisation was still just tied to TARGET_MICROMIPS for the 4.9 > > branch. > > > > > > Catherin

RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-11-18 Thread Matthew Fortune
> > -Original Message- > > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > > Sent: Tuesday, November 18, 2014 12:22 PM > > To: Rozycki, Maciej > > Cc: gcc-patches@gcc.gnu.org; Moore, Catherine; Eric Christopher > > Subject: RE: [PATCH] MIP

RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-11-18 Thread Moore, Catherine
> -Original Message- > From: Matthew Fortune [mailto:matthew.fort...@imgtec.com] > Sent: Tuesday, November 18, 2014 12:22 PM > To: Rozycki, Maciej > Cc: gcc-patches@gcc.gnu.org; Moore, Catherine; Eric Christopher > Subject: RE: [PATCH] MIPS/GCC: Unconditional jump

RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-11-18 Thread Matthew Fortune
Maciej W. Rozycki writes: > On Mon, 17 Nov 2014, Matthew Fortune wrote: > > > > gcc/ > > > * gcc/config/mips/mips.md (*jump_absolute): Use a branch when in > > > range, a jump otherwise. > > > > OK. > > > > I only got my head around this code last week otherwise I wouldn't > > have known wh

RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-11-18 Thread Maciej W. Rozycki
On Mon, 17 Nov 2014, Matthew Fortune wrote: > > gcc/ > > * gcc/config/mips/mips.md (*jump_absolute): Use a branch when in > > range, a jump otherwise. > > OK. > > I only got my head around this code last week otherwise I wouldn't have > known whether this was correct! Committed now

RE: [PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-11-17 Thread Matthew Fortune
> OK to apply? > > 2014-11-17 Maciej W. Rozycki > > gcc/ > * gcc/config/mips/mips.md (*jump_absolute): Use a branch when in > range, a jump otherwise. OK. I only got my head around this code last week otherwise I wouldn't have known whether this was correct! Thanks, Matth

[PATCH] MIPS/GCC: Unconditional jump generation bug fix

2014-11-17 Thread Maciej W. Rozycki
Hi, This was lost in the original microMIPS submission. For absolute microMIPS jumps GCC always produces a branch instruction, causing a `relocation truncated to fit: R_MICROMIPS_PC16_S1' linker error if the branch target turns out of range. The TARGET_ABICALLS_PIC2 macro is never set in ab