Re: [PATCH] Fix zero-masking for vcvtps2ph when dest operand is memory.

2020-06-03 Thread Hongtao Liu via Gcc-patches
On Thu, Jun 4, 2020 at 2:43 PM Richard Biener wrote: > > On Thu, 4 Jun 2020, Hongtao Liu wrote: > > > Hi Richard: > > Could you help review this patch. > > uros said he wouldn't review patches related to x86 vector ISA anymore. > > I can't spot anything wrong but I know nothing about what a >

Re: [PATCH] Fix zero-masking for vcvtps2ph when dest operand is memory.

2020-06-03 Thread Richard Biener
On Thu, 4 Jun 2020, Hongtao Liu wrote: > Hi Richard: > Could you help review this patch. > uros said he wouldn't review patches related to x86 vector ISA anymore. I can't spot anything wrong but I know nothing about what a define_subst is. You say "Bootstrap is ok, regression test on i386/x8

Re: [PATCH] Fix zero-masking for vcvtps2ph when dest operand is memory.

2020-06-03 Thread Hongtao Liu via Gcc-patches
Hi Richard: Could you help review this patch. uros said he wouldn't review patches related to x86 vector ISA anymore. On Wed, Jun 3, 2020 at 10:26 AM Hongtao Liu wrote: > > Hi: > When dest is memory, zero-masking is not valid, only merging-masking > is available, > > Bootstrap is ok, regr

[PATCH] Fix zero-masking for vcvtps2ph when dest operand is memory.

2020-06-02 Thread Hongtao Liu via Gcc-patches
Hi: When dest is memory, zero-masking is not valid, only merging-masking is available, Bootstrap is ok, regression test on i386/x86-64 backend is ok. gcc/ChangeLog: * gcc/config/i386/sse.md (*vcvtps2ph_store): Refine from *vcvtps2ph_store. (vcvtps2ph256): Refine constr