Re: [PATCH] Fix valgrind reported issue with diagnostics caret (PR c/69627)

2016-02-03 Thread Jeff Law
On 02/03/2016 01:25 PM, David Malcolm wrote: On Wed, 2016-02-03 at 21:07 +0100, Jakub Jelinek wrote: Hi! As range->m_caret.m_{line,column} is only initialized if range->m_show_caret_p is true, we really shouldn't be looking at those fields otherwise. Fixed thusly, bootstrapped/regtested on x86_

Re: [PATCH] Fix valgrind reported issue with diagnostics caret (PR c/69627)

2016-02-03 Thread David Malcolm
On Wed, 2016-02-03 at 21:07 +0100, Jakub Jelinek wrote: > Hi! > > As range->m_caret.m_{line,column} is only initialized if > range->m_show_caret_p is true, we really shouldn't be looking at > those > fields otherwise. > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, > ok for

[PATCH] Fix valgrind reported issue with diagnostics caret (PR c/69627)

2016-02-03 Thread Jakub Jelinek
Hi! As range->m_caret.m_{line,column} is only initialized if range->m_show_caret_p is true, we really shouldn't be looking at those fields otherwise. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-02-03 Jakub Jelinek PR c/69627 * diagno