On 02/03/2016 01:25 PM, David Malcolm wrote:
On Wed, 2016-02-03 at 21:07 +0100, Jakub Jelinek wrote:
Hi!
As range->m_caret.m_{line,column} is only initialized if
range->m_show_caret_p is true, we really shouldn't be looking at
those
fields otherwise.
Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
ok for
trunk?
I'm not a reviewer, but fwiw the change looks good to me; thanks.
[the uninitialized data is coming from:
gcc_rich_location::add_expr, which leaves m_show_caret_p as false, and
doesn't bother initializing m_caret].
Given you know this code better than anyone, that should carry enough
weight to be an approval, even if we haven't gone through the formal
process of appointing you as a reviewer for these bits.
jeff
