Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-26 Thread Bernd Schmidt
On 11/26/2015 09:53 PM, Martin Liška wrote: Is the patch still candidate to be merged in current stage3, or should I leave it to the next stage1? What about the first patch or the patch, where I just applied replacement of whitespaces? As I said previously, the one to just replace whitespace is

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-26 Thread Martin Liška
On 11/20/2015 12:15 PM, Martin Liška wrote: On 11/20/2015 03:14 AM, Bernd Schmidt wrote: BTW, I'm with whoever said absolutely no way to the idea of making automatic changes like this as part of a commit hook. I think the whitespace change can go in if it hasn't already, but I think the other

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-20 Thread Martin Liška
On 11/20/2015 03:14 AM, Bernd Schmidt wrote: > BTW, I'm with whoever said absolutely no way to the idea of making automatic > changes like this as part of a commit hook. > > I think the whitespace change can go in if it hasn't already, but I think the > other one still has enough problems that I

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Bernd Schmidt
BTW, I'm with whoever said absolutely no way to the idea of making automatic changes like this as part of a commit hook. I think the whitespace change can go in if it hasn't already, but I think the other one still has enough problems that I'll say - leave it for the next stage 1. @@ -178,8

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Jeff Law
On 11/19/2015 06:58 AM, Bernd Schmidt wrote: On 11/19/2015 11:16 AM, Martin Liška wrote: You are right, however as the original coding style was really broken, it was much easier to use the tool and clean-up fall-out. Waiting for thoughts related to v2. Better, but still some oddities. I hope

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Martin Liška
On 11/19/2015 02:58 PM, Bernd Schmidt wrote: > On 11/19/2015 11:16 AM, Martin Liška wrote: >> You are right, however as the original coding style was really broken, >> it was much easier >> to use the tool and clean-up fall-out. >> >> Waiting for thoughts related to v2. > > Better, but still some

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Bernd Schmidt
On 11/19/2015 11:16 AM, Martin Liška wrote: You are right, however as the original coding style was really broken, it was much easier to use the tool and clean-up fall-out. Waiting for thoughts related to v2. Better, but still some oddities. I hope you won't get mad at me if I suggest doing t

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Martin Liška
On 11/19/2015 01:50 AM, Joseph Myers wrote: I don't think all the reformattings here are things we want to do globally for most source files. E.g. @@ -75,18 +74,17 @@ get_mask_first_set_bit (unsigned mask) static bool has_undefined_value_p (tree t) { - return (ssa_undefined_value_p (t)

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Bernd Schmidt
On 11/19/2015 01:50 AM, Joseph Myers wrote: I don't think all the reformattings here are things we want to do globally for most source files. While I do appreciate the sentiment behind the patch, I agree with all of Joseph's points. Especially the clearly incorrect changes should be reverted

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Joseph Myers
I don't think all the reformattings here are things we want to do globally for most source files. E.g. > @@ -75,18 +74,17 @@ get_mask_first_set_bit (unsigned mask) > static bool > has_undefined_value_p (tree t) > { > - return (ssa_undefined_value_p (t) > - || (possibly_undefined_nam

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Jeff Law
? Thanks, Martin 0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch From 54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 13 Nov 2015 12:23:22 +0100 Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c gcc/ChangeLog: 2015-11-13 Martin Liska * tree

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Martin Liška
6_64-linux-gnu. >>>> Ready for trunk? >>>> >>>> Thanks, >>>> Martin >>>> >>>> >>>> 0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch >>>> >>>> >>>> From 54851503251dee7a8bd074485db262715e62

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Jeff Law
54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 13 Nov 2015 12:23:22 +0100 Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c gcc/ChangeLog: 2015-11-13 Martin Liska * tree-ssa-uninit.c (convert_control_dep_chain_into_preds): Fix GNU coding style

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Martin Liška
0001-Fix-memory-leaks-in-tree-ssa-uninit.c.patch >> >> >> From 54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001 >> From: marxin >> Date: Fri, 13 Nov 2015 12:23:22 +0100 >> Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c >> >> gcc/ChangeLog: >> >>

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Jeff Law
12:23:22 +0100 Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c gcc/ChangeLog: 2015-11-13 Martin Liska * tree-ssa-uninit.c (convert_control_dep_chain_into_preds): Fix GNU coding style. (find_def_preds): Use auto_vec. (destroy_predicate_vecs): Change signature

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-13 Thread Martin Liška
Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk? Thanks, Martin >From 54851503251dee7a8bd074485db262715e628728 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 13 Nov 2015 12:23:22 +0100 Subject: [PATCH] Fix memory leaks in tree-ssa-uninit.c gcc/ChangeLog: 2015-11