Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-21 Thread Jakub Jelinek
On Thu, Apr 21, 2016 at 05:23:34PM +0200, Marek Polacek wrote: > On Thu, Apr 21, 2016 at 04:19:12PM +0100, Bin.Cheng wrote: > > On Thu, Apr 21, 2016 at 4:13 PM, Marek Polacek wrote: > > > On Wed, Apr 20, 2016 at 11:57:23AM -0700, H.J. Lu wrote: > > >> On Wed, Apr 20, 2016 at 4:19 AM, Marek Polacek

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-21 Thread Marek Polacek
On Thu, Apr 21, 2016 at 04:19:12PM +0100, Bin.Cheng wrote: > On Thu, Apr 21, 2016 at 4:13 PM, Marek Polacek wrote: > > On Wed, Apr 20, 2016 at 11:57:23AM -0700, H.J. Lu wrote: > >> On Wed, Apr 20, 2016 at 4:19 AM, Marek Polacek wrote: > >> It leads to ICE on 32-bit x86 host: > >> > >> https://gcc

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-21 Thread Bin.Cheng
On Thu, Apr 21, 2016 at 4:13 PM, Marek Polacek wrote: > On Wed, Apr 20, 2016 at 11:57:23AM -0700, H.J. Lu wrote: >> On Wed, Apr 20, 2016 at 4:19 AM, Marek Polacek wrote: >> It leads to ICE on 32-bit x86 host: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70725#c8 > > I can't reproduce with g

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-21 Thread Marek Polacek
On Wed, Apr 20, 2016 at 11:57:23AM -0700, H.J. Lu wrote: > On Wed, Apr 20, 2016 at 4:19 AM, Marek Polacek wrote: > It leads to ICE on 32-bit x86 host: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70725#c8 I can't reproduce with gcc-6: $ xgcc-6 -O3 -march=skylake-avx512 -c pr70725.c nor with

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread H.J. Lu
On Wed, Apr 20, 2016 at 4:19 AM, Marek Polacek wrote: > On Wed, Apr 20, 2016 at 12:54:12PM +0200, Richard Biener wrote: >> On Wed, Apr 20, 2016 at 12:37 PM, Jakub Jelinek wrote: >> > On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: >> >> > --- gcc/tree-if-conv.c >> >> > +++ gcc/tre

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Richard Biener
On Wed, Apr 20, 2016 at 1:19 PM, Marek Polacek wrote: > On Wed, Apr 20, 2016 at 12:54:12PM +0200, Richard Biener wrote: >> On Wed, Apr 20, 2016 at 12:37 PM, Jakub Jelinek wrote: >> > On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: >> >> > --- gcc/tree-if-conv.c >> >> > +++ gcc/tre

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Marek Polacek
On Wed, Apr 20, 2016 at 12:54:12PM +0200, Richard Biener wrote: > On Wed, Apr 20, 2016 at 12:37 PM, Jakub Jelinek wrote: > > On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: > >> > --- gcc/tree-if-conv.c > >> > +++ gcc/tree-if-conv.c > >> > @@ -262,6 +262,16 @@ ifc_temp_var (tree ty

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Richard Biener
On Wed, Apr 20, 2016 at 12:37 PM, Jakub Jelinek wrote: > On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: >> > --- gcc/tree-if-conv.c >> > +++ gcc/tree-if-conv.c >> > @@ -262,6 +262,16 @@ ifc_temp_var (tree type, tree expr, >> > gimple_stmt_iterator *gsi) >> >return new_name; >

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Jakub Jelinek
On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: > > --- gcc/tree-if-conv.c > > +++ gcc/tree-if-conv.c > > @@ -262,6 +262,16 @@ ifc_temp_var (tree type, tree expr, > > gimple_stmt_iterator *gsi) > >return new_name; > > } > > > > +/* Return true when COND is a false predicate.

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Marek Polacek
On Wed, Apr 20, 2016 at 11:47:07AM +0200, Richard Biener wrote: > On Wed, Apr 20, 2016 at 11:42 AM, Marek Polacek wrote: > > On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: > >> On Tue, Apr 19, 2016 at 8:35 PM, Marek Polacek wrote: > >> > While predicate_mem_writes has a check to

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Richard Biener
On Wed, Apr 20, 2016 at 11:42 AM, Marek Polacek wrote: > On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: >> On Tue, Apr 19, 2016 at 8:35 PM, Marek Polacek wrote: >> > While predicate_mem_writes has a check to skip conditions that were >> > evaluated >> > to true, it's lacking the

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Marek Polacek
On Wed, Apr 20, 2016 at 11:04:08AM +0200, Richard Biener wrote: > On Tue, Apr 19, 2016 at 8:35 PM, Marek Polacek wrote: > > While predicate_mem_writes has a check to skip conditions that were > > evaluated > > to true, it's lacking the same check for false, so we hit an assert later > > on. > >

Re: [PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-20 Thread Richard Biener
On Tue, Apr 19, 2016 at 8:35 PM, Marek Polacek wrote: > While predicate_mem_writes has a check to skip conditions that were evaluated > to true, it's lacking the same check for false, so we hit an assert later on. > So I'm adding is_false_predicate. Maybe it should be added to other spots as > we

[PATCH] Fix ICE in predicate_mem_writes (PR tree-optimization/70725)

2016-04-19 Thread Marek Polacek
While predicate_mem_writes has a check to skip conditions that were evaluated to true, it's lacking the same check for false, so we hit an assert later on. So I'm adding is_false_predicate. Maybe it should be added to other spots as well, but I'm not sure about that. Bootstrapped/regtested on x86