Re: [PATCH] Assorted --disable-checking fixes [PR117249]

2024-10-25 Thread Richard Biener
On Fri, 25 Oct 2024, Jakub Jelinek wrote: > Hi! > > We have currently 3 different definitions of gcc_assert macro, one used most > of the time (unless --disable-checking) which evaluates the condition at > runtime and also checks it at runtime, then one for --disable-checking GCC > 4.5+ > which

Re: [PATCH] Assorted --disable-checking fixes [PR117249]

2024-10-25 Thread Alex Coplan
On 25/10/2024 10:19, Jakub Jelinek wrote: > Hi! > > We have currently 3 different definitions of gcc_assert macro, one used most > of the time (unless --disable-checking) which evaluates the condition at > runtime and also checks it at runtime, then one for --disable-checking GCC > 4.5+ > which l

Re: [PATCH] Assorted --disable-checking fixes [PR117249]

2024-10-25 Thread Thomas Schwinge
Hi Jakub! Just one item, quickly: On 2024-10-25T10:19:58+0200, Jakub Jelinek wrote: > We have currently 3 different definitions of gcc_assert macro, one used most > of the time (unless --disable-checking) which evaluates the condition at > runtime and also checks it at runtime, then one for --di

[PATCH] Assorted --disable-checking fixes [PR117249]

2024-10-25 Thread Jakub Jelinek
Hi! We have currently 3 different definitions of gcc_assert macro, one used most of the time (unless --disable-checking) which evaluates the condition at runtime and also checks it at runtime, then one for --disable-checking GCC 4.5+ which looks like ((void)(UNLIKELY (!(EXPR)) ? __builtin_unreacha