Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2015-06-27 Thread Dmitry Vyukov
On Sat, Jun 27, 2015 at 7:12 PM, Jakub Jelinek wrote: > On Sat, Jun 27, 2015 at 04:53:22PM +0200, Dmitry Vyukov wrote: >> Do you plan to move forward with this patch? Is it waiting to be reviewed? >> People keep asking about exception support for tsan (I guess it is >> critical for a significant p

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2015-06-27 Thread Jakub Jelinek
On Sat, Jun 27, 2015 at 04:53:22PM +0200, Dmitry Vyukov wrote: > Do you plan to move forward with this patch? Is it waiting to be reviewed? > People keep asking about exception support for tsan (I guess it is > critical for a significant potion of C++ out there). I am trying to > sketch support in

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2015-06-27 Thread Dmitry Vyukov
Hi Jakub, Do you plan to move forward with this patch? Is it waiting to be reviewed? People keep asking about exception support for tsan (I guess it is critical for a significant potion of C++ out there). I am trying to sketch support in llvm. And I am leaning towards an approach similar to yours,

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2014-12-16 Thread Richard Biener
On Tue, Dec 16, 2014 at 11:23 AM, Jakub Jelinek wrote: > On Tue, Dec 16, 2014 at 10:47:06AM +0100, Richard Biener wrote: >> On Mon, Dec 15, 2014 at 7:50 PM, Jakub Jelinek wrote: >> > Hi! >> > >> > As discussed in the PR, to support exceptions in -fsanitize=thread code, >> > it is desirable to cal

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2014-12-16 Thread Jakub Jelinek
On Tue, Dec 16, 2014 at 01:25:54PM +0400, Dmitry Vyukov wrote: > I am not qualified to review the actual code changes, but from the > description it looks good to me. > > It adds a EH frame to every function, right? In 64-bit mode there is > no runtime penalty, right? Do you have any idea about bi

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2014-12-16 Thread Jakub Jelinek
On Tue, Dec 16, 2014 at 10:47:06AM +0100, Richard Biener wrote: > On Mon, Dec 15, 2014 at 7:50 PM, Jakub Jelinek wrote: > > Hi! > > > > As discussed in the PR, to support exceptions in -fsanitize=thread code, > > it is desirable to call __tsan_func_exit also when leaving functions by > > means of

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2014-12-16 Thread Richard Biener
On Mon, Dec 15, 2014 at 7:50 PM, Jakub Jelinek wrote: > Hi! > > As discussed in the PR, to support exceptions in -fsanitize=thread code, > it is desirable to call __tsan_func_exit also when leaving functions by > means of exceptions. > > Adding EH too late sounds too hard to me, so this patch inst

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2014-12-16 Thread Dmitry Vyukov
Cross referenced this patch from https://code.google.com/p/thread-sanitizer/issues/detail?id=78 On Tue, Dec 16, 2014 at 12:25 PM, Dmitry Vyukov wrote: > I am not qualified to review the actual code changes, but from the > description it looks good to me. > > It adds a EH frame to every function,

Re: [PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2014-12-16 Thread Dmitry Vyukov
I am not qualified to review the actual code changes, but from the description it looks good to me. It adds a EH frame to every function, right? In 64-bit mode there is no runtime penalty, right? Do you have any idea about binary size increase? Does gcc build in C++ mode nowadays? It can be a good

[PATCH] Add support for exceptions to tsan (PR sanitizer/64265)

2014-12-15 Thread Jakub Jelinek
Hi! As discussed in the PR, to support exceptions in -fsanitize=thread code, it is desirable to call __tsan_func_exit also when leaving functions by means of exceptions. Adding EH too late sounds too hard to me, so this patch instead adds an internal call during gimplification, makes sure the inl