Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-08-30 Thread Matthias Klose
Am 20.08.2014 um 22:12 schrieb Svante Signell: > On Wed, 2014-05-21 at 10:48 +0200, Samuel Thibault wrote: >> Svante Signell, le Wed 21 May 2014 10:44:54 +0200, a écrit : >>> On Wed, 2014-05-21 at 10:33 +0200, Arnaud Charlet wrote: >> I think the majority of work has bee done, Now that patch wi

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-08-20 Thread Svante Signell
On Wed, 2014-05-21 at 10:48 +0200, Samuel Thibault wrote: > Svante Signell, le Wed 21 May 2014 10:44:54 +0200, a écrit : > > On Wed, 2014-05-21 at 10:33 +0200, Arnaud Charlet wrote: > > > > > I think the majority of work has bee done, Now that patch will change > > > > > slightly for every missing

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-22 Thread Arnaud Charlet
BTW, > I wonder ho the kfreebsd people managed to get accepted upstream? This is typically a good example of patches being accepted too rapidly, and leading to maintenance issues, see: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56274 for which nobody is stepping up to fix. So we might well en

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Samuel Thibault
Svante Signell, le Wed 21 May 2014 11:42:30 +0200, a écrit : > On Wed, 2014-05-21 at 11:27 +0200, Samuel Thibault wrote: > > Guaranteeing long term support *is* about taking up the work of checking > > periodically that the port works fine. If anybody does it, then it's > > fine. If nobody does i

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Svante Signell
On Wed, 2014-05-21 at 11:27 +0200, Samuel Thibault wrote: > Svante Signell, le Wed 21 May 2014 11:22:44 +0200, a écrit : > > On Wed, 2014-05-21 at 10:47 +0200, Samuel Thibault wrote: > > > Svante Signell, le Wed 21 May 2014 10:40:37 +0200, a écrit : > > > > > > What kind of person do you have to be

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Samuel Thibault
Svante Signell, le Wed 21 May 2014 11:22:44 +0200, a écrit : > On Wed, 2014-05-21 at 10:47 +0200, Samuel Thibault wrote: > > Svante Signell, le Wed 21 May 2014 10:40:37 +0200, a écrit : > > > > > What kind of person do you have to be to be accepted, a GNU/Hurd > > > > > developer or a GNU/Ada devel

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Svante Signell
On Wed, 2014-05-21 at 10:47 +0200, Samuel Thibault wrote: > Svante Signell, le Wed 21 May 2014 10:40:37 +0200, a écrit : > > > > What kind of person do you have to be to be accepted, a GNU/Hurd > > > > developer or a GNU/Ada developer having a gnu.org account? > > > > > > Nothing special, just lik

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Samuel Thibault
Svante Signell, le Wed 21 May 2014 10:44:54 +0200, a écrit : > On Wed, 2014-05-21 at 10:33 +0200, Arnaud Charlet wrote: > > > > I think the majority of work has bee done, Now that patch will change > > > > slightly for every missing feature added to Hurd. > > > > > > Then it's all good, it's a mat

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Samuel Thibault
Svante Signell, le Wed 21 May 2014 10:40:37 +0200, a écrit : > > > What kind of person do you have to be to be accepted, a GNU/Hurd > > > developer or a GNU/Ada developer having a gnu.org account? > > > > Nothing special, just like for contributing to any opensource project; > > just someone who c

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Svante Signell
On Wed, 2014-05-21 at 10:33 +0200, Arnaud Charlet wrote: > > > I think the majority of work has bee done, Now that patch will change > > > slightly for every missing feature added to Hurd. > > > > Then it's all good, it's a matter of what I said above. > > Don't forget also the part where general

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Samuel Thibault
Arnaud Charlet, le Wed 21 May 2014 10:33:31 +0200, a écrit : > > > I think the majority of work has bee done, Now that patch will change > > > slightly for every missing feature added to Hurd. > > > > Then it's all good, it's a matter of what I said above. > > Don't forget also the part where gen

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Svante Signell
On Wed, 2014-05-21 at 10:29 +0200, Samuel Thibault wrote: > Svante Signell, le Wed 21 May 2014 10:20:16 +0200, a écrit : > > On Wed, 2014-05-21 at 10:03 +0200, Samuel Thibault wrote: > > > Svante Signell, le Wed 21 May 2014 09:49:59 +0200, a écrit : > > > > Thomas and Samuel: It looks like upstream

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Arnaud Charlet
> > I think the majority of work has bee done, Now that patch will change > > slightly for every missing feature added to Hurd. > > Then it's all good, it's a matter of what I said above. Don't forget also the part where general changes are done in GNAT which require update to target specific fil

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Samuel Thibault
Svante Signell, le Wed 21 May 2014 10:20:16 +0200, a écrit : > On Wed, 2014-05-21 at 10:03 +0200, Samuel Thibault wrote: > > Svante Signell, le Wed 21 May 2014 09:49:59 +0200, a écrit : > > > Thomas and Samuel: It looks like upstream don't accept patches unless a > > > Hurd port maintainer commits

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Svante Signell
On Wed, 2014-05-21 at 10:03 +0200, Samuel Thibault wrote: > Svante Signell, le Wed 21 May 2014 09:49:59 +0200, a écrit : > > Thomas and Samuel: It looks like upstream don't accept patches unless a > > Hurd port maintainer commits to it. What's the use of all this job? > > Well, simply to keep the

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Samuel Thibault
Svante Signell, le Wed 21 May 2014 09:49:59 +0200, a écrit : > Thomas and Samuel: It looks like upstream don't accept patches unless a > Hurd port maintainer commits to it. What's the use of all this job? Well, simply to keep the changes working. That is not surprising at all. > (Of course it ca

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-21 Thread Svante Signell
On Mon, 2014-05-19 at 16:25 +0200, Arnaud Charlet wrote: > > > That's actually the biggest concern when people submit a new port: they > > > submit it, get it approved, commit it and then are no longer available > > > for any maintenance when these files need to be updated/become outdated/ > > > no

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Arnaud Charlet
> > That's actually the biggest concern when people submit a new port: they > > submit it, get it approved, commit it and then are no longer available > > for any maintenance when these files need to be updated/become outdated/ > > no longer compile or run. > > I can try to do that in the near fut

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Svante Signell
On Mon, 2014-05-19 at 15:53 +0200, Arnaud Charlet wrote: > > Do you want me to remove all GNU/Hurd specific header file info? > > No, I want you to remove commented out code, such as: > > > +-- SIGLTHRRES : constant := 32; -- GNU/LinuxThreads restart signal > > +-- SIGLTHRCAN : constant := 3

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Arnaud Charlet
> Do you want me to remove all GNU/Hurd specific header file info? No, I want you to remove commented out code, such as: > +-- SIGLTHRRES : constant := 32; -- GNU/LinuxThreads restart signal > +-- SIGLTHRCAN : constant := 33; -- GNU/LinuxThreads cancel signal > +-- SIGLTHRDBG : constant :

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Svante Signell
On Mon, 2014-05-19 at 14:50 +0200, Arnaud Charlet wrote: > > The build went fine. Is something still missing? > > We never keep commented out code, except with a ??? comment explaining why. Do you want me to remove all GNU/Hurd specific header file info? > We don't use 'FIXME', we use ??? instea

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Arnaud Charlet
> The build went fine. Is something still missing? We never keep commented out code, except with a ??? comment explaining why. We don't use 'FIXME', we use ??? instead. Also, some of the comments seem to be copy/paste from freebsd, which is likely not appropriate for GNU Hurd, so need to be revis

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-19 Thread Svante Signell
On Wed, 2014-05-14 at 12:53 +0200, Eric Botcazou wrote: > > Attached is a patch for support of GNU/Hurd in gnat-4.9. This patch has > > been used and updated in Debian since gnat-4.6, and is currently used to > > build gnat-4.9. Now when the body file s-osinte-posix.adb in gcc-4.9 > > defines tv_ns

Re: [PATCH] Add support for GNU/Hurd in gnat-4.9

2014-05-14 Thread Eric Botcazou
> Attached is a patch for support of GNU/Hurd in gnat-4.9. This patch has > been used and updated in Debian since gnat-4.6, and is currently used to > build gnat-4.9. Now when the body file s-osinte-posix.adb in gcc-4.9 > defines tv_nsec in timespec POSIX-correctly as long again, we think it > is t

[PATCH] Add support for GNU/Hurd in gnat-4.9

2014-04-25 Thread Svante Signell
Hello, Attached is a patch for support of GNU/Hurd in gnat-4.9. This patch has been used and updated in Debian since gnat-4.6, and is currently used to build gnat-4.9. Now when the body file s-osinte-posix.adb in gcc-4.9 defines tv_nsec in timespec POSIX-correctly as long again, we think it is tim