on 2019/7/11 下午9:55, Richard Sandiford wrote:
> Kewen.Lin writes:
>> + /* Emit a hint if the fallthrough target of current basic block
>> +isn't the one placed right next. */
>> + else if (EDGE_COUNT (bb->succs) > 0)
>> + {
>> +
Kewen.Lin writes:
> + /* Emit a hint if the fallthrough target of current basic block
> +isn't the one placed right next. */
> + else if (EDGE_COUNT (bb->succs) > 0)
> + {
> + gcc_assert (BB_END (bb) == tmp_rtx);
> +
Hi Richard,
on 2019/7/11 下午4:51, Richard Sandiford wrote:
> Kewen.Lin writes:
>>
>> - if (flags & TDF_BLOCKS)
>
> I think we still need an if here, but with the condition instead being:
>
>cfun->curr_properties & PROP_cfg
>
>> + else if (EDGE_COUNT (bb->succs) > 0)
>> +
Kewen.Lin writes:
> Hi Richard,
>
> on 2019/7/11 上午3:30, Richard Sandiford wrote:
>> "Kewen.Lin" writes:
>>> Hi all,
>>> Is it a reasonable patch? If yes, is it ok for trunk?
>>
>> It looks really useful, but IMO we should either emit the hint for all
>> end-of-block insns with a surprising fall
Hi Richard,
on 2019/7/11 上午3:30, Richard Sandiford wrote:
> "Kewen.Lin" writes:
>> Hi all,
>> Is it a reasonable patch? If yes, is it ok for trunk?
>
> It looks really useful, but IMO we should either emit the hint for all
> end-of-block insns with a surprising fallthrough edge, or -- if we
> re
"Kewen.Lin" writes:
> Hi all,
>
> 6: NOTE_INSN_BASIC_BLOCK 2
>
>12: r135:CC=cmp(r122:DI,0)
>13: pc={(r135:CC!=0)?L52:pc}
> REG_DEAD r135:CC
> REG_BR_PROB 1041558836
>31: L31:
>17: NOTE_INSN_BASIC_BLOCK 3
>
> The above RTL sequence is from pass doloop dump
Hi all,
6: NOTE_INSN_BASIC_BLOCK 2
12: r135:CC=cmp(r122:DI,0)
13: pc={(r135:CC!=0)?L52:pc}
REG_DEAD r135:CC
REG_BR_PROB 1041558836
31: L31:
17: NOTE_INSN_BASIC_BLOCK 3
The above RTL sequence is from pass doloop dumping with -fdump-rtl-all-slim, I
misunders