Re: [PATCH] Add hints for slim dumping if fallthrough bb of jump isn't next bb

[Kewen.Lin]

on 2019/7/11 下午9:55, Richard Sandiford wrote:
> Kewen.Lin <li...@linux.ibm.com> writes:
>> +             /* Emit a hint if the fallthrough target of current basic block
>> +                isn't the one placed right next.  */
>> +             else if (EDGE_COUNT (bb->succs) > 0)
>> +               {
>> +                 gcc_assert (BB_END (bb) == tmp_rtx);
>> +                 const rtx_insn *ninsn = NEXT_INSN (tmp_rtx);
>> +                 /* Bypass intervening deleted-insn notes and debug insns.  
>> */
>> +                 while (ninsn && !NONDEBUG_INSN_P (ninsn)
>> +                        && !start[INSN_UID (ninsn)])
> 
> Just a cosmetic thing, but when the full expression needs to be split
> over several lines, there should be one condition per line:
> 
>                while (ninsn
>                       && !NONDEBUG_INSN_P (ninsn)
>                       && !start[INSN_UID (ninsn)])
> 
> OK with that change, thanks.
> 

Thanks Richard!

Regression tested and bootstrapped on powerpc64le-unknown-linux-gnu. 

Committed as r273430 with above change.

Kewen