Re: [PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-10 Thread Diego Novillo
On 11-11-10 13:25 , Delesley Hutchins wrote: But you should not see such an expression in gimple. The array index is always a gimple_val. I'm not sure what you mean. The expression array[i+1] compiles to the following (courtesy of dump-tree-ssa): D.2095_4 = (long unsigned int) i_1; D.2096_

Re: [PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-10 Thread Delesley Hutchins
> But you should not see such an expression in gimple.  The array index is > always a gimple_val. I'm not sure what you mean. The expression array[i+1] compiles to the following (courtesy of dump-tree-ssa): D.2095_4 = (long unsigned int) i_1; D.2096_5 = D.2095_4 + 1; D.2097_6 = D.2096_5 * 4; D

Re: [PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-10 Thread Diego Novillo
On 11-11-10 13:05 , Delesley Hutchins wrote: Why PLUS_EXPR and MULT_EXPR? Pointer arithmetic should use POINTER_PLUS_EXPR exclusively. I don't think you should be seeing PLUS_EXPRs here. The MULT_EXPR show up in scaling expressions? MULT_EXPR shows up in array indexing, since the index is mu

Re: [PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-10 Thread Delesley Hutchins
> Why PLUS_EXPR and MULT_EXPR?  Pointer arithmetic should use > POINTER_PLUS_EXPR exclusively.  I don't think you should be seeing > PLUS_EXPRs here.  The MULT_EXPR show up in scaling expressions? MULT_EXPR shows up in array indexing, since the index is multiplied by the size of the element; gcc c

Re: [PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-10 Thread Diego Novillo
On 11-11-03 14:20 , Delesley Hutchins wrote: This patch adds support for array indexing (i.e. operator []) in lock expressions. The current version of gcc seems to emit these as expressions involving pointer arithmetic, so we update get_canonical_lock_expr() to handle such expressions. Bootstr

Re: [PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-08 Thread Ollie Wild
On Thu, Nov 3, 2011 at 1:20 PM, Delesley Hutchins wrote: > > This patch adds support for array indexing (i.e. operator []) in lock > expressions.  The current version of gcc seems to emit these as > expressions involving pointer arithmetic, so we  update > get_canonical_lock_expr() to handle such

[PATCH] [Annotalysis] Add support for arrays in lock expressions

2011-11-03 Thread Delesley Hutchins
This patch adds support for array indexing (i.e. operator []) in lock expressions. The current version of gcc seems to emit these as expressions involving pointer arithmetic, so we update get_canonical_lock_expr() to handle such expressions. Bootstrapped and passed gcc regression testsuite on x8