RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Kyrylo Tkachov
> -Original Message- > From: Joseph Myers > Sent: 06 May 2020 15:46 > To: Richard Biener > Cc: Kyrylo Tkachov ; Florian Weimer > ; Szabolcs Nagy ; gcc- > patc...@gcc.gnu.org; Jakub Jelinek > Subject: Re: [PATCH][AArch64] Use __getauxval instead of getauxval in

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Joseph Myers
On Wed, 6 May 2020, Richard Biener wrote: > > Here is the updated patch for the record. > > Jakub, richi, is this ok for the GCC 10 branch? > > I'll defer to Joseph who is release manager as well. This version is OK with me. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Szabolcs Nagy
The 05/06/2020 11:39, Kyrylo Tkachov wrote: > > -Original Message- > > From: Florian Weimer > > Sent: 06 May 2020 11:28 > > > > Is __gnu_linux__ defined with musl? It's not really GNU/Linux, after > > all. musl doesn't have __getauxval IIRC, so it would break the build > > there. > > I

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Richard Biener via Gcc-patches
; > > To: Kyrylo Tkachov > > > Cc: Joseph Myers ; Szabolcs Nagy > > > ; gcc-patches@gcc.gnu.org; Jakub Jelinek > > > ; Richard Biener > > > Subject: Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE > > > detection code in libgcc &g

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Kyrylo Tkachov
> -Original Message- > From: Kyrylo Tkachov > Sent: 06 May 2020 11:40 > To: Florian Weimer > Cc: Joseph Myers ; Szabolcs Nagy > ; gcc-patches@gcc.gnu.org; Jakub Jelinek > ; Richard Biener > Subject: RE: [PATCH][AArch64] Use __getauxval instead of getauxval in

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Kyrylo Tkachov
> -Original Message- > From: Florian Weimer > Sent: 06 May 2020 11:28 > To: Kyrylo Tkachov > Cc: Joseph Myers ; Szabolcs Nagy > ; gcc-patches@gcc.gnu.org; Jakub Jelinek > ; Richard Biener > Subject: Re: [PATCH][AArch64] Use __getauxval instead of getauxval in

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Florian Weimer via Gcc-patches
* Kyrylo Tkachov: > diff --git a/libgcc/config/aarch64/lse-init.c > b/libgcc/config/aarch64/lse-init.c > index 74acef25cce..57236610468 100644 > --- a/libgcc/config/aarch64/lse-init.c > +++ b/libgcc/config/aarch64/lse-init.c > @@ -29,19 +29,20 @@ see the files COPYING3 and COPYING.RUNTIME respect

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-06 Thread Kyrylo Tkachov
> -Original Message- > From: Joseph Myers > Sent: 05 May 2020 22:30 > To: Kyrylo Tkachov > Cc: Szabolcs Nagy ; Florian Weimer > ; gcc-patches@gcc.gnu.org > Subject: RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE > detection code in libgcc

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Joseph Myers
On Tue, 5 May 2020, Kyrylo Tkachov wrote: > This version of the fix uses __getauxval instead of getauxval. > The whole thing is guarded simply on __GLIBC__ >= 2. > __getauxval was introduced in 2.16 but the aarch64 port was added in 2.17 so > in practice I expect all aarch64 glibcs to support __g

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Joseph Myers
On Tue, 5 May 2020, Szabolcs Nagy wrote: > > A design principle is that glibc built with libgcc configured without > > glibc headers but with --with-glibc-version should produce an identical > > stripped binary to the glibc resulting from a longer alternating sequence > > of GCC and glibc build

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Kyrylo Tkachov
> -Original Message- > From: Joseph Myers > Sent: 04 May 2020 21:03 > To: Szabolcs Nagy > Cc: Kyrylo Tkachov ; Florian Weimer > ; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE > detection code in libgcc

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-05 Thread Szabolcs Nagy
The 05/04/2020 20:02, Joseph Myers wrote: > On Mon, 4 May 2020, Szabolcs Nagy wrote: > > i think __getauxval needs to be declared where it is used. > > Yes. > > > and libgcc should do a link test in configure becasuse a > > libc may provide sys/auxv.h but not have __getauxval e.g. > > musl libc d

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-04 Thread Joseph Myers
On Mon, 4 May 2020, Szabolcs Nagy wrote: > i think __getauxval needs to be declared where it is used. Yes. > and libgcc should do a link test in configure becasuse a > libc may provide sys/auxv.h but not have __getauxval e.g. > musl libc does not export __getauxval, only getauxval. libgcc can't

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-04 Thread Szabolcs Nagy
The 05/04/2020 11:34, Kyrylo Tkachov wrote: > > -Original Message- > > From: Florian Weimer > > Sent: 04 May 2020 11:40 > > To: Kyrylo Tkachov > > Cc: gcc-patches@gcc.gnu.org; Joseph Myers > > Subject: Re: [PATCH][AArch64] Use __getauxval instead of

RE: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-04 Thread Kyrylo Tkachov
> -Original Message- > From: Florian Weimer > Sent: 04 May 2020 11:40 > To: Kyrylo Tkachov > Cc: gcc-patches@gcc.gnu.org; Joseph Myers > Subject: Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE > detection code in libgcc > > * Kyrylo Tkach

Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-04 Thread Florian Weimer via Gcc-patches
* Kyrylo Tkachov: > This patch fixes > https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545004.html by using > __getauxval in the libgcc code. > Bootstrap and testing on aarch64-none-linux-gnu shows no problem. > From what I could gather from my glibc testing the elf/check-localplt test > pas

[PATCH][AArch64] Use __getauxval instead of getauxval in LSE detection code in libgcc

2020-05-04 Thread Kyrylo Tkachov
Hi all, This patch fixes https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545004.html by using __getauxval in the libgcc code. Bootstrap and testing on aarch64-none-linux-gnu shows no problem. >From what I could gather from my glibc testing the elf/check-localplt test >passes. Joseph, Florian