The 05/04/2020 11:34, Kyrylo Tkachov wrote: > > -----Original Message----- > > From: Florian Weimer <fwei...@redhat.com> > > Sent: 04 May 2020 11:40 > > To: Kyrylo Tkachov <kyrylo.tkac...@arm.com> > > Cc: gcc-patches@gcc.gnu.org; Joseph Myers <jos...@codesourcery.com> > > Subject: Re: [PATCH][AArch64] Use __getauxval instead of getauxval in LSE > > detection code in libgcc > > > > * Kyrylo Tkachov: > > > > > This patch fixes https://gcc.gnu.org/pipermail/gcc-patches/2020- > > May/545004.html by using __getauxval in the libgcc code. > > > Bootstrap and testing on aarch64-none-linux-gnu shows no problem. > > > From what I could gather from my glibc testing the elf/check-localplt test > > passes. > > > > > > Joseph, Florian, does this fix look like what you had in mind? > > > If I commit it to trunk and the branches will glibc be fine with it? > > > > Doesn't this cause an implicit function declaration warning? > > I don't get such a warning during bootstrap.
i think __getauxval needs to be declared where it is used. and libgcc should do a link test in configure becasuse a libc may provide sys/auxv.h but not have __getauxval e.g. musl libc does not export __getauxval, only getauxval.
