Re: [PATCH,i386] Fix adxintrin on mingw.

2014-10-06 Thread Uros Bizjak
On Thu, Oct 2, 2014 at 4:29 PM, Ilya Tocar wrote: > Hi, > > sizeof (long) == 4 on windows, so we should use long long as param type. > Patch below does it. > Ok for trunk? > > 2014-10-02 Ilya Tocar > > * config/i386/adxintrin.h (_subborrow_u64): Use long long for param > type. >

Re: [PATCH,i386] Fix adxintrin on mingw.

2014-10-06 Thread Ilya Tocar
On 03 Oct 07:53, H.J. Lu wrote: > On Fri, Oct 3, 2014 at 6:46 AM, Ilya Tocar wrote: > > On 02 Oct 07:41, H.J. Lu wrote: > >> On Thu, Oct 2, 2014 at 7:29 AM, Ilya Tocar wrote: > >> > >> The same is true for x32. Can you add a testcase to show it > >> fails on x32 without the fix? > >> > > > > Thi

Re: [PATCH,i386] Fix adxintrin on mingw.

2014-10-03 Thread H.J. Lu
On Fri, Oct 3, 2014 at 6:46 AM, Ilya Tocar wrote: > On 02 Oct 07:41, H.J. Lu wrote: >> On Thu, Oct 2, 2014 at 7:29 AM, Ilya Tocar wrote: >> > Hi, >> > >> > sizeof (long) == 4 on windows, so we should use long long as param type. >> > Patch below does it. >> >> The same is true for x32. Can you a

Re: [PATCH,i386] Fix adxintrin on mingw.

2014-10-03 Thread Ilya Tocar
On 02 Oct 07:41, H.J. Lu wrote: > On Thu, Oct 2, 2014 at 7:29 AM, Ilya Tocar wrote: > > Hi, > > > > sizeof (long) == 4 on windows, so we should use long long as param type. > > Patch below does it. > > The same is true for x32. Can you add a testcase to show it > fails on x32 without the fix? >

Re: [PATCH,i386] Fix adxintrin on mingw.

2014-10-02 Thread H.J. Lu
On Thu, Oct 2, 2014 at 7:29 AM, Ilya Tocar wrote: > Hi, > > sizeof (long) == 4 on windows, so we should use long long as param type. > Patch below does it. The same is true for x32. Can you add a testcase to show it fails on x32 without the fix? > Ok for trunk? > > 2014-10-02 Ilya Tocar > >

[PATCH,i386] Fix adxintrin on mingw.

2014-10-02 Thread Ilya Tocar
Hi, sizeof (long) == 4 on windows, so we should use long long as param type. Patch below does it. Ok for trunk? 2014-10-02 Ilya Tocar * config/i386/adxintrin.h (_subborrow_u64): Use long long for param type. (_addcarry_u64): Ditto. (_addcarryx_u64): Ditto. ---