On 03 Oct 07:53, H.J. Lu wrote:
> On Fri, Oct 3, 2014 at 6:46 AM, Ilya Tocar <tocarip.in...@gmail.com> wrote:
> > On 02 Oct 07:41, H.J. Lu wrote:
> >> On Thu, Oct 2, 2014 at 7:29 AM, Ilya Tocar <tocarip.in...@gmail.com> wrote:
> >>
> >> The same is true for x32. Can you add a testcase to show it
> >> fails on x32 without the fix?
> >>
> >
> > This could only be done with runtime test.
> > I've had troubles running sde (emulator) on x32 enabled system,
> > but replacing long long with int in intrinsic signature will cause
> > adx-addcarryx64-2.c to fail under sde on 64 bits. I believe it will
> > also fail on sde+{win,x32} or real hardware, when it's available.
> >
>
> Can we scan the assembly output for the wrong instruction?
>
I don't think so.
Incorrect instruction is movl (instead of movq) for value load.
However with x32 we also generate movl for pointer moves,
So scanning for movl doesn't make sense. And hardcoding particular
movl will make test quite fragile.
