On Wed, Aug 28, 2013 at 1:39 PM, Caroline Tice wrote:
> num_vtable_args was an int that we manually incremented/decremented,
> so it might have been negative. I am
> assuming that a vec.length() can never be negative. So before
> the else-clause was explicitly checking that the value was 0 or 1
On Wed, Aug 28, 2013 at 10:30 AM, Diego Novillo wrote:
> On 2013-08-28 12:59 , Caroline Tice wrote:
>
>> static void
>> -output_set_info (tree record_type, tree *vtbl_ptr_array, int array_size)
>> +output_set_info (tree record_type, vec *vtbl_ptr_array)
>
>
Okay, will do.
> Since this function
On 2013-08-28 12:59 , Caroline Tice wrote:
static void
-output_set_info (tree record_type, tree *vtbl_ptr_array, int array_size)
+output_set_info (tree record_type, vec *vtbl_ptr_array)
Since this function does not modify vtbl_ptr_array, you could pass it by
value.
@@ -1023,23 +1010,23 @
There are two patches attached in your original submission. I assume
they're both identical?
On Wed, Aug 28, 2013 at 12:59 PM, Caroline Tice wrote:
> PING!
>
> Could somebody please, pretty please review this patch? It's not very
> big or complex, and it's been out there for three weeks now
PING!
Could somebody please, pretty please review this patch? It's not very
big or complex, and it's been out there for three weeks nowIs
there something else I need to do for this?
-- Caroline Tice
cmt...@google.com
On Wed, Aug 21, 2013 at 1:30 PM, Caroline Tice wrote:
> Ping? Ping?
>
> O
Ping? Ping?
On Wed, Aug 14, 2013 at 12:14 PM, Caroline Tice wrote:
> Ping?
>
> On Thu, Aug 8, 2013 at 3:16 PM, Caroline Tice wrote:
>> This patch replaces the fixed sized array that was holding vtable
>> pointers for a particular class hierarchy with a vector, allowing for
>> dynamic resizing.
Ping?
On Thu, Aug 8, 2013 at 3:16 PM, Caroline Tice wrote:
> This patch replaces the fixed sized array that was holding vtable
> pointers for a particular class hierarchy with a vector, allowing for
> dynamic resizing. It also fixes issues with the warning diagnostics.
> I am in the process of r
This patch replaces the fixed sized array that was holding vtable
pointers for a particular class hierarchy with a vector, allowing for
dynamic resizing. It also fixes issues with the warning diagnostics.
I am in the process of running regression tests with this patch;
assuming they all pass, is t
