Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-18 Thread Jakub Jelinek
On Wed, May 18, 2016 at 05:40:33PM +0800, Chung-Lin Tang wrote: > On 2016/5/17 5:00 PM, Jakub Jelinek wrote: > > On Tue, May 17, 2016 at 04:56:42PM +0800, Chung-Lin Tang wrote: > >> I assume that bumping GOMP_VERSION in include/gomp-constants.h would be > >> enough? > > > > I think so. > > > >

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-18 Thread Chung-Lin Tang
On 2016/5/17 5:00 PM, Jakub Jelinek wrote: > On Tue, May 17, 2016 at 04:56:42PM +0800, Chung-Lin Tang wrote: >> I assume that bumping GOMP_VERSION in include/gomp-constants.h would be >> enough? > > I think so. > > Jakub > How is this patch? I have added a comment to remind to adjust the

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-17 Thread Jakub Jelinek
On Tue, May 17, 2016 at 04:56:42PM +0800, Chung-Lin Tang wrote: > I assume that bumping GOMP_VERSION in include/gomp-constants.h would be > enough? I think so. Jakub

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-17 Thread Chung-Lin Tang
On 2016/5/12 6:56 PM, Jakub Jelinek wrote: > On Thu, May 12, 2016 at 12:47:18PM +0200, Thomas Schwinge wrote: >> Hi! >> >> On Thu, 12 May 2016 12:02:58 +0200, Jakub Jelinek wrote: >>> ABI incompatible change for the plugin >>> interface (affecting OpenACC capable plugins only), I think you just sh

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-12 Thread Jakub Jelinek
On Thu, May 12, 2016 at 12:47:18PM +0200, Thomas Schwinge wrote: > Hi! > > On Thu, 12 May 2016 12:02:58 +0200, Jakub Jelinek wrote: > > ABI incompatible change for the plugin > > interface (affecting OpenACC capable plugins only), I think you just should > > rename the plugin callback you add the

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-12 Thread Thomas Schwinge
Hi! On Thu, 12 May 2016 12:02:58 +0200, Jakub Jelinek wrote: > ABI incompatible change for the plugin > interface (affecting OpenACC capable plugins only), I think you just should > rename the plugin callback you add the argument to, so that > || !DLSYM_OPT (openacc.register_async_clean

Re: [PATCH, libgomp] Rewire OpenACC async

2016-05-12 Thread Jakub Jelinek
On Tue, Mar 29, 2016 at 05:48:25PM +0800, Chung-Lin Tang wrote: > I've updated this patch for trunk (as attached), and re-tested without > regressions. This patch is still a fix for > libgomp.oacc-c-c++-common/asyncwait-1.c, > which FAILs right now. > > ChangeLog is still as before. Is this okay

Re: [PATCH, libgomp] Rewire OpenACC async (Ping x3)

2016-05-10 Thread Chung-Lin Tang
Ping x3 On 2016/4/16 3:40 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/4/8 07:02 PM, Chung-Lin Tang wrote: >> Ping. >> >> On 2016/3/29 5:48 PM, Chung-Lin Tang wrote: >>> I've updated this patch for trunk (as attached), and re-tested without >>> regressions. This patch is still a fix for >>> lib

Re: [PATCH, libgomp] Rewire OpenACC async

2016-04-16 Thread Chung-Lin Tang
Ping. On 2016/4/8 07:02 PM, Chung-Lin Tang wrote: > Ping. > > On 2016/3/29 5:48 PM, Chung-Lin Tang wrote: >> I've updated this patch for trunk (as attached), and re-tested without >> regressions. This patch is still a fix for >> libgomp.oacc-c-c++-common/asyncwait-1.c, >> which FAILs right now.

Re: [PATCH, libgomp] Rewire OpenACC async

2016-04-08 Thread Chung-Lin Tang
Ping. On 2016/3/29 5:48 PM, Chung-Lin Tang wrote: > I've updated this patch for trunk (as attached), and re-tested without > regressions. This patch is still a fix for > libgomp.oacc-c-c++-common/asyncwait-1.c, > which FAILs right now. > > ChangeLog is still as before. Is this okay for trunk? >

Re: [PATCH, libgomp] Rewire OpenACC async

2016-03-29 Thread Chung-Lin Tang
I've updated this patch for trunk (as attached), and re-tested without regressions. This patch is still a fix for libgomp.oacc-c-c++-common/asyncwait-1.c, which FAILs right now. ChangeLog is still as before. Is this okay for trunk? Thanks, Chung-Lin On 2015/12/22 4:58 PM, Chung-Lin Tang wrote:

Re: [PATCH, libgomp] Rewire OpenACC async

2015-12-22 Thread Chung-Lin Tang
Ping. On 2015/11/24 6:27 PM, Chung-Lin Tang wrote: > Hi, this patch reworks some of the way that asynchronous copyouts are > implemented for OpenACC in libgomp. > > Before this patch, we had a somewhat confusing way of implementing this > by having two refcounts for each mapping: refcount and asy

Re: [PATCH, libgomp] Rewire OpenACC async

2015-12-05 Thread Chung-Lin Tang
On 2015/12/1 08:01 PM, Julian Brown wrote: > On Tue, 24 Nov 2015 18:27:24 +0800 > Chung-Lin Tang wrote: > >> Hi, this patch reworks some of the way that asynchronous copyouts are >> implemented for OpenACC in libgomp. >> >> Before this patch, we had a somewhat confusing way of implementing >> thi

Re: [PATCH, libgomp] Rewire OpenACC async

2015-12-01 Thread Julian Brown
On Tue, 24 Nov 2015 18:27:24 +0800 Chung-Lin Tang wrote: > Hi, this patch reworks some of the way that asynchronous copyouts are > implemented for OpenACC in libgomp. > > Before this patch, we had a somewhat confusing way of implementing > this by having two refcounts for each mapping: refcount

[PATCH, libgomp] Rewire OpenACC async

2015-11-24 Thread Chung-Lin Tang
Hi, this patch reworks some of the way that asynchronous copyouts are implemented for OpenACC in libgomp. Before this patch, we had a somewhat confusing way of implementing this by having two refcounts for each mapping: refcount and async_refcount, which I never got working again after the last wa