Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-26 Thread Uros Bizjak
Hello! > I've added avx512f support to __builtin_cpu_supports. > I'm not sure about bw+vl, i think for compound values like > avx512bd+dq+vl, arch is better. Also for such cases prority is unclear, > what should we choose bw+vl or e. g. avx512f+er? > I've left MPX bits in cpuid.h, in case we will

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-26 Thread Ilya Tocar
> >> I think using cpuid for that is just fine. __builtin_cpu_supports > >> is for ISA additions users might actually want to version code for, > >> MPX stuff, as the instructions are nops without hw support, are not > >> something one would multi-version a function for. > >> If anything, AVX512F

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-21 Thread Ilya Enkovich
2014-11-21 20:45 GMT+03:00 Jeff Law : > On 11/20/14 09:40, Jakub Jelinek wrote: >> >> On Thu, Nov 20, 2014 at 07:36:03PM +0300, Ilya Enkovich wrote: >>> >>> Hi, >>> >>> MPX runtime checks some feature bits in order to check MPX is fully >>> supported. Runtime does it by cpuid calls but there is a

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-21 Thread Jeff Law
On 11/20/14 09:40, Jakub Jelinek wrote: On Thu, Nov 20, 2014 at 07:36:03PM +0300, Ilya Enkovich wrote: Hi, MPX runtime checks some feature bits in order to check MPX is fully supported. Runtime does it by cpuid calls but there is a __builtin_cpu_supports which may be used for that. Unfortunat

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-20 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 07:36:03PM +0300, Ilya Enkovich wrote: > Hi, > > MPX runtime checks some feature bits in order to check MPX is fully > supported. Runtime does it by cpuid calls but there is a > __builtin_cpu_supports which may be used for that. Unfortunately > currently it doesn't suppor

[PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-20 Thread Ilya Enkovich
Hi, MPX runtime checks some feature bits in order to check MPX is fully supported. Runtime does it by cpuid calls but there is a __builtin_cpu_supports which may be used for that. Unfortunately currently it doesn't support required bits. Will it be OK to add them for trunk? Thanks, Ilya --