Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-18 Thread Kirill Yukhin
http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00511.html

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-17 Thread Maxim Kuvyrkov
On 18/04/2012, at 2:32 AM, Ilya Enkovich wrote: >> On Tue, Apr 17, 2012 at 3:16 PM, Uros Bizjak wrote: ... >> >> The patch looks OK to me in the sense, that there is no difference for >> x86 targets. >> >> So, OK for x86. >> >> Thanks, >> Uros. > > Thanks, Uros! > > Maxim, could you please l

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-17 Thread Ilya Enkovich
> On Tue, Apr 17, 2012 at 3:16 PM, Uros Bizjak wrote: >> On Tue, Apr 17, 2012 at 12:16 PM, Ilya Enkovich >> wrote: > > It has nothing but defines for Android. It did not move any existing > code to this file. > Adding linux-common.h to i386 backend needs approval from >

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-17 Thread Uros Bizjak
On Tue, Apr 17, 2012 at 3:16 PM, Uros Bizjak wrote: > On Tue, Apr 17, 2012 at 12:16 PM, Ilya Enkovich > wrote: It has nothing but defines for Android. It did not move any existing code to this file. >>> >>> Adding linux-common.h to i386 backend needs approval from >>> i386 ba

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-17 Thread Uros Bizjak
On Tue, Apr 17, 2012 at 12:16 PM, Ilya Enkovich wrote: >>> >>> It has nothing but defines for Android. It did not move any existing >>> code to this file. >>> >> >> Adding linux-common.h to i386 backend needs approval from >> i386 backend maintainer.   If a patch also adds Android support, >> i386

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-17 Thread Ilya Enkovich
>> >> It has nothing but defines for Android. It did not move any existing >> code to this file. >> > > Adding linux-common.h to i386 backend needs approval from > i386 backend maintainer.   If a patch also adds Android support, > i386 backend maintainer may not feel comfortable to review it. > How

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread H.J. Lu
On Mon, Apr 16, 2012 at 9:08 AM, Ilya Enkovich wrote: >> On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich >> wrote: Maybe it is better to break it into 2 patches: 1. Introduce config/i386/linux-common.h with any new functionalities 2. Add Android support. Thanks.

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread Ilya Enkovich
> On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich wrote: >>> >>> Maybe it is better to break it into 2 patches: >>> >>> 1. Introduce config/i386/linux-common.h with any new functionalities >>> 2. Add Android support. >>> >>> Thanks. >>> >>> >>> H.J. >>> --- >> Hi, >> >> The first part will just add

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread H.J. Lu
On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich wrote: >> >> Maybe it is better to break it into 2 patches: >> >> 1. Introduce config/i386/linux-common.h with any new functionalities >> 2. Add Android support. >> >> Thanks. >> >> >> H.J. >> --- > Hi, > > The first part will just add empty file. Wha

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread Ilya Enkovich
> > Maybe it is better to break it into 2 patches: > > 1. Introduce config/i386/linux-common.h with any new functionalities > 2. Add Android support. > > Thanks. > > > H.J. > --- Hi, The first part will just add empty file. What is the reason to do it? Testing will not even reveal if I added it in

Re: [PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread H.J. Lu
On Mon, Apr 16, 2012 at 8:33 AM, Ilya Enkovich wrote: > Hello, > > Here is patch for i386 Android support. It is the second part of > previously splitted patch > (http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00127.html). The first > part has been committed > (http://gcc.gnu.org/ml/gcc-cvs/2012-04/

[PATCH, i386, Android] Add Android support for i386 target

2012-04-16 Thread Ilya Enkovich
Hello, Here is patch for i386 Android support. It is the second part of previously splitted patch (http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00127.html). The first part has been committed (http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00378.html). Bootstrapped and checked on linux-x86_64. OK for tru