On Mon, Apr 16, 2012 at 9:08 AM, Ilya Enkovich <enkovich....@gmail.com> wrote: >> On Mon, Apr 16, 2012 at 9:01 AM, Ilya Enkovich <enkovich....@gmail.com> >> wrote: >>>> >>>> Maybe it is better to break it into 2 patches: >>>> >>>> 1. Introduce config/i386/linux-common.h with any new functionalities >>>> 2. Add Android support. >>>> >>>> Thanks. >>>> >>>> >>>> H.J. >>>> --- >>> Hi, >>> >>> The first part will just add empty file. What is the reason to do it? >>> Testing will not even reveal if I added it incorrectly. >>> >> >> It should contain everything, minus any new Android changes, >> which should be in the second patch. > > It has nothing but defines for Android. It did not move any existing > code to this file. >
Adding linux-common.h to i386 backend needs approval from i386 backend maintainer. If a patch also adds Android support, i386 backend maintainer may not feel comfortable to review it. However, if you simplify add linux-common.h with XXX_SPEC, i386 backend maintainer can review it easily. -- H.J.
