Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread H.J. Lu
On Thu, May 23, 2019 at 8:25 AM Iain Sandoe wrote: > > > > On 23 May 2019, at 16:17, H.J. Lu wrote: > > > > On Thu, May 23, 2019 at 6:09 AM Uros Bizjak wrote: > >> > >> On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: > >> > These changes are OK as long as they don't regress HJ's x86_64

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Iain Sandoe
> On 23 May 2019, at 16:17, H.J. Lu wrote: > > On Thu, May 23, 2019 at 6:09 AM Uros Bizjak wrote: >> >> On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: >> These changes are OK as long as they don't regress HJ's x86_64 and i686 autotesters. >>> >>> Applied as r271544, will loo

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread H.J. Lu
On Thu, May 23, 2019 at 6:09 AM Uros Bizjak wrote: > > On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: > > > > These changes are OK as long as they don't regress HJ's x86_64 and > > > i686 autotesters. > > > > Applied as r271544, will look out for such fails. > > > > > Double points if they a

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Uros Bizjak
On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: > > These changes are OK as long as they don't regress HJ's x86_64 and > > i686 autotesters. > > Applied as r271544, will look out for such fails. > > > Double points if they also fix -fpic failures. ;) > > make check-gcc-c RUNTESTFLAGS="--targe

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Iain Sandoe
Hi Uros. > On 23 May 2019, at 07:23, Uros Bizjak wrote: > > On Wed, May 22, 2019 at 8:41 PM Iain Sandoe wrote: >> >> As Dominque noted in PR 64895, somewhere between revisions >> r244915 and r244957 we see the fuse-caller-save* tests started to >> XPASS on Darwin, which is a PIC target by defa

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-22 Thread Uros Bizjak
On Wed, May 22, 2019 at 8:41 PM Iain Sandoe wrote: > > As Dominque noted in PR 64895, somewhere between revisions > r244915 and r244957 we see the fuse-caller-save* tests started to > XPASS on Darwin, which is a PIC target by default. > > The XFAILed parts of the tests never seem to be exercised

[PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-22 Thread Iain Sandoe
As Dominque noted in PR 64895, somewhere between revisions r244915 and r244957 we see the fuse-caller-save* tests started to XPASS on Darwin, which is a PIC target by default. The XFAILed parts of the tests never seem to be exercised on Linux, and therefore the change would be unnoticed there.