Re: [PATCH, PR94769] fortran/io.c: Fix use of uninitialized variable num

2020-04-29 Thread Jakub Jelinek via Gcc-patches
On Wed, Apr 29, 2020 at 01:53:01PM +0200, Stefan Schulze Frielinghaus wrote: > Hi Tobias, > > On Tue, Apr 28, 2020 at 05:06:15PM +0200, Tobias Burnus wrote: > > Hi Stefan, > > > > I prefer Jakub's suggestion – his change LGTM. > > Please find attached an updated patch. Bootstrapped and regteste

Re: [PATCH, PR94769] fortran/io.c: Fix use of uninitialized variable num

2020-04-29 Thread Stefan Schulze Frielinghaus via Gcc-patches
Hi Tobias, On Tue, Apr 28, 2020 at 05:06:15PM +0200, Tobias Burnus wrote: > Hi Stefan, > > I prefer Jakub's suggestion – his change LGTM. Please find attached an updated patch. Bootstrapped and regtested on S/390. Ok for master? Cheers, Stefan > On 4/28/20 2:30 PM, Jakub Jelinek via Gcc-patc

Re: [PATCH, PR94769] fortran/io.c: Fix use of uninitialized variable num

2020-04-28 Thread Tobias Burnus
Hi Stefan, I prefer Jakub's suggestion – his change LGTM. Cheers, Tobias On 4/28/20 2:30 PM, Jakub Jelinek via Gcc-patches wrote: On Tue, Apr 28, 2020 at 01:53:07PM +0200, Stefan Schulze Frielinghaus via Gcc-patches wrote: gcc/fortran/ChangeLog: 2020-04-28 Stefan Schulze Frielinghaus

Re: [PATCH, PR94769] fortran/io.c: Fix use of uninitialized variable num

2020-04-28 Thread Richard Biener via Gcc-patches
On Tue, Apr 28, 2020 at 3:23 PM Jakub Jelinek via Gcc-patches wrote: > > On Tue, Apr 28, 2020 at 01:53:07PM +0200, Stefan Schulze Frielinghaus via > Gcc-patches wrote: > > gcc/fortran/ChangeLog: > > > > 2020-04-28 Stefan Schulze Frielinghaus > > > > PR fortran/94769 > > * io.c

Re: [PATCH, PR94769] fortran/io.c: Fix use of uninitialized variable num

2020-04-28 Thread Richard Biener via Gcc-patches
On Tue, Apr 28, 2020 at 2:44 PM Stefan Schulze Frielinghaus via Gcc-patches wrote: > > While bootstrapping GCC on S/390 the following warning occurs: > > gcc/fortran/io.c: In function 'bool gfc_resolve_dt(gfc_code*, gfc_dt*, > locus*)': > gcc/fortran/io.c:3857:7: error: 'num' may be used uninitia

Re: [PATCH, PR94769] fortran/io.c: Fix use of uninitialized variable num

2020-04-28 Thread Jakub Jelinek via Gcc-patches
On Tue, Apr 28, 2020 at 01:53:07PM +0200, Stefan Schulze Frielinghaus via Gcc-patches wrote: > gcc/fortran/ChangeLog: > > 2020-04-28 Stefan Schulze Frielinghaus > > PR fortran/94769 > * io.c (check_io_constraints): Initialize local variable num. > --- > gcc/fortran/io.c | 2 +

[PATCH, PR94769] fortran/io.c: Fix use of uninitialized variable num

2020-04-28 Thread Stefan Schulze Frielinghaus via Gcc-patches
While bootstrapping GCC on S/390 the following warning occurs: gcc/fortran/io.c: In function 'bool gfc_resolve_dt(gfc_code*, gfc_dt*, locus*)': gcc/fortran/io.c:3857:7: error: 'num' may be used uninitialized in this function [-Werror=maybe-uninitialized] 3857 | if (num == 0) |