On Wed, Apr 29, 2020 at 01:53:01PM +0200, Stefan Schulze Frielinghaus wrote:
> Hi Tobias,
>
> On Tue, Apr 28, 2020 at 05:06:15PM +0200, Tobias Burnus wrote:
> > Hi Stefan,
> >
> > I prefer Jakub's suggestion – his change LGTM.
>
> Please find attached an updated patch. Bootstrapped and regtested on
> S/390. Ok for master?
Ok, thanks.
> gcc/fortran/ChangeLog:
>
> 2020-04-28 Stefan Schulze Frielinghaus <stefa...@linux.ibm.com>
>
> PR fortran/94769
> * io.c (check_io_constraints): Initialize local variable num to
> -1 and assert that it receives a meaningful value by function
> compare_to_allowed_values.
> ---
> gcc/fortran/io.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/fortran/io.c b/gcc/fortran/io.c
> index e066666e01d..981cf9e88dd 100644
> --- a/gcc/fortran/io.c
> +++ b/gcc/fortran/io.c
> @@ -3840,7 +3840,7 @@ if (condition) \
>
> if (dt->asynchronous)
> {
> - int num;
> + int num = -1;
> static const char * asynchronous[] = { "YES", "NO", NULL };
>
> /* Note: gfc_reduce_init_expr reports an error if not init-expr. */
> @@ -3853,6 +3853,8 @@ if (condition) \
> io_kind_name (k), warn, &dt->asynchronous->where, &num))
> return false;
>
> + gcc_checking_assert (num != -1);
> +
> /* For "YES", mark related symbols as asynchronous. */
> if (num == 0)
> {
> --
> 2.25.3
>
Jakub
