On 10/7/19 8:56 AM, Richard Biener wrote:
> On Sun, Oct 6, 2019 at 1:24 PM Bernd Edlinger
> wrote:
>>
>> On 10/5/19 8:24 PM, Segher Boessenkool wrote:
>>>
>>> I am maintainer of combine, I know all about its many problems (it has much
>>> deeper problems than this unfortunately). Thanks for your
On Mon, Oct 07, 2019 at 08:56:44AM +0200, Richard Biener wrote:
> But I agree that mechanically "fixing" the current code-base, while ending up
> with no new introductions of local shadowing, is worse if it makes the current
> code-base worse.
Obfucating the names is not often a good fix for the "
On Sun, Oct 6, 2019 at 1:24 PM Bernd Edlinger wrote:
>
> On 10/5/19 8:24 PM, Segher Boessenkool wrote:
> >
> > I am maintainer of combine, I know all about its many problems (it has much
> > deeper problems than this unfortunately). Thanks for your help though, this
> > is much appreciated, but I
On 10/5/19 8:24 PM, Segher Boessenkool wrote:
>
> I am maintainer of combine, I know all about its many problems (it has much
> deeper problems than this unfortunately). Thanks for your help though, this
> is much appreciated, but I do think your current patch is not a step in the
> right directi
Hi Bernd,
On Sat, Oct 05, 2019 at 09:12:19AM +, Bernd Edlinger wrote:
> On 10/5/19 10:08 AM, Segher Boessenkool wrote:
> > I'll just review the combine part.
> >
> > On Sat, Oct 05, 2019 at 06:36:34AM +, Bernd Edlinger wrote:
> >> --- gcc/combine.c (revision 276598)
> >> +++ gcc/combine.
Hi Segher,
On 10/5/19 10:08 AM, Segher Boessenkool wrote:
> Hi Bernd,
>
> I'll just review the combine part.
>
> On Sat, Oct 05, 2019 at 06:36:34AM +, Bernd Edlinger wrote:
>> --- gcc/combine.c(revision 276598)
>> +++ gcc/combine.c(working copy)
>> @@ -1219,7 +1219,7 @@ combine_instr
Hi Bernd,
I'll just review the combine part.
On Sat, Oct 05, 2019 at 06:36:34AM +, Bernd Edlinger wrote:
> --- gcc/combine.c (revision 276598)
> +++ gcc/combine.c (working copy)
> @@ -1219,7 +1219,7 @@ combine_instructions (rtx_insn *f, unsigned int nr
>FOR_BB_INSNS (this_basi
Hi,
this fixes -Wshadow=local warnings in the following files:
M gcc/asan.c
M gcc/attribs.c
M gcc/auto-inc-dec.c
M gcc/bb-reorder.c
M gcc/builtins.c
M gcc/caller-save.c
M gcc/calls.c
M gcc/cfgbuild.c
M gcc/cfg.c
M gcc/cfgcleanup.c
M
