On 10/5/19 8:24 PM, Segher Boessenkool wrote: > > I am maintainer of combine, I know all about its many problems (it has much > deeper problems than this unfortunately). Thanks for your help though, this > is much appreciated, but I do think your current patch is not a step in the > right direction. >
Hmm, thanks for your open words these are of course important. I will not commit this under obvious rules since you objected to the patch in general. What I want to achieve is to make sure that new code is not introducing more variable shadowing. New shadowing variables are introduced by new code, unless we have a warning enabled. And the warning need to be enabled together with -Werror otherwise it will be overlooked. For instance I believe MISRA has even stronger coding rules with respect to shadowing. What I tried to do was adding -Wshadow=local to the -Werror warnings set and do a more or less mechanical change over the whole code base. How that mechanical change is done - if at all -, needs to be agreed upon. Currently I have the impression that we do not agree if this warning is to be enabled at all. Bernd.
