Re: [PATCH] aarch64: Fix typo in aarch64-ldp-fusion.cc:combine_reg_notes [PR114936]

2024-05-07 Thread Richard Earnshaw (lists)
On 03/05/2024 15:45, Alex Coplan wrote: > This fixes a typo in combine_reg_notes in the load/store pair fusion > pass. As it stands, the calls to filter_notes store any > REG_FRAME_RELATED_EXPR to fr_expr with the following association: > > - i2 -> fr_expr[0] > - i1 -> fr_expr[1] > > but then

[PATCH] aarch64: Fix typo in aarch64-ldp-fusion.cc:combine_reg_notes [PR114936]

2024-05-03 Thread Alex Coplan
This fixes a typo in combine_reg_notes in the load/store pair fusion pass. As it stands, the calls to filter_notes store any REG_FRAME_RELATED_EXPR to fr_expr with the following association: - i2 -> fr_expr[0] - i1 -> fr_expr[1] but then the checks inside the following if statement expect the

Re: [PATCH] aarch64: Fix typo in comment about FEATURE_STRING

2024-04-02 Thread Richard Sandiford
Christophe Lyon writes: > Fix the comment to document FEATURE_STRING instead of FEAT_STRING. > > 2024-03-29 Christophe Lyon > > gcc/ > * config/aarch64/aarch64-option-extensions.def: Fix comment. OK, thanks. Richard > --- > gcc/config/aarch64/aarch64-option-extensions.def | 16 +

[PATCH] aarch64: Fix typo in comment about FEATURE_STRING

2024-03-29 Thread Christophe Lyon
Fix the comment to document FEATURE_STRING instead of FEAT_STRING. 2024-03-29 Christophe Lyon gcc/ * config/aarch64/aarch64-option-extensions.def: Fix comment. --- gcc/config/aarch64/aarch64-option-extensions.def | 16 1 file changed, 8 insertions(+), 8 deleti

Re: [Patch AArch64] Fix typo in aarch64_builtin_reciprocal.

2015-12-01 Thread Ramana Radhakrishnan
On 01/12/15 09:04, Jakub Jelinek wrote: > On Tue, Dec 01, 2015 at 08:58:53AM +, Ramana Radhakrishnan wrote: >> The patch to restructure builtin_reciprocals missed out an obvious ')'. >> Adjusted thusly and applied as obvious to trunk. > > Sorry for that. Could you please also handle the gi

Re: [Patch AArch64] Fix typo in aarch64_builtin_reciprocal.

2015-12-01 Thread Jakub Jelinek
On Tue, Dec 01, 2015 at 08:58:53AM +, Ramana Radhakrishnan wrote: > The patch to restructure builtin_reciprocals missed out an obvious ')'. > Adjusted thusly and applied as obvious to trunk. Sorry for that. Could you please also handle the gimple_call_internal_p case, so that it actually ret

[Patch AArch64] Fix typo in aarch64_builtin_reciprocal.

2015-12-01 Thread Ramana Radhakrishnan
The patch to restructure builtin_reciprocals missed out an obvious ')'. Adjusted thusly and applied as obvious to trunk. regards Ramana 2015-12-01 Ramana Radhakrishnan * config/aarch64/aarch64.c (aarch64_builtin_reciprocal): Fix typo.

[PATCH] [AArch64] fix typo in vec_store_lanesoi_lane

2015-07-22 Thread Charles Baylis
Committed as obvious r226061. gcc/ChangeLog: 2015-07-22 Charles Baylis * config/aarch64/aarch64-simd.md (vec_store_lanesoi_lane): Fix typo in attribute. From 7d98f7fc82cfc3012b460e4f4f91200fedcb04db Mon Sep 17 00:00:00 2001 From: Charles Baylis Date: Tue, 21 Jul 2015 16:54:32

Re: [PATCH, AArch64] Fix typo

2014-08-26 Thread Richard Earnshaw
On 15/08/14 17:24, Evandro Menezes wrote: > I tripped at a typo that goes undetected because the macro NAMED_PARAM > doesn't apply in the absence of designated initializers. > > Since struct scale_addr_mode_cost has the cost for DI, but not for QI, the > instances of struct cpu_addrcost_table are

RE: [PATCH, AArch64] Fix typo

2014-08-20 Thread Evandro Menezes
Greenhalgh; Richard Earnshaw; Marcus Shawcroft; ram...@gcc.gnu.org Subject: Re: [PATCH, AArch64] Fix typo On Wed, Aug 20, 2014 at 4:45 PM, Evandro Menezes wrote: > This is a trivial patch. However, without it, the addressing mode > cost is incorrectly calculated, since the cost intended for

Re: [PATCH, AArch64] Fix typo

2014-08-20 Thread Ramana Radhakrishnan
: Evandro Menezes [mailto:e.mene...@samsung.com] > Sent: Tuesday, August 19, 2014 14:40 > To: 'James Greenhalgh' > Cc: 'gcc-patches@gcc.gnu.org'; 'James Greenhalgh'; > 'richard.earns...@arm.com'; 'marcus.shawcr...@arm.com' > Subject:

RE: [PATCH, AArch64] Fix typo

2014-08-20 Thread Evandro Menezes
ichard.earns...@arm.com'; 'marcus.shawcr...@arm.com' Subject: RE: [PATCH, AArch64] Fix typo Ping, pretty please. -- Evandro Menezes Austin, USA e.mene...@samsung.com +1-512-425-3365 -Original Message- From: Evandro Menezes [mailto:e.m

RE: [PATCH, AArch64] Fix typo

2014-08-19 Thread Evandro Menezes
x27;gcc-patches@gcc.gnu.org'; 'James Greenhalgh'; 'richard.earns...@arm.com'; 'marcus.shawcr...@arm.com' Subject: RE: [PATCH, AArch64] Fix typo Ping. -- Evandro Menezes Austin, USA e.mene...@samsung.com +1-512-425-336

RE: [PATCH, AArch64] Fix typo

2014-08-18 Thread Evandro Menezes
hes@gcc.gnu.org'; 'James Greenhalgh'; 'richard.earns...@arm.com'; 'marcus.shawcr...@arm.com' Subject: RE: [PATCH, AArch64] Fix typo Thanks for the review. -- Evandro Menezes Austin, USA e.mene...@samsung.com +1-512-425-336

RE: [PATCH, AArch64] Fix typo

2014-08-15 Thread Evandro Menezes
, 2014 11:36 To: Evandro Menezes Cc: gcc-patches@gcc.gnu.org; 'James Greenhalgh'; richard.earns...@arm.com; marcus.shawcr...@arm.com Subject: Re: [PATCH, AArch64] Fix typo On Fri, Aug 15, 2014 at 05:24:58PM +0100, Evandro Menezes wrote: > I tripped at a typo that goes undetected beca

Re: [PATCH, AArch64] Fix typo

2014-08-15 Thread James Greenhalgh
On Fri, Aug 15, 2014 at 05:24:58PM +0100, Evandro Menezes wrote: > I tripped at a typo that goes undetected because the macro NAMED_PARAM > doesn't apply in the absence of designated initializers. > > Since struct scale_addr_mode_cost has the cost for DI, but not for QI, the > instances of struct

[PATCH, AArch64] Fix typo

2014-08-15 Thread Evandro Menezes
I tripped at a typo that goes undetected because the macro NAMED_PARAM doesn't apply in the absence of designated initializers. Since struct scale_addr_mode_cost has the cost for DI, but not for QI, the instances of struct cpu_addrcost_table are not initialized as intended due to the different ord