Ping. -- Evandro Menezes Austin, USA [email protected] +1-512-425-3365 -----Original Message----- From: Evandro Menezes [mailto:[email protected]] Sent: Friday, August 15, 2014 14:55 To: 'James Greenhalgh' Cc: '[email protected]'; 'James Greenhalgh'; '[email protected]'; '[email protected]' Subject: RE: [PATCH, AArch64] Fix typo
Thanks for the review. -- Evandro Menezes Austin, USA [email protected] +1-512-425-3365 -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of James Greenhalgh Sent: Friday, August 15, 2014 11:36 To: Evandro Menezes Cc: [email protected]; 'James Greenhalgh'; [email protected]; [email protected] Subject: Re: [PATCH, AArch64] Fix typo On Fri, Aug 15, 2014 at 05:24:58PM +0100, Evandro Menezes wrote: > I tripped at a typo that goes undetected because the macro NAMED_PARAM > doesn't apply in the absence of designated initializers. > > Since struct scale_addr_mode_cost has the cost for DI, but not for QI, > the instances of struct cpu_addrcost_table are not initialized as > intended due to the different order of the structure members. Thanks for spotting and fixing this. The ChangeLog entry should be added to gcc/ChangeLog, and should look like this: 2014-08-14 Evandro Menezes <[email protected]> * config/aarch64/aarch64.c (generic_addrcost_table): Initialize elements in the correct order. (cortexa57_addrcost_table): Likewise. My fixes were: * Two spaces between your name and email address. * Name the structure/function/thing changed. * Set the path relative to the ChangeLog being modified. Otherwise, this patch looks correct to me. However, you will need approval from an AArch64 port maintainer (For AArch64 this is Richard Earnshaw or Marcus Shawcroft - both added to CC). Thanks, James
