Re: [001/nnn] poly_int: add poly-int.h

2017-12-15 Thread Jeff Law
On 12/15/2017 02:08 AM, Richard Biener wrote: > On Fri, Dec 15, 2017 at 4:40 AM, Martin Sebor wrote: >> On 12/07/2017 03:48 PM, Jeff Law wrote: >>> >>> On 12/07/2017 03:38 PM, Richard Sandiford wrote: >>> > So I think that's the final ack on this series. Thanks to both of you, r

Re: [001/nnn] poly_int: add poly-int.h

2017-12-15 Thread Richard Biener
On Fri, Dec 15, 2017 at 4:40 AM, Martin Sebor wrote: > On 12/07/2017 03:48 PM, Jeff Law wrote: >> >> On 12/07/2017 03:38 PM, Richard Sandiford wrote: >> So I think that's the final ack on this series. >>> >>> >>> Thanks to both of you, really appreciate it! >> >> Sorry it took so long. >> >>>

Re: [001/nnn] poly_int: add poly-int.h

2017-12-14 Thread Martin Sebor
On 12/07/2017 03:48 PM, Jeff Law wrote: On 12/07/2017 03:38 PM, Richard Sandiford wrote: So I think that's the final ack on this series. Thanks to both of you, really appreciate it! Sorry it took so long. Richard S. can you confirm? I fully expect the trunk has moved some and the patche

Re: [001/nnn] poly_int: add poly-int.h

2017-12-07 Thread Jeff Law
On 12/07/2017 03:38 PM, Richard Sandiford wrote: >> So I think that's the final ack on this series. > > Thanks to both of you, really appreciate it! Sorry it took so long. > >> Richard S. can you confirm? I fully expect the trunk has moved some >> and the patches will need adjustments -- consi

Re: [001/nnn] poly_int: add poly-int.h

2017-12-07 Thread Richard Sandiford
Jeff Law writes: > On 12/07/2017 07:46 AM, Richard Biener wrote: >> On Wed, Dec 6, 2017 at 9:11 PM, Jeff Law wrote: >>> On 11/13/2017 05:04 PM, Richard Sandiford wrote: Richard Sandiford writes: > Richard Sandiford writes: >> This patch adds a new "poly_int" class to represent poly

Re: [001/nnn] poly_int: add poly-int.h

2017-12-07 Thread Jeff Law
On 12/07/2017 07:46 AM, Richard Biener wrote: > On Wed, Dec 6, 2017 at 9:11 PM, Jeff Law wrote: >> On 11/13/2017 05:04 PM, Richard Sandiford wrote: >>> Richard Sandiford writes: Richard Sandiford writes: > This patch adds a new "poly_int" class to represent polynomial integers > of

Re: [001/nnn] poly_int: add poly-int.h

2017-12-07 Thread Richard Biener
On Wed, Dec 6, 2017 at 9:11 PM, Jeff Law wrote: > On 11/13/2017 05:04 PM, Richard Sandiford wrote: >> Richard Sandiford writes: >>> Richard Sandiford writes: This patch adds a new "poly_int" class to represent polynomial integers of the form: C0 + C1*X1 + C2*X2 ... + Cn*Xn

Re: [001/nnn] poly_int: add poly-int.h

2017-12-06 Thread Jeff Law
On 11/13/2017 05:04 PM, Richard Sandiford wrote: > Richard Sandiford writes: >> Richard Sandiford writes: >>> This patch adds a new "poly_int" class to represent polynomial integers >>> of the form: >>> >>> C0 + C1*X1 + C2*X2 ... + Cn*Xn >>> >>> It also adds poly_int-based typedefs for offsets

Re: [001/nnn] poly_int: add poly-int.h

2017-11-16 Thread Jeff Law
On 11/13/2017 04:36 PM, Richard Sandiford wrote: > Jeff Law writes: >> On 11/09/2017 04:06 AM, Richard Sandiford wrote: >> Let me say at the outset that I struggle to comprehend that a few instructions is even a consideration when not optimizing, especially in light of the bug the m

Re: [001/nnn] poly_int: add poly-int.h

2017-11-14 Thread Richard Sandiford
Martin Sebor writes: > On 11/13/2017 04:36 PM, Richard Sandiford wrote: >> Jeff Law writes: >>> On 11/09/2017 04:06 AM, Richard Sandiford wrote: >>> > Let me say at the outset that I struggle to comprehend that a few > instructions is even a consideration when not optimizing, especially >

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Martin Sebor
On 11/13/2017 04:36 PM, Richard Sandiford wrote: Jeff Law writes: On 11/09/2017 04:06 AM, Richard Sandiford wrote: Let me say at the outset that I struggle to comprehend that a few instructions is even a consideration when not optimizing, especially in light of the bug the macro caused that w

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Richard Sandiford
Richard Sandiford writes: > Richard Sandiford writes: >> This patch adds a new "poly_int" class to represent polynomial integers >> of the form: >> >> C0 + C1*X1 + C2*X2 ... + Cn*Xn >> >> It also adds poly_int-based typedefs for offsets and sizes of various >> precisions. In these typedefs, th

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Richard Sandiford
Jeff Law writes: > On 11/09/2017 04:06 AM, Richard Sandiford wrote: > >>> Let me say at the outset that I struggle to comprehend that a few >>> instructions is even a consideration when not optimizing, especially >>> in light of the bug the macro caused that would have been prevented >>> by using

Re: [001/nnn] poly_int: add poly-int.h

2017-11-13 Thread Jeff Law
On 11/09/2017 04:06 AM, Richard Sandiford wrote: >> Let me say at the outset that I struggle to comprehend that a few >> instructions is even a consideration when not optimizing, especially >> in light of the bug the macro caused that would have been prevented >> by using a function instead. But.

Re: [001/nnn] poly_int: add poly-int.h

2017-11-09 Thread Martin Sebor
On 11/09/2017 04:06 AM, Richard Sandiford wrote: Martin Sebor writes: On 11/08/2017 11:28 AM, Richard Sandiford wrote: Martin Sebor writes: On 11/08/2017 09:51 AM, Richard Sandiford wrote: Martin Sebor writes: On 11/08/2017 02:32 AM, Richard Sandiford wrote: Martin Sebor writes: I have

Re: [001/nnn] poly_int: add poly-int.h

2017-11-09 Thread Richard Sandiford
Martin Sebor writes: > On 11/08/2017 11:28 AM, Richard Sandiford wrote: >> Martin Sebor writes: >>> On 11/08/2017 09:51 AM, Richard Sandiford wrote: Martin Sebor writes: > On 11/08/2017 02:32 AM, Richard Sandiford wrote: >> Martin Sebor writes: >>> I haven't done nearly a thoro

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Martin Sebor
On 11/08/2017 11:28 AM, Richard Sandiford wrote: Martin Sebor writes: On 11/08/2017 09:51 AM, Richard Sandiford wrote: Martin Sebor writes: On 11/08/2017 02:32 AM, Richard Sandiford wrote: Martin Sebor writes: I haven't done nearly a thorough review but the dtor followed by the placement

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Richard Sandiford
Martin Sebor writes: > On 11/08/2017 09:51 AM, Richard Sandiford wrote: >> Martin Sebor writes: >>> On 11/08/2017 02:32 AM, Richard Sandiford wrote: Martin Sebor writes: > I haven't done nearly a thorough review but the dtor followed by > the placement new in the POLY_SET_COEFF() ma

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Martin Sebor
On 11/08/2017 09:51 AM, Richard Sandiford wrote: Martin Sebor writes: On 11/08/2017 02:32 AM, Richard Sandiford wrote: Martin Sebor writes: I haven't done nearly a thorough review but the dtor followed by the placement new in the POLY_SET_COEFF() macro caught my eye so I thought I'd ask soon

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Martin Sebor
On 11/08/2017 09:51 AM, Richard Sandiford wrote: Martin Sebor writes: On 11/08/2017 02:32 AM, Richard Sandiford wrote: Martin Sebor writes: I haven't done nearly a thorough review but the dtor followed by the placement new in the POLY_SET_COEFF() macro caught my eye so I thought I'd ask soon

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Richard Sandiford
Martin Sebor writes: > On 11/08/2017 02:32 AM, Richard Sandiford wrote: >> Martin Sebor writes: >>> I haven't done nearly a thorough review but the dtor followed by >>> the placement new in the POLY_SET_COEFF() macro caught my eye so >>> I thought I'd ask sooner rather than later. Given the macr

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Martin Sebor
On 11/08/2017 02:32 AM, Richard Sandiford wrote: Martin Sebor writes: I haven't done nearly a thorough review but the dtor followed by the placement new in the POLY_SET_COEFF() macro caught my eye so I thought I'd ask sooner rather than later. Given the macro definition: + The dummy compari

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Richard Sandiford
Richard Sandiford writes: > This patch adds a new "poly_int" class to represent polynomial integers > of the form: > > C0 + C1*X1 + C2*X2 ... + Cn*Xn > > It also adds poly_int-based typedefs for offsets and sizes of various > precisions. In these typedefs, the Ci coefficients are compile-time >

Re: [001/nnn] poly_int: add poly-int.h

2017-11-08 Thread Richard Sandiford
Martin Sebor writes: > I haven't done nearly a thorough review but the dtor followed by > the placement new in the POLY_SET_COEFF() macro caught my eye so > I thought I'd ask sooner rather than later. Given the macro > definition: > > + The dummy comparison against a null C * is just a way of c

Re: [001/nnn] poly_int: add poly-int.h

2017-10-25 Thread Martin Sebor
On 10/23/2017 10:57 AM, Richard Sandiford wrote: This patch adds a new "poly_int" class to represent polynomial integers of the form: C0 + C1*X1 + C2*X2 ... + Cn*Xn It also adds poly_int-based typedefs for offsets and sizes of various precisions. In these typedefs, the Ci coefficients are co

[001/nnn] poly_int: add poly-int.h

2017-10-23 Thread Richard Sandiford
This patch adds a new "poly_int" class to represent polynomial integers of the form: C0 + C1*X1 + C2*X2 ... + Cn*Xn It also adds poly_int-based typedefs for offsets and sizes of various precisions. In these typedefs, the Ci coefficients are compile-time constants and the Xi indeterminates are