Re: [PATCH 2/4] cfgloopmanip: Add infrastructure for scaling of multi-exit loops [PR117790]

On 6 January 2025 12:34:45 CET, Alex Coplan wrote: nit: s/caling/calling/ thanks

Re: [PATCH] Fortran: fix front-end GMP memleaks

On 22 December 2024 21:50:41 CET, Harald Anlauf wrote: >Dear all, > >please find attached fixes for GMP memleaks in the gfortran frontend >found when running f951 under valgrind. One of them surfaced when >looking at a testcases that invoved pointer rank remapping. After a >successful gfc_array_

Re: [PATCH 2/4] RISC-V: Implement TARGET_SCHED_PRESSURE_PREFER_NARROW [PR/114729]

On 20 October 2024 21:40:16 CEST, Vineet Gupta wrote: >diff --git a/gcc/testsuite/gcc.target/riscv/sched1-spills/spill1.cpp >b/gcc/testsuite/gcc.target/riscv/sched1-spills/spill1.cpp >new file mode 100644 >index ..47a9d1a01ab4 >--- /dev/null >+++ b/gcc/testsuite/gcc.target/riscv/sche

Re: [Patch] Fortran: Use OpenACC's acc_on_device builtin, fix OpenMP' __builtin_is_initial_device

On 14 October 2024 10:23:56 CEST, Thomas Schwinge wrote: >Hi Tobias! > >On 2024-10-13T10:21:01+0200, Tobias Burnus wrote: >> Now pushed as r15-4298-g3269a722b7a036. > >> Tobias Burnus wrote: >>> Anyone feeling like reviewing this patch? > >Yes. But please allow for more than 1 1/2 work days. >

Re: [Patch] Fortran: Dead-function removal in error.cc (shrinking by 40%)

On 11 October 2024 16:42:44 CEST, David Malcolm wrote: >On Fri, 2024-10-11 at 15:34 +0100, Paul Richard Thomas wrote: >> Hi Tobias, >> >> Good catch! It looks 'obvious' to me too :-) yeah, thanks for the explicit cleanup >> > * I want to move support range-based locations, which is also a >>

Re: [PATCH] arm: Force flag_pic for FDPIC

On 26 September 2024 20:51:55 CEST, Fangrui Song wrote: >On Thu, Sep 26, 2024 at 11:21 AM Ramana Radhakrishnan > wrote: >> >> On Mon, Mar 4, 2024 at 1:43 PM Fangrui Song wrote: >> > >> > From: Fangrui Song >> > >> > -fno-pic -mfdpic generated code is like regular -fno-pic, not suitable >> > for

Re: [PATCH] arm: Force flag_pic for FDPIC

On 27 September 2024 16:05:01 CEST, "Richard Earnshaw (lists)" wrote: >On 26/09/2024 19:21, Ramana Radhakrishnan wrote: >> On Mon, Mar 4, 2024 at 1:43 PM Fangrui Song wrote: >>> >>> From: Fangrui Song >>> >>> -fno-pic -mfdpic generated code is like regular -fno-pic, not suitable >>> for FDPIC (

Re: [PATCH] gfortran testsuite: Remove unit-files in files having open-statements, PR116701

On 25 September 2024 22:08:15 CEST, rep.dot@gmail.com wrote: > >>Your interpretation of my typo is correct. Along with Andre I like auto >>cleanup. On new test cases we try to have them self delete whether they pass >>or fail. >> > >so why don't we issue the cleanup then, regardless?

Re: [PATCH] gfortran testsuite: Remove unit-files in files having open-statements, PR116701

>Your interpretation of my typo is correct. Along with Andre I like auto >cleanup. On new test cases we try to have them self delete whether they pass >or fail. > so why don't we issue the cleanup then, regardless? >So your changes are ok with me. > >> No. >> >>>

Re: [PATCH v2] gfortran testsuite: Remove unit-files in files having open-statements, PR116701

On 25 September 2024 13:51:07 CEST, Andre Vehreschild wrote: >Hi Hans-Peter, > >preface: I am not a testsuite nor an m4 expert. > >So I may be wrong in arguing that your changes look reasonable. I like the >"automatic" clean-up process very much. So by me, ok for mainline. But you may >want to wai

Re: [PATCH] fortran: Support optional dummy as BACK argument of MINLOC/MAXLOC.

On 27 July 2024 21:11:19 CEST, Mikael Morin wrote: >Le 27/07/2024 à 19:23, rep.dot@gmail.com a écrit : >> On 22 July 2024 20:53:18 CEST, Mikael Morin wrote: >>> From: Mikael Morin >>> >>> Hello, >>> >>> this fixes a null pointer dereference with absent optional dummy passed >>> as BACK arg

Re: [PATCH] fortran: Support optional dummy as BACK argument of MINLOC/MAXLOC.

On 22 July 2024 20:53:18 CEST, Mikael Morin wrote: >From: Mikael Morin > >Hello, > >this fixes a null pointer dereference with absent optional dummy passed >as BACK argument of MINLOC/MAXLOC. > >Tested for regression on x86_64-linux. >OK for master? > >-- >8 -- > >Protect the evaluation of BACK w

Re: [Patch] Fortran: invoke.texi - link to OpenCoarrays.org + mention libcaf_single

On 20 May 2024 02:31:27 CEST, Sandra Loosemore wrote: >On 5/19/24 02:01, Tobias Burnus wrote: >> I noticed that gfortran's coarray support did not link to the >> http://www.opencoarrays.org/ > >> [snip] >> >> diff --git a/gcc/fortran/invoke.texi b/gcc/fortran/invoke.texi >> index 40e8e4a7cdd..78

Re: [PATCH] Value range: Add range op for __builtin_isfinite

On 12 April 2024 07:30:10 CEST, HAO CHEN GUI wrote: > > >patch.diff >diff --git a/gcc/gimple-range-op.cc b/gcc/gimple-range-op.cc >index 9de130b4022..99c511728d3 100644 >--- a/gcc/gimple-range-op.cc >+++ b/gcc/gimple-range-op.cc >@@ -1192,6 +1192,56 @@ public: > } > } op_cfn_isinf; > >+//Imple

Re: [PATCH v3] tree-profile: Disable indirect call profiling for IFUNC resolvers

On 5 April 2024 03:03:05 CEST, "H.J. Lu" wrote: >On Thu, Apr 4, 2024 at 5:34 PM wrote: >> >> On 3 April 2024 15:49:13 CEST, "H.J. Lu" wrote: > >> + /* Skip if it has been visited. */ >> + unsigned int uid = e->caller->get_uid (); >> + if (bitmap_bit_p (ifunc_ref_map, uid)) >> +

Re: [PATCH v3] tree-profile: Disable indirect call profiling for IFUNC resolvers

On 3 April 2024 15:49:13 CEST, "H.J. Lu" wrote: >> OK witht that change. >> Honza > >I am checking in this patch with the updated comments: > > /* Disable indirect call profiling for an IFUNC resolver and its > callees since it requires TLS which hasn't been set up yet when > the dynami

Re: [PATCH] cpp: new built-in __EXP_COUNTER__

On 19 March 2024 18:27:13 CET, Kaz Kylheku wrote: >On 2024-03-18 00:30, Jonathan Wakely wrote: >> I don't have an opinion on the implementation, or the proposal itself, >> except that the implementation seems susprisingly simple, which is >> nice. > >Hi Jonathan, > >Here is an updated patch. > >It

Re: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

On 19 March 2024 14:40:57 CET, Christophe Lyon wrote: >On Mon, 18 Mar 2024 at 22:35, Evgeny Karpov >wrote: >> >> Monday, March 18, 2024 2:27 PM >> Christophe Lyon wrote: >> >> > > +/* Disable SEH and declare the required SEH-related macros that are >> > > +still needed for compilation. */ #und

Re: [patch, libgfortran] Part 2: PR105456 Child I/O does not propage iostat

On 5 March 2024 04:15:12 CET, Jerry D wrote: > >Attached is the revised patch using the already available string_len_trim >function. > >This hunk is only executed if a user has not passed an iostat or iomsg >variable in the parent I/O statement and an error is triggered which >terminates execu

Re: [PATCH, v2] Fix fortran/PR114024

On 23 February 2024 22:15:17 CET, Harald Anlauf wrote: >Hi Steve, all, > >here's an updated patch with an enhanced testcase that also >checks MOLD= besides SOURCE=. > >Regtested on x86_64-pc-linux-gnu. Is it OK for mainline? LGTM cheers > >Cheers, >Harald

Re: [PATCH v1 05/13] Reuse MinGW from i386 for AArch64

On 21 February 2024 19:34:43 CET, Evgeny Karpov wrote: > Please use git send-email. Your mail ends up as empty as here, otherwise. The ChangeLog has to be expressed in present tense, as mandated by the standard; s/Moved/Move/g etc. In any sane world ( and in gcc ) to fold, respectively a fold

Re: [PATCH 5/5] bpf: renamed coreout.* files to btfext-out.*.

On 21 February 2024 18:16:30 CET, David Faust wrote: > > >On 2/20/24 02:24, Cupertino Miranda wrote: >> gcc/ChangeLog: >> * config.gcc (target_gtfiles): changed coreout to btfext-out. >> (extra_objs): changed coreout to btfext-out. > >I think these entries should start with a capital let

Re: [PATCH] gcc/configure: Re-introduce INSTALL_INFO

On 5 February 2024 12:30:23 CET, Christophe Lyon wrote: >On Fri, 2 Feb 2024 at 11:40, Christophe Lyon >wrote: >> >> On Fri, 2 Feb 2024 at 11:10, wrote: >> > >> > On 1 February 2024 18:15:34 CET, Christophe Lyon >> > wrote: >> > >BUILD_INFO is currently a byproduct of checking makeinfo >> > >

Re: [PATCH] x86-64: Find a scratch register for large model profiling

On 2 February 2024 00:02:54 CET, "H.J. Lu" wrote: >On Thu, Feb 1, 2024 at 10:32 AM Jakub Jelinek wrote: >> >> On Thu, Feb 01, 2024 at 10:15:30AM -0800, H.J. Lu wrote: >> > --- a/gcc/config/i386/i386.cc >> > +++ b/gcc/config/i386/i386.cc >> > @@ -22749,6 +22749,31 @@ current_fentry_section (const

Re: [PATCH] gcc/configure: Re-introduce INSTALL_INFO

On 1 February 2024 18:15:34 CET, Christophe Lyon wrote: >BUILD_INFO is currently a byproduct of checking makeinfo >presence/version. INSTALL_INFO used to be defined similarly, but was >removed in 2000 (!) by commit 17db658241d18cf6db59d31bc2d6eac96e9257df >(svn r38141). > >In order to save build

Re: [PATCH] Fortran: Mark internal symbols as artificial [PR88009,PR68800]

On 29 January 2024 22:06:04 CET, Harald Anlauf wrote: >Am 29.01.24 um 21:45 schrieb Bernhard Reutner-Fischer: >> On Wed, 17 Nov 2021 21:32:14 +0100 >> Harald Anlauf wrote: >> >>> Do you have testcases/reproducers demonstrating that the patch actually >>> fixes the issues you're describing? >> >

Re: [PATCH] Fortran: use name of array component in runtime error message [PR30802]

On 28 January 2024 22:43:37 CET, Steve Kargl wrote: >On Sun, Jan 28, 2024 at 08:56:24PM +0100, Harald Anlauf wrote: >> >> Am 28.01.24 um 12:39 schrieb Mikael Morin: >> > Le 24/01/2024 à 22:39, Harald Anlauf a écrit : >> > > Dear all, >> > > >> > > this patch is actually only a followup fix to g

Re: [PATCH v2 5/5] Add documentation for musttail attribute

On 24 January 2024 20:30:45 CET, Andi Kleen wrote: >--- > gcc/doc/extend.texi | 16 > 1 file changed, 16 insertions(+) > >diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi >index 0bc586d120e7..c68d32bed8de 100644 >--- a/gcc/doc/extend.texi >+++ b/gcc/doc/extend.texi >@@ -9867,

Re: [PATCH] openmp: Change to using a hashtab to lookup offload target addresses for indirect function calls

On 22 January 2024 21:33:17 CET, Kwok Cheung Yeung wrote: >Hi > >There was a bug in the declare-target-indirect-2.c libgomp testcase (testing >indirect calls in offloaded target regions, spread over multiple >teams/threads) that due to an errant fallthrough in a switch statement >resulted in o

Re: Fix merging of value predictors

On 17 January 2024 14:20:49 CET, Jan Hubicka wrote: >--- a/gcc/predict.def >+++ b/gcc/predict.def >@@ -94,6 +94,16 @@ DEF_PREDICTOR (PRED_LOOP_ITERATIONS_GUESSED, "guessed loop >iterations", > DEF_PREDICTOR (PRED_LOOP_ITERATIONS_MAX, "guessed loop iterations", > PROB_UNINITIALIZED,

Re: [committed] Fix comment typos

Hi Just another commentary typo.. On 17 January 2024 11:23:01 CET, Jakub Jelinek wrote: >--- gcc/gengtype.cc.jj 2024-01-03 11:51:23.314845233 +0100 >+++ gcc/gengtype.cc2024-01-16 18:56:57.383009291 +0100 >@@ -4718,8 +4718,8 @@ write_roots (pair_p variables, bool emit > } > > /* Prints not-

Re: [PATCH] RISC-V: Tweak the wording for the sorry message

On 19 January 2024 03:41:57 CET, Kito Cheng wrote: >Thanks, pushed to trunk :) Thanks, but don't you have to update the tests too, at least gcc/testsuite/gcc.target/riscv/rvv/base/big_endian-2.c ? thanks > >On Fri, Jan 19, 2024 at 10:36 AM juzhe.zh...@rivai.ai > wrote: >> >> OK >> >> __

Re: [commit] MIPS: Add ATTRIBUTE_UNUSED to mips_start_function_definition

On 11 January 2024 10:59:21 CET, YunQiang Su wrote: >Fix build warning: > mips.cc: warning: unused parameter 'decl'. > >gcc > * config/mips/mips.cc (mips_start_function_definition): > Add ATTRIBUTE_UNUSED. >--- > gcc/config/mips/mips.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 del

Re: hurd: Add multilib paths for gnu-x86_64

On 27 November 2023 15:48:33 CET, Thomas Schwinge wrote: >Hi! > >On 2023-10-28T21:19:59+0200, Samuel Thibault wrote: >> We need the multilib paths in gcc to find e.g. glibc crt files on >> Debian. > >ACK. > >> This is essentially based on t-linux64 version. > >Yes, but isn't the overall setup di

Re: [RFA] New pass for sign/zero extension elimination

On 22 November 2023 23:23:41 CET, Jeff Law wrote: > > >On 11/20/23 11:56, Dimitar Dimitrov wrote: >> On Sun, Nov 19, 2023 at 05:47:56PM -0700, Jeff Law wrote: >> ... >>> + enum rtx_code xcode = GET_CODE (x); >>> + if (xcode == SET) >>> + { >>> + const_rtx dst = SET_DEST (x); >>> +

Re: [PATCH v2] Format gotools.sum closer to what DejaGnu does

On 3 November 2023 14:38:06 CET, Jeff Law wrote: > > >On 11/3/23 06:54, Maxim Kuvyrkov wrote: >> gotools/ChangeLog: >> >> * Makefile.am: Update "Running ..." output >> * Makefile.in: Regenerate. >OK. Thanks for running down the differences in the autogenerated bits. Many thanks for

Re: [PATCH 2/4] maintainer-scripts/gcc_release: create index between snapshots <-> commits

On 2 November 2023 11:25:47 CET, Jonathan Wakely wrote: >On Thu, 2 Nov 2023 at 10:23, Andreas Schwab wrote: >> >> On Nov 02 2023, Jonathan Wakely wrote: >> >> > Git tags are cheap, but I can imagine a concern about hundreds of new >> > tags "littering" the output of 'git tag -l'. I don't _think_ y

Re: [PATCH] Format gotools.sum closer to what DejaGnu does

On 2 November 2023 18:06:54 CET, Maxim Kuvyrkov wrote: >> On Nov 2, 2023, at 21:02, rep.dot@gmail.com wrote: >> >> Hi Maxim! >> >> Many thanks for the patch! Quick question below.. >> >> On 2 November 2023 13:48:55 CET, Maxim Kuvyrkov >> wrote: >>> ... to restore compatability with valid

Re: [PATCH] Format gotools.sum closer to what DejaGnu does

Hi Maxim! Many thanks for the patch! Quick question below.. On 2 November 2023 13:48:55 CET, Maxim Kuvyrkov wrote: >... to restore compatability with validate_failures.py . >The testsuite script validate_failures.py expects >"Running ..." to extract values, >and gotools.sum provided "Running

Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

On 24 October 2023 09:36:22 CEST, Ajit Agarwal wrote: >Hello Bernhard: > >On 23/10/23 7:40 pm, Bernhard Reutner-Fischer wrote: >> On Mon, 23 Oct 2023 12:16:18 +0530 >> Ajit Agarwal wrote: >> >>> Hello All: >>> >>> Addressed below review comments in the version 11 of the patch. >>> Please review

Re: [PATCH] Fortran/OpenMP: event handle in task detach cannot be a coarray [PR104131]

On 24 October 2023 21:25:01 CEST, Harald Anlauf wrote: >Dear all, > >the attached simple patch adds a forgotten check that an event handle >cannot be a coarray. This case appears to have been overlooked in the >original fix for this PR. > >I intend to commit as obvious within 24h unless there are

Re: [PATCH] gcc.c-torture/execute/builtins/fputs.c: Define _GNU_SOURCE

On 22 October 2023 21:45:12 CEST, Jeff Law wrote: > > >On 10/22/23 10:09, Andrew Pinski wrote: >> On Sun, Oct 22, 2023 at 12:47 AM Florian Weimer wrote: >>> >>> Current glibc headers only declare fputs_unlocked for _GNU_SOURCE. >>> Defining the macro avoids an implicit function declaration. >>

Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

On 21 October 2023 01:56:16 CEST, Vineet Gupta wrote: >On 10/19/23 23:50, Ajit Agarwal wrote: >> Hello All: >> >> This version 9 of the patch uses abi interfaces to remove zero and sign >> extension elimination. >> Bootstrapped and regtested on powerpc-linux-gnu. >> >> In this version (version

Re: [PATCH v9] tree-ssa-sink: Improve code sinking pass

On 12 October 2023 14:35:36 CEST, Ajit Agarwal wrote: >This patch improves code sinking pass to sink statements before call to reduce >register pressure. >Review comments are incorporated. Typo: "block block" And spurious whitespace changes.

Re: [PATCH 01/12] [contrib] validate_failures.py: Avoid testsuite aliasing

On 27 September 2023 16:47:27 CEST, Maxim Kuvyrkov wrote: >Hi Bernhard, > >Thanks, I meant to fix this, but forgot. np. >The underlying problem here is that we want to detect which sub-testsuites had >failures. Current regex doesn't match go's case because there is no "..." at >the end: "Run