On 19 March 2024 18:27:13 CET, Kaz Kylheku <k...@kylheku.com> wrote: >On 2024-03-18 00:30, Jonathan Wakely wrote: >> I don't have an opinion on the implementation, or the proposal itself, >> except that the implementation seems susprisingly simple, which is >> nice. > >Hi Jonathan, > >Here is an updated patch. > >It rebased cleanly over more than newer 16000 commits, suggesting >that the area in the cpp code is "still waters", which is good. > >I made the documentation change not to recommend using #if, but >#ifdef. > >I got rid of the ChangeLog changes, and also tried to pay more >attention to the log message format, where the ChangeLog pieces >are specified. > >In the first test case, I had to adjust the expected warning text >for two lines. >
Please forgive the bike shedding, but __EXP_COUNTER__ would lead me into thinking about exponents or thereabouts. __MACRO_EXPANSION_COUNTER__ is more what your patch is about, IMHO? Maybe you could come up with a more descriptive name, please? And, while I can see what could possibly be done with that, I'm not really convinced that it would be a wise idea to (unilaterally) support that idea. Don't you think that this would encourage producing more spaghetti code? Just curious about real world motivating examples I guess. cheers
