Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-18 Thread Sam James
Philipp Tomsich writes: > Applied to trunk (16.0.0), thank you! > Should this be backported to the GCC-15 release branch as well? BTW, what's the plan for enabling this on trunk now by default? (I don't recall if some other issues were left.)

Re: [PATCH 1/2] DSE: Support triming of some more memset [PR87901]

2025-04-17 Thread Sam James
Andrew Pinski writes: > DSE has support for trimming memset (and memset like) statements. > In this case we have `MEM [(char * {ref-all})&z] = {};` in > the IR and when we go to trim it, we call build_fold_addr_expr which leaves > around This looks cut off?

Re: [PATCH] Add COBOL information to gcc.gnu.org index.html

2025-04-17 Thread Sam James
Robert Dubner writes: > Okay for htdocs/master? > > From d412e45d5afeecded3c8cf1b6b2865e088a480cc Mon Sep 17 00:00:00 2001 > From: Robert Dubner > Date: Thu, 17 Apr 2025 15:12:26 -0400 > Subject: [PATCH] Add COBOL information to gcc.gnu.org index.html > > * htdocs/index.html: Add COBOL inf

[PATCH v2] doc: say "compatible types" for -fstrict-aliasing

2025-04-16 Thread Sam James
Include the term used in the standard to ease further research for users, and while at it, rephrase the description of the rule entirely using Alexander Monakov's suggestion: it was previously wrong (and imprecise) as "the same address" may well be re-used later on, and the issue is the access via

Re: [PATCH] doc: say "compatible types" for -fstrict-aliasing

2025-04-16 Thread Sam James
Jakub Jelinek writes: > On Wed, Mar 26, 2025 at 10:41:52AM +0000, Sam James wrote: >> Include the term used in the standard to ease further research for users. >> >> gcc/ChangeLog: >> >> * doc/invoke.texi: Use "compatible types" term. >> --

Re: [PATCH] PR tree-optimization/119712 - Always reflect lower bits from mask in subranges.

2025-04-16 Thread Sam James
Andrew MacLeod writes: > This was a fun one!   An actual bug, and it took a while to sort out.  > After chasing down some red herrings, this turns out to be an issue of > interaction between the range and value masks and intervening > calculations. (Just want to say thanks for the detailed commi

Re: [r15-9427 Regression] FAIL: gcc.dg/ipa/pr119530.c execution test on Linux/x86_64

2025-04-14 Thread Sam James
"haochen.jiang" writes: > On Linux/x86_64, > > de1c734a8ae034c92f485e7f58b7fcb1c921ecd2 is the first bad commit > commit de1c734a8ae034c92f485e7f58b7fcb1c921ecd2 > Author: Martin Jambor > Date: Mon Apr 14 14:21:15 2025 +0200 > > ipa-cp: Make propagation of bits in IPA-CP aware of type conv

[PATCH] ltmain.in: don't suppress output for PIC compilations

2025-04-14 Thread Sam James
When working on xz, I set `-Werror=suggest-attribute=returns_nonnull`, and the build failed (as I expected it to), but with no visible error from the compiler. There's a mysterious '>/dev/null 2>&1' on the second line where liblzma_la-common.o is built without PIC. With -fPIC, IPA doesn't end up d

Re: [PATCH] c++: Fix various Wnarrowing minor issues

2025-04-11 Thread Sam James
Vishnu Mohandas writes: > Hello, > This is a possible fix for Wnarrowing warning issues. > Bootstrapped on x86_64 Linux. Please see my remarks at https://inbox.sourceware.org/gcc-patches/87iknbzfw4@gentoo.org/.

Re: [PATCH] Improve [-W..] display for -Wformat

2025-04-10 Thread Sam James
Vishnu Mohandas writes: > Hello, Hi, > The patch below proposes a possible improvement for the issue mentioned in > bug 65445. Although I'm not certain that it > address all the concerns, it does seem to make it better.> Unfortunately, I see a few issues here. There needs to be a ChangeLog en

[COMMITTED htdocs] gcc-3.2/changes: fix 'several' typo

2025-04-10 Thread Sam James
--- Pushed. htdocs/gcc-3.2/changes.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-3.2/changes.html b/htdocs/gcc-3.2/changes.html index 7b9ea63f..4ab9fdce 100644 --- a/htdocs/gcc-3.2/changes.html +++ b/htdocs/gcc-3.2/changes.html @@ -59,7 +59,7 @@ C++ -

Re: [PATCH] Makefile.tpl: Implement per-stage GDCFLAGS [PR116975]

2025-04-10 Thread Sam James
Iain Buclaw writes: > Hi, > > This patch implements STAGE1_GDCFLAGS and others to the configure > machinery, allowing the GDCFLAGS for each bootstrap stage of building > gdc to be overriden, as is the case with CXXFLAGS for other front-ends. > > This is limited to just the generation of recipes f

Re: combine: Re-enable 2->2 combinations, with limits [PR116398]

2025-04-05 Thread Sam James
Richard Sandiford writes: > This series is an update of: > > https://gcc.gnu.org/pipermail/gcc-patches/2025-April/679924.html > > As discussed in that thread, the changes since last time are to make > distribute_links start from the last use, where easy, and to avoid > an unnecessary insn walk

Re: [PATCH] testsuite: Fix up strub-internal-pr112938.C test for C++2{0,3,6}

2025-04-05 Thread Sam James
Jakub Jelinek writes: > On Thu, Mar 27, 2025 at 12:05:21AM +0000, Sam James wrote: >> The test was being ignored because dg.exp looks for .C in g++.dg/. >> >> gcc/testsuite/ChangeLog: >> PR middle-end/112938 >> >> * g++.dg/strub-internal-pr11293

[PATCH] aarch64: change another CRC test

2025-04-05 Thread Sam James
Fixed the iteration number in crc-crc32-data16.c test from 8 to 16 to match the test name, just like in r15-9038-gdf55a933cfc675. gcc/testsuite/ChangeLog: * gcc.target/aarch64/crc-crc32-data16.c: Fix iteration count to match testname. --- Do we need this as well? Untested so far.

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-04-05 Thread Sam James
Jakub Jelinek writes: > Hi! > > r15-8956 changed in the test: > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > +/* { dg-final { scan-assembler-times "ldclr\t" 16 } */ > which made it even worse than before, when the directive has > been silently ignored because it didn't match the regex

Re: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Sam James
ghtened out, everything is working without > the flag_strict_aliasing modification. > > Thanks for asking, and thanks for listening. > >> -Original Message- >> From: Robert Dubner >> Sent: Friday, April 4, 2025 16:02 >> To: Sam James >> Cc: GCC Patches &g

Re: [PATCH] wwwdocs: Clarify DCO name/identity and (anonymous) pseudonym policy

2025-04-04 Thread Sam James
NightStrike writes: > How is an online only name different from an anonymous pseudonym? It doesn’t > seem to me that your changes actually > clarify anything. To me, they make it more ambiguous. The idea is to not have something throwaway (please also don't toppost).

Re: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Sam James
Robert Dubner writes: > From e70fe5ed46ab129a8b1da961c47d3fb75b11b988 Mon Sep 17 00:00:00 2001 > From: Bob Dubner mailto:rdub...@symas.com > Date: Fri, 4 Apr 2025 13:48:58 -0400 > Subject: [PATCH] cobol: Eliminate cobolworx UAT errors when compiling with > -Os > > Testcases compiled with -Os were

Re: [PATCH] testsuite: arm: Fix dg-final in short-vfp-1.c [PR119556]

2025-03-31 Thread Sam James
Christophe Lyon writes: > Recent syntactic fixes enabled the test, but the result was failing. > > It turns out it was missing a space between the register arguments in > the scan-assembler-times directives. Great find, thanks. > > gcc/testsuite/ChangeLog: > > PR target/119556 > * g

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-03-30 Thread Sam James
Christophe Lyon writes: > Le dim. 30 mars 2025, 22:10, Sam James a écrit : > > Jakub Jelinek writes: > > > Hi! > > > > r15-8956 changed in the test: > > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > > +/* { dg-final { scan-

[PATCH] testsuite: arm: fixup more dg-final syntax

2025-03-29 Thread Sam James
... as Richard E mentioned on the ML. Followup to r15-8956-ge90d6c2639c392. gcc/testsuite/ChangeLog: * gcc.target/arm/short-vfp-1.c: Add whitespace around brace. --- Pushed. gcc/testsuite/gcc.target/arm/short-vfp-1.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH] doc: document incremental LTO flags

2025-03-28 Thread Sam James
Michal Jires writes: > On Thu, 2025-03-27 at 15:33:44 +0000, Sam James wrote: >> >> One thing I wasn't quite sure on yet: is -flto-partition=cache automatic >> with -flto-incremental? Or is it just an optional flag I can pass for >> more effective incrementa

Re: [PATCH 12/12] testsuite, s390: fix broken dg directives

2025-03-28 Thread Sam James
David Malcolm writes: > Found by dg-lint. > > gcc/testsuite/ChangeLog: > * gcc.target/s390/target-attribute/tattr-1.c: Fix missing trailing > close brace on dg-do directive. > * gcc.target/s390/target-attribute/tattr-2.c: Likewise. I've cherry-picked the remaining ones and reso

Re: [PATCH 1/3] testsuite: harmless dg-* whitespace fixes

2025-03-27 Thread Sam James
Harald Anlauf writes: > Sam, > > who approved the fortran testsuite changes? We've been doing them as obvious by consensus since last year. I'm sorry for the error. > > Am 27.03.25 um 14:28 schrieb Sam James: >> These just fix inconsistent/unusual style to avoid

Re: [PATCH 5/6] testsuite: fix more dg-* whitespace issues

2025-03-27 Thread Sam James
Marek Polacek writes: > On Thu, Mar 27, 2025 at 12:38:55AM +0000, Sam James wrote: >> A handful of cosmetic ones in here but most meant the directive wasn't >> doing anything. > > This patch breaks g++.dg/template/explicit-args6.C for me. See PR119490. I can XFAIL i

[PATCH] testsuite: revert Fortran change

2025-03-27 Thread Sam James
Revert part of my change from r15-8973-g1307de1b4e7d5e; as Harald points out, the comment explains why this is there. It's a hack but it needs to stay for now. (I did have this marked as a TODO in my branch and didn't leave a proper note as to why, so it's my fault.) gcc/testsuite/ChangeLog:

[PATCH] testsuite: aarch64: fix another unbalanced }

2025-03-27 Thread Sam James
In r15-8956-ge90d6c2639c392, I missed one, so while it did fix a problem, it also exposed another because the braces were now unbalanced. There's IMO more to do here with ideally whitespace before the } when using scan-assembler-times but let's do that later. gcc/testsuite/ChangeLog: * g

Re: [PATCH] doc: document incremental LTO flags

2025-03-27 Thread Sam James
Michal Jires writes: > This adds missing documentation for LTO flags. > > Ok? > > gcc/ChangeLog: > > * doc/invoke.texi: (Optimize Options): > Add incremental LTO flags. > --- > gcc/doc/invoke.texi | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > >

[PATCH 3/3] testsuite: fix dg-* typos

2025-03-27 Thread Sam James
I have a handful more of these left but those introduce FAILs, while these all introduce new PASSes. libstdc++-v3/ChangeLog: * testsuite/std/format/string_neg.cc: Add missing brace for dg-error. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fd-datagram-socket.c: Fix 'dg-message' sp

[PATCH 2/3] testsuite: fix typos in comments

2025-03-27 Thread Sam James
This fixes some 'scan-tree-dump-times' (vs '-time') typos and one or two others I noticed in passing. gcc/testsuite/ChangeLog: * g++.dg/warn/Winvalid-memory-model.C: Fix typo in comment. * gcc.dg/builtin-dynamic-object-size-19.c: Ditto. * gcc.dg/builtin-object-size-19.c: D

[PATCH 1/3] testsuite: harmless dg-* whitespace fixes

2025-03-27 Thread Sam James
These just fix inconsistent/unusual style to avoid noise when grepping and also people picking up bad habits when they see it (as similar mistakes can be harmful). gcc/testsuite/ChangeLog: * c-c++-common/goacc/pr69916.c: Fix unusual whitespace in dg-*. * g++.old-deja/g++.abi/vtabl

[PATCH 0/3] testsuite: more typo/directive fixes

2025-03-27 Thread Sam James
Pushed. Sam James (3): testsuite: harmless dg-* whitespace fixes testsuite: fix typos in comments testsuite: fix dg-* typos gcc/testsuite/c-c++-common/goacc/pr69916.c| 2 +- gcc/testsuite/g++.dg/warn/Winvalid-memory-model.C | 2 +- gcc/testsuite/g++.old-deja/g++.abi

[PATCH 4/6] testsuite: fix dg-message typos

2025-03-26 Thread Sam James
gcc/testsuite/ChangeLog: * g++.dg/diagnostic/unclosed-extern-c.C: Fix 'dg-message' typo. * g++.dg/warn/Wno-attributes-1.C: Ditto. --- gcc/testsuite/g++.dg/diagnostic/unclosed-extern-c.C | 2 +- gcc/testsuite/g++.dg/warn/Wno-attributes-1.C| 6 +++--- 2 files changed, 4 inse

[PATCH 2/6] testsuite: fix dg-bogus typo

2025-03-26 Thread Sam James
The dg-bogus directive here is trying to match -Warray-bounds or -Wstringop-overflow, but it got the casing wrong on the latter. gcc.dg/pr89350.c gets this right. gcc/testsuite/ChangeLog: PR middle-end/93437 * g++.dg/warn/Wstringop-overflow-5.C: Fix -Wstringop-overflow casing. --

[PATCH 3/4] testsuite: g++.dg: vect: fix PR37143 filename

2025-03-26 Thread Sam James
The test was being ignored because vect.exp looks for .cc in g++.dg/vect/. gcc/testsuite/ChangeLog: PR tree-optimization/37143 * g++.dg/vect/pr37143.C: Move to... * g++.dg/vect/pr37143.cc: ...here. --- gcc/testsuite/g++.dg/vect/{pr37143.C => pr37143.cc} | 0 1 file change

[PATCH 5/6] testsuite: fix more dg-* whitespace issues

2025-03-26 Thread Sam James
A handful of cosmetic ones in here but most meant the directive wasn't doing anything. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/udlit-namespace-ambiguous.C: Fix whitespace. * g++.dg/cpp2a/constexpr-init21.C: Ditto. * g++.dg/diagnostic/wrong-tag-1.C: Ditto. * g++.dg/

[PATCH] testsuite: fixup tree scan syntax for strub-internal-pr112938.C

2025-03-26 Thread Sam James
This wasn't being run before my r15-8949-g6b21f7969241cf so went unnoticed. Match [0-9+] instead of [0-9][0-9] and escape the parentheses around 'D'. gcc/testsuite/ChangeLog: PR testsuite/119489 * g++.dg/strub-internal-pr112938.C: Adjust pattern. --- Pushed as obvious. gcc/test

[PATCH 2/4] testsuite: tree-ssa: fix PR98265 filename

2025-03-26 Thread Sam James
.C is for C++ testcases and gcc.dg's dg.exp ignores .c. The test was not being run. gcc/testsuite/ChangeLog: PR ipa/98265 * gcc.dg/tree-ssa/pr98265.C: Move to... * g++.dg/tree-ssa/pr98265.C: ...here. --- gcc/testsuite/{gcc.dg => g++.dg}/tree-ssa/pr98265.C | 0 1 file chan

[PATCH 0/6] testsuite: more misc. syntax fixes

2025-03-26 Thread Sam James
Pushed as obvious. Sam James (6): testsuite: fortran: fix dg syntax errors testsuite: fix dg-bogus typo testsuite: more (mostly cosmetic) dg- whitespace fixes testsuite: fix dg-message typos testsuite: fix more dg-* whitespace issues testsuite: assorted targets: add missing braces to

[PATCH 1/6] testsuite: fortran: fix dg syntax errors

2025-03-26 Thread Sam James
No change in test results. The changes other than the first are arguably not errors, but still clearly wrong and mistakes. gcc/testsuite/ChangeLog: * gfortran.dg/associate_70.f90: Replace ')' with '}'. * gfortran.dg/bessel_3.f90: Drop extraneous ')'. * gfortran.dg/c_funloc

[PATCH 3/6] testsuite: more (mostly cosmetic) dg- whitespace fixes

2025-03-26 Thread Sam James
Some of these are harmless but still inconsistent (and asking for trouble given it may give people the wrong idea about similar "style"). gcc/testsuite/ChangeLog: * g++.dg/cpp0x/gen-attrs-6.C: Surround 'target' by whitespace. * gcc.target/aarch64/atomic-inst-ldlogic.c: Fix 'dg-fin

[PATCH] doc: say "compatible types" for -fstrict-aliasing

2025-03-26 Thread Sam James
Include the term used in the standard to ease further research for users. gcc/ChangeLog: * doc/invoke.texi: Use "compatible types" term. --- gcc/doc/invoke.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index b3f

[PATCH 6/6] testsuite: assorted targets: add missing braces to dg-* directives

2025-03-26 Thread Sam James
These get ignored otherwise. gcc/testsuite/ChangeLog: * gcc.target/arc/taux-1.c: Add missing brace. * gcc.target/arc/taux-2.c: Ditto. * gcc.target/i386/addr-space-1.c: Ditto. * gcc.target/ia64/mfused-madd-vect.c: Ditto. * gcc.target/ia64/mfused-madd.c: Ditt

[PATCH 4/4] testsuite: tree-ssa: fix PR98265 test to use C++14

2025-03-26 Thread Sam James
This test was previously not being run at all so this wasn't noticed until my fix just now. The test needs C++14 and it also should use scan-tree-dump, not scan-tree-dump-times, as it wasn't passing a count parameter. gcc/testsuite/ChangeLog: PR ipa/98265 * g++.dg/tree-ssa/pr9826

[PATCH 1/4] testsuite: g++.dg: fix PR112938 filename

2025-03-26 Thread Sam James
The test was being ignored because dg.exp looks for .C in g++.dg/. gcc/testsuite/ChangeLog: PR middle-end/112938 * g++.dg/strub-internal-pr112938.cc: Move to... * g++.dg/strub-internal-pr112938.C: ...here. --- .../{strub-internal-pr112938.cc => strub-internal-pr112938.C}

[PATCH 0/4] testsuite: filename/location fixes

2025-03-26 Thread Sam James
These weren't being run before because of the wrong filename or location. Pushed the lot as obvious. Sam James (4): testsuite: g++.dg: fix PR112938 filename testsuite: tree-ssa: fix PR98265 filename testsuite: g++.dg: vect: fix PR37143 filename testsuite: tree-ssa: fix PR98265 te

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
Sam James writes: > David Malcolm writes: > >> This patch adds a new dg-lint subdirectory below contrib, containing >> a "dg-lint" script for detecting common mistakes made in our DejaGnu >> tests. >> I should say: I don't think any of my comm

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
Jakub Jelinek writes: > On Wed, Mar 26, 2025 at 09:32:30PM +0000, Sam James wrote: >> Right, we can extend it for 'dg-do known-actions' as well. > > I think that shouldn't be necessary. > > gcc-dg-test-1 should already complain about unexpected actions. Ah, you're right. Thanks.

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
David Malcolm writes: > On Wed, 2025-03-26 at 19:59 +0100, Jakub Jelinek wrote: >> On Wed, Mar 26, 2025 at 02:34:43PM -0400, David Malcolm wrote: >> >> Thanks for working on this. >> My python is very limited, so just adding some comments rather >> than doing patch review. >> >> > +COMMON_MISSP

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
David Malcolm writes: > This patch adds a new dg-lint subdirectory below contrib, containing > a "dg-lint" script for detecting common mistakes made in our DejaGnu > tests. > > Specifically, DejaGnu's dg.exp's dg-get-options has a regexp for > detecting dg- directives > https://git.savannah.gnu

Re: [PATCH] testsuite: add testcase for recent alias fix

2025-03-26 Thread Sam James
Martin Jambor writes: > Hi, > > On Tue, Mar 25 2025, Sam James wrote: >> r15-7961-gdc47161c1f32c3 fixes a typo in ao_compare::compare_ao_refs >> but there wasn't a testcase available at the time. Now there is. >> >> Thanks to Andrew for the testcase. >

[PATCH] testsuite: add testcase for recent alias fix

2025-03-25 Thread Sam James
r15-7961-gdc47161c1f32c3 fixes a typo in ao_compare::compare_ao_refs but there wasn't a testcase available at the time. Now there is. Thanks to Andrew for the testcase. gcc/testsuite/ChangeLog: PR testsuite/119382 * gcc.dg/ipa/ipa-icf-40.c: New test. Co-authored-by: Andrew Pinsk

Re: [PATCH] COBOL v3: 3/14 80K bld: config and build machinery

2025-03-17 Thread Sam James
Andreas Schwab writes: > On Mär 13 2025, James K. Lowden wrote: > >> On Tue, 11 Mar 2025 11:18:22 +0100 >> Andreas Schwab wrote: >> >>> libgcobol/configure.tgt says it's supported on powerpc64le. >> >> Our intention, tell me if you disagree, is that cobol is enabled if >> >> 1. --enable-languag

Re: [PATCH v2] reassoc: Optimize CMP/XOR expressions [PR116860]

2025-03-16 Thread Sam James
Hans-Peter Nilsson writes: > On Thu, 13 Mar 2025, Konstantinos Eleftheriou wrote: >> Testcases for match.pd patterns >> `((a ^ b) & c) cmp d | a != b -> (0 cmp d | a != b)` and >> `(a ^ b) cmp c | a != b -> (0 cmp c | a != b)` were failing on some targets, >> like PowerPC. >> >> This patch adds

Re: [PATCH] contrib: Wrap git repo access in gcc-changelog.

2025-03-15 Thread Sam James
"Robin Dapp" writes: > Hi, > > since updating to Fedora 41 I have been seeing ignored python exceptions > like the following when using 'git gcc-verify' = > contrib/gcc_changelog/git_check_commit.py. > > Checking 90fcc1f4f1a5537e8d30628895a07cbb2e7e16ff: OK > Exception ignored in: > Traceback (

Re: [PATCH][v3] Simple cobol.dg testsuite

2025-03-13 Thread Sam James
Simon Sobisch writes: > Thanks for your work on adding a testsuite. Can you please explain why > you do this when a complete testsuite exists in autoconf (autotest) > format (which roots back to decade of work in GnuCOBOL, with all > copyrights for that already with the FSF)? > I don't think any

Re: [PATCH] Add Robert Dubner to Maintainers

2025-03-11 Thread Sam James
Robert Dubner writes: >> -Original Message- >> From: Jakub Jelinek >> Sent: Tuesday, March 11, 2025 17:40 >> To: Robert Dubner >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH] Add Robert Dubner to Maintainers >> >> On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote: >>

Re: The COBOL front end -- The Initial Onslaught

2025-03-11 Thread Sam James
Robert Dubner writes: > > I need to be able to change, at the very least, the Assignment field. I > don't seem to have any way of doing that. Make sure your email address on Bugzilla is x...@gcc.gnu.org. Using that address grants the account editbugs privileges. sam

Re: [PATCH] i386: Verify that argument registers are spilled properly

2025-03-09 Thread Sam James
Uros Bizjak writes: > On Sun, Mar 9, 2025 at 3:05 PM H.J. Lu wrote: >> >> RDI, RSI, RDX and RCX registers are used to pass arguments in 64-bit >> mode. EAX, EDX and ECX registers are used to pass arguments in 32-bit >> mode. Add tests to verify that argument registers are spilled properly. >>

Re: [RFC] PR81358: Enable automatic linking of libatomic

2025-03-07 Thread Sam James
Sam James writes: > Prathamesh Kulkarni writes: > >>> -Original Message- >>> From: Prathamesh Kulkarni >>> Sent: 10 January 2025 09:48 >>> To: Thomas Schwinge >>> Cc: Tobias Burnus ; Joseph Myers >>> ; Xi Ruoyao ; Matth

[PATCH htdocs 2/2] gcc-8/porting_to: link to Fedora mass rebuild post

2025-03-05 Thread Sam James
As is done for other releases. --- Pushed. htdocs/gcc-8/porting_to.html | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/htdocs/gcc-8/porting_to.html b/htdocs/gcc-8/porting_to.html index d24ea347..1d16a29e 100644 --- a/htdocs/gcc-8/porting_to.html +++ b/htdocs/gcc-8/porti

[PATCH htdocs 1/2] gcc-4.8/porting_to: update link to archive of Fedora rebuild

2025-03-05 Thread Sam James
--- Pushed. htdocs/gcc-4.8/porting_to.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-4.8/porting_to.html b/htdocs/gcc-4.8/porting_to.html index 9ed0d06b..c7e188ef 100644 --- a/htdocs/gcc-4.8/porting_to.html +++ b/htdocs/gcc-4.8/porting_to.html @@ -231,7 +231,7

[PATCH htdocs] bugs: Link to all 'Porting to' docs in 'Common problems when upgrading ...'

2025-03-05 Thread Sam James
Suggested by Andrew Pinski. I think it makes sense to have it in here even if perhaps a bit verbose, because we really try to tell bug reporters to read the page properly. --- This takes into account Gerald's comments, hopefully faithfully. Gerald, let me know if I misinterpreted anything or need

Re: [PATCH htdocs] bugs: Link to all 'Porting to' docs in 'Common problems when upgrading ...'

2025-03-05 Thread Sam James
Gerald Pfeifer writes: > On Wed, 12 Feb 2025, Sam James wrote: >> Suggested by Andrew Pinski. I think it makes sense to have it in here >> even if perhaps a bit verbose, because we really try to tell bug >> reporters to read the page properly. > > Makes sense. >

Re: [PATCH htdocs 1/2] bugs: improve "ABI changes" subsection

2025-03-03 Thread Sam James
nd myself citing this section a few times recently and don't want people to get the wrong idea). > > > > On Wed, 12 Feb 2025 at 09:30, Sam James wrote: >> >> C++ ABI for C++ standards with full support by GCC (rather than those >> marked as experimental per https

Re: [PATCH htdocs] bugs: Link to all 'Porting to' docs in 'Common problems when upgrading ...'

2025-03-03 Thread Sam James
Sam James writes: > Suggested by Andrew Pinski. I think it makes sense to have it in here even > if perhaps a bit verbose, because we really try to tell bug reporters to > read the page properly. > > This could also be a table. Ping on this if I may.

Re: [PATCH] libstdc++: Allow 'configure.host' to modify 'EXTRA_CFLAGS', 'EXTRA_CXX_FLAGS'

2025-02-26 Thread Sam James
Thomas Schwinge writes: > In particular, 'GLIBCXX_ENABLE_CXX_FLAGS' shouldn't overwrite > 'EXTRA_CXX_FLAGS' > (and prepend any additional '--enable-cxx-flags=[...]'). Why 'CXX_FLAGS' spelling (which is unusual) rather than 'CXXFLAG-- ah, I see we have a load of EXTRA_CXXFLAGS, and then a lot of

Re: [PATCH] i386: Implement Thread Local Storage on Windows

2025-02-19 Thread Sam James
Julian Waters writes: > Apologies, here is the implementation with regenerated configure this time. > Do excuse me sending an entirely new mail instead of replying to the previous > one, I have to do it this way due to a quirk in my email client. > > best regards, > Julian > > gcc/ChangeLog: >

Re: [PATCH] builtins: Ensure sin and cos properly set errno when INFINITY is passed [PR80042]

2025-02-17 Thread Sam James
Peter Damianov writes: > POSIX says that sin and cos should set errno to EDOM when infinity is passed > to > them. Make sure this is accounted for in builtins.def, and add tests. > > gcc/ > PR middle-end/80042 > * builtins.def: (sin|cos)(f|l) can set errno. > gcc/testsuite/ > *

Re: [PATCH] COBOL 12/15 24K pos: Posix adapter framework

2025-02-17 Thread Sam James
"James K. Lowden" writes: > On Sat, 15 Feb 2025 21:24:52 +0000 > Sam James wrote: > >> > +prototypes.cpp: posix.txt >> > + awk -F'[/.]' '{ print $$6 }' $^ | \ >> > + while read F; do echo "/* $$F */" && man 2

Re: [PATCH] COBOL 3/15 92K bld: config and build machinery

2025-02-17 Thread Sam James
"James K. Lowden" writes: > On Sat, 15 Feb 2025 21:18:50 +0000 > Sam James wrote: > >> Please generate these files with vanilla autoconf-2.69, not >> distro-patched autoconf. > > Sure thing, Sam. I meant to do that; I thought I did. It might be that the

Re: [PATCH] COBOL 6/15 156K lex: lexer

2025-02-17 Thread Sam James
"James K. Lowden" writes: > On Sat, 15 Feb 2025 23:32:37 -0500 > David Malcolm wrote: > > In defense of lack of free(3) ... > >> > +const char * >> > +esc( size_t len, const char input[] ) { >> > +  static char spaces[] = "([,;]?[[:space:]])+"; >> > +  static char spaceD[] = "(\n {6}D" "|" "[,;]

Re: [PATCH] COBOL 5/15 380K hdr: header files

2025-02-17 Thread Sam James
"James K. Lowden" writes: > On Sat, 15 Feb 2025 21:30:16 +0000 > Sam James wrote: > >> > + * This stand-in for std::regex was written because the >> > implementation provided >> > + * by the GCC libstdc++ in GCC 11 proved too slow, where "

Re: [r15-7532 Regression] FAIL: g++.dg/asan/pr118763.C -Os execution test on Linux/x86_64

2025-02-17 Thread Sam James
"haochen.jiang" writes: > On Linux/x86_64, > > e96e1bb69c7b46db18e747ee379a62681bc8c82d is the first bad commit > commit e96e1bb69c7b46db18e747ee379a62681bc8c82d > Author: Jason Merrill > Date: Fri Feb 14 10:53:01 2025 +0100 > > c++: extended temp cleanups [PR118856] > > caused > > FAIL: g

Re: [PATCH] COBOL 10/15 252K gen: GENERIC interface support

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:53 PM EST > Subject: [PATCH] 3 new 'cobol' FE files > > gcc/cobol/ChangeLog > * gengen.cc: New file. > * genmath.cc: New file. >

Re: [PATCH] COBOL 12/15 24K pos: Posix adapter framework

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:54 PM EST > Subject: [PATCH] 12 new 'cobol' FE files Please make sure the commit summaries reflect the contents. > > gcc/cobol/ChangeLog >

Re: [PATCH] COBOL 3/15 92K bld: config and build machinery

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:52 PM EST > Subject: [PATCH] Add 'cobol' to 17 files The commit message summary (first line) should say something like the email title, so

Re: [PATCH] COBOL 6/15 156K lex: lexer

2025-02-15 Thread Sam James
"James K. Lowden" writes: > From 5d53920602e234e4d99ae2d502e662ee3699978e 4 Oct 2024 12:01:22 -0400 > From: "James K. Lowden" > Date: Sat 15 Feb 2025 12:50:52 PM EST > Subject: [PATCH] 3 new 'cobol' FE files > > gcc/cobol/ChangeLog > * cdf-copy.cc: New file. > * lexio.cc: New file. >

Re: [PATCH v4] [ifcombine] avoid creating out-of-bounds BIT_FIELD_REFs [PR118514]

2025-02-13 Thread Sam James
Alexandre Oliva writes: > On Feb 6, 2025, Sam James wrote: > >> Richard Biener writes: >>> On Thu, Feb 6, 2025 at 2:41 PM Alexandre Oliva wrote: >>>> >>>> On Jan 27, 2025, Richard Biener wrote: >>>> > (I see the assert is no lon

Re: [PATCH htdocs] bugs: mention ASAN too

2025-02-13 Thread Sam James
Gerald Pfeifer writes: > On Mon, 11 Nov 2024, Sam James wrote: >> Request that reporters try `-fsanitize=address,undefined` rather than >> just `-fsanitize=undefined` when reporting bugs. We get invalid bug >> reports which ASAN would've caught sometimes, even if it&

[PATCH htdocs] bugs: Link to all 'Porting to' docs in 'Common problems when upgrading ...'

2025-02-12 Thread Sam James
Suggested by Andrew Pinski. I think it makes sense to have it in here even if perhaps a bit verbose, because we really try to tell bug reporters to read the page properly. This could also be a table. --- htdocs/bugs/index.html | 24 1 file changed, 24 insertions(+) diff

[PATCH htdocs 1/2] bugs: improve "ABI changes" subsection

2025-02-12 Thread Sam James
C++ ABI for C++ standards with full support by GCC (rather than those marked as experimental per https://gcc.gnu.org/projects/cxx-status.html) should be stable. It's certainly not the case in 2025 that one needs a full world rebuild for C++ libraries using e.g. the default standard or any other sup

[PATCH htdocs 2/2] gcc-15/porting_to: link to "Standards conformance" section for C++

2025-02-12 Thread Sam James
Suggested by Andrew Pinski. --- htdocs/gcc-15/porting_to.html | 6 ++ 1 file changed, 6 insertions(+) diff --git a/htdocs/gcc-15/porting_to.html b/htdocs/gcc-15/porting_to.html index b9b2efc7..829ae92f 100644 --- a/htdocs/gcc-15/porting_to.html +++ b/htdocs/gcc-15/porting_to.html @@ -137,6 +1

Re: [PATCH] x86: Properly find the maximum stack slot alignment

2025-02-12 Thread Sam James
"H.J. Lu" writes: > Don't assume that stack slots can only be accessed by stack or frame > registers. We first find all registers defined by stack or frame > registers. Then check memory accesses by such registers, including > stack and frame registers. > > gcc/ > > PR target/109780 > PR target

Re: [PATCH htdocs] gcc-14: document -ftrampoline-impl

2025-02-10 Thread Sam James
Iain Sandoe writes: >> On 10 Feb 2025, at 08:28, Sam James wrote: >> >> --- >> Iain, does this look OK? >> >> htdocs/gcc-14/changes.html | 7 +++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/htdocs/gcc-14/changes.html b/

[PATCH htdocs] gcc-14: document -ftrampoline-impl

2025-02-09 Thread Sam James
--- Iain, does this look OK? htdocs/gcc-14/changes.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index ba4780ca..2db442b2 100644 --- a/htdocs/gcc-14/changes.html +++ b/htdocs/gcc-14/changes.html @@ -123,6 +123,13 @@ You may

Re: [PATCH v3] [ifcombine] avoid creating out-of-bounds BIT_FIELD_REFs [PR118514]

2025-02-06 Thread Sam James
Richard Biener writes: > On Thu, Feb 6, 2025 at 2:41 PM Alexandre Oliva wrote: >> >> On Jan 27, 2025, Richard Biener wrote: >> >> > What I was saying that the conservative tree_could_trap_p could say >> > 'yes' to a certain encoding of a ref but 'no' to another if in reality >> > the ref can ne

Re: [PATCH v1] RISC-V: Make FRM as global register [PR118103] [PR118646]

2025-01-25 Thread Sam James
"Li, Pan2" writes: > Thanks Jeff and Sam, updated v2 for -fno-strict-aliasing. Thanks! The test looks good now. > > Pan > > -Original Message- > From: Jeff Law > Sent: Sunday, January 26, 2025 1:06 AM > To: Li, Pan2 ; gcc-patches@gcc.gnu.org > Cc: juzhe.zh...@rivai.ai; kito.ch...@gmai

Re: [PATCH v1] RISC-V: Make FRM as global register [PR118103] [PR118646]

2025-01-25 Thread Sam James
pan2...@intel.com writes: > From: Pan Li > > After we enabled the labe-combine pass after the mode-switching pass, it > will try to combine below insn patterns into op. Aka: > > (insn 40 5 41 2 (set (reg:SI 11 a1 [151]) > (reg:SI 69 frm)) "pr118103-simple.c":67:15 2712 {frrmsi} > (nil)) > (i

Re: [committed] testsuite: Require int32plus for test case pr117546.c

2025-01-21 Thread Sam James
Dimitar Dimitrov writes: > Test case is valid even if size of int is more than 32 bits. > > Pushed to trunk as obvious. > > gcc/testsuite/ChangeLog: > > * gcc.dg/torture/pr117546.c: Require effective target int32plus. > > Cc: Georg-Johann Lay > Cc: Sam J

Re: [PATCH] testsuite: Fixes for test case pr117546.c

2025-01-18 Thread Sam James
.c: Require effective target int32. > (main): Add return statement. > > Ok for trunk? > > Cc: Sam James > Signed-off-by: Dimitar Dimitrov > --- I think it can go in as obvious. Thanks for the fixup. > gcc/testsuite/gcc.dg/torture/pr117546.c | 4 +++- > 1 file changed

Re: [RFC] PR81358: Enable automatic linking of libatomic

2025-01-17 Thread Sam James
Prathamesh Kulkarni writes: >> -Original Message- >> From: Prathamesh Kulkarni >> Sent: 10 January 2025 09:48 >> To: Thomas Schwinge >> Cc: Tobias Burnus ; Joseph Myers >> ; Xi Ruoyao ; Matthew >> Malcomson ; gcc-patches@gcc.gnu.org; Tom de >> Vries >> Subject: RE: [RFC] PR81358: Enabl

Re: [PATCH] MAINTAINERS: Add myself to write after approval

2025-01-17 Thread Sam James
See https://gcc.gnu.org/gitwrite.html#authenticated.

[COMMITTED 1/2] doc: trivial grammar fix

2025-01-15 Thread Sam James
We say 'a constant .. expression' elsewhere. Fix the grammar. gcc/ChangeLog: * doc/extend.texi: Add 'a' for grammar fix. --- Committed as obvious. gcc/doc/extend.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 1e1b

[COMMITTED 2/2] doc: cleanup trailing whitespace

2025-01-15 Thread Sam James
gcc/ChangeLog: * doc/extend.texi: Cleanup trailing whitespace. --- Committed as obvious. gcc/doc/extend.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index 84894efc2ea4..52ba78b80361 100644 --- a/gcc/doc/extend.te

Re: [PATCH] Annotate dbg_line_numbers table

2025-01-15 Thread Sam James
Richard Biener writes: > [...]. It also cuts the lines down to 10 entries. (This version doesn't ;)) > > static int dbg_line_numbers[1267] = { > /* 0 */ 161, 164, 173, 175, 178, 181, 183, 189, 197, 195, > /* 10 */ 199, 201, 205, 923, 921, 2060, 2071, 2052, 2058, 2063, > ... >

Re: [RFC/RFA] [PR tree-optimization/92539] Improve code and avoid Warray-bounds false positive

2025-01-09 Thread Sam James
Richard Biener writes: > On Wed, Jan 8, 2025 at 5:34 PM Qing Zhao wrote: >> >> >> >> > On Jan 7, 2025, at 07:29, Richard Biener >> > wrote: >> > >> > On Mon, Jan 6, 2025 at 5:40 PM Qing Zhao wrote: >> >> >> >> >> >> >> >>> On Jan 6, 2025, at 11:01, Richard Biener >> >>> wrote: >> >>> >> >>>

Re: [PATCH 1/2] testsuite: add testcase for fixed PR117546

2025-01-06 Thread Sam James
Jeff Law writes: > On 1/3/25 11:11 AM, Sam James wrote: >> Sam James writes: >> >>> PR117546 was fixed by Eric's r14-10693-gadab597af288d6 change, but >>> the testcase here is sufficiently different to be worth including >>> in torture/. >>

Re: [PATCH 1/2] testsuite: add testcase for fixed PR117546

2025-01-03 Thread Sam James
Sam James writes: > PR117546 was fixed by Eric's r14-10693-gadab597af288d6 change, but > the testcase here is sufficiently different to be worth including > in torture/. > > gcc/testsuite/ChangeLog: > PR ipa/117546 > * gcc.dg/torture/pr117546.c: New test. &

  1   2   3   4   5   >