Re: [PATCH] arm: avoid gcc_s dependency

2025-07-15 Thread Sam James
Pierre Ossman writes: > On 14/07/2025 22:24, Sam James wrote: >> A patch rebased against trunk would also be appreciated. See >> https://gcc.gnu.org/contribute.html for the needed format. >> > > The patch applies cleanly against trunk, so nothing is needed there.

Re: [PATCH] arm: avoid gcc_s dependency

2025-07-14 Thread Sam James
Kyrylo Tkachov writes: > + arm maintainers. > > Hi Pierre, > >> On 14 Jul 2025, at 14:07, Pierre Ossman wrote: >> >> Suggested fix for this issue: >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60428 >> >> Did not get any response there, so seeing if this is a better forum for >> suggest

Re: [PATCH v2] x86-64: Add --enable-x86-64-mfentry

2025-07-12 Thread Sam James
"H.J. Lu" writes: > On Sat, Jul 12, 2025 at 6:58 AM Siddhesh Poyarekar > wrote: >> >> On 2025-07-11 15:28, Uros Bizjak wrote: >> >> Why not just switch over unconditionally? __fentry__ seems like a >> >> better alternative to mcount overall and it has been around long enough >> >> that even ol

Re: [PATCH] x86-64: Add --enable-x86-64-mfentry

2025-07-11 Thread Sam James
Uros Bizjak writes: > On Fri, Jul 11, 2025 at 2:33 PM Siddhesh Poyarekar > wrote: >> >> On 2025-07-08 18:07, Sam James wrote: >> >> OK in principle, but please allow some time for distro maintainers >> >> (CC'd) to voice their opinion. >>

Re: [PATCH] x86-64: Add --enable-x86-64-mfentry

2025-07-11 Thread Sam James
Siddhesh Poyarekar writes: > On 2025-07-08 18:07, Sam James wrote: >>> OK in principle, but please allow some time for distro maintainers >>> (CC'd) to voice their opinion. >> It looks good to me and I plan on us using it. I'd like opinions >> from &g

Re: [PATCH] x86-64: Add --enable-x86-64-mfentry

2025-07-08 Thread Sam James
Uros Bizjak writes: > On Thu, Jul 3, 2025 at 12:01 PM H.J. Lu wrote: >> >> When profiling is enabled with shrink wrapping, the mcount call may not >> be placed at the function entry after >> >> pushq %rbp >> movq %rsp,%rbp >> >> As the result, the profile data may be skewed which makes PGO less

Re: [PATCH] x86: Preserve frame pointer for no_callee_saved_registers attribute

2025-06-29 Thread Sam James
"H.J. Lu" writes: > Update functions with no_callee_saved_registers/preserve_none attribute > to preserve frame pointer since caller may use it to save the current > stack: > > pushq %rbp > movq %rsp, %rbp > ... > call function > ... > leave > ret > > If callee changes frame pointer without resto

Re: Do not drop discriminator when inlining

2025-06-24 Thread Sam James
Jan Hubicka writes: >> > That is why I checked for loc != UNKNOWN_LOCATION. I did not expect >> > UNKNOWN_LOCATION to have discriminators. What they are good for? >> >> I have no idea, this was simply a defensive review where it's no >> longer obvious that inlined_function_outer_scope_p would s

[COMMITTED] Fixup dropping REG_EQUAL note in ext-dce

2025-06-23 Thread Sam James
Followup to r16-1613-g34e1e5e33ec3eb. remove_reg_equal_equiv_notes's 2nd argument is 'no_rescan' which we accidentally had on, tripping an assert in combine or ira because we hadn't left things in a consistent state. Fix the thinko by enabling rescanning. gcc/ChangeLog: PR rtl-optimizatio

Re: [COMMITTED] Check if constant is a member before returning it.

2025-06-10 Thread Sam James
Andrew MacLeod writes: > There is a bug in irange::set_range_from_bitmask where if the bitmask > indicated the result is a singleton, it would simply return that > singleton.  It never actually checked to see if that singleton was > actually contained in the range, in which case it should return

Re: [PATCH] Add newlib to gitignore

2025-06-06 Thread Sam James
Thomas Schwinge writes: > Hi! > > On 2025-06-02T22:01:44+0530, Arijit Kumar Das > wrote: >>> Umm, I don't think so. I've been building crosses with gcc for decades. >>> It should not be necessary, though it may sometimes be convenient. > > Right. Similarly to how it's, for example, documented

Re: [PATCH v25 1/3] c: Add _Countof operator

2025-05-28 Thread Sam James
Alejandro Colomar writes: > [...] > diff --git a/gcc/testsuite/gcc.dg/countof-vla.c > b/gcc/testsuite/gcc.dg/countof-vla.c > new file mode 100644 > index ..cc225df20689 > --- /dev/null > +++ b/gcc/testsuite/gcc.dg/countof-vla.c > @@ -0,0 +1,35 @@ > +/* { dg-do compile } */ > +/* { dg

Re: [14.x PATCH] c: Allow bool and enum null pointer constants [PR112556]

2025-05-14 Thread Sam James
Joseph Myers writes: > On Wed, 14 May 2025, Sam James wrote: > >> > (cherry picked from commit 3d525fce70fa0ffa0b22af6e213643e1ceca5ab5) >> > --- >> > As discussed on the PR, I feel like this is worth having for 14 as we're >> > asking upstreams to

Re: [14.x PATCH] c: Allow bool and enum null pointer constants [PR112556]

2025-05-14 Thread Sam James
Sam James writes: > From: Joseph Myers > > As reported in bug 112556, GCC wrongly rejects conversion of null > pointer constants with bool or enum type to pointers in > convert_for_assignment (assignment, initialization, argument passing, > return). Fix the code there to allo

Re: [AUTOFDO][AARCH64] Add support for profilebootstrap

2025-05-10 Thread Sam James
Kugan Vivekanandarajah writes: > Add support for autoprofiledbootstrap in aarch64. > This is similar to what is done for i386. Added > gcc/config/aarch64/gcc-auto-profile for aarch64 profile > creation. > > How to run: > configure --with-build-config=bootstrap-lto > make autoprofiledbootstrap > >

Re: [PATCH] ltmain.in: don't suppress output for PIC compilations

2025-05-09 Thread Sam James
Sam James writes: > When working on xz, I set `-Werror=suggest-attribute=returns_nonnull`, and > the build failed (as I expected it to), but with no visible error from > the compiler. There's a mysterious '>/dev/null 2>&1' on the second line where > lib

Re: [PATCH] gimple: Don't assert that switch has nondefault cases during lowering [PR120080]

2025-05-09 Thread Sam James
Filip Kastl writes: > Hi, > > bootstrapped and regtested on x86_64 linux. Ok to push? > > Filip Kastl > No testcase? I think pinskia's reduced testcase from the bug should be fine. I can handle adding that later if needed though.

[14.x PATCH] c: Allow bool and enum null pointer constants [PR112556]

2025-05-08 Thread Sam James
From: Joseph Myers As reported in bug 112556, GCC wrongly rejects conversion of null pointer constants with bool or enum type to pointers in convert_for_assignment (assignment, initialization, argument passing, return). Fix the code there to allow BOOLEAN_TYPE and ENUMERAL_TYPE; it already allow

Re: [PATCH] i386: Implement Thread Local Storage on Windows

2025-05-06 Thread Sam James
Julian Waters writes: > gcc bootstrap works on my end pretty well, but you know what they say, > no one likes an "It works on my device" developer :) The reason he asked is https://gcc.gnu.org/contribute.html#patches (it's convention to state how you tested it & on what platforms) and whether th

Re: [PATCH] libphobos: enable for sparc64-unknown-linux-gnu

2025-05-05 Thread Sam James
Iain Buclaw writes: > Excerpts from Sam James's message of April 20, 2025 2:46 am: >> This bootstraps with some test failures but works well enough to build >> 11..15. >> >> libphobos/ChangeLog: >> >> * configure.tgt: Add sparc64-unknown-linux-gnu as a supported target. >> --- >> As discus

Re: [PATCH v4] libstdc++: Implement C++26 features (P2546R5)

2025-05-05 Thread Sam James
Jonathan Wakely writes: > [...] > +void > +std::breakpoint() noexcept > +{ > + PROBE(std::breakpoint); > + > + if (__gnu_cxx::debugger_signal_for_breakpoint > 0) > +std::raise(__gnu_cxx::debugger_signal_for_breakpoint); > + glib's https://gitlab.gnome.org/GNOME/glib/-/blob/main/glib/gbackt

Re: [PATCH 0/3][RFC] Remove TARGET_LRA_P hook

2025-05-03 Thread Sam James
John Paul Adrian Glaubitz writes: > Hello, > > > > >> This mini-series removes the TARGET_LRA_P hook, forcing all targets >> to use LRA. I have not touched the targets that define -mlra >> in terms of a 'Target Mask(XXX)' since IIRC there's no way to >> "default" that. I'd expect those to wrong

Re: Update GCC16 to use libffi 3.4.8

2025-05-03 Thread Sam James
Simon Sobisch writes: > As GCC15 is now strict on dynamic function as > int *func() > to mean exactly zero arguments via its default -std=gnu23, I'm looking > into a dynamic option that would work for C23 and recognized libffi > being built as part of GCC and being part of its source tree, wh

Re: [PATCH 1/3] Force targets to use LRA which opted out via hook_bool_void_false

2025-05-02 Thread Sam James
Richard Biener writes: > * config/alpha/alpha.cc (TARGET_LRA_P): Remove define. > * config/bfin/bfin.cc (TARGET_LRA_P): Likewise. > * config/c6x/c6x.cc (TARGET_LRA_P): Likewise. > * config/fr30/fr30.cc (TARGET_LRA_P): Likewise. > * config/frv/frv.cc (TARGET_LRA_P): L

Re: [PATCH 2/3] Flip default to LRA for targets with -mlra

2025-05-02 Thread Sam James
Richard Biener writes: > This flips the default to LRA for targets with an -mlra option not > using Mask(..). Please tag PR113934 for avr, PR113939 for m68k, PR113933 for pa, and PR55212 for sh.

[committed htdocs v2] bugs: improve "ABI changes" subsection

2025-05-01 Thread Sam James
C++ ABI for C++ standards with full support by GCC (rather than those marked as experimental per https://gcc.gnu.org/projects/cxx-status.html) should be stable. It's certainly not the case in 2025 that one needs a full world rebuild for C++ libraries using e.g. the default standard or any other sup

Re: [PATCH] debug/78685 - reword -Og documentation

2025-04-28 Thread Sam James
Richard Biener writes: > On Mon, 28 Apr 2025, Alexander Monakov wrote: > >> >> On Mon, 28 Apr 2025, Richard Biener wrote: >> >> > The following rewords the documentation for -Og which over-promises >> > the ability to debug the generated code. While -Og enables >> > var-tracking and thus impro

Re: [PATCH v2] gcc: do not apply store motion on loop with no exits.

2025-04-27 Thread Sam James
ywgrit writes: > I encountered one problem with loop-im pass. > I compiled the program dhry2reg which belongs to > unixbench(https://github.com/kdlucas/byte-unixbench). > > The gcc used > gcc (GCC) 12.3.0 > > The commands executed as following > make > ./Run -c -i 1 dhry2reg > > The results are

Re: [PATCH 30/61] MSA: Make MSA and microMIPS R5 unsupported

2025-04-27 Thread Sam James
Xi Ruoyao writes: > On Wed, 2025-04-23 at 12:43 +, Aleksandar Rakic wrote: >> From 16b3207aed5e4846fde4f3ffa1253c65ef6ba056 Mon Sep 17 00:00:00 2001 >> From: Aleksandar Rakic >> Date: Wed, 23 Apr 2025 14:14:17 +0200 >> Subject: [PATCH] Make MSA and microMIPS R5 unsupported >> >> There are n

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-22 Thread Sam James
Jakub Jelinek writes: > On Mon, Apr 21, 2025 at 10:52:22AM +0200, Richard Biener wrote: >> On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >> > >> > On Fri, Apr 18, 2025 at 06:04:29PM +0200, Rainer Orth wrote: >> > > That's one option, but maybe it's better the other way round: instead of >

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-22 Thread Sam James
Jakub Jelinek writes: > On Mon, Apr 21, 2025 at 10:16:39AM +0100, Sam James wrote: >> Sam James writes: >> >> > Richard Biener writes: >> > >> >> On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >> >>> >> >>> O

Re: [PATCH] sanitizer: Store no_sanitize attribute value in uint32 instead of unsigned

2025-04-22 Thread Sam James
Kees Cook writes: > On Thu, Apr 10, 2025 at 05:17:51PM -0700, Keith Packard wrote: >> A target using 16-bit ints won't have enough bits to hold the whole >> flag_sanitize set. Be explicit about using uint32 for the attribute data. >> >> Signed-off-by: Keith Packard >> --- >> gcc/c-family/c-att

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-21 Thread Sam James
Sam James writes: > Richard Biener writes: > >> On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >>> >>> On Fri, Apr 18, 2025 at 06:04:29PM +0200, Rainer Orth wrote: >>> > That's one option, but maybe it's better the other way round: in

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-21 Thread Sam James
Richard Biener writes: > On Fri, Apr 18, 2025 at 8:10 PM Jakub Jelinek wrote: >> >> On Fri, Apr 18, 2025 at 06:04:29PM +0200, Rainer Orth wrote: >> > That's one option, but maybe it's better the other way round: instead of >> > excluding known-bad targets, restrict cobol to known-good ones >> >

Re: [PATCH] cobol: Allow for undefined NAME_MAX [PR119217]

2025-04-19 Thread Sam James
Robert Dubner writes: >> -Original Message- >> From: Jakub Jelinek >> Sent: Friday, April 18, 2025 14:10 >> To: Rainer Orth >> Cc: Richard Biener ; Andreas Schwab >> ; gcc-patches@gcc.gnu.org; Robert Dubner >> ; James K. Lowden >> Subject: Re: [PATCH] cobol: Allow for undefined NAME_MA

[PATCH] libphobos: enable for sparc64-unknown-linux-gnu

2025-04-19 Thread Sam James
This bootstraps with some test failures but works well enough to build 11..15. libphobos/ChangeLog: * configure.tgt: Add sparc64-unknown-linux-gnu as a supported target. --- As discussed on IRC. OK? I'd like to backport it to branches in due course once they're all open and some time on t

Re: [PATCH] avoid-store-forwarding: Fix reg init on load-elimination [PR119160]

2025-04-18 Thread Sam James
Philipp Tomsich writes: > Applied to trunk (16.0.0), thank you! > Should this be backported to the GCC-15 release branch as well? BTW, what's the plan for enabling this on trunk now by default? (I don't recall if some other issues were left.)

Re: [PATCH 1/2] DSE: Support triming of some more memset [PR87901]

2025-04-17 Thread Sam James
Andrew Pinski writes: > DSE has support for trimming memset (and memset like) statements. > In this case we have `MEM [(char * {ref-all})&z] = {};` in > the IR and when we go to trim it, we call build_fold_addr_expr which leaves > around This looks cut off?

Re: [PATCH] Add COBOL information to gcc.gnu.org index.html

2025-04-17 Thread Sam James
Robert Dubner writes: > Okay for htdocs/master? > > From d412e45d5afeecded3c8cf1b6b2865e088a480cc Mon Sep 17 00:00:00 2001 > From: Robert Dubner > Date: Thu, 17 Apr 2025 15:12:26 -0400 > Subject: [PATCH] Add COBOL information to gcc.gnu.org index.html > > * htdocs/index.html: Add COBOL inf

[PATCH v2] doc: say "compatible types" for -fstrict-aliasing

2025-04-16 Thread Sam James
Include the term used in the standard to ease further research for users, and while at it, rephrase the description of the rule entirely using Alexander Monakov's suggestion: it was previously wrong (and imprecise) as "the same address" may well be re-used later on, and the issue is the access via

Re: [PATCH] doc: say "compatible types" for -fstrict-aliasing

2025-04-16 Thread Sam James
Jakub Jelinek writes: > On Wed, Mar 26, 2025 at 10:41:52AM +0000, Sam James wrote: >> Include the term used in the standard to ease further research for users. >> >> gcc/ChangeLog: >> >> * doc/invoke.texi: Use "compatible types" term. >> --

Re: [PATCH] PR tree-optimization/119712 - Always reflect lower bits from mask in subranges.

2025-04-16 Thread Sam James
Andrew MacLeod writes: > This was a fun one!   An actual bug, and it took a while to sort out.  > After chasing down some red herrings, this turns out to be an issue of > interaction between the range and value masks and intervening > calculations. (Just want to say thanks for the detailed commi

Re: [r15-9427 Regression] FAIL: gcc.dg/ipa/pr119530.c execution test on Linux/x86_64

2025-04-14 Thread Sam James
"haochen.jiang" writes: > On Linux/x86_64, > > de1c734a8ae034c92f485e7f58b7fcb1c921ecd2 is the first bad commit > commit de1c734a8ae034c92f485e7f58b7fcb1c921ecd2 > Author: Martin Jambor > Date: Mon Apr 14 14:21:15 2025 +0200 > > ipa-cp: Make propagation of bits in IPA-CP aware of type conv

[PATCH] ltmain.in: don't suppress output for PIC compilations

2025-04-14 Thread Sam James
When working on xz, I set `-Werror=suggest-attribute=returns_nonnull`, and the build failed (as I expected it to), but with no visible error from the compiler. There's a mysterious '>/dev/null 2>&1' on the second line where liblzma_la-common.o is built without PIC. With -fPIC, IPA doesn't end up d

Re: [PATCH] c++: Fix various Wnarrowing minor issues

2025-04-11 Thread Sam James
Vishnu Mohandas writes: > Hello, > This is a possible fix for Wnarrowing warning issues. > Bootstrapped on x86_64 Linux. Please see my remarks at https://inbox.sourceware.org/gcc-patches/87iknbzfw4@gentoo.org/.

Re: [PATCH] Improve [-W..] display for -Wformat

2025-04-10 Thread Sam James
Vishnu Mohandas writes: > Hello, Hi, > The patch below proposes a possible improvement for the issue mentioned in > bug 65445. Although I'm not certain that it > address all the concerns, it does seem to make it better.> Unfortunately, I see a few issues here. There needs to be a ChangeLog en

[COMMITTED htdocs] gcc-3.2/changes: fix 'several' typo

2025-04-10 Thread Sam James
--- Pushed. htdocs/gcc-3.2/changes.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-3.2/changes.html b/htdocs/gcc-3.2/changes.html index 7b9ea63f..4ab9fdce 100644 --- a/htdocs/gcc-3.2/changes.html +++ b/htdocs/gcc-3.2/changes.html @@ -59,7 +59,7 @@ C++ -

Re: [PATCH] Makefile.tpl: Implement per-stage GDCFLAGS [PR116975]

2025-04-10 Thread Sam James
Iain Buclaw writes: > Hi, > > This patch implements STAGE1_GDCFLAGS and others to the configure > machinery, allowing the GDCFLAGS for each bootstrap stage of building > gdc to be overriden, as is the case with CXXFLAGS for other front-ends. > > This is limited to just the generation of recipes f

Re: combine: Re-enable 2->2 combinations, with limits [PR116398]

2025-04-05 Thread Sam James
Richard Sandiford writes: > This series is an update of: > > https://gcc.gnu.org/pipermail/gcc-patches/2025-April/679924.html > > As discussed in that thread, the changes since last time are to make > distribute_links start from the last use, where easy, and to avoid > an unnecessary insn walk

Re: [PATCH] testsuite: Fix up strub-internal-pr112938.C test for C++2{0,3,6}

2025-04-05 Thread Sam James
Jakub Jelinek writes: > On Thu, Mar 27, 2025 at 12:05:21AM +0000, Sam James wrote: >> The test was being ignored because dg.exp looks for .C in g++.dg/. >> >> gcc/testsuite/ChangeLog: >> PR middle-end/112938 >> >> * g++.dg/strub-internal-pr11293

[PATCH] aarch64: change another CRC test

2025-04-05 Thread Sam James
Fixed the iteration number in crc-crc32-data16.c test from 8 to 16 to match the test name, just like in r15-9038-gdf55a933cfc675. gcc/testsuite/ChangeLog: * gcc.target/aarch64/crc-crc32-data16.c: Fix iteration count to match testname. --- Do we need this as well? Untested so far.

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-04-05 Thread Sam James
Jakub Jelinek writes: > Hi! > > r15-8956 changed in the test: > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > +/* { dg-final { scan-assembler-times "ldclr\t" 16 } */ > which made it even worse than before, when the directive has > been silently ignored because it didn't match the regex

Re: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Sam James
ghtened out, everything is working without > the flag_strict_aliasing modification. > > Thanks for asking, and thanks for listening. > >> -Original Message- >> From: Robert Dubner >> Sent: Friday, April 4, 2025 16:02 >> To: Sam James >> Cc: GCC Patches &g

Re: [PATCH] wwwdocs: Clarify DCO name/identity and (anonymous) pseudonym policy

2025-04-04 Thread Sam James
NightStrike writes: > How is an online only name different from an anonymous pseudonym? It doesn’t > seem to me that your changes actually > clarify anything. To me, they make it more ambiguous. The idea is to not have something throwaway (please also don't toppost).

Re: [committed] cobol: Eliminate cobolworx UAT errors when compiling with -Os

2025-04-04 Thread Sam James
Robert Dubner writes: > From e70fe5ed46ab129a8b1da961c47d3fb75b11b988 Mon Sep 17 00:00:00 2001 > From: Bob Dubner mailto:rdub...@symas.com > Date: Fri, 4 Apr 2025 13:48:58 -0400 > Subject: [PATCH] cobol: Eliminate cobolworx UAT errors when compiling with > -Os > > Testcases compiled with -Os were

Re: [PATCH] testsuite: arm: Fix dg-final in short-vfp-1.c [PR119556]

2025-03-31 Thread Sam James
Christophe Lyon writes: > Recent syntactic fixes enabled the test, but the result was failing. > > It turns out it was missing a space between the register arguments in > the scan-assembler-times directives. Great find, thanks. > > gcc/testsuite/ChangeLog: > > PR target/119556 > * g

Re: [committed] testsuite: Fix up atomic-inst-ldlogic.c

2025-03-30 Thread Sam James
Christophe Lyon writes: > Le dim. 30 mars 2025, 22:10, Sam James a écrit : > > Jakub Jelinek writes: > > > Hi! > > > > r15-8956 changed in the test: > > -/* { dg-final { scan-assembler-times "ldclr\t" 16} */ > > +/* { dg-final { scan-

[PATCH] testsuite: arm: fixup more dg-final syntax

2025-03-29 Thread Sam James
... as Richard E mentioned on the ML. Followup to r15-8956-ge90d6c2639c392. gcc/testsuite/ChangeLog: * gcc.target/arm/short-vfp-1.c: Add whitespace around brace. --- Pushed. gcc/testsuite/gcc.target/arm/short-vfp-1.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH] doc: document incremental LTO flags

2025-03-28 Thread Sam James
Michal Jires writes: > On Thu, 2025-03-27 at 15:33:44 +0000, Sam James wrote: >> >> One thing I wasn't quite sure on yet: is -flto-partition=cache automatic >> with -flto-incremental? Or is it just an optional flag I can pass for >> more effective incrementa

Re: [PATCH 12/12] testsuite, s390: fix broken dg directives

2025-03-28 Thread Sam James
David Malcolm writes: > Found by dg-lint. > > gcc/testsuite/ChangeLog: > * gcc.target/s390/target-attribute/tattr-1.c: Fix missing trailing > close brace on dg-do directive. > * gcc.target/s390/target-attribute/tattr-2.c: Likewise. I've cherry-picked the remaining ones and reso

Re: [PATCH 1/3] testsuite: harmless dg-* whitespace fixes

2025-03-27 Thread Sam James
Harald Anlauf writes: > Sam, > > who approved the fortran testsuite changes? We've been doing them as obvious by consensus since last year. I'm sorry for the error. > > Am 27.03.25 um 14:28 schrieb Sam James: >> These just fix inconsistent/unusual style to avoid

Re: [PATCH 5/6] testsuite: fix more dg-* whitespace issues

2025-03-27 Thread Sam James
Marek Polacek writes: > On Thu, Mar 27, 2025 at 12:38:55AM +0000, Sam James wrote: >> A handful of cosmetic ones in here but most meant the directive wasn't >> doing anything. > > This patch breaks g++.dg/template/explicit-args6.C for me. See PR119490. I can XFAIL i

[PATCH] testsuite: revert Fortran change

2025-03-27 Thread Sam James
Revert part of my change from r15-8973-g1307de1b4e7d5e; as Harald points out, the comment explains why this is there. It's a hack but it needs to stay for now. (I did have this marked as a TODO in my branch and didn't leave a proper note as to why, so it's my fault.) gcc/testsuite/ChangeLog:

[PATCH] testsuite: aarch64: fix another unbalanced }

2025-03-27 Thread Sam James
In r15-8956-ge90d6c2639c392, I missed one, so while it did fix a problem, it also exposed another because the braces were now unbalanced. There's IMO more to do here with ideally whitespace before the } when using scan-assembler-times but let's do that later. gcc/testsuite/ChangeLog: * g

Re: [PATCH] doc: document incremental LTO flags

2025-03-27 Thread Sam James
Michal Jires writes: > This adds missing documentation for LTO flags. > > Ok? > > gcc/ChangeLog: > > * doc/invoke.texi: (Optimize Options): > Add incremental LTO flags. > --- > gcc/doc/invoke.texi | 26 +++--- > 1 file changed, 23 insertions(+), 3 deletions(-) > >

[PATCH 3/3] testsuite: fix dg-* typos

2025-03-27 Thread Sam James
I have a handful more of these left but those introduce FAILs, while these all introduce new PASSes. libstdc++-v3/ChangeLog: * testsuite/std/format/string_neg.cc: Add missing brace for dg-error. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fd-datagram-socket.c: Fix 'dg-message' sp

[PATCH 2/3] testsuite: fix typos in comments

2025-03-27 Thread Sam James
This fixes some 'scan-tree-dump-times' (vs '-time') typos and one or two others I noticed in passing. gcc/testsuite/ChangeLog: * g++.dg/warn/Winvalid-memory-model.C: Fix typo in comment. * gcc.dg/builtin-dynamic-object-size-19.c: Ditto. * gcc.dg/builtin-object-size-19.c: D

[PATCH 1/3] testsuite: harmless dg-* whitespace fixes

2025-03-27 Thread Sam James
These just fix inconsistent/unusual style to avoid noise when grepping and also people picking up bad habits when they see it (as similar mistakes can be harmful). gcc/testsuite/ChangeLog: * c-c++-common/goacc/pr69916.c: Fix unusual whitespace in dg-*. * g++.old-deja/g++.abi/vtabl

[PATCH 0/3] testsuite: more typo/directive fixes

2025-03-27 Thread Sam James
Pushed. Sam James (3): testsuite: harmless dg-* whitespace fixes testsuite: fix typos in comments testsuite: fix dg-* typos gcc/testsuite/c-c++-common/goacc/pr69916.c| 2 +- gcc/testsuite/g++.dg/warn/Winvalid-memory-model.C | 2 +- gcc/testsuite/g++.old-deja/g++.abi

[PATCH 4/6] testsuite: fix dg-message typos

2025-03-26 Thread Sam James
gcc/testsuite/ChangeLog: * g++.dg/diagnostic/unclosed-extern-c.C: Fix 'dg-message' typo. * g++.dg/warn/Wno-attributes-1.C: Ditto. --- gcc/testsuite/g++.dg/diagnostic/unclosed-extern-c.C | 2 +- gcc/testsuite/g++.dg/warn/Wno-attributes-1.C| 6 +++--- 2 files changed, 4 inse

[PATCH 2/6] testsuite: fix dg-bogus typo

2025-03-26 Thread Sam James
The dg-bogus directive here is trying to match -Warray-bounds or -Wstringop-overflow, but it got the casing wrong on the latter. gcc.dg/pr89350.c gets this right. gcc/testsuite/ChangeLog: PR middle-end/93437 * g++.dg/warn/Wstringop-overflow-5.C: Fix -Wstringop-overflow casing. --

[PATCH 3/4] testsuite: g++.dg: vect: fix PR37143 filename

2025-03-26 Thread Sam James
The test was being ignored because vect.exp looks for .cc in g++.dg/vect/. gcc/testsuite/ChangeLog: PR tree-optimization/37143 * g++.dg/vect/pr37143.C: Move to... * g++.dg/vect/pr37143.cc: ...here. --- gcc/testsuite/g++.dg/vect/{pr37143.C => pr37143.cc} | 0 1 file change

[PATCH 5/6] testsuite: fix more dg-* whitespace issues

2025-03-26 Thread Sam James
A handful of cosmetic ones in here but most meant the directive wasn't doing anything. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/udlit-namespace-ambiguous.C: Fix whitespace. * g++.dg/cpp2a/constexpr-init21.C: Ditto. * g++.dg/diagnostic/wrong-tag-1.C: Ditto. * g++.dg/

[PATCH] testsuite: fixup tree scan syntax for strub-internal-pr112938.C

2025-03-26 Thread Sam James
This wasn't being run before my r15-8949-g6b21f7969241cf so went unnoticed. Match [0-9+] instead of [0-9][0-9] and escape the parentheses around 'D'. gcc/testsuite/ChangeLog: PR testsuite/119489 * g++.dg/strub-internal-pr112938.C: Adjust pattern. --- Pushed as obvious. gcc/test

[PATCH 2/4] testsuite: tree-ssa: fix PR98265 filename

2025-03-26 Thread Sam James
.C is for C++ testcases and gcc.dg's dg.exp ignores .c. The test was not being run. gcc/testsuite/ChangeLog: PR ipa/98265 * gcc.dg/tree-ssa/pr98265.C: Move to... * g++.dg/tree-ssa/pr98265.C: ...here. --- gcc/testsuite/{gcc.dg => g++.dg}/tree-ssa/pr98265.C | 0 1 file chan

[PATCH 0/6] testsuite: more misc. syntax fixes

2025-03-26 Thread Sam James
Pushed as obvious. Sam James (6): testsuite: fortran: fix dg syntax errors testsuite: fix dg-bogus typo testsuite: more (mostly cosmetic) dg- whitespace fixes testsuite: fix dg-message typos testsuite: fix more dg-* whitespace issues testsuite: assorted targets: add missing braces to

[PATCH 1/6] testsuite: fortran: fix dg syntax errors

2025-03-26 Thread Sam James
No change in test results. The changes other than the first are arguably not errors, but still clearly wrong and mistakes. gcc/testsuite/ChangeLog: * gfortran.dg/associate_70.f90: Replace ')' with '}'. * gfortran.dg/bessel_3.f90: Drop extraneous ')'. * gfortran.dg/c_funloc

[PATCH 3/6] testsuite: more (mostly cosmetic) dg- whitespace fixes

2025-03-26 Thread Sam James
Some of these are harmless but still inconsistent (and asking for trouble given it may give people the wrong idea about similar "style"). gcc/testsuite/ChangeLog: * g++.dg/cpp0x/gen-attrs-6.C: Surround 'target' by whitespace. * gcc.target/aarch64/atomic-inst-ldlogic.c: Fix 'dg-fin

[PATCH] doc: say "compatible types" for -fstrict-aliasing

2025-03-26 Thread Sam James
Include the term used in the standard to ease further research for users. gcc/ChangeLog: * doc/invoke.texi: Use "compatible types" term. --- gcc/doc/invoke.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index b3f

[PATCH 6/6] testsuite: assorted targets: add missing braces to dg-* directives

2025-03-26 Thread Sam James
These get ignored otherwise. gcc/testsuite/ChangeLog: * gcc.target/arc/taux-1.c: Add missing brace. * gcc.target/arc/taux-2.c: Ditto. * gcc.target/i386/addr-space-1.c: Ditto. * gcc.target/ia64/mfused-madd-vect.c: Ditto. * gcc.target/ia64/mfused-madd.c: Ditt

[PATCH 4/4] testsuite: tree-ssa: fix PR98265 test to use C++14

2025-03-26 Thread Sam James
This test was previously not being run at all so this wasn't noticed until my fix just now. The test needs C++14 and it also should use scan-tree-dump, not scan-tree-dump-times, as it wasn't passing a count parameter. gcc/testsuite/ChangeLog: PR ipa/98265 * g++.dg/tree-ssa/pr9826

[PATCH 1/4] testsuite: g++.dg: fix PR112938 filename

2025-03-26 Thread Sam James
The test was being ignored because dg.exp looks for .C in g++.dg/. gcc/testsuite/ChangeLog: PR middle-end/112938 * g++.dg/strub-internal-pr112938.cc: Move to... * g++.dg/strub-internal-pr112938.C: ...here. --- .../{strub-internal-pr112938.cc => strub-internal-pr112938.C}

[PATCH 0/4] testsuite: filename/location fixes

2025-03-26 Thread Sam James
These weren't being run before because of the wrong filename or location. Pushed the lot as obvious. Sam James (4): testsuite: g++.dg: fix PR112938 filename testsuite: tree-ssa: fix PR98265 filename testsuite: g++.dg: vect: fix PR37143 filename testsuite: tree-ssa: fix PR98265 te

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
Sam James writes: > David Malcolm writes: > >> This patch adds a new dg-lint subdirectory below contrib, containing >> a "dg-lint" script for detecting common mistakes made in our DejaGnu >> tests. >> I should say: I don't think any of my comm

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
Jakub Jelinek writes: > On Wed, Mar 26, 2025 at 09:32:30PM +0000, Sam James wrote: >> Right, we can extend it for 'dg-do known-actions' as well. > > I think that shouldn't be necessary. > > gcc-dg-test-1 should already complain about unexpected actions. Ah, you're right. Thanks.

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
David Malcolm writes: > On Wed, 2025-03-26 at 19:59 +0100, Jakub Jelinek wrote: >> On Wed, Mar 26, 2025 at 02:34:43PM -0400, David Malcolm wrote: >> >> Thanks for working on this. >> My python is very limited, so just adding some comments rather >> than doing patch review. >> >> > +COMMON_MISSP

Re: [PATCH 01/12] contrib: add dg-lint and libgdiagnostics.py [PR116163]

2025-03-26 Thread Sam James
David Malcolm writes: > This patch adds a new dg-lint subdirectory below contrib, containing > a "dg-lint" script for detecting common mistakes made in our DejaGnu > tests. > > Specifically, DejaGnu's dg.exp's dg-get-options has a regexp for > detecting dg- directives > https://git.savannah.gnu

Re: [PATCH] testsuite: add testcase for recent alias fix

2025-03-26 Thread Sam James
Martin Jambor writes: > Hi, > > On Tue, Mar 25 2025, Sam James wrote: >> r15-7961-gdc47161c1f32c3 fixes a typo in ao_compare::compare_ao_refs >> but there wasn't a testcase available at the time. Now there is. >> >> Thanks to Andrew for the testcase. >

[PATCH] testsuite: add testcase for recent alias fix

2025-03-25 Thread Sam James
r15-7961-gdc47161c1f32c3 fixes a typo in ao_compare::compare_ao_refs but there wasn't a testcase available at the time. Now there is. Thanks to Andrew for the testcase. gcc/testsuite/ChangeLog: PR testsuite/119382 * gcc.dg/ipa/ipa-icf-40.c: New test. Co-authored-by: Andrew Pinsk

Re: [PATCH] COBOL v3: 3/14 80K bld: config and build machinery

2025-03-17 Thread Sam James
Andreas Schwab writes: > On Mär 13 2025, James K. Lowden wrote: > >> On Tue, 11 Mar 2025 11:18:22 +0100 >> Andreas Schwab wrote: >> >>> libgcobol/configure.tgt says it's supported on powerpc64le. >> >> Our intention, tell me if you disagree, is that cobol is enabled if >> >> 1. --enable-languag

Re: [PATCH v2] reassoc: Optimize CMP/XOR expressions [PR116860]

2025-03-16 Thread Sam James
Hans-Peter Nilsson writes: > On Thu, 13 Mar 2025, Konstantinos Eleftheriou wrote: >> Testcases for match.pd patterns >> `((a ^ b) & c) cmp d | a != b -> (0 cmp d | a != b)` and >> `(a ^ b) cmp c | a != b -> (0 cmp c | a != b)` were failing on some targets, >> like PowerPC. >> >> This patch adds

Re: [PATCH] contrib: Wrap git repo access in gcc-changelog.

2025-03-15 Thread Sam James
"Robin Dapp" writes: > Hi, > > since updating to Fedora 41 I have been seeing ignored python exceptions > like the following when using 'git gcc-verify' = > contrib/gcc_changelog/git_check_commit.py. > > Checking 90fcc1f4f1a5537e8d30628895a07cbb2e7e16ff: OK > Exception ignored in: > Traceback (

Re: [PATCH][v3] Simple cobol.dg testsuite

2025-03-13 Thread Sam James
Simon Sobisch writes: > Thanks for your work on adding a testsuite. Can you please explain why > you do this when a complete testsuite exists in autoconf (autotest) > format (which roots back to decade of work in GnuCOBOL, with all > copyrights for that already with the FSF)? > I don't think any

Re: [PATCH] Add Robert Dubner to Maintainers

2025-03-11 Thread Sam James
Robert Dubner writes: >> -Original Message- >> From: Jakub Jelinek >> Sent: Tuesday, March 11, 2025 17:40 >> To: Robert Dubner >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH] Add Robert Dubner to Maintainers >> >> On Tue, Mar 11, 2025 at 02:24:26PM -0500, Robert Dubner wrote: >>

Re: The COBOL front end -- The Initial Onslaught

2025-03-11 Thread Sam James
Robert Dubner writes: > > I need to be able to change, at the very least, the Assignment field. I > don't seem to have any way of doing that. Make sure your email address on Bugzilla is x...@gcc.gnu.org. Using that address grants the account editbugs privileges. sam

Re: [PATCH] i386: Verify that argument registers are spilled properly

2025-03-09 Thread Sam James
Uros Bizjak writes: > On Sun, Mar 9, 2025 at 3:05 PM H.J. Lu wrote: >> >> RDI, RSI, RDX and RCX registers are used to pass arguments in 64-bit >> mode. EAX, EDX and ECX registers are used to pass arguments in 32-bit >> mode. Add tests to verify that argument registers are spilled properly. >>

Re: [RFC] PR81358: Enable automatic linking of libatomic

2025-03-07 Thread Sam James
Sam James writes: > Prathamesh Kulkarni writes: > >>> -Original Message- >>> From: Prathamesh Kulkarni >>> Sent: 10 January 2025 09:48 >>> To: Thomas Schwinge >>> Cc: Tobias Burnus ; Joseph Myers >>> ; Xi Ruoyao ; Matth

[PATCH htdocs 2/2] gcc-8/porting_to: link to Fedora mass rebuild post

2025-03-05 Thread Sam James
As is done for other releases. --- Pushed. htdocs/gcc-8/porting_to.html | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/htdocs/gcc-8/porting_to.html b/htdocs/gcc-8/porting_to.html index d24ea347..1d16a29e 100644 --- a/htdocs/gcc-8/porting_to.html +++ b/htdocs/gcc-8/porti

[PATCH htdocs 1/2] gcc-4.8/porting_to: update link to archive of Fedora rebuild

2025-03-05 Thread Sam James
--- Pushed. htdocs/gcc-4.8/porting_to.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/htdocs/gcc-4.8/porting_to.html b/htdocs/gcc-4.8/porting_to.html index 9ed0d06b..c7e188ef 100644 --- a/htdocs/gcc-4.8/porting_to.html +++ b/htdocs/gcc-4.8/porting_to.html @@ -231,7 +231,7

[PATCH htdocs] bugs: Link to all 'Porting to' docs in 'Common problems when upgrading ...'

2025-03-05 Thread Sam James
Suggested by Andrew Pinski. I think it makes sense to have it in here even if perhaps a bit verbose, because we really try to tell bug reporters to read the page properly. --- This takes into account Gerald's comments, hopefully faithfully. Gerald, let me know if I misinterpreted anything or need

  1   2   3   4   5   >