This libgo patch avoids the libc memmove and memclr functions when the
type being moved or cleared may contain pointer values. This is
necessary to ensure that Go's concurrent garbage collector doesn't see
corrupt pointer values.
The libc memmove and memclr don't reliably operate on full memory
wo
This libgo patch passe the correct pointer to the system call in
recvmsgRaw. The code in recvmsgRaw, introduced in CL 384695
(https://gcc.gnu.org/pipermail/gcc-patches/2022-February/590289.html),
incorrectly passed &rsa to the recvmsg system call. But in recvmsgRaw
rsa is already a pointer passed b
Andreas Schwab writes:
> * regex.c (regex_compile): Don't write beyond array bounds when
> collecting range expression.
This is OK.
Thanks.
Ian
On Wed, Apr 9, 2025 at 7:16 AM John David Anglin wrote:
>
> Tested on hppa64-hp-hpux11.11.
>
> Okay?
>
> Dave
> ---
>
> libbacktrace: Add hpux fileline support
>
> Fixes libstdc++ stacktrace tests.
>
> 2025-04-09 John David Anglin
>
> libbacktrace/ChangeLog:
> * fileline.c (hpux_get_exe
Jakub Jelinek writes:
> On Tue, Apr 08, 2025 at 03:03:03PM +0200, Richard Biener wrote:
>> It seems that at least when cross-compiling at least collect2 pulls
>> in objects from libbacktrace.a which is linked via LIBDEPS. But
>> libbacktrace for the host is only built -fPIC with --enable-host-sh
On Tue, Mar 4, 2025 at 2:12 AM Richard Biener wrote:
> As PR119098 shows the gccgo driver uses the install path compiled
> into the shared libgo and thus updating that but not the driver
> will cause the driver to fail to find other tools like cgo.
>
> Thus bump the SONAME for GCC 15 as well, as
On Thu, Jan 30, 2025 at 3:23 PM Ian Lance Taylor wrote:
>
> This patch from pgerell at GitHub adds some casts to libbacktrace to
> avoid undefined shifts. These shifts are OK on all real systems but
> may as well get it right. Bootstrapped and ran libbacktrace tests on
> x86_
This patch updates the attributes for the relatively few builtin
functions defined by the Go frontend to the current ones in
builtins.def. This fixes PR 118746. Bootstrapped and ran Go
testsuite on x86_64-pc-linux-gnu. Committed to mainline.
Ian
PR go/118746
* go-gcc.cc (class Gcc_backend): De
This patch from pgerell at GitHub adds some casts to libbacktrace to
avoid undefined shifts. These shifts are OK on all real systems but
may as well get it right. Bootstrapped and ran libbacktrace tests on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
libbacktrace: add casts to avoid undefined
Richard Earnshaw writes:
> Older versions of the Arm architecture lack support for __sync
> operations directly in hardware and require calls into appropriate
> operating-system hooks. But such hooks obviously don't exist in a
> freestanding environment.
>
> Consquently, it is incorrect to assum
PR 118286 points out that some libgo tests are starting to fail
because they use test certificates that expired on January 1. This
libgo patch is a backport of https://go.dev/cl/640237 in the main
repo. It uses the existing config.Time field to avoid these test
failures. Bootstrapped and ran Go t
PR 117812 reports a libbacktrace test failure when building with a
2018 version of zstd, because ZSTD_CLEVEL_DEFAULT is not defined.
This patch avoids using it, replacing it with the default value 3.
The test doesn't really care what compression level is used anyhow.
Bootstrapped and ran libbacktra
David Edelsohn writes:
> On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth
> wrote:
>
>> Hi David,
>>
>> > No objection from me, but Ian is the maintainer of libiberty, so I'll
>> defer
>> > to him, especially about style and overall software engineering.
>> >
>> > The C23 change presumably will break
This patch to the Go frontend changes traversal to always traverse
method declarations (method definitions were already traversed). This
removes one existing case that explicitly traversed method
declarations, in favor of the common approach.
Note that the gc Go compiler rejects method declaratio
The libbacktrace code accidentally use WIN32_MEAN_AND_LEAN when it
should have use WIN32_LEAN_AND_MEAN. This was pointed out by awmorgan
on GitHub. I've committed this patch to fix it.
Ian
* fileline.c: Use WIN32_LEAN_AND_MEAN, not WIN32_MEAN_AND_LEAN.
* pecoff.c: Likew
This patch to the Go frontend increases the size of a temporary buffer
to avoid a new warning. The warning was breaking bootstrapping with
Go.
GCC has a new -Wformat-truncation warning that triggers on some Go
frontend code:
../../gcc/go/gofrontend/go-encode-id.cc: In function 'std::string
go_en
On Thu, Oct 31, 2024 at 1:01 PM Mark Wielaard wrote:
>
> These comment typos were found in the valgrind fork of libiberty
> demangle code.
>
> libiberty/ChangeLog:
>
> * cplus-dem.c: Change preceeded to preceded.
>
> include/ChangeLog:
>
> * safe-ctype.h: Change accidently to accid
On Tue, Oct 29, 2024 at 2:04 PM Samuel Thibault
wrote:
>
> * libgo/go/syscall/syscall_funcs.go: Do not build on GNU/Hurd.
> * libgo/go/syscall/syscall_funcs_stubs.go: Build on GNU/Hurd.
> * libgo/runtime/go-nosys.c: Do not produce syscall() stub on
> GNU/Hurd.
>
T
This patch by Pavel Safonov recognizes the new DWARF section names
used on macos Sequoia. Bootstrapped and ran libbacktrace tests on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
* macho.c (dwarf_section_names): Add __debug_addr and
__debug_line_str.
d97243588c8b5cbe8b657fd51f08038c42c81908
d
On Thu, Oct 17, 2024 at 1:19 PM Joseph Myers wrote:
>
> Making GCC default to -std=gnu23 for C code produces Go test failures
> because of C code used by Go that uses a variable called nullptr, which is
> a keyword in C23.
>
> I've submitted this fix upstream at
> https://github.com/golang/go/pull
Because libbacktrace merges adjacent address ranges where possible,
and because the GNU linker can deduplicate functions leaving debuginfo
that refers to address ranges in other compilation units, it is
possible for libbacktrace to have overlapping address ranges, in
particular to overlap ranges wi
This patch to the Go frontend avoids assuming that ATTRIBUTE_UNUSED is
defined. While it is defined when building the Go frontend as part of
GCC, it is meant to work with other compilers as well. Bootstrapped
and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline.
Ian
e89ddb749517ea
This patch, based on one by Kirill Müller, adds -Wpointer-arith to the
libbacktrace warning options, and adds casts to avoid the cases where
the warning currently fires. Bootstrapped and ran libbacktrace
testsuite on x86_64-pc-linux-gnu. Committed to mainline.
Ian
* configure.ac (ACX_PROG_CC_WA
This patch to the Go frontend determines that panic arguments are
empty interfaces. After https://go.dev/cl//536643 passing NULL as the
expected type permitted an untyped constant expression to remain
untyped. This change will fix them to take on the empty interface
type.
The panic and print/prin
On Mon, Jul 29, 2024 at 12:41 PM Björn Schäpers wrote:
>
> > Instead of deleting those, move them inside the parentheses:
> >
> > typedef VOID (CALLBACK *LDR_DLL_NOTIFICATION)(ULONG,
> > struct dll_notification_data*,
> >
On Fri, Mar 15, 2024 at 1:41 PM Björn Schäpers wrote:
>
> Am 10.01.2024 um 13:34 schrieb Eli Zaretskii:
> >> Date: Tue, 9 Jan 2024 21:02:44 +0100
> >> Cc: i...@google.com, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
> >> From: Björn Schäpers
> >>
> >> Am 07.01.2024 um 18:03 schrieb Eli Zaretskii:
>
This libbacktrace patch uses __has_attribute for fallthrough. It also
fixes some FALLTHROUGH comments to use ATTRIBUTE_FALLTHROUGH.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed
to mainline.
Ian
* internal.h: Use __has_attribute to check for fallthrough
attribute.
* elf.c
On Wed, Jul 17, 2024 at 5:40 PM Ian Lance Taylor wrote:
>
> This libbacktrace patch improves backtrace_print when there is no
> debug info. It falls back to calling backtrace_syminfo, and uses that
> to print an offset from a symbol if it can. This is a partial fix for
> htt
This libbacktrace patch improves backtrace_print when there is no
debug info. It falls back to calling backtrace_syminfo, and uses that
to print an offset from a symbol if it can. This is a partial fix for
https://github.com/ianlancetaylor/libbacktrace/issues/59.
Bootstrapped and ran libbacktrace
This patch adds some notes about dl_iterate_phdr to the libbacktrace
README file. In general dl_iterate_phdr is not async-signal-safe and
does call malloc, so programs that want to use libbacktrace functions
from a signal handler or within malloc must make an initiali
libbacktrace call in order to
On Tue, Jul 16, 2024 at 5:41 PM David Edelsohn wrote:
>
> I believe that this patch broke bootstrap on AIX:
>
> /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c: In function 'xcoff_add':
> /nasfarm/edelsohn/src/src/libbacktrace/xcoff.c:1309:40: error: incompatible
> type for argument 2 of 'backtrac
On Mon, Jul 15, 2024 at 3:17 PM Max Filippov wrote:
>
> On Mon, Jul 15, 2024 at 10:21:18AM -0700, Ian Lance Taylor wrote:
> > Can you see whether this patch works for FDPIC support? This is based
> > on your patch but has various changes. Thanks.
>
> Yes, it is work
Can you see whether this patch works for FDPIC support? This is based
on your patch but has various changes. Thanks.
Ian
diff --git a/libbacktrace/dwarf.c b/libbacktrace/dwarf.c
index cc36a0a2990..96ffc4cc481 100644
--- a/libbacktrace/dwarf.c
+++ b/libbacktrace/dwarf.c
@@ -388,8 +388,8 @@ struct
On Sat, Jul 13, 2024 at 7:52 PM Max Filippov wrote:
>
> On Wed, Jul 10, 2024 at 12:49 PM Ian Lance Taylor wrote:
> > On Sun, May 26, 2024 at 11:51 PM Max Filippov wrote:
> > > diff --git a/libbacktrace/internal.h b/libbacktrace/internal.h
> > > index 4fa
libbacktrace could get an infinite recursion in an odd case in which a
.gnu_debugdata section was added to a debug file, and mini_debuginfo
was put into the debug file, and the debug file was put into a
/usr/lib/debug directory to be found by build ID. This combination
doesn't really make sense bu
Mach-O and PE/COFF don't record symbol sizes in the symbol table.
Adjust the libbacktrace testsuite so that it doesn't fail if the
symbol size is unknown, only if it is incorrect. Ran libbacktrace
tests on macOS on the compile farm and on x86_64-pc-linux-gnu.
Committed to mainline.
Ian
The libbacktrace symbol table code was incorrectly discarding global
Mach-O symbols. This patch fixes the problem. Tested on macOS on the
compile farm, and also on x86_64-pc-linux-gnu. Committed to mainline.
Ian
For PR libbacktrace/97082
* macho.c (MACH_O_N_EXT): Don't
On Thu, Jul 11, 2024 at 4:18 PM Andrew Pinski wrote:
>
> On Thu, Jul 11, 2024 at 4:14 PM Ian Lance Taylor wrote:
> >
> > The libbacktrace testsuite was not passing when run with current
> > versions of clang. Add the optnone attribute to make it pass. Add
> > -W
The libbacktrace testsuite was not passing when run with current
versions of clang. Add the optnone attribute to make it pass. Add
-Wno-attributes and -Wno-unknown-attributes to disable warnings about
unrecognized function attributes. Bootstrapped and ran libbacktrace
testsuite on x86_64-pc-linu
This small libbacktrace patch suggests compiling with -g (and, on
macOS, running dsymutil), if there is no debug info. Ran libbacktrace
testsuite. Committed to mainline.
Ian
* elf.c (elf_nodebug): Suggest -g.
* macho.c (macho_nodebug): Suggest -g and dsymutil.
This minor libbacktrace patch removes trailing whitespace. Ran
libbacktrace tests. Committed to mainline.
Ian
* dwarf.c: Remove trailing whitespace.
* macho.c: Likewise.
3f660179d6a0ebcd83d6a546f48a163d1a685f72
diff --git a/libbacktrace/dwarf.c b/libbacktrace/dwarf.c
index ed067
On Sun, May 26, 2024 at 11:51 PM Max Filippov wrote:
>
> diff --git a/libbacktrace/internal.h b/libbacktrace/internal.h
> index 4fa0af8cb6c9..456911166026 100644
> --- a/libbacktrace/internal.h
> +++ b/libbacktrace/internal.h
> @@ -323,10 +323,22 @@ struct dwarf_sections
>
> struct dwarf_data;
>
I've committed this libbacktrace patch to not fail on the case where
there are no bits available when looking backward. This can happen at
the very end of the frame if no bits are actually required. The test
case is long and may be proprietary, so not including it.
Bootstrapped and ran libbacktra
"Kewen.Lin" writes:
> Hi,
>
> Gentle ping:
>
> https://gcc.gnu.org/pipermail/gcc-patches/2024-June/653387.html
>
> BR,
> Kewen
>
> on 2024/6/3 11:00, Kewen Lin wrote:
>> Joseph pointed out "floating types should have their mode,
>> not a poorly defined precision value" in the discussion[1],
>> as
On Thu, Jun 6, 2024 at 7:13 AM Rainer Orth
wrote:
>
> The Go testsuite's go.sum file ends in
>
> Couldn't determine version of
> /var/gcc/regression/master/11.4-gcc-64/build/gcc/gccgo
>
> on Solaris. It turns out this happens because gccgo -v is confused:
>
> [...]
> gcc version 15.0.0 20240531
On Thu, Jun 6, 2024 at 7:00 AM Rainer Orth
wrote:
>
> The index0-out.go test FAILs on Solaris (SPARC and x86, 32 and 64-bit),
> as well as several others:
>
> FAIL: ./index0-out.go execution, -O0 -g -fno-var-tracking-assignments
>
> The test SEGVs because it tries a stack acess way beyond the st
On Thu, May 30, 2024 at 12:48 AM Martin Uecker wrote:
>
>
> Hi Ian,
>
> can you give me a green light for the go changes. The C FE
> changes were approved.
>
> The only change with respect to the last version are
> the removal of the unneeded null check for the
> main variant (as discussed) and th
On Thu, May 23, 2024 at 2:48 PM Martin Uecker wrote:
>
> Am Donnerstag, dem 23.05.2024 um 14:30 -0700 schrieb Ian Lance Taylor:
> > On Thu, May 23, 2024 at 2:00 PM Joseph Myers wrote:
> > >
> > > On Tue, 21 May 2024, Martin Uecker wrote:
> > > >
> &g
On Thu, May 23, 2024 at 2:00 PM Joseph Myers wrote:
>
> On Tue, 21 May 2024, Martin Uecker wrote:
> >
> > C: allow aliasing of compatible types derived from enumeral types
> > [PR115157]
> >
> > Aliasing of enumeral types with the underlying integer is now allowed
> > by setting the a
On Thu, May 2, 2024 at 12:23 PM Björn Schäpers wrote:
>
> Am 28.04.2024 um 20:16 schrieb Ian Lance Taylor:
> >
> > Which of your other patches are still relevant? Thanks.
> >
> only this one.
Thanks. Committed.
Ian
On Thu, May 2, 2024 at 7:06 AM Rainer Orth
wrote:
>
> * libgo configure.ac and Makefile.am can now expect HAVE_STAT_TIMESPEC
> to be true and libgo_cv_lib_setcontext_clobbers_tls doesn't apply any
> longer. Any change would have to go upstream first and I don't know
> about Ian's policy fo
On Wed, May 1, 2024 at 7:50 PM Andrew Pinski wrote:
>
> On Wed, May 1, 2024 at 7:40 PM Ian Lance Taylor wrote:
> >
> > On Wed, May 1, 2024 at 12:43 AM Aldy Hernandez wrote:
> > >
> > > gcc/ChangeLog:
> > >
> > > * ipa-f
On Wed, May 1, 2024 at 12:43 AM Aldy Hernandez wrote:
>
> gcc/ChangeLog:
>
> * ipa-fnsummary.cc (evaluate_properties_for_edge): Initialize
> Value_Range's.
> * value-range.h (class Value_Range): Add a buffer and remove
> m_irange and m_frange.
> (Value_Range::Value
This libgo patch, by Rainer Orth, dumps register values on Solaris on
a crash. This fixes GC PR 106813. Bootstrapped and ran Go testsuite
on x86_64-pc-linux-gnu. Committed to mainline.
Ian
a05efc8bf5ed329ea7d9b1740c326bdc6b04e37a
diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE
in
This libgo patch changes runtime/runtime.h to use the C99
header file rather than defining a bool type and true/false constants
itself. C99 was a long time ago and in case this file is always
compiled by the newly built GCC. This should fix GCC PR 114875.
Bootstrapped on x86_64-pc-linux-gnu. Co
On Thu, Apr 25, 2024 at 1:15 PM Björn Schäpers wrote:
>
> > Attached is the combined version of the two patches, only implementing the
> > variant with the tlhelp32 API.
> >
> > Tested on x86 and x86_64 windows.
> >
> > Kind regards,
> > Björn.
>
> A friendly ping.
Thanks. Committed as follows.
On Tue, Apr 23, 2024 at 7:24 AM Jakub Jelinek wrote:
>
> What we could do is drop the HAVE_COMPRESSED_DEBUG stuff altogether, and
> instead similarly how we have HAVE_COMPRESSED_DEBUG_ZSTD have
> HAVE_COMPRESSED_DEBUG_{ZLIB,ZLIB_GABI,ZLIB_GNU} and for each of those
> if linker supports them test w
On Mon, Apr 15, 2024 at 5:42 AM Jakub Jelinek wrote:
>
> 2024-04-15 Jakub Jelinek
>
> * Makefile.am (install-exec-local, uninstall-local): Add goals
> on the else branch of if NATIVE to ensure reproducibility.
> * Makefile.in: Regenerate.
This is OK. Go ahead and commi
On Thu, Apr 4, 2024 at 9:27 AM Christophe Lyon
wrote:
>
> go has a go.dvi build rule, but lacks the go.install-dvi one.
>
> 2024-04-04 Christophe Lyon
>
> gcc/go/
> * Make-lang.in (go.install-dvi): New rule.
This is OK. Thanks.
Ian
This patch to the Go frontend uses the correct size and comparison
when doing an index value overflow check. This has apparently been
wrong since I introduced the code ten years ago. This fixes GCC PR
114500. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.
Committed to mainline.
Ian
1
This patch to the Go testsuite updates issue16016.go. This backports
https://go.dev/cl/574536 into the GCC testsuite. This fixes PR
go/114453. Bootstrapped and ran test. Committed to mainline.
Ian
5b6f599670994bef957bd15c683102468a7104f1
diff --git a/gcc/testsuite/go.test/test/fixedbugs/issue1
This patch to the Go frontend fixes an uninitialized variables in
lower_method_expression. This fixes GCC PR 114463. Bootstrapped and
ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline.
Ian
7b2a24f3964509bd5b74c4579c7ea5684e82aee1
diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofron
pp; bootstrap=true; }; // since 4f4e53dd8517c0b2
> - year 2004
Yes. I was just trying to answer your question.
Ian
> Am 25. März 2024 23:59:52 UTC schrieb Ian Lance Taylor :
>>
>> On Sat, Mar 23, 2024 at 4:32 AM Дилян Палаузов
>> wrote:
>>>
>>>
>>>
On Sat, Mar 23, 2024 at 4:32 AM Дилян Палаузов
wrote:
>
> Can the build experts say what needs to be changed? The dependencies I added
> are missing in the build configuration (@if gcc-bootstrap).
>
> I cannot say if libbacktrace should or should not be a bootstrap=true module.
I don't count as
Reportedly when lld compresses debug sections, it fails to set the
alignment of the compressed section such that the compressed header
can be read directly. To me this seems like a bug in lld. However,
libbacktrace needs to work around it. This patch, originally by the
GitHub user ubyte, does th
Some of the libbacktrace tests link a program and then modify the
debug info in some way. When configured with --enable-shared the
linking, using libtool, generates a shell script. That causes the
tests to fail because they can't modify the debug info of a shell
script. This patch, originally by
This patch to libbacktrace corrects the LZMA block header parsing to
skip all the padding bytes, verifying that they are zero. This fixes
https://github.com/ianlancetaylor/libbacktrace/issues/118.
Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu. I was
able to verify that the proble
On Thu, Feb 29, 2024 at 7:47 PM Ian Lance Taylor wrote:
>
> This patch to libbacktrace reads symbol tables from debuginfo files.
> These become another symbol table to search. This is needed if people
> use --strip-all rather than --strip-debug when adding a debuglink
> secti
This patch to libbacktrace reads symbol tables from debuginfo files.
These become another symbol table to search. This is needed if people
use --strip-all rather than --strip-debug when adding a debuglink
section. This fixes
https://github.com/ianlancetaylor/libbacktrace/issues/113.
Bootstrapped
On Tue, Feb 6, 2024 at 6:08 PM Jason Merrill wrote:
>
> Tested x86_64-pc-linux-gnu. Any thoughts?
It still makes sense to me, for what that's worth.
Ian
> -- 8< --
>
> The patch for PR22340 (r104978) moved the adding of TARGET_LIB_PATH to
> RPATH_ENVVAR from POSTSTAGE1_HOST_EXPORTS to HOST_EX
This libgo patch bumps the version number for the GCC 14 release.
This is for GCC PR 113668. Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
7b0597eba6b29387b56b8d6a4b38f3586e6b49a5
diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofrontend/MERGE
index ec7e2ab1
This patch to the Go frontend adds Type::message_name to print types
in ways that makes sense to users. As we move toward generics, the
error messages need to be able to refer to types in a readable manner.
Today we use this new feature in AST dumps. Bootstrapped and ran Go
testsuite on x86_64-pc
This libgo patch generates better error messages then the Go GOARCH
and GOOS values can't be determined from the target. This indicates
that the target is not supported. This is for GCC PR 113530.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed
to mainline.
Ian
cfc6d9ae8143c
This patch to the Go frontend exports the type "any" as a builtin.
Otherwise we can't tell the difference between builtin type "any" and
a locally defined type "any".
This will require updates to the gccgo export data parsers in the main
Go repo and the x/tools repo. These updates are https://go.
On Thu, Jan 25, 2024 at 11:53 AM Björn Schäpers wrote:
>
> Am 23.01.2024 um 23:37 schrieb Ian Lance Taylor:
> > On Thu, Jan 4, 2024 at 2:33 PM Björn Schäpers wrote:
> >>
> >> Am 03.01.2024 um 00:12 schrieb Björn Schäpers:
> >>> Am 30.11.2023 um 20:53 sc
On Thu, Jan 4, 2024 at 2:33 PM Björn Schäpers wrote:
>
> Am 03.01.2024 um 00:12 schrieb Björn Schäpers:
> > Am 30.11.2023 um 20:53 schrieb Ian Lance Taylor:
> >> On Fri, Jan 20, 2023 at 2:55 AM Björn Schäpers wrote:
> >>>
> >>> From: Björn S
This patch to the Go frontend stops passing the iota value to the
lowering pass. It is no longer used. The iota value is now handled
in the determine-types pass. Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
896148947b9ff4845c8bc334f8eff30f91ff3c9a
diff -
On Mon, Dec 18, 2023 at 5:32 PM Ian Lance Taylor wrote:
>
> This Go frontend patch moves the lowering pass after the type
> determination and the type checking passes. This lets us simplify
> some of the code that determines the type of an expression, which
> previously had to
This Go frontend patch moves the lowering pass after the type
determination and the type checking passes. This lets us simplify
some of the code that determines the type of an expression, which
previously had to work correctly both before and after type
determination.
I'm doing this to help with
On Tue, Dec 5, 2023 at 2:06 PM Jakub Jelinek wrote:
>
> Ok for trunk (both gcc and binutils)?
>
> 2023-12-05 Jakub Jelinek
>
> * configure.ac (HAVE_X86_SHA1_HW_SUPPORT): Verify __get_cpuid and
> __get_cpuid_count are not implicitly declared.
> * configure: Regenerated.
On Thu, Nov 30, 2023 at 11:58 AM Ian Lance Taylor wrote:
>
> On Thu, Nov 30, 2023 at 11:56 AM Iain Sandoe wrote:
> >
> > > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote:
> > >
> > > On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote:
> > &g
On Thu, Nov 30, 2023 at 11:46 AM Ian Lance Taylor wrote:
>
> On Thu, Nov 30, 2023 at 1:30 AM Rainer Orth
> wrote:
> >
> > the gcc-autoregen bot correctly complained that the libgo and libstdc++
> > configure scripts hadn't been regenerated. I'd have commit
On Thu, Nov 30, 2023 at 11:56 AM Iain Sandoe wrote:
>
> > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote:
> >
> > On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote:
> >>
> >> Thanks a lot Alexandre for the review!
> >
> > This patch chang
On Fri, Jan 20, 2023 at 2:55 AM Björn Schäpers wrote:
>
> From: Björn Schäpers
>
> Fixes https://github.com/ianlancetaylor/libbacktrace/issues/53, except
> that libraries loaded after the backtrace_initialize are not handled.
> But as far as I can see that's the same for elf.
Thanks, but I don't
On Thu, Nov 30, 2023 at 1:30 AM Rainer Orth
wrote:
>
> the gcc-autoregen bot correctly complained that the libgo and libstdc++
> configure scripts hadn't been regenerated. I'd have commited the
> following as obvious (just whitespace change), but since libgo is
> imported from upstream, I'm unce
On Sun, Oct 22, 2023 at 2:18 PM FX Coudert wrote:
>
> Thanks a lot Alexandre for the review!
This patch changed the files lingo/configure.ac and libgo/configure.
Those files live in an upstream repository and should be changed there
and then merged into the GCC repo, as described in libgo/README.
On Mon, Nov 20, 2023 at 11:58 AM Björn Schäpers wrote:
>
> An updated version, using neither A or W, but just the macro.
Thanks. Committed as follows.
Ian
1017495bc91d40570f58c37e88ca013164782129
diff --git a/libbacktrace/pecoff.c b/libbacktrace/pecoff.c
index 56af4828e27..f976a963bf3 100644
--
On Mon, Nov 20, 2023 at 11:57 AM Björn Schäpers wrote:
>
> this is what I'm using with GCC 12 and 13 on my windows machines, rebased onto
> the current HEAD.
Thanks. Committed as follows.
Ian
* fileline.c: Include if available.
(windows_get_executable_path): New static
The libbacktrace sources, as used by libstdc++-v3, fail to correctly
determine whether the system supports dl_iterate_phdr. The issue is
that the libbacktrace configure assumes that _GNU_SOURCE is defined
during compilation, but the libstdc++-v3 configure does not do that.
This configury failure i
On Tue, Oct 24, 2023, 11:03 AM Jeff Law wrote:
>
>
> On 10/24/23 09:26, Stefan Schulze Frielinghaus wrote:
> > Currently _BitInt is only supported on x86_64 which means that for other
> > targets all tests fail with e.g.
> >
> > gcc.misc-tests/godump-1.c:237:1: sorry, unimplemented: '_BitInt(32)'
This patch to the Go frontend just moves Selector_expression up in
file. This is a mechanical change to expressions.cc. This will make
Selector_expression visible to Builtin_call_expression for later work.
This produces a very large "git --diff", but "git diff --minimal" is
clear. Bootstrapped a
This patch to the Go frontend changes the Expression
{numeric,string,boolean}_constant_value methods to be non-const. This
does not affect anything immediately, but will be useful for later CLs
in this series.
The only real effect is to Builtin_call_expression::do_export, which
remains const and
This Go frontend patches passes the Gogo IR pointer to
Runtime::make_call. This is a boilerplate change that doesn't affect
compiler output. It's not currently used but will be used by later
CLs in this series. Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu. Committed to mainline.
Ia
This Go frontend patches adds an Expression::is_untyped method. This
method is not currently used by anything, but it will be used by later
changes in this series. Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu. Committed to mainline.
Ian
ac50e9b72bf9bb6d5b28096bb164fb050db6e290
diff
This libgo patch adds a missing type conversion. The gofrontend
incorrectly accepted code that was missing a type conversion. The
test case for this is bug518.go in https://go.dev/cl/536537. Future
CLs in this series will detect the type error. Bootstrapped and ran
Go testsuite on x86_64-pc-lin
This patch to the Go frontend removes the traverse_assignments
support. The last caller was removed in https://go.dev/cl/18261 in
2016. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu.
Committed to mainline.
Ian
a6e74b0b3316f3f0b2096d6a175c31bed58ae4ed
diff --git a/gcc/go/gofrontend/MER
This patch to the Go frontend removes the name_ field from the
Type_switch_statement class. It's not used for anything.
Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed
to mainline.
Ian
1a1fba1e25779247a4969789885ce80b7b4a2359
diff --git a/gcc/go/gofrontend/MERGE b/gcc/go/gofr
This patch to the G frontend passes a pointer to the Gogo IR to the
determine types pass and the type verification pass. This is a
straight refactoring that does not change the compiler behavior. This
is in preparation for future CLs that rearrange the pass ordering.
This introduces one new call
On Tue, Oct 3, 2023 at 12:04 PM Brendan Shanks wrote:
>
> + ret = posix_spawnattr_init (&attr);
> + if (ret) { *err = ret; *errmsg = "posix_spawnattr_init"; goto exit; }
Sorry, but let's keep the formatting used in the rest of the file.
if (ret != 0)
{
*err = ret;
*errmsg = "posix_sp
On Fri, Sep 29, 2023 at 12:18 PM Brendan Shanks wrote:
>
> + #define ERR_ON_FAILURE(ret, func) \
> +do { if (ret) { *err = ret; *errmsg = func; goto exit; } else {} } while
> (0)
Thanks, but please don't use a macro that changes control flow.
Ian
1 - 100 of 1029 matches
Mail list logo
