Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

Ping? thanks, Cong On Tue, Jul 8, 2014 at 8:23 PM, Xinliang David Li wrote: > Cong, can you ping this patch again? There does not seem to be > pending comments left. > > David > > On Tue, Dec 17, 2013 at 10:05 AM, Cong Hou wrote: >> Ping? >> >> >> th

Re: [PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

On Tue, Jun 24, 2014 at 4:05 AM, Richard Biener wrote: > On Sat, May 3, 2014 at 2:39 AM, Cong Hou wrote: >> On Mon, Apr 28, 2014 at 4:04 AM, Richard Biener wrote: >>> On Thu, 24 Apr 2014, Cong Hou wrote: >>> >>>> Given the following loop: >>>&

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

OK. Thank you very much for your review, Richard! thanks, Cong On Tue, Jun 24, 2014 at 4:19 AM, Richard Biener wrote: > On Tue, Dec 3, 2013 at 2:06 AM, Cong Hou wrote: >> Hi Richard >> >> Could you please take a look at this patch and see if it is ready for >> the

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

the trunk? If it is necessary I can re-post this patch in a new thread. Thank you! Cong On Tue, Dec 17, 2013 at 10:04 AM, Cong Hou wrote: > > Ping? > > > thanks, > Cong > > > On Mon, Dec 2, 2013 at 5:06 PM, Cong Hou wrote: > > Hi Richard > > > > C

Re: [PATCH] A new reload-rewrite pattern recognizer for GCC vectorizer.

Ping? thanks, Cong On Wed, Apr 30, 2014 at 1:28 PM, Cong Hou wrote: > Thank you for reminding me the omp possibility. Yes, in this case my > pattern is incorrect, because I assume all aliases will be resolved by > alias checks, which may not be true

Re: [PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

On Mon, Apr 28, 2014 at 4:04 AM, Richard Biener wrote: > On Thu, 24 Apr 2014, Cong Hou wrote: > >> Given the following loop: >> >> int a[N]; >> short b[N*2]; >> >> for (int i = 0; i < N; ++i) >> a[i] = b[i*2]; >> >> >&g

Re: [PATCH] A new reload-rewrite pattern recognizer for GCC vectorizer.

AM, Jakub Jelinek wrote: > On Thu, Apr 24, 2014 at 05:32:54PM -0700, Cong Hou wrote: >> In this patch a new reload-rewrite pattern detector is composed to >> handle the following pattern in the loop being vectorized: >> >>x = *p; >>... >>y = *p; >

[PATCH] A new reload-rewrite pattern recognizer for GCC vectorizer.

-1,3 +1,10 @@ +2014-04-23 Cong Hou + + * tree-vect-patterns.c (vect_recog_reload_rewrite_pattern): + New function. + (vect_vect_recog_func_ptrs): Add new pattern. + * tree-vectorizer.h (NUM_PATTERNS): Update the pattern count. + 2014-04-23 David Malcolm * i

[PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

gcc/ChangeLog b/gcc/ChangeLog index 117cdd0..e7143f1 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-04-23 Cong Hou + + * tree-vect-stmts.c (detect_pack_unpack_pattern): New function. + (vect_gen_widened_results_half): Call detect_pack_unpack_pattern. + 2014-04-23 Da

[PATCH] Fix PR60896

vect_internal_def. The patch is attached. Bootstrapped and tested on a x86_64 machine. OK for trunk? thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 117cdd0..0af5e16 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2014-04-23 Cong Hou + + PR tree-optimization

Re: Fixing PR60773

Thanks for the comments, and the attached file is the updated patch. thanks, Cong On Tue, Apr 8, 2014 at 12:28 AM, Rainer Orth wrote: > Cong Hou writes: > >> In the patch of >> PR60656(http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01668.html), the >> test case requi

Re: Fixing PR60773

On Tue, Apr 8, 2014 at 12:07 AM, Jakub Jelinek wrote: > On Mon, Apr 07, 2014 at 12:16:12PM -0700, Cong Hou wrote: >> --- a/gcc/testsuite/ChangeLog >> +++ b/gcc/testsuite/ChangeLog >> @@ -1,3 +1,11 @@ >> +2014-04-07 Cong Hou >> + >> + PR testsuite/60773 &

Fixing PR60773

arget vect_widen_mult_si_to_di_pattern to fix this issue. Bootstrapped and tested on x86_64. OK for trunk? thanks, Cong diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 414a745..ea860e7 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,11 @@ +2014-04-07 Con

Re: [PATCH] Fix PR60505

Ping? thanks, Cong On Wed, Mar 19, 2014 at 11:39 AM, Cong Hou wrote: > On Tue, Mar 18, 2014 at 4:43 AM, Richard Biener wrote: >> >> On Mon, 17 Mar 2014, Cong Hou wrote: >> >> > On Mon, Mar 17, 2014 at 6:44 AM, Richard Biener wrote: >> >

[PATCH] Fixing PR60656

index e1d8666..d7d5b82 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2014-03-28 Cong Hou + + PR tree-optimization/60656 + * tree-vect-stmts.c (supportable_widening_operation): + Fix a bug that elements in a vector with vect_used_by_reduction + property are incorrectly

Re: [PATCH] Fix PR60505

On Tue, Mar 18, 2014 at 4:43 AM, Richard Biener wrote: > > On Mon, 17 Mar 2014, Cong Hou wrote: > > > On Mon, Mar 17, 2014 at 6:44 AM, Richard Biener wrote: > > > On Fri, 14 Mar 2014, Cong Hou wrote: > > > > > >> On Fri, Mar 14, 2014 at 12:58 AM, R

Re: [PATCH] Fix PR60505

On Mon, Mar 17, 2014 at 6:44 AM, Richard Biener wrote: > On Fri, 14 Mar 2014, Cong Hou wrote: > >> On Fri, Mar 14, 2014 at 12:58 AM, Richard Biener wrote: >> > On Fri, 14 Mar 2014, Jakub Jelinek wrote: >> > >> >> On Fri, Mar 14, 2014 at 08:52:07AM +0100

Re: [PATCH] Fix PR60505

On Fri, Mar 14, 2014 at 12:58 AM, Richard Biener wrote: > On Fri, 14 Mar 2014, Jakub Jelinek wrote: > >> On Fri, Mar 14, 2014 at 08:52:07AM +0100, Richard Biener wrote: >> > > Consider this fact and if there are alias checks, we can safely remove >> > > the epilogue if the maximum trip count of th

Re: [PATCH] Fix PR60505

On Thu, Mar 13, 2014 at 2:27 AM, Richard Biener wrote: > On Wed, 12 Mar 2014, Cong Hou wrote: > >> Thank you for pointing it out. I didn't realized that alias analysis >> has influences on this issue. >> >> The current problem is that the epilogue may be unneces

Re: [PATCH] Fix PR60505

akub Jelinek wrote: > On Tue, Mar 11, 2014 at 04:16:13PM -0700, Cong Hou wrote: >> This patch is fixing PR60505 in which the vectorizer may produce >> unnecessary epilogues. >> >> Bootstrapped and tested on a x86_64 machine. >> >> OK for trunk? > > That look

[PATCH] Fix PR60505

@@ +2014-03-11 Cong Hou + + PR tree-optimization/60505 + * tree-vect-loop.c (vect_analyze_loop_2): Check the maximum number + of iterations of the loop and see if we should build the epilogue. + 2014-03-10 Jakub Jelinek PR ipa/60457 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog

[GOOGLE] Prevent x_flag_complex_method to be set to 2 for C++.

With this patch x_flag_complex_method won't be set to 2 for C++ so that multiply/divide between std::complex objects won't be replaced by expensive builtin function calls. Bootstrapped and passed regression test. OK for Google branch? thanks, Cong Index: gcc/c-family/c-opts.c ===

[GOOGLE] Emit a single unaligned load/store instruction for i386 m_GENERIC

This small patch lets GCC emit a single unaligned load/store instruction for m_GENERIC i386 CPUs. Bootstrapped and passed regression test. OK for Google branch? thanks, Cong Index: gcc/config/i386/i386.c === --- gcc/config/i386/i

Re: [PATCH] Fixing PR60000: A bug in the vectorizer.

uld > just move them at the end of if (is_store) and clear pattern_def_seq there > before the continue. Add gcc_assert (!transform_pattern_stmt); too? I agree. I have updated the patch accordingly. Bootstrapped and tested on x86_64. OK for the trunk? thanks, Cong diff --git a/gcc/ChangeLog

Re: [PATCH] Fixing PR60000: A bug in the vectorizer.

Wrong format. Send it again. On Thu, Jan 30, 2014 at 4:57 PM, Cong Hou wrote: > > Hi > > PR6 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=6) is caused by GCC > vectorizer. The bug appears when handling vectorization patterns. When a > pattern statement has additio

Re: [PATCH] Fixing PR59006 and PR58921 by delaying loop invariant hoisting in vectorizer.

I noticed that LIM could not hoist vector invariant, and that is why my first implementation tries to hoist them all. In addition, there are two disadvantages of hoisting invariant load + lim method: First, for some instructions the scalar version is faster than the vector version, and in this ca

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

Ping? thanks, Cong On Mon, Dec 2, 2013 at 5:02 PM, Cong Hou wrote: > Any comment on this patch? > > > thanks, > Cong > > > On Fri, Nov 22, 2013 at 11:40 AM, Cong Hou wrote: >> On Fri, Nov 22, 2013 at 3:57 AM, Marc Glisse wrote: >>> On Thu, 21 Nov 201

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Ping? thanks, Cong On Mon, Dec 2, 2013 at 5:06 PM, Cong Hou wrote: > Hi Richard > > Could you please take a look at this patch and see if it is ready for > the trunk? The patch is pasted as a text file here again. > > Thank you very much! > > > Cong > > &

Re: [PATCH] Enhancing the widen-mult pattern in vectorization.

pe T2. This strategy makes the patch more clean. Bootstrapped and tested on an x86-64 machine. thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f298c0b..12990b2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2013-12-02 Cong Hou + + * tree-vect-patte

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

Hi Richard You mentioned that Micha has a patch pending that enables of zero-step stores. What is the status of this patch? I could not find it through searching "Micha". Thank you! Cong On Wed, Oct 16, 2013 at 2:02 AM, Richard Biener wrote: > On Tue, 15 Oct 2013, Cong Hou wrot

[PATCH] Enhancing the widen-mult pattern in vectorization.

thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f298c0b..44ed204 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,12 @@ +2013-12-02 Cong Hou + + * tree-vect-patterns.c (vect_recog_widen_mult_pattern): Enhance + the widen-mult pattern by handling two operands with diffe

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Hi Richard Could you please take a look at this patch and see if it is ready for the trunk? The patch is pasted as a text file here again. Thank you very much! Cong On Mon, Nov 11, 2013 at 11:25 AM, Cong Hou wrote: > Hi James > > Sorry for the late reply. > > > On Fri, N

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

Any comment on this patch? thanks, Cong On Fri, Nov 22, 2013 at 11:40 AM, Cong Hou wrote: > On Fri, Nov 22, 2013 at 3:57 AM, Marc Glisse wrote: >> On Thu, 21 Nov 2013, Cong Hou wrote: >> >>> On Thu, Nov 21, 2013 at 4:39 PM, Marc Glisse wrote: >>>> >

Re: [PATCH] Fixing PR59006 and PR58921 by delaying loop invariant hoisting in vectorizer.

On Wed, Nov 27, 2013 at 1:53 AM, Richard Biener wrote: > On Fri, 22 Nov 2013, Cong Hou wrote: > >> Hi >> >> Currently in GCC vectorization, some loop invariant may be detected >> after aliasing checks, which can be hoisted outside of the loop. The >>

[PATCH] Fixing PR59006 and PR58921 by delaying loop invariant hoisting in vectorizer.

on an x86-64 machine. thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 2c0554b..0614bab 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,18 @@ +2013-11-22 Cong Hou + + PR tree-optimization/58921 + PR tree-optimization/59006 + * tree-vectorizer.h (struct _stmt_vec_info)

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

On Fri, Nov 22, 2013 at 3:57 AM, Marc Glisse wrote: > On Thu, 21 Nov 2013, Cong Hou wrote: > >> On Thu, Nov 21, 2013 at 4:39 PM, Marc Glisse wrote: >>> >>> On Thu, 21 Nov 2013, Cong Hou wrote: >>> >>>> While I added the new define_insn_and_sp

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

On Fri, Nov 22, 2013 at 1:32 AM, Uros Bizjak wrote: > Hello! > >> In consequence, the ix86_expand_multi_arg_builtin() function tries to >> check two args but based on the define_expand of xop_vmfrcz2, >> the content of insn_data[CODE_FOR_xop_vmfrczv4sf2].operand[2] may be >> incorrect (because it

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

On Thu, Nov 21, 2013 at 4:39 PM, Marc Glisse wrote: > On Thu, 21 Nov 2013, Cong Hou wrote: > >> While I added the new define_insn_and_split for vec_merge, a bug is >> exposed: in config/i386/sse.md, [ define_expand "xop_vmfrcz2" ] >> only takes one input, but t

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Ping... thanks, Cong On Fri, Nov 15, 2013 at 9:52 AM, Cong Hou wrote: > Any more comments? > > > > thanks, > Cong > > > On Wed, Nov 13, 2013 at 6:06 PM, Cong Hou wrote: >> Ping? >> >> >> thanks, >> Cong >> >> >> On

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

On Tue, Nov 19, 2013 at 1:45 AM, Richard Biener wrote: > > On Mon, 18 Nov 2013, Cong Hou wrote: > > > I tried your method and it works well for doubles. But for float, > > there is an issue. For the following gimple code: > > > >c1 = a - b; > >c2 =

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

On Mon, Nov 18, 2013 at 12:27 PM, Uros Bizjak wrote: > On Mon, Nov 18, 2013 at 9:15 PM, Cong Hou wrote: > >>>> This patch adds the support to two non-isomorphic operations addsub >>>> and subadd for SLP vectorizer. More non-isomorphic operations can be >>&

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

On Fri, Nov 15, 2013 at 10:18 AM, Richard Earnshaw wrote: > On 15/11/13 02:06, Cong Hou wrote: >> Hi >> >> This patch adds the support to two non-isomorphic operations addsub >> and subadd for SLP vectorizer. More non-isomorphic operations can be >> added

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

On Fri, Nov 15, 2013 at 1:20 AM, Uros Bizjak wrote: > Hello! > >> This patch adds the support to two non-isomorphic operations addsub >> and subadd for SLP vectorizer. More non-isomorphic operations can be >> added later, but the limitation is that operations on even/odd >> elements should still b

Re: [PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

ss, we could not use this method for float values. What do you think? thanks, Cong On Fri, Nov 15, 2013 at 12:53 AM, Richard Biener wrote: > On Thu, 14 Nov 2013, Cong Hou wrote: > >> Hi >> >> This patch adds the support to two non-isomorphic operations addsub >

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Any more comments? thanks, Cong On Wed, Nov 13, 2013 at 6:06 PM, Cong Hou wrote: > Ping? > > > thanks, > Cong > > > On Mon, Nov 11, 2013 at 11:25 AM, Cong Hou wrote: >> Hi James >> >> Sorry for the late reply. >> >> >> On Fri, Nov

[PATCH] Support addsub/subadd as non-isomorphic operations for SLP vectorizer.

/ChangeLog b/gcc/ChangeLog index 2c0554b..656d5fb 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,31 @@ +2013-11-14 Cong Hou + + * tree-vect-slp.c (vect_create_new_slp_node): Initialize + SLP_TREE_OP_CODE. + (slp_supported_non_isomorphic_op): New function. Check if the + non-isomorphic

Re: [PATCH] Do not set flag_complex_method to 2 for C++ by default.

d will think GCC performs >> poorly. > > > Correctness over speed is better. I am sorry GCC is the only one > which gets it correct here. If people don't like there is a flag to > disable it. > > Thanks, > Andrew Pinski > >> >> thanks, >> >>

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Ping? thanks, Cong On Mon, Nov 11, 2013 at 11:25 AM, Cong Hou wrote: > Hi James > > Sorry for the late reply. > > > On Fri, Nov 8, 2013 at 2:55 AM, James Greenhalgh > wrote: >>> On Tue, Nov 5, 2013 at 9:58 AM, Cong Hou wrote: >>> > Thank you for y

[PATCH] Do not set flag_complex_method to 2 for C++ by default.

g_complex_method = 2; } /* Common initialization before calling option handlers. */ Index: gcc/c-family/ChangeLog === --- gcc/c-family/ChangeLog (revision 204712) +++ gcc/c-family/ChangeLog (working copy) @@ -1,3 +1,8 @@ +2013-11-13 Cong

[PATCH] [Vectorization] Fixing a bug in alias checks merger.

gcc/ChangeLog index 2c0554b..5faa5ca 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,14 @@ +2013-11-12 Cong Hou + + * tree-vectorizer.h (struct dr_with_seg_len): Remove the base + address field as it can be obtained from dr. Rename the struct. + * tree-vect-data-ref

Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c

Got it! thanks, Cong On Tue, Nov 12, 2013 at 10:05 AM, Jakub Jelinek wrote: > On Tue, Nov 12, 2013 at 10:04:15AM -0800, Cong Hou wrote: >> Thank you for pointing it out. The updated patch is pasted below. I >> will pay attention to it in the future. > > Ok, thanks. &

Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c

+1,7 @@ +2013-11-12 Cong Hou + + * gcc.dg/vect/pr58508.c: Remove dg-options as vect_int is indicated. + 2013-10-29 Cong Hou * gcc.dg/vect/pr58508.c: Update. diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c b/gcc/testsuite/gcc.dg/vect/pr58508.c index fff7a04..c4921bb 100644

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Hi James Sorry for the late reply. On Fri, Nov 8, 2013 at 2:55 AM, James Greenhalgh wrote: >> On Tue, Nov 5, 2013 at 9:58 AM, Cong Hou wrote: >> > Thank you for your detailed explanation. >> > >> > Once GCC detects a reduction operation, it will automaticall

Re: [PATCH] Bug fix for PR59050

Thank you for your advice! I will follow this instruction in future. thanks, Cong On Mon, Nov 11, 2013 at 1:32 AM, Richard Biener wrote: > On Fri, 8 Nov 2013, Cong Hou wrote: > >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59050 >> >> This is my bad. I forget to c

Re: [PATCH] Bug fix for PR59050

Hi Jeff I have committed the fix. Please update your repo. Thank you! Cong On Mon, Nov 11, 2013 at 10:32 AM, Jeff Law wrote: > On 11/11/13 02:32, Richard Biener wrote: >> >> On Fri, 8 Nov 2013, Cong Hou wrote: >> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?i

Re: [PATCH] Bug fix for PR59050

Yes, I think so. The bug is that the arguments of tree_int_cst_compare() may not be constant integers. This patch should take care of it. thanks, Cong On Fri, Nov 8, 2013 at 12:06 PM, H.J. Lu wrote: > On Fri, Nov 8, 2013 at 10:34 AM, Cong Hou wrote: >> http://gcc.gnu.org

Re: [PATCH] Reducing number of alias checks in vectorization.

Thank you for the report. I have submitted a bug fix patch waiting to be reviewed. thanks, Cong On Fri, Nov 8, 2013 at 5:26 AM, Dominique Dhumieres wrote: > According to http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00197.html > revision 204538 is breaking several tests. On x86_64-apple-dar

[PATCH] Bug fix for PR59050

/ChangeLog @@ -1,3 +1,8 @@ +2013-11-08 Cong Hou + + PR tree-optimization/59050 + * tree-vect-data-refs.c (comp_dr_addr_with_seg_len_pair): Bug fix. + 2013-11-07 Cong Hou * tree-vect-loop-manip.c (vect_create_cond_for_alias_checks): diff --git a/gcc/tree-vect-data-refs.c b/gcc

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

Now is this patch OK for the trunk? Thank you! thanks, Cong On Tue, Nov 5, 2013 at 9:58 AM, Cong Hou wrote: > Thank you for your detailed explanation. > > Once GCC detects a reduction operation, it will automatically > accumulate all elements in the vector after the loop. In

Re: [PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c

Ping. OK for the trunk? thanks, Cong On Fri, Nov 1, 2013 at 10:47 AM, Cong Hou wrote: > It seems that on some platforms the loops in > testsuite/gcc.dg/vect/pr58508.c may be unable to be vectorized. This > small patch added { dg-require-effective-target vect_int } to make > su

Re: [PATCH] Handling == or != comparisons that may affect range test optimization.

On Tue, Nov 5, 2013 at 12:23 PM, Jeff Law wrote: > On 10/31/13 18:03, Cong Hou wrote: >> >> (This patch is for the bug 58728: >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58728) >> >> As in the bug report, consider the following loop: >> >>

Re: [PATCH] Handling == or != comparisons that may affect range test optimization.

. thanks, Cong On Tue, Nov 5, 2013 at 12:53 PM, Jakub Jelinek wrote: > On Tue, Nov 05, 2013 at 01:23:00PM -0700, Jeff Law wrote: >> On 10/31/13 18:03, Cong Hou wrote: >> >(This patch is for the bug 58728: >> >http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58728) >> >

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

behavior should not be difficult to explain. If you have more questions or think that the documentation is still improper please let me know. Thank you very much! Cong On Tue, Nov 5, 2013 at 1:53 AM, James Greenhalgh wrote: > On Mon, Nov 04, 2013 at 06:30:55PM +0000, Cong Hou wrote: >> On

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

On Mon, Nov 4, 2013 at 2:06 AM, James Greenhalgh wrote: > On Fri, Nov 01, 2013 at 04:48:53PM +0000, Cong Hou wrote: >> diff --git a/gcc/doc/md.texi b/gcc/doc/md.texi >> index 2a5a2e1..8f5d39a 100644 >> --- a/gcc/doc/md.texi >> +++ b/gcc/doc/md.texi >> @@ -

[PATCH] Small fix: add { dg-require-effective-target vect_int } to testsuite/gcc.dg/vect/pr58508.c

index 9d0f4a5..3d9916d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2013-10-29 Cong Hou + + * gcc.dg/vect/pr58508.c: Update. + 2013-10-15 Cong Hou * gcc.dg/vect/pr58508.c: New test. diff --git a/gcc/testsuite/gcc.dg/vect/pr58508.c b/gcc

[PATCH] Handling == or != comparisons that may affect range test optimization.

and make check both get passed. Any comment? thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8a38316..9247222 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2013-10-31 Cong Hou + + PR tree-optimization/58728 + * tree-ssa-reassoc.c (suitable_cond_bb): Consider

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

This update makes it more safe. You showed me how to write better expand code. Thank you for the improvement! thanks, Cong On Thu, Oct 31, 2013 at 11:43 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 9:02 PM, Cong Hou wrote: >> I have run check_GNU_style.sh on my patch. >>

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

will add the documentation for the new operation SAD_EXPR. I use sad by just following udot_prod as those two operations are quite similar: OPTAB_D (udot_prod_optab, "udot_prod$I$a") thanks, Cong > > regards > Ramana > > > > > > On Tue, Oct 29, 2013 at 10:23

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

On Wed, Oct 30, 2013 at 4:27 AM, Richard Biener wrote: > On Tue, 29 Oct 2013, Cong Hou wrote: > >> Hi >> >> SAD (Sum of Absolute Differences) is a common and important algorithm >> in image processing and other areas. SSE2 even introduced a new >> instruct

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

I have run check_GNU_style.sh on my patch. The patch is submitted. Thank you for your comments and help on this patch! thanks, Cong On Wed, Oct 30, 2013 at 11:13 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 7:01 PM, Cong Hou wrote: > >>>> I found my problem: I put

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

Also, as the current expand for abs() on 8/16bit integer is not used at all, should I comment them temporarily now? Later I can uncomment them once I finished the pattern recognizer. thanks, Cong On Wed, Oct 30, 2013 at 10:22 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 6:01 PM, Cong

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Wed, Oct 30, 2013 at 10:22 AM, Uros Bizjak wrote: > On Wed, Oct 30, 2013 at 6:01 PM, Cong Hou wrote: >> I found my problem: I put DONE outside of if not inside. You are >> right. I have updated my patch. > > OK, great that we put things in order ;) > > Does this p

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

Forget to attach the patch file. thanks, Cong On Wed, Oct 30, 2013 at 10:01 AM, Cong Hou wrote: > I found my problem: I put DONE outside of if not inside. You are > right. I have updated my patch. > > I appreciate your comment and test on it! > > > thanks, > Cong

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

-22 Cong Hou + + PR target/58762 + * config/i386/i386-protos.h (ix86_expand_sse2_abs): New function. + * config/i386/i386.c (ix86_expand_sse2_abs): New function. + * config/i386/sse.md: Add SSE2 support to abs (8/16/32-bit-int). + 2013-10-14 David Malcolm * dumpfile.h (gcc::dump_manager

[PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

g +++ b/gcc/ChangeLog @@ -1,3 +1,23 @@ +2013-10-29 Cong Hou + + * tree-vect-patterns.c (vect_recog_sad_pattern): New function for SAD + pattern recognition. + (type_conversion_p): PROMOTION is true if it's a type promotion + conversion, and false otherwise. Return true if the given expre

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Tue, Oct 29, 2013 at 10:34 AM, Uros Bizjak wrote: > On Tue, Oct 29, 2013 at 6:18 PM, Cong Hou wrote: > >>>> For the define_expand I added as below, the else body is there to >>>> avoid fall-through transformations to ABS operation in optabs.c. >>>>

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

attached a text file in which all tabs are there. The updated patch is pasted below (and also in the attached file). Thank you very much for your comment! Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8a38316..84c7ab5 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8a38316..84c7ab5 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2013-10-22 Cong Hou + + PR target/58762 + * config/i386/i386-protos.h (ix86_expand_sse2_abs): New function. + * config/i386/i386.c (ix86_expand_sse2_abs): N

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Wed, Oct 23, 2013 at 11:18 PM, Jakub Jelinek wrote: > On Wed, Oct 23, 2013 at 09:40:21PM -0700, Cong Hou wrote: >> On Wed, Oct 23, 2013 at 8:52 AM, Joseph S. Myers >> wrote: >> > On Tue, 22 Oct 2013, Cong Hou wrote: >> > >> >> For abs(char/short

Re: [PATCH] Fixing improper conversion from sin() to sinf() in optimization mode.

, 7 Oct 2013, Cong Hou wrote: > >> + if (type != newtype) >> +break; > > That comparison would wrongly treat as different cases where the types > differ only in one being a typedef, having qualifiers, etc. - or if in > future GCC implemented proposed TS 18661-3, cases w

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

, Cong On Wed, Oct 23, 2013 at 9:40 PM, Cong Hou wrote: > On Wed, Oct 23, 2013 at 8:52 AM, Joseph S. Myers > wrote: >> On Tue, 22 Oct 2013, Cong Hou wrote: >> >>> For abs(char/short), type conversions are needed as the current abs() >>> function/operation do

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Wed, Oct 23, 2013 at 8:52 AM, Joseph S. Myers wrote: > On Tue, 22 Oct 2013, Cong Hou wrote: > >> For abs(char/short), type conversions are needed as the current abs() >> function/operation does not accept argument of char/short type. >> Therefore when we want to get

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Wed, Oct 23, 2013 at 12:20 AM, Uros Bizjak wrote: > Hello! > >> Currently GCC could not vectorize abs() operation for integers on x86 >> with only SSE2 support. For int type, the reason is that the expand on >> abs() is not defined for vector type. This patch defines such an >> expand so that a

Re: [PATCH] Vectorizing abs(char/short/int) on x86.

On Tue, Oct 22, 2013 at 8:11 PM, wrote: > > > Sent from my iPad > >> On Oct 22, 2013, at 7:23 PM, Cong Hou wrote: >> >> This patch aims at PR58762. >> >> Currently GCC could not vectorize abs() operation for integers on x86 >> with only SSE2 supp

[PATCH] Vectorizing abs(char/short/int) on x86.

and analysis. thanks, Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8a38316..e0f33ee 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,13 @@ +2013-10-22 Cong Hou + + PR target/58762 + * convert.c (convert_to_integer): Convert (char) abs ((int) char_val) + into abs (char

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

Henderson shend...@gcc.gnu.org Matthew Hiller hil...@redhat.com Manfred Hollstein m...@suse.com +Cong Hou co...@google.com Falk Hueffner f...@debian.o

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

Jeff, thank you for installing this patch. Actually I already have the write privileges. I just came back from a trip. Thank you again! thanks, Cong On Fri, Oct 18, 2013 at 10:22 PM, Jeff Law wrote: > On 10/18/13 03:56, Richard Biener wrote: >> >> On Thu, 17 Oct 2013,

Re: [PATCH] Fixing improper conversion from sin() to sinf() in optimization mode.

Ping? thanks, Cong On Mon, Oct 7, 2013 at 10:15 AM, Cong Hou wrote: > You are right. I am not an expert on numerical analysis, but I tested > your case and it proves the number 4 conversion is not safe. > > Now we have four conversions which are safe once the precision >

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

branch and make the code more brief. I have updated the patch and also included the nested loop example into the test case. Thank you! Cong diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 8a38316..2637309 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2013-10-15 Cong Hou

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

On Wed, Oct 16, 2013 at 2:02 AM, Richard Biener wrote: > On Tue, 15 Oct 2013, Cong Hou wrote: > >> Thank you for your reminder, Jeff! I just noticed Richard's comment. I >> have modified the patch according to that. >> >> The new patch is attached. > > (po

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

Thank you for your reminder, Jeff! I just noticed Richard's comment. I have modified the patch according to that. The new patch is attached. thanks, Cong On Tue, Oct 15, 2013 at 12:33 PM, Jeff Law wrote: > On 10/14/13 17:31, Cong Hou wrote: >> >> Any comment on this patc

Re: [PATCH] Relax the requirement of reduction pattern in GCC vectorizer.

I have corrected the ChangeLog format, and committed this patch. Thank you! Cong On Tue, Oct 15, 2013 at 6:38 AM, Richard Biener wrote: > On Sat, Sep 28, 2013 at 3:28 AM, Cong Hou wrote: >> The current GCC vectorizer requires the following pattern as a simple >> reduct

Re: [PATCH] Relax the requirement of reduction pattern in GCC vectorizer.

Ping... thanks, Cong On Wed, Oct 2, 2013 at 11:18 AM, Cong Hou wrote: > Ping.. Any comment on this patch? > > > thanks, > Cong > > > On Sat, Sep 28, 2013 at 9:34 AM, Xinliang David Li wrote: >> You can also add a test case of this form: >> >> int f

Re: [PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

Any comment on this patch? thanks, Cong On Thu, Oct 3, 2013 at 3:59 PM, Cong Hou wrote: > During loop versioning in vectorization, the alias check guarantees > that any load of a data reference with zero-step is a loop invariant, > which can be hoisted outside of the loop. After hoi

Fwd: [PATCH] Reducing number of alias checks in vectorization.

Sorry for forgetting using plain-text mode. Resend it. -- Forwarded message -- From: Cong Hou Date: Mon, Oct 14, 2013 at 3:29 PM Subject: Re: [PATCH] Reducing number of alias checks in vectorization. To: Richard Biener , GCC Patches Cc: Jakub Jelinek I have made a new patch

Re: [PATCH] Fixing improper conversion from sin() to sinf() in optimization mode.

ChangeLog (revision 203250) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2013-10-07 Cong Hou + + * convert.c (convert_to_real): Forbid unsafe math function + conversions including sin/cos/log etc. Add precision check + for sqrt. + 2013-10-07 Bill Schmidt * config/rs6000/rs6000.c (altiv

Re: [PATCH] Fixing improper conversion from sin() to sinf() in optimization mode.

Ping... thanks, Cong On Fri, Sep 20, 2013 at 9:49 AM, Cong Hou wrote: > Any comment or more suggestions on this patch? > > > thanks, > Cong > > On Mon, Sep 9, 2013 at 7:28 PM, Cong Hou wrote: >> On Mon, Sep 9, 2013 at 6:26 PM, Xinliang David Li wrote: >>

[PATCH] Hoist loop invariant statements containing data refs with zero-step during loop-versioning in vectorization.

During loop versioning in vectorization, the alias check guarantees that any load of a data reference with zero-step is a loop invariant, which can be hoisted outside of the loop. After hoisting the load statement, there may exist more loop invariant statements. This patch tries to find all those s

Re: [PATCH] Reducing number of alias checks in vectorization.

anks, Cong On Thu, Oct 3, 2013 at 10:57 AM, Cong Hou wrote: > I noticed that there is a "struct dataref_aux" defined in > tree-vectorizer.h which is specific to the vectorizer pass and is > stored in (void*)aux in "struct data_reference". Can we add one more > field

Re: [PATCH] Reducing number of alias checks in vectorization.

On Thu, Oct 3, 2013 at 2:06 PM, Joseph S. Myers wrote: > On Tue, 1 Oct 2013, Cong Hou wrote: > >> +#include >> +#include >> +#include >> + >> #include "config.h" > > Whatever the other issues about including these headers at all, any syste

  1   2   >