Re: [PATCH v4 0/1] Add warnings of potentially-uninitialized padding bits

2025-06-12 Thread Christopher Bazley
Ping On 21/05/2025 16:13, Christopher Bazley wrote: Commit 0547dbb725b reduced the number of cases in which union padding bits are zeroed when the relevant language standard does not strictly require it, unless gcc was invoked with -fzero-init-padding-bits=unions or -fzero-init-padding-bits=all

Re: [PATCH v4 0/1] Add warnings of potentially-uninitialized padding bits

2025-05-29 Thread Christopher Bazley
Dear GCC Developers, Please could somebody review this patch? I previously received comments from Joseph and Jakub, which I believe I have addressed. Thanks, Chris On 21/05/2025 16:13, Christopher Bazley wrote: Commit 0547dbb725b reduced the number of cases in which union padding bits are

Re: [PATCH v2 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-23 Thread Christopher Bazley
Hi Jakub, On 21/05/2025 14:46, Christopher Bazley wrote: Hi Jakub, Thanks for your review. On 21/05/2025 13:51, Jakub Jelinek wrote: On Wed, May 21, 2025 at 01:42:01PM +0100, Christopher Bazley wrote: On 21/05/2025 12:26, Christopher Bazley wrote: Hi Joseph, Thanks for reviewing my patch

[PATCH v4 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-21 Thread Christopher Bazley
Commit 0547dbb725b reduced the number of cases in which union padding bits are zeroed when the relevant language standard does not strictly require it, unless gcc was invoked with -fzero-init-padding-bits=unions or -fzero-init-padding-bits=all in order to explicitly request

[PATCH v4 0/1] Add warnings of potentially-uninitialized padding bits

2025-05-21 Thread Christopher Bazley
t; to the diagnostic message. Link to v1: https://inbox.sourceware.org/gcc-patches/20250520104940.3546-1-chris.baz...@arm.com/ Link to v2: https://inbox.sourceware.org/gcc-patches/20250520144524.5968-1-chris.baz...@arm.com/ Link to v3: https://inbox.sourceware.org/gcc-patches/20250521124745

Re: [PATCH v2 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-21 Thread Christopher Bazley
Hi Jakub, Thanks for your review. On 21/05/2025 13:51, Jakub Jelinek wrote: On Wed, May 21, 2025 at 01:42:01PM +0100, Christopher Bazley wrote: On 21/05/2025 12:26, Christopher Bazley wrote: Hi Joseph, Thanks for reviewing my patch. On 20/05/2025 18:02, Joseph Myers wrote: On Tue, 20 May

[PATCH v3 0/1] Add warnings of potentially-uninitialized padding bits

2025-05-21 Thread Christopher Bazley
/ Link to v2: https://inbox.sourceware.org/gcc-patches/20250520144524.5968-2-chris.baz...@arm.com/ Christopher Bazley (1): Add warnings of potentially-uninitialized padding bits gcc/common.opt| 4 + gcc/doc/invoke.texi | 85 +++

[PATCH v3 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-21 Thread Christopher Bazley
Commit 0547dbb725b reduced the number of cases in which union padding bits are zeroed when the relevant language standard does not strictly require it, unless gcc was invoked with -fzero-init-padding-bits=unions or -fzero-init-padding-bits=all in order to explicitly request

Re: [PATCH v2 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-21 Thread Christopher Bazley
On 21/05/2025 12:26, Christopher Bazley wrote: Hi Joseph, Thanks for reviewing my patch. On 20/05/2025 18:02, Joseph Myers wrote: On Tue, 20 May 2025, Christopher Bazley wrote: +    if (!cleared) +  { +    if (complete_p.padded_non_union +    && warn_zero_init_padd

Re: [PATCH v2 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-21 Thread Christopher Bazley
Hi Joseph, Thanks for reviewing my patch. On 20/05/2025 18:02, Joseph Myers wrote: On Tue, 20 May 2025, Christopher Bazley wrote: + if (!cleared) + { + if (complete_p.padded_non_union + && warn_zero_init_padding_bits >= ZERO_INIT_PADDI

[PATCH v2 0/1] Add warnings of potentially-uninitialized padding bits

2025-05-20 Thread Christopher Bazley
it is a470433732e77ae29a717cf79049ceeea3cbe979 Changes in v2: - Add missing changelog entry. Link to v1: https://inbox.sourceware.org/gcc-patches/20250520104940.3546-1-chris.baz...@arm.com/ Christopher Bazley (1): Add warnings of potentially-uninitialized padding bits gcc/common.opt

[PATCH v2 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-20 Thread Christopher Bazley
Commit 0547dbb725b reduced the number of cases in which union padding bits are zeroed when the relevant language standard does not strictly require it, unless gcc was invoked with -fzero-init-padding-bits=unions or -fzero-init-padding-bits=all in order to explicitly request

[PATCH 0/1] Add warnings of potentially-uninitialized padding bits

2025-05-20 Thread Christopher Bazley
Base commit is a470433732e77ae29a717cf79049ceeea3cbe979 Christopher Bazley (1): Add warnings of potentially-uninitialized padding bits gcc/common.opt| 4 + gcc/doc/invoke.texi | 85 ++- gcc/expr.cc

[PATCH 1/1] Add warnings of potentially-uninitialized padding bits

2025-05-20 Thread Christopher Bazley
Commit 0547dbb725b reduced the number of cases in which union padding bits are zeroed when the relevant language standard does not strictly require it, unless gcc was invoked with -fzero-init-padding-bits=unions or -fzero-init-padding-bits=all in order to explicitly request

[PATCH v2 1/1] Fix BZ 119317: named loops (C2y) with debug info

2025-05-01 Thread Christopher Bazley
Named loops (C2y) could not previously be compiled with -O1 and -ggdb2 or higher because the label preceding a loop (or switch) could not be found when using such command lines. This could be observed by compiling gcc/gcc/testsuite/gcc.dg/c2y-named-loops-1.c with the provoking command line (or any

[PATCH v2 0/1] Fix BZ 119317: named loops (C2y) with debug info

2025-05-01 Thread Christopher Bazley
., FAIL: gcc.dg/c2y-named-loops-8.c (test for excess errors) Changes in v2: - Fixed a formatting issue. - Added a test. Link to v1: https://inbox.sourceware.org/gcc-patches/20250429124531.103475-1-chris.baz...@arm.com/ Christopher Bazley (1): Fix BZ 119317: named loops (C2y) with debug info gcc

[PATCH 1/1] Fix BZ 119317: named loops (C2y) with debug info

2025-04-29 Thread Christopher Bazley
Named loops (C2y) could not previously be compiled with -O1 and -ggdb2 or higher because the label preceding a loop (or switch) could not be found when using such command lines. This could be observed by compiling gcc/gcc/testsuite/gcc.dg/c2y-named-loops-1.c with the provoking command line (or any

[PATCH 0/1] Fix BZ 119317: named loops (C2y) with debug info

2025-04-29 Thread Christopher Bazley
operand ‘main’ does not refer to a named loop 5 | continue main; | ^~~~ test.c:3:3: warning: label ‘main’ defined but not used \[-Wunused-label\] 3 | main: | ^~~~ gcc/xgcc -B gcc -std=gnu2y -O1 -ggdb2 -Wall -c \ test.c -o test.o Christopher Bazley (1