On 21/05/2025 12:26, Christopher Bazley wrote:
Hi Joseph,
Thanks for reviewing my patch.
On 20/05/2025 18:02, Joseph Myers wrote:
On Tue, 20 May 2025, Christopher Bazley wrote:
+ if (!cleared)
+ {
+ if (complete_p.padded_non_union
+ && warn_zero_init_padding_bits >= ZERO_INIT_PADDING_BITS_ALL)
+ {
+ warning (OPT_Wzero_init_padding_bits_,
+ "Padding bits might not be initialized to zero; "
+ "consider using %<-fzero-init-padding-bits=all%>");
+ }
+ else if (complete_p.padded_union
+ && warn_zero_init_padding_bits
+ >= ZERO_INIT_PADDING_BITS_UNIONS)
+ {
+ warning (OPT_Wzero_init_padding_bits_,
+ "Padding bits might not be initialized to zero; "
+ "consider using %<-fzero-init-padding-bits=unions%> "
+ "or %<-fzero-init-padding-bits=all%>");
Diagnostics should start with a lowercase letter.
I'll change it to "padding might not be initialized to zero..." OK?
("padding" seems to be more common than "padding bits" in existing
messages.)
Is there anything I need to do for initialization?
Sorry, I meant "internationalisation" (i.e. to support translation), not
"initialization"!
--
Christopher Bazley
Staff Software Engineer, GNU Tools Team.
Arm Ltd, 110 Fulbourn Road, Cambridge, CB1 9NJ, UK.
http://www.arm.com/
