Re: [PATCH RFC] c++: add -Wsfinae-incomplete

2025-06-13 Thread Jason Merrill
On 6/13/25 1:36 PM, Patrick Palka wrote: On Fri, 13 Jun 2025, Jason Merrill wrote: Tested x86_64-pc-linux-gnu, any comments? Bikeshedding? -- 8< -- We already error about a type definition causing a concept check to change value, but it would be useful to diagnose this for other SFINAE conte

Re: [PATCH 0/1] [RFC][AutoFDO] Propagate inline information to outline definitions if not inlined

2025-06-13 Thread Kugan Vivekanandarajah
Hi, > On 13 Jun 2025, at 7:21 pm, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > >> From: Dhruv Chawla > Hi, >> >> For reasons explained in the patch, this patch prevents the loss of profile >> information when inlining occurs in the profiled binary but n

Re: [PATCH] configury: replace autoconf obsolete macros [PR/103459]

2025-06-13 Thread Joseph Myers
On Fri, 13 Jun 2025, Pietro Monteiro wrote: > > Adding this \ at end of file looks suspect. > > > > OK with that ChangeLog entry fixed and the stray \ at end of file removed > > (assuming the same output files are still generated after that change). > > I applied the patch on top of trunk (), re

Re: [PATCH] configury: replace autoconf obsolete macros [PR/103459]

2025-06-13 Thread Pietro Monteiro
On Fri, Jun 13, 2025, at 2:02 PM, Joseph Myers wrote: > On Wed, 21 May 2025, Pietro Monteiro wrote: > >> lto-plugin/ChangeLog: >> >> * configure: Regenerate. >> * configure.ac: Replace AC_CANONICAL_SYSTEM with AC_CANONICAL_SYSTEM. > > That ChangeLog entry is clearly incorrect. Sorry. It

Re: [PATCH] c++: ICE with unexpanded pack in asm

2025-06-13 Thread Marek Polacek
On Wed, Jun 04, 2025 at 09:18:45PM +0800, yxj-github-437 wrote: > > This line seems wrongly indented, should be only two spaces more > > than the if line: > > > > if (check_for_bare_parameter_packs (expression)) > >expression = error_mark_node; > > > > > > The patch LGTM otherwise, thanks. >

[wwwdocs v2] Add C23 status table

2025-06-13 Thread Marek Polacek
On Thu, Jun 12, 2025 at 05:39:26PM +, Joseph Myers wrote: > On Wed, 11 Jun 2025, Marek Polacek wrote: > > > This patch adds the C23 Support in GCC table (compiler features only). > > > > While creating it, I've consulted Annex M.2, our own changes.html, > > Joseph's "ISO C23 support in the GN

[PATCH v5 2/3][C FE, __bdos] Convert a pointer reference with counted_by attribute to .ACCESS_WITH_SIZE and use it in builtinin-object-size.

2025-06-13 Thread Qing Zhao
gcc/c/ChangeLog: * c-typeck.cc (build_counted_by_ref): Handle pointers with counted_by. (build_access_with_size_for_counted_by): Likewise. gcc/ChangeLog: * tree-object-size.cc (access_with_size_object_size): Handle pointers with counted_by. (collect_object

[PATCH v5 3/3][C sanitizer] Use the counted_by attribute of pointers in array bound checker.

2025-06-13 Thread Qing Zhao
Current array bound checker only instruments ARRAY_REF, and the INDEX information is the 2nd operand of the ARRAY_REF. When extending the array bound checker to pointer references with counted_by attributes, the hardest part is to get the INDEX of the corresponding array ref from the offset comput

[PATCH v5 0/3] extend "counted_by" attribute to pointer fields of structures

2025-06-13 Thread Qing Zhao
Hi, This is the 5th version of the patch set to extend "counted_by" attribute to pointer fields of structures. compared to the 4rd version: https://gcc.gnu.org/pipermail/gcc-patches/2025-May/683538.html https://gcc.gnu.org/pipermail/gcc-patches/2025-May/683539.html https://gcc.gnu.org/pipermail

[PATCH v5 1/3][C FE] Extend "counted_by" attribute to pointer fields of structures.

2025-06-13 Thread Qing Zhao
For example: struct PP { size_t count2; char other1; char *array2 __attribute__ ((counted_by (count2))); int other2; } *pp; specifies that the "array2" is an array that is pointed by the pointer field, and its number of elements is given by the field "count2" in the same structure. gcc/c-

Re: [PATCH] libstdc++: add a workaround for format_kind> [PR120644]

2025-06-13 Thread Giuseppe D'Angelo
Hello, On 13/06/2025 15:02, Jonathan Wakely wrote: OK thanks Committed as r16-1501-gf6f4efdf397269. Thanks, -- Giuseppe D'Angelo smime.p7s Description: S/MIME Cryptographic Signature

Re: [PATCH] configury: replace autoconf obsolete macros [PR/103459]

2025-06-13 Thread Joseph Myers
On Wed, 21 May 2025, Pietro Monteiro wrote: > lto-plugin/ChangeLog: > > * configure: Regenerate. > * configure.ac: Replace AC_CANONICAL_SYSTEM with AC_CANONICAL_SYSTEM. That ChangeLog entry is clearly incorrect. > diff --git a/config/asmcfi.m4 b/config/asmcfi.m4 > index a725aa11de4.

Re: [PATCH RFC] c++: add -Wsfinae-incomplete

2025-06-13 Thread Patrick Palka
On Fri, 13 Jun 2025, Jason Merrill wrote: > Tested x86_64-pc-linux-gnu, any comments? Bikeshedding? > > -- 8< -- > > We already error about a type definition causing a concept check to change > value, but it would be useful to diagnose this for other SFINAE contexts as > well; the memoization p

[PATCH RFC] c++: add -Wsfinae-incomplete

2025-06-13 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, any comments? Bikeshedding? -- 8< -- We already error about a type definition causing a concept check to change value, but it would be useful to diagnose this for other SFINAE contexts as well; the memoization problem also affects templates. So -Wsfinae-incomplete re

Re: [PATCH] [lra] force reg update after spilling to memory [PR120424]

2025-06-13 Thread Vladimir Makarov
On 6/6/25 3:21 AM, Alexandre Oliva wrote: On Jun 6, 2025, Alexandre Oliva wrote: Now, since lra_update_fp2sp_elimination checks that !elimination_fp2sp_occured_p, we *could* disable the fp2sp elimination, if it's selected, right away, so that it is not applied after we've disabled it, and t

Re: [PATCH 2/2] Fix non-std float suffices [PR92826]

2025-06-13 Thread Joseph Myers
On Fri, 13 Jun 2025, Gábor Németh wrote: > > > A new option is added to warn if floating point literals have non-standard > > > suffices (currently Q and W) in pedantic mode. The option is ON by > > > default. > > > > I don't think we should turn this off when building GCC itself (as opposed > >

Re: [PATCH 2/2] Fix non-std float suffices [PR92826]

2025-06-13 Thread Gábor Németh
A new option is added to warn if floating point literals have non-standard suffices (currently Q and W) in pedantic mode. The option is ON by default. I don't think we should turn this off when building GCC itself (as opposed to target libraries). Host floating-point should only be used for lim

Re: [PATCH] AArch64 SIMD: convert mvn+shrn into mvni+subhn

2025-06-13 Thread Remi Machet
On 6/13/25 11:22, Alex Coplan wrote: > External email: Use caution opening links or attachments > > > Hi Remi, > > On 12/06/2025 17:02, Richard Sandiford wrote: >> Remi Machet writes: >>> Add an optimization to aarch64 SIMD converting mvn+shrn into mvni+subhn >>> which >>> allows for better o

Re: [PATCH] AArch64 SIMD: convert mvn+shrn into mvni+subhn

2025-06-13 Thread Richard Sandiford
Alex Coplan writes: > Hi Remi, > > On 12/06/2025 17:02, Richard Sandiford wrote: >> Remi Machet writes: >> > +  "TARGET_SIMD" >> > +  "#" >> > +  "&& true" >> > +  [(const_int 0)] >> > +{ >> > +  rtx tmp; >> > +  if (can_create_pseudo_p ()) >> > +    tmp = gen_reg_rtx (mode); >> > +  else >> > + 

Re: [PATCH] AArch64 SIMD: convert mvn+shrn into mvni+subhn

2025-06-13 Thread Alex Coplan
Hi Remi, On 12/06/2025 17:02, Richard Sandiford wrote: > Remi Machet writes: > > Add an optimization to aarch64 SIMD converting mvn+shrn into mvni+subhn > > which > > allows for better optimization when the code is inside a loop by using a > > constant. It can be helpful for reviewers to show t

[PATCH] fixincludes: skip stdio_stdarg_h on modern darwin

2025-06-13 Thread FX Coudert
Hi, All macOS SDK since at least macOS 10.9, and until macOS 10.12 (included), feature these lines in : /* DO NOT REMOVE THIS COMMENT: fixincludes needs to see: * __gnuc_va_list and include */ The clear intent (and effect) was to bypass gcc’s stdio_stdarg_h fixinclude. However, since macOS 10

Re: [PATCH] c++, coroutines: Ensure that the resumer is marked as can_throw.

2025-06-13 Thread Jason Merrill
On 6/11/25 1:12 PM, Iain Sandoe wrote: On 11 Jun 2025, at 17:53, Jason Merrill wrote: On 6/9/25 3:54 PM, Iain Sandoe wrote: I was planning to apply this as obvious - but it is needed for the next patch to be posted - so noting here now. I discussed with one of the original coroutines paper

Re: [PATCH] aarch64: Fold NOT+PTEST to NOTS [PR118150]

2025-06-13 Thread Spencer Abson
On Fri, Jun 13, 2025 at 02:12:44PM +, Kyrylo Tkachov wrote: > Hi Spencer, > > Thanks for the patch. > > > On 13 Jun 2025, at 14:46, Spencer Abson wrote: > > > > Add the missing combiner patterns for folding NOT+PTEST to NOTS when > > they share the same GP. > > > > I guess GP here means “

[PATCH V1] RISC-V:Add the MIPS P8700 conditional move extension instruction support.

2025-06-13 Thread Umesh Kalappa
Addressed the most of comments and tried to refactor the riscv_expand_conditional_move() to some extent. No regressions are found for "runtest --tool gcc --target_board='riscv-sim/-mabi=lp64d/-mtune=mips-p8700/-O2 ' riscv.exp" *config/riscv/riscv-cores.def(RISCV_CORE):Updated the suppor

Re: [PATCH] libstdc++: Optimize __make_comp_proj and __make_pred_proj for empty types

2025-06-13 Thread Patrick Palka
On Fri, 13 Jun 2025, Tomasz Kaminski wrote: > > > On Fri, Jun 13, 2025 at 3:54 PM Patrick Palka wrote: > On Fri, 13 Jun 2025, Tomasz Kaminski wrote: > > > > > > > On Thu, Jun 12, 2025 at 9:05 PM Patrick Palka > wrote: > >       On Thu, 12 Jun 2025, Patrick Palka

Re: [PATCH] libstdc++: Optimize __make_comp_proj and __make_pred_proj for empty types

2025-06-13 Thread Tomasz Kaminski
On Fri, Jun 13, 2025 at 4:46 PM Patrick Palka wrote: > On Fri, 13 Jun 2025, Tomasz Kaminski wrote: > > > > > > > On Fri, Jun 13, 2025 at 3:54 PM Patrick Palka wrote: > > On Fri, 13 Jun 2025, Tomasz Kaminski wrote: > > > > > > > > > > > On Thu, Jun 12, 2025 at 9:05 PM Patr

Re: [PATCH] libstdc++: Optimize __make_comp_proj and __make_pred_proj for empty types

2025-06-13 Thread Tomasz Kaminski
On Fri, Jun 13, 2025 at 3:54 PM Patrick Palka wrote: > On Fri, 13 Jun 2025, Tomasz Kaminski wrote: > > > > > > > On Thu, Jun 12, 2025 at 9:05 PM Patrick Palka wrote: > > On Thu, 12 Jun 2025, Patrick Palka wrote: > > > > > On Thu, 12 Jun 2025, Jonathan Wakely wrote: > > > > >

Re: [PATCH] libstdc++: Optimize __make_comp_proj and __make_pred_proj for empty types

2025-06-13 Thread Jonathan Wakely
On 13/06/25 09:54 -0400, Patrick Palka wrote: On Fri, 13 Jun 2025, Tomasz Kaminski wrote: On Thu, Jun 12, 2025 at 9:05 PM Patrick Palka wrote: On Thu, 12 Jun 2025, Patrick Palka wrote: > On Thu, 12 Jun 2025, Jonathan Wakely wrote: > > > > > > > On Thu, 12

Re: [PATCH] aarch64: Fold NOT+PTEST to NOTS [PR118150]

2025-06-13 Thread Kyrylo Tkachov
Hi Spencer, Thanks for the patch. > On 13 Jun 2025, at 14:46, Spencer Abson wrote: > > Add the missing combiner patterns for folding NOT+PTEST to NOTS when > they share the same GP. > I guess GP here means “governing predicate”? GP usually means “General Purpose (register)” in aarch64 so it’d

Re: [PATCH] libstdc++: Optimize __make_comp_proj and __make_pred_proj for empty types

2025-06-13 Thread Patrick Palka
On Fri, 13 Jun 2025, Tomasz Kaminski wrote: > > > On Thu, Jun 12, 2025 at 9:05 PM Patrick Palka wrote: > On Thu, 12 Jun 2025, Patrick Palka wrote: > > > On Thu, 12 Jun 2025, Jonathan Wakely wrote: > > > > > > > > > > > On Thu, 12 Jun 2025, 16:56 Patrick Palk

[PATCH v2] AArch64 SIMD: convert mvn+shrn into mvni+subhn

2025-06-13 Thread Remi Machet
Add an optimization to aarch64 SIMD converting mvn+shrn into mvni+subhn which allows for better optimization when the code is inside a loop by using a constant. Bootstrapped and regtested on aarch64-linux-gnu. Signed-off-by: Remi Machet gcc/ChangeLog: * config/aarch64/aarch64-simd.md

Re: [PATCH] libstdc++: Format %r, %x and %X using locale's time_put facet [PR120648]

2025-06-13 Thread Jonathan Wakely
On Fri, 13 Jun 2025 at 14:17, Tomasz Kamiński wrote: > > Similarly to issue reported for %c in PR117214, the format string for locale > specific time (%r, %X) and date (%x) representations may contain specifiers > not accepted by chrono-spec, leading to exception being thrown. This > happened for

Re: [PATCH v2] libstdc++: Fix std::uninitialized_value_construct for arrays [PR120397]

2025-06-13 Thread Jonathan Wakely
On Fri, 13 Jun 2025 at 10:38, Daniel Krügler wrote: > > Am Fr., 13. Juni 2025 um 11:33 Uhr schrieb Jonathan Wakely > : >> >> The std::uninitialized_{value,default}_construct{,_n} algorithms should >> be able to create arrays, but that currently fails because when an >> exception happens they clea

[PATCH] libstdc++: Format %r, %x and %X using locale's time_put facet [PR120648]

2025-06-13 Thread Tomasz Kamiński
Similarly to issue reported for %c in PR117214, the format string for locale specific time (%r, %X) and date (%x) representations may contain specifiers not accepted by chrono-spec, leading to exception being thrown. This happened for following conversion specifier and locale combinations: * %r, %

RE: [PATCH v2] x86: Update memcpy/memset inline strategies for -mtune=generic

2025-06-13 Thread Cui, Lili
> -Original Message- > From: Jan Hubicka > Sent: Monday, April 21, 2025 6:35 PM > To: H.J. Lu > Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao ; > ubiz...@gmail.com > Subject: Re: [PATCH v2] x86: Update memcpy/memset inline strategies for - > mtune=generic > > > On Mon, Apr 21, 2025 at 7:24

Re: [PATCH] expand: Add a helper function for edge splitting [PR120629]

2025-06-13 Thread Richard Sandiford
Jakub Jelinek writes: > On Fri, Jun 13, 2025 at 10:05:14AM +0200, Jakub Jelinek wrote: >> On Fri, Jun 13, 2025 at 08:52:55AM +0100, Richard Sandiford wrote: >> > > 2025-06-12 Jakub Jelinek >> > > >> > > * cfgexpand.cc (construct_init_block): If first_block isn't BB_RTL, >> > > has any PHI nod

Re: [PATCH] libstdc++: add a workaround for format_kind> [PR120644]

2025-06-13 Thread Jonathan Wakely
On Fri, 13 Jun 2025 at 10:55, Giuseppe D'Angelowrote: > > Hi, > > Attached is a workaround for > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120644 > > It looks it's a C++ frontend bug, this commit just silences the > regression in the modules testsuite that have been observed after the > introd

Re: [PATCH v3] simplify-rtx.cc:Simplify XOR(AND(ROTATE(~1) A) ASHIFT(1 A)) to IOR.

2025-06-13 Thread Richard Sandiford
Jiawei writes: > This patch adds a new simplification rule to `simplify-rtx.cc` that > handles a common bit manipulation pattern involving a single-bit set > and clear followed by XOR. > > The transformation targets RTL of the form: > > (xor (and (rotate (~1) A) B) (ashift 1 A)) > > which is sem

[PATCH] aarch64: Fold NOT+PTEST to NOTS [PR118150]

2025-06-13 Thread Spencer Abson
Add the missing combiner patterns for folding NOT+PTEST to NOTS when they share the same GP. gcc/ChangeLog: * config/aarch64/aarch64-sve.md (*one_cmpl3_cc): New combiner pattern. (*one_cmpl3_ptest): Likewise. gcc/testsuite/ChangeLog: * gcc.target/aarch64/sve/acle

[PATCH] expand: Add a helper function for edge splitting [PR120629]

2025-06-13 Thread Jakub Jelinek
On Fri, Jun 13, 2025 at 10:05:14AM +0200, Jakub Jelinek wrote: > On Fri, Jun 13, 2025 at 08:52:55AM +0100, Richard Sandiford wrote: > > > 2025-06-12 Jakub Jelinek > > > > > > * cfgexpand.cc (construct_init_block): If first_block isn't BB_RTL, > > > has any PHI nodes and false_edge->dest_idx

Re: [PATCH] testsuite: Fix pr119160.c for non-glibc targets [PR119862]

2025-06-13 Thread Philipp Tomsich
Thank you, applied to trunk! --Philipp. On Fri, 13 Jun 2025 at 09:30, Konstantinos Eleftheriou wrote: > > On Thu, Jun 12, 2025 at 5:20 PM Jeff Law wrote: > > > > > > > > On 6/10/25 1:09 AM, Konstantinos Eleftheriou wrote: > > > Testcase pr119160.c fails with symbol referencing errors for > > >

[PATCH v2 4/4] RISC-V: Add support for xtheadvector fault-only-first segment load/store intrinsics

2025-06-13 Thread yunzezhu
From: Yunze Zhu This commit add support for xtheadvector-specific fault-only-first segment load/store intrinsics with b/h/w suffix. We also defined enum to be used in thead-vector.md https://github.com/XUANTIE-RV/thead-extension-spec/pull/66 V2: Change to reuse existed thead function base th_lo

Re: [PATCH 0/1] [RFC][AutoFDO] Propagate inline information to outline definitions if not inlined

2025-06-13 Thread Jan Hubicka
> On 13/06/25 14:51, Jan Hubicka wrote: > > External email: Use caution opening links or attachments > > > > > > > From: Dhruv Chawla > > Hi, > > > > > > For reasons explained in the patch, this patch prevents the loss of > > > profile > > > information when inlining occurs in the profiled bin

[PATCH v2 3/4] RISC-V: Add support for xtheadvector indexed segment load/store intrinsics

2025-06-13 Thread yunzezhu
From: Yunze Zhu This commit add support for xtheadvector-specific indexed segment load/store intrinsics with b/h/w suffix. We also defined enum to be used in thead-vector.md https://github.com/XUANTIE-RV/thead-extension-spec/pull/66 V2: Change to reuse existed thead function base th_loadstore_w

[PATCH v2 2/4] RISC-V: Add support for xtheadvector strided segment load/store intrinsics

2025-06-13 Thread yunzezhu
From: Yunze Zhu This commit add support for xtheadvector-specific strided segment load/store intrinsics with b/h/w suffix. We also defined enum to be used in thead-vector.md https://github.com/XUANTIE-RV/thead-extension-spec/pull/66 V2: Change to reuse existed thead function base th_loadstore_w

[PATCH v2 1/4] RISC-V: Add support for xtheadvector unit-stride segment load/store intrinsics

2025-06-13 Thread yunzezhu
From: Yunze Zhu This commit add support for xtheadvector-specific unit-stride segment load/store intrinsics with b/h/w suffix. We also defined enum to be used in thead-vector.md https://github.com/XUANTIE-RV/thead-extension-spec/pull/66 V2: Change to reuse existed thead function base th_loadsto

Re: [PATCH v5 0/8] Implement layouts from mdspan.

2025-06-13 Thread Luc Grosheintz
Thank you both for the tips and information: * In that case I can update the auxiliary files after mdspan. * I use gcc-commit-mklog, but during rebasing / fixups, I edit the changelog manually (and mistakes creep in). Just tried gcc-verify it found a mistake in a patch I was preparing and

[PATCH v2 1/1] libstdc++: Implement default_accessor from mdspan.

2025-06-13 Thread Luc Grosheintz
libstdc++-v3/ChangeLog: * include/std/mdspan (default_accessor): New class. * src/c++23/std.cc.in: Register default_accessor. * testsuite/23_containers/mdspan/accessors/default.cc: New test. Signed-off-by: Luc Grosheintz --- libstdc++-v3/include/std/mdspan

[PATCH v2 0/1] Implement default_accessor.

2025-06-13 Thread Luc Grosheintz
This is a rebased and retested version of: https://gcc.gnu.org/pipermail/libstdc++/2025-June/061936.html The test has been moved to a subdirectory `accessors`. Luc Grosheintz (1): libstdc++: Implement default_accessor from mdspan. libstdc++-v3/include/std/mdspan | 26 l

[PATCH v3] simplify-rtx.cc:Simplify XOR(AND(ROTATE(~1) A) ASHIFT(1 A)) to IOR.

2025-06-13 Thread Jiawei
This patch adds a new simplification rule to `simplify-rtx.cc` that handles a common bit manipulation pattern involving a single-bit set and clear followed by XOR. The transformation targets RTL of the form: (xor (and (rotate (~1) A) B) (ashift 1 A)) which is semantically equivalent to: B |

RE: [PATCH V2] x86: Enable separate shrink wrapping

2025-06-13 Thread Cui, Lili
> -Original Message- > From: Uros Bizjak > Sent: Thursday, June 12, 2025 5:05 PM > To: Cui, Lili > Cc: gcc-patches@gcc.gnu.org; Liu, Hongtao ; > richard.guent...@gmail.com; Michael Matz > Subject: Re: [PATCH V2] x86: Enable separate shrink wrapping > > On Thu, Jun 12, 2025 at 10:58 AM

Re: [PATCH] libstdc++: add a workaround for format_kind> [PR120644]

2025-06-13 Thread Tomasz Kaminski
LGTM, thanks. It's interesting that having deduced the return type caused an issue. On Fri, Jun 13, 2025 at 11:56 AM Giuseppe D'Angelo < giuseppe.dang...@kdab.com> wrote: > Hi, > > Attached is a workaround for > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120644 > > It looks it's a C++ fronten

[PATCH] libstdc++: add a workaround for format_kind> [PR120644]

2025-06-13 Thread Giuseppe D'Angelo
Hi, Attached is a workaround for https://gcc.gnu.org/bugzilla/show_bug.cgi?id=120644 It looks it's a C++ frontend bug, this commit just silences the regression in the modules testsuite that have been observed after the introduction of range support for optional in r16-1487-g774ae8734f0e19. T

Re: [PATCH 2/4] cfgloopmanip: Add infrastructure for scaling of multi-exit loops [PR117790]

2025-06-13 Thread Alex Coplan
On 28/04/2025 16:33, Alex Coplan wrote: > On 15/04/2025 19:48, Jan Hubicka wrote: > > Hi, > > > gcc/ChangeLog: > > > > > > PR tree-optimization/117790 > > > * tree-vect-loop.cc (scale_profile_for_vect_loop): Use > > > scale_loop_profile_hold_exit_counts instead of scale_loop_profile. Drop >

Re: [PATCH 0/1] [RFC][AutoFDO] Propagate inline information to outline definitions if not inlined

2025-06-13 Thread Dhruv Chawla
On 13/06/25 14:51, Jan Hubicka wrote: External email: Use caution opening links or attachments From: Dhruv Chawla Hi, For reasons explained in the patch, this patch prevents the loss of profile information when inlining occurs in the profiled binary but not in the auto-profile pass as a de

Re: [PATCH v2] libstdc++: Fix std::uninitialized_value_construct for arrays [PR120397]

2025-06-13 Thread Tomasz Kaminski
On Fri, Jun 13, 2025 at 11:31 AM Jonathan Wakely wrote: > The std::uninitialized_{value,default}_construct{,_n} algorithms should > be able to create arrays, but that currently fails because when an > exception happens they clean up using std::_Destroy and in C++17 that > doesn't support destroyi

Re: [PATCH v2] libstdc++: Fix std::uninitialized_value_construct for arrays [PR120397]

2025-06-13 Thread Daniel Krügler
Am Fr., 13. Juni 2025 um 11:33 Uhr schrieb Jonathan Wakely < jwak...@redhat.com>: > The std::uninitialized_{value,default}_construct{,_n} algorithms should > be able to create arrays, but that currently fails because when an > exception happens they clean up using std::_Destroy and in C++17 that >

Re: [PATCH] libstdc++: Improve documentation on copyright notices in new tests

2025-06-13 Thread Tomasz Kaminski
On Wed, Jun 11, 2025 at 11:36 AM Jonathan Wakely wrote: > Clarify that FSF copyright notices in tests are incorrect for > contributions under DCO terms. Clarify the sentence about copying > existing tests to clarify that it is only referring to copying the code > in the test file, rather than jus

[PATCH v2] libstdc++: Fix std::uninitialized_value_construct for arrays [PR120397]

2025-06-13 Thread Jonathan Wakely
The std::uninitialized_{value,default}_construct{,_n} algorithms should be able to create arrays, but that currently fails because when an exception happens they clean up using std::_Destroy and in C++17 that doesn't support destroying arrays. (For C++20 and later, std::destroy does handle destroyi

Re: [PATCH 0/1] [RFC][AutoFDO] Propagate inline information to outline definitions if not inlined

2025-06-13 Thread Jan Hubicka
> From: Dhruv Chawla Hi, > > For reasons explained in the patch, this patch prevents the loss of profile > information when inlining occurs in the profiled binary but not in the > auto-profile pass as a decision. As an example, for this code: I was wondering about this problem too > - Annotation

[PATCH 1/1] [RFC][AutoFDO] Propagate information to outline copies if not inlined

2025-06-13 Thread dhruvc
From: Dhruv Chawla This patch modifies afdo_set_bb_count to propagate profile information to outline copies of functions if they are not inlined. This information gets lost otherwise. Signed-off-by: Dhruv Chawla gcc/ChangeLog: * gcc/auto-profile.cc (count_info): Adjust comments.

Re: [PATCH] expand: Fix up edge splitting for ENTRY block during expansion if there are any PHIs [PR120629]

2025-06-13 Thread Jakub Jelinek
On Fri, Jun 13, 2025 at 08:52:55AM +0100, Richard Sandiford wrote: > > 2025-06-12 Jakub Jelinek > > > > * cfgexpand.cc (construct_init_block): If first_block isn't BB_RTL, > > has any PHI nodes and false_edge->dest_idx before redirection is > > different from make_single_succ_edge re

Re: [committed] libstdc++: Replace _CharT template parameter with CharT in format tests.

2025-06-13 Thread Daniel Krügler
Am Fr., 13. Juni 2025 um 09:33 Uhr schrieb Tomasz Kamiński < tkami...@redhat.com>: > As pointed out by Daniel Krügler we do not need to use reserved name > in tests. > > libstdc++-v3/ChangeLog: > > * testsuite/23_containers/vector/bool/format.cc: Replaced _CharT > with CharT. >

Re: [PATCH] expand: Fix up edge splitting for ENTRY block during expansion if there are any PHIs [PR120629]

2025-06-13 Thread Richard Sandiford
Jakub Jelinek writes: > Hi! > > Andrew ran some extra ranger checking during bootstrap and found one more > case (though much rarer than the GIMPLE_COND case). > > Seems on fold-const.cc (native_encode_expr) we end up with bb 2, ENTRY > bb successor, having PHI nodes (usually there is some bb in b

[committed] libstdc++: Replace _CharT template parameter with CharT in format tests.

2025-06-13 Thread Tomasz Kamiński
As pointed out by Daniel Krügler we do not need to use reserved name in tests. libstdc++-v3/ChangeLog: * testsuite/23_containers/vector/bool/format.cc: Replaced _CharT with CharT. * testsuite/std/format/debug.cc: Likewise. * testsuite/std/format/ranges/adaptors.cc:

Re: [PATCH] testsuite: Fix pr119160.c for non-glibc targets [PR119862]

2025-06-13 Thread Konstantinos Eleftheriou
On Thu, Jun 12, 2025 at 5:20 PM Jeff Law wrote: > > > > On 6/10/25 1:09 AM, Konstantinos Eleftheriou wrote: > > Testcase pr119160.c fails with symbol referencing errors for > > `__cyg_profile_func_enter` and `__cyg_profile_func_exit` on non-glibc > > systems. > > > > This patch adds empty definiti

Re: [PATCH v4 2/2] libstdc++: Directly implement ranges::sort [PR100795]

2025-06-13 Thread Tomasz Kaminski
On Thu, Jun 12, 2025 at 7:33 PM Patrick Palka wrote: > On Thu, 12 Jun 2025, Patrick Palka wrote: > > > Changes in v4: > > * Don't pass a projection function throughout the helpers, instead > > create a pass a composite predicate via __make_comp_proj. > LGTM. > > > > -- >8 -- > > > > As wit

Re: [PATCH v4 1/2] libstdc++: Directly implement ranges::heap algos [PR100795]

2025-06-13 Thread Tomasz Kaminski
On Thu, Jun 12, 2025 at 6:53 PM Patrick Palka wrote: > Changes in v4: > * Don't pass a projection function throughout the helpers, instead > create a pass a composite predicate via __make_comp_proj. > LGTM. > > -- >8 -- > > ranges::push_heap, ranges::pop_heap, ranges::make_heap and > range