On Fri, Jun 13, 2025 at 02:12:44PM +0000, Kyrylo Tkachov wrote: > Hi Spencer, > > Thanks for the patch. > > > On 13 Jun 2025, at 14:46, Spencer Abson <spencer.ab...@arm.com> wrote: > > > > Add the missing combiner patterns for folding NOT+PTEST to NOTS when > > they share the same GP. > > > > I guess GP here means “governing predicate”? > GP usually means “General Purpose (register)” in aarch64 so it’d be good to > make the terminology explicit in the commit message. > > > gcc/ChangeLog: > > > > * config/aarch64/aarch64-sve.md (*one_cmpl<mode>3_cc): New > > combiner pattern. > > (*one_cmpl<mode>3_ptest): Likewise. > > > > The ChangeLog entry should mention PR target/118150 so that bugzilla is > properly updated on commit. > > > gcc/testsuite/ChangeLog: > > > > * gcc.target/aarch64/sve/acle/general/not_1.c: New test. > > > > --- > > Bootstapped & regtested on aarch64-linux-gnu. OK for master? > > > > Thanks, > > Spencer > > --- > > gcc/config/aarch64/aarch64-sve.md | 36 +++++++++++++++++++ > > .../aarch64/sve/acle/general/not_1.c | 22 ++++++++++++ > > 2 files changed, 58 insertions(+) > > create mode 100644 gcc/testsuite/gcc.target/aarch64/sve/acle/general/not_1.c > > > > diff --git a/gcc/config/aarch64/aarch64-sve.md > > b/gcc/config/aarch64/aarch64-sve.md > > index c5d3e8cd3b3..0f85cafa16a 100644 > > --- a/gcc/config/aarch64/aarch64-sve.md > > +++ b/gcc/config/aarch64/aarch64-sve.md > > The comment in this section says: > > ;; ------------------------------------------------------------------------- > ;; ---- [PRED] Inverse > ;; ------------------------------------------------------------------------- > ;; Includes: > ;; - NOT > ;; ———————————————————————————————————— > > It should now include NOTS as well. >
Gah, thanks for catching those - a bit careless of me! Spencer
