Ping: [PATCH V4] Do not allow -mvsx to boost the cpu to power7

2024-12-03 Thread Michael Meissner
Ping patch to not allow -mvsx to boost the cpu to power7 Message-ID https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669106.html -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meiss...@linux.ibm.com

[PATCH] testsuite: Fix CRC testcases

2024-12-03 Thread Bohan Lei
The RISC-V part has been fixed by another committed patch in https://gcc.gnu.org/pipermail/gcc-patches/2024-December/670722.html. -- From:Xi Ruoyao Send Time:2024 Dec. 4 (Wed.) 15:12 To:Bohan Lei Cc:"gcc-patches" Subject:Re: [PATCH]

Ping: [PATCH V4 0/2] Separate PowerPC ISA bits from architecture bits set by -mcpu=

2024-12-03 Thread Michael Meissner
Ping patches 1-2 to separate PowerPC ISA bits from architecture bits set by -mcpu=. Message-ID Explanation of the patch set: https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669108.html Patch #1, add rs6000 architecture masks: https://gcc.gnu.org/pipermail/gcc-patches/2024-November/66910

Ping: [PATCH V4 0/5] Add more user friendly TARGET_ names for PowerPC

2024-12-03 Thread Michael Meissner
Ping patches 1-5 to Add more user friendly TARGET_ names for PowerPC: Message-ID Information for patch set: https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669067.html Patch #1, Change TARGET_POPCNTB to TARGET_POWER5: https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669068.html

RE: [PATCH] Support Intel AVX10.2 minmax, vector copy and compare instructions

2024-12-03 Thread Jiang, Haochen
Oops, Please ignore this patch, should be sent to Binutils not here. Multi-threading made the mistake. Thx, Haochen > From: Haochen Jiang > Sent: Wednesday, December 4, 2024 3:29 PM > > From: "Mo, Zewei" > > Hi all, > > As satcvt patch is about to commit, we will move on the final patch of

[PATCH] Support Intel AVX10.2 minmax, vector copy and compare instructions

2024-12-03 Thread Haochen Jiang
From: "Mo, Zewei" Hi all, As satcvt patch is about to commit, we will move on the final patch of AVX10.2. This patch will focus on AVX10.2 minmax, vector copy and compare instructions, which is mainly Chapter 8, 11 and 14 of AVX10.2 SPEC. Reference: Intel Advanced Vector Extensions 10.2 Archit

Re: [PATCH] testsuite: Fix CRC testcases

2024-12-03 Thread Xi Ruoyao
On Tue, 2024-12-03 at 17:14 +0800, Bohan Lei wrote: > Thank you for pointing it out. I guess the RV32 issue may still exist. Please send v2 with only the RISC-V fixes if you can still reproduce the issue. > > Bohan > > -- > From:Xi

Re: [PATCH v2] phiopt: Reset the number of iterations information of a loop when changing an exit from the loop [PR117243]

2024-12-03 Thread Richard Biener
> Am 04.12.2024 um 06:24 schrieb Andrew Pinski : > > After r12-5300-gf98f373dd822b3, phiopt could get the following bb structure: > | >middle-bb -| > || > | || | >phi<1, 2> | | >cond | | > || | > |+---| >

Re: PING: [PATCH v4 1/7] Honor TARGET_PROMOTE_PROTOTYPES during RTL expand

2024-12-03 Thread H.J. Lu
On Wed, Dec 4, 2024 at 11:55 AM H.J. Lu wrote: > > On Tue, Dec 3, 2024 at 4:09 PM Richard Biener > wrote: > > > > On Mon, Dec 2, 2024 at 7:55 PM Jeff Law wrote: > > > > > > > > > > > > On 12/2/24 1:55 AM, Richard Biener wrote: > > > > On Sun, Dec 1, 2024 at 11:15 PM Jeff Law wrote: > > > >> > >

[PATCH v2] phiopt: Reset the number of iterations information of a loop when changing an exit from the loop [PR117243]

2024-12-03 Thread Andrew Pinski
After r12-5300-gf98f373dd822b3, phiopt could get the following bb structure: | middle-bb -| || | || | phi<1, 2> | | cond | | || | |+---| Which was considered 2 loops. The inner loop had esimtate of upper

[PATCH v5 5/7] vect-simd-clone-1[6-8][cd].c: Expect in-branch clones for x86

2024-12-03 Thread H.J. Lu
Since the C frontend no longer promotes char and short arguments, expect in-branch clones for x86. PR middle-end/14907 * gcc.dg/vect/vect-simd-clone-16c.c: Expect in-branch clones for x86. * gcc.dg/vect/vect-simd-clone-16d.c: Likewise. * gcc.dg/vect/vect-sim

[PATCH v5 7/7] ssa-fre-4.c: Enable for all targets and adjust scan match

2024-12-03 Thread H.J. Lu
Since the C frontend no longer promotes char argument, enable ssa-fre-4.c for all targets and adjust scan match. PR middle-end/14907 * gcc.dg/tree-ssa/ssa-fre-4.c: Enable for all targets and adjust scan match. Signed-off-by: H.J. Lu --- gcc/testsuite/gcc.dg/tree-ssa/ssa-

[PATCH v5 4/7] i386: Adjust apx-ndd.c for frontend promotion removal

2024-12-03 Thread H.J. Lu
Since the C frontend no longer promotes integer argument smaller than int, the apx-ndd.c codgen is slightly different: apx-ndd.s (original)2024-11-10 06:07:09.894876973 +0800 apx-ndd.s (updated) 2024-11-10 06:06:59.371860565 +0800 @@ -17,7 +17,7 @@ foo_add_char: foo1_add_char: .LFB1:

[PATCH v5 2/7] Drop targetm.promote_prototypes from C, C++ and Ada frontends

2024-12-03 Thread H.J. Lu
Remove the targetm.calls.promote_prototypes call from C, C++ and Ada frontends. gcc/ PR c/48274 PR middle-end/14907 PR middle-end/112877 * gimple.cc (gimple_builtin_call_types_compatible_p): Remove the targetm.calls.promote_prototypes call. * tree.c

[PATCH v5 3/7] Use incoming small integer argument type if possible

2024-12-03 Thread H.J. Lu
For targets, like x86, which define TARGET_PROMOTE_PROTOTYPES to return true, all integer arguments smaller than int are passed as int: [hjl@gnu-tgl-3 pr14907]$ cat x.c extern int baz (char c1); int foo (char c1) { return baz (c1); } [hjl@gnu-tgl-3 pr14907]$ gcc -S -O2 -m32 x.c [hjl@gnu-tgl-3 p

[PATCH v5 0/7] Correct outgoing integer argument promotion

2024-12-03 Thread H.J. Lu
Changes from v4: 1. Rename gcc/testsuite/gfortran.dg/pr14907-1.f90 to gcc/testsuite/gfortran.dg/pr112877-1.f90 2. Mention https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48274 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112877 Changes from v3: 1. Split improvement of outgoing integer argument pro

[PATCH v5 6/7] scev-cast.c: Enable for all targets and adjust scan matches

2024-12-03 Thread H.J. Lu
Since the C frontend no longer promotes char argument, enable scev-cast.c for all targets and adjust scan matches. PR middle-end/14907 * gcc.dg/tree-ssa/scev-cast.c: Enable for all targets and adjust scan match. Signed-off-by: H.J. Lu --- gcc/testsuite/gcc.dg/tree-ssa/sc

[PATCH v5 1/7] Honor TARGET_PROMOTE_PROTOTYPES during RTL expand

2024-12-03 Thread H.J. Lu
Promote integer arguments smaller than int if TARGET_PROMOTE_PROTOTYPES returns true. PR middle-end/112877 * calls.c (initialize_argument_information): Promote small integer arguments if TARGET_PROMOTE_PROTOTYPES returns true. gcc/testsuite/ PR middle-end/112877

[RFC PATCH v2] cselib: Reuse VALUEs on reg adjustments

2024-12-03 Thread Bohan Lei
This is v2 of the patch in https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669380.html. I missed the ChangeLog entry in that version. The commit 2c0fa3ecf70d199af18785702e9e0548fd3ab793 reuses VALUEs on sp adjustments. We can generalize the idea and reuse VALUEs on other registers. This

Re: PING: [PATCH v4 1/7] Honor TARGET_PROMOTE_PROTOTYPES during RTL expand

2024-12-03 Thread H.J. Lu
On Tue, Dec 3, 2024 at 4:09 PM Richard Biener wrote: > > On Mon, Dec 2, 2024 at 7:55 PM Jeff Law wrote: > > > > > > > > On 12/2/24 1:55 AM, Richard Biener wrote: > > > On Sun, Dec 1, 2024 at 11:15 PM Jeff Law wrote: > > >> > > >> > > >> > > >> On 11/27/24 3:34 PM, H.J. Lu wrote: > > >>> On Thu,

Re: [PATCH 2/2] RISC-V: Support RISC-V Profiles RVA/B23.

2024-12-03 Thread Jiawei
在 2024/12/3 23:54, Palmer Dabbelt 写道: On Tue, 03 Dec 2024 03:02:47 PST (-0800), jia...@iscas.ac.cn wrote: This patch introduces support for RISC-V Profiles RV23A and RV23B [1], enabling developers to utilize these profiles through the -march option. [1] https://github.com/riscv/riscv-profile

Re: [PATCH] gcc: download_prerequisites: add --verbose and --no-verbose

2024-12-03 Thread Tiezhu Yang
On 12/04/2024 10:33 AM, Xi Ruoyao wrote: On Wed, 2024-12-04 at 10:28 +0800, Tiezhu Yang wrote: On 12/03/2024 09:12 PM, Eric Gallager wrote: On Tue, Dec 3, 2024 at 7:09 AM Tiezhu Yang wrote: When executing the script download_prerequisites, the download speed may be extremely slow and there i

Re: [PATCH] gcc: download_prerequisites: add --verbose and --no-verbose

2024-12-03 Thread Xi Ruoyao
On Wed, 2024-12-04 at 10:28 +0800, Tiezhu Yang wrote: > On 12/03/2024 09:12 PM, Eric Gallager wrote: > > On Tue, Dec 3, 2024 at 7:09 AM Tiezhu Yang wrote: > > > > > > When executing the script download_prerequisites, the download speed may > > > be extremely slow and there is no any output, the u

Re: [PATCH] gcc: download_prerequisites: add --verbose and --no-verbose

2024-12-03 Thread Tiezhu Yang
On 12/03/2024 09:12 PM, Eric Gallager wrote: On Tue, Dec 3, 2024 at 7:09 AM Tiezhu Yang wrote: When executing the script download_prerequisites, the download speed may be extremely slow and there is no any output, the users do not know what happened. Given the command wget and curl have optio

[PATCH v1 2/2] RISC-V: Refactor the testcases for bswap16-0

2024-12-03 Thread pan2 . li
From: Pan Li This patch would like to refactor the testcases of bswap16-0 after sorts of optimization option passing to testcase. To fits the big lmul like m8 for asm dump check. The below test suites are passed for this patch. * The rv64gcv fully regression test. It is test only patch and obv

[PATCH v1 1/2] RISC-V: Fix incorrect optimization options passing to convert and unop

2024-12-03 Thread pan2 . li
From: Pan Li Like the strided load/store, the testcases of vector convert and unop are designed to pick up different sorts of optimization options but actually these option are ignored according to the Execution log of the gcc.log. This patch would like to make it correct almost the same as how

Re: [PATCH v3 5/7] Support for 64-bit location_t: Activate 64-bit location_t

2024-12-03 Thread Lewis Hyatt
On Tue, Dec 3, 2024 at 7:33 AM Richard Biener wrote: > > On Mon, Dec 2, 2024 at 1:50 AM Lewis Hyatt wrote: > > > > With the codebase having already been prepared to handle it, change > > location_t to be a 64-bit integer instead of a 32-bit integer. > > OK if there's no comments from others withi

Re: [PATCH] phiopt: don't handle the case cond edge dest is itself [PR117243]

2024-12-03 Thread Andrew Pinski
On Tue, Dec 3, 2024 at 12:34 AM Richard Biener wrote: > > On Mon, Dec 2, 2024 at 10:52 PM Andrew Pinski > wrote: > > > > After r12-5300-gf98f373dd822b3, phiopt could get the following bb structure: > > | > > middle-bb -| > > || > > | || | > > phi

[PATCH] c++, v2: Fix up erroneous template error recovery ICE [PR117826]

2024-12-03 Thread Jakub Jelinek
On Tue, Dec 03, 2024 at 05:14:31PM -0500, Jason Merrill wrote: > GTY((cache)) sounds right to me. OK with that change. In that case I think it needs to be simple_cache_map_traits rather than simple_hashmap_traits. So, I'll test following patch instead momentarily. Worked on the testcase from th

Re: [PATCH] c++: Fix up erroneous template error recovery ICE [PR117826]

2024-12-03 Thread Jason Merrill
On 12/3/24 3:42 AM, Jakub Jelinek wrote: Hi! The testcase in the PR (which can't be easily reduced and is way too large and has way too many errors) results in an ICE, because the erroneous_templates hash_map holds trees of erroneous templates across ggc_collect and some of the templates in ther

Re: [PATCH v3 1/1] CPP: Add flag to generate resolver at default version implementation.

2024-12-03 Thread Jason Merrill
On 11/26/24 9:35 AM, alfie.richa...@arm.com wrote: This patch adds the TARGET_CREATE_FMV_DISPATCHER_AT_DEFAULT_IMPL flag which changes FMV behavior for target_version functions to match the Arm C Language Extension. The functional differences consist of: 1. Generating the resolver for the dispa

Re: [PATCH] testsuite: Mark gcc.c-torture/execute/memcpy-a?.c tests expensive

2024-12-03 Thread Mike Stump
On Dec 2, 2024, at 4:27 AM, Maciej W. Rozycki wrote: > > These tests can take several seconds per compilation to complete, taking > total elapsed time measured in minutes. Mark them as expensive so as to > let people skip them where they want to save on testing time. > > gcc/testsuite/

Re: [patch,testsuite] Rectify some tests

2024-12-03 Thread Mike Stump
On Dec 3, 2024, at 3:08 AM, Georg-Johann Lay wrote: > > This patch fixes some unrelated tests that were failing. > In most cases, bad tests are slipping in because they > are preprocessed like: > > size_t -> long unsigned int -> breaks when size_t is smaller etc. > > Other reason is that they a

[committed v2] libstdc++: Add fancy pointer support to std::forward_list [PR57272]

2024-12-03 Thread Jonathan Wakely
This takes a very similar approach to the changes for std::list. libstdc++-v3/ChangeLog: PR libstdc++/57272 * include/bits/forward_list.h (_GLIBCXX_USE_ALLOC_PTR_FOR_LIST): Define. (_Fwd_list_node_base::_M_base_ptr): New member functions. (_Fwd_list_node::_

[committed] libstdc++: Simplify allocator propagation helpers using 'if constexpr'

2024-12-03 Thread Jonathan Wakely
Use diagnostic pragmas to allow using `if constexpr` in C++11 mode, so that we don't need to use tag dispatching. These helpers could be removed entirely by just using `if constexpr` directly in the container member functions, but that's a slightly larger change that can happen later. It also loo

Re: [PATCH] c++: Don't reject pointer to virtual method during constant evaluation [PR117615]

2024-12-03 Thread Jason Merrill
On 12/3/24 12:25 PM, Simon Martin wrote: We currently reject the following valid code: === cut here === struct Base { virtual void doit (int v) const {} }; struct Derived : Base { void doit (int v) const {} }; using fn_t = void (Base::*)(int) const; struct Helper { fn_t mFn;

Re: [PATCH 3/3 v2] libstdc++: Add fancy pointer support to std::list [PR57272]

2024-12-03 Thread Jonathan Wakely
Pushed On Sat, 16 Nov 2024 at 23:34, Jonathan Wakely wrote: > > Currently std::list uses raw pointers to connect its nodes, which is > non-conforming. We should use the allocator's pointer type everywhere > that a "pointer" is needed. > > Because the existing types like _List_node are part of the

[committed] libstdc++: Fix parallel std::exclusive_scan [PR108236]

2024-12-03 Thread Jonathan Wakely
The standard says that std::exclusive_scan can be used to work in place, i.e. where the output range is the same as the input range. This means that the first sum cannot be written to the output until after reading the first input value, otherwise we'll already have overwritten the first input valu

Re: [PATCH 2/3] libstdc++: Stop using _Self typedefs in std::list iterators

2024-12-03 Thread Jonathan Wakely
Pushed On Fri, 15 Nov 2024 at 15:28, Jonathan Wakely wrote: > > We can just use the injected-class-name instead of defining a new name. > That seems simpler. > > libstdc++-v3/ChangeLog: > > * include/bits/stl_list.h (_List_iterator): Remove _Self typedef > and just use injected-cl

Re: [PATCH 1/3] libstdc++: Refactor std::list::size() for cxx11 ABI

2024-12-03 Thread Jonathan Wakely
Pushed On Fri, 15 Nov 2024 at 15:26, Jonathan Wakely wrote: > > Remove some preprocessor conditionals by moving the _M_size member for > the cxx11 ABI into a new base class, which is empty for the gcc4-compat > ABI. > > Move some unused members that are only retained for ABI compatibility to > th

Re: [PATCH] c++: Allow overloaded builtins to be used in SFINAE context

2024-12-03 Thread Jason Merrill
On 12/3/24 8:46 AM, Matthew Malcomson wrote: Attempting to resend my response differently since my last email seems to have had problems with email permissions. Apologies for the duplication. On 12/2/24 16:48, Jason Merrill wrote: External email: Use caution opening links or attachments On 1

Re: [PATCH v2] c++: P2865R5, Remove Deprecated Array Comparisons from C++26 [PR117788]

2024-12-03 Thread Jason Merrill
On 12/3/24 2:46 PM, Marek Polacek wrote: On Thu, Nov 28, 2024 at 12:04:56PM -0500, Jason Merrill wrote: On 11/27/24 9:06 PM, Marek Polacek wrote: Not a bugfix, but this should only affect C++26. Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8-- This patch implements P2865R5

[pushed, wwwdocs] onlinedocs: add link to libgdiagnostics documentation

2024-12-03 Thread David Malcolm
Pushed, as libgdiagnostics API docs are now up on gcc.gnu.org --- htdocs/onlinedocs/index.html | 1 + 1 file changed, 1 insertion(+) diff --git a/htdocs/onlinedocs/index.html b/htdocs/onlinedocs/index.html index d3fa24c6..07e3de17 100644 --- a/htdocs/onlinedocs/index.html +++ b/htdocs/onlinedocs

RE: [PATCH 2/2]middle-end: use two's complement equality when comparing IVs during candidate selection [PR114932]

2024-12-03 Thread Tamar Christina
> > This patch implements a new OEP flag called OEP_STRUCTURAL_EQ. This flag > > will > > check if the operands would produce the same bit values after the > > computations > > even if the final sign is different. > > I think the name is badly chosen - we already have OEP_LEXICOGRAPHIC and > OE

[PING][PATCH 00/15] Fix data races with sub-longword accesses on Alpha

2024-12-03 Thread Maciej W. Rozycki
On Mon, 18 Nov 2024, Maciej W. Rozycki wrote: > As it happens these data races also apply to BWX Alpha systems, as I have > discovered in the course of this effort, although owing to how the Alpha > backend of GCC has implemented block copy and clear operations rather than > actual hardware li

[r15-5897 Regression] FAIL: gfortran.dg/class_transformational_1.f90 -O3 -g (test for excess errors) on Linux/x86_64

2024-12-03 Thread haochen.jiang
On Linux/x86_64, 31250baf81446aa4fc1b729e2fc5165a36005ebc is the first bad commit commit 31250baf81446aa4fc1b729e2fc5165a36005ebc Author: Paul Thomas Date: Tue Dec 3 15:56:53 2024 + Fortran: Fix class transformational intrinsic calls [PR102689] caused FAIL: gfortran.dg/class_transfor

Re: [PATCH 2/2] c++/coroutines: handle (new-)extended alignment [PR104177]

2024-12-03 Thread Iain Sandoe
> On 3 Dec 2024, at 19:50, Jason Merrill wrote: > > On 12/3/24 2:31 PM, Iain Sandoe wrote: >>> On 3 Dec 2024, at 18:28, Jason Merrill wrote: >>> >>> On 9/18/24 4:36 PM, Arsen Arsenović wrote: This patch implements support for frames and promises with new-extended alignment. Th

Re: [PATCH 2/2] c++/coroutines: handle (new-)extended alignment [PR104177]

2024-12-03 Thread Iain Sandoe
> On 3 Dec 2024, at 18:28, Jason Merrill wrote: > > On 9/18/24 4:36 PM, Arsen Arsenović wrote: >> This patch implements support for frames and promises with new-extended >> alignment. >> There are two kinds of alignment to worry about here: >> - Promise alignment, which causes "internal" paddi

Re: [PATCH 2/2] c++/coroutines: handle (new-)extended alignment [PR104177]

2024-12-03 Thread Jason Merrill
On 12/3/24 2:31 PM, Iain Sandoe wrote: On 3 Dec 2024, at 18:28, Jason Merrill wrote: On 9/18/24 4:36 PM, Arsen Arsenović wrote: This patch implements support for frames and promises with new-extended alignment. There are two kinds of alignment to worry about here: - Promise alignment, which

[PATCH v2] c++: P2865R5, Remove Deprecated Array Comparisons from C++26 [PR117788]

2024-12-03 Thread Marek Polacek
On Thu, Nov 28, 2024 at 12:04:56PM -0500, Jason Merrill wrote: > On 11/27/24 9:06 PM, Marek Polacek wrote: > > Not a bugfix, but this should only affect C++26. > > > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > > > -- >8-- > > This patch implements P2865R5 by promoting the w

Re: [PATCH 2/2] c++/coroutines: handle (new-)extended alignment [PR104177]

2024-12-03 Thread Jason Merrill
On 12/3/24 1:28 PM, Jason Merrill wrote: On 9/18/24 4:36 PM, Arsen Arsenović wrote: This patch implements support for frames and promises with new-extended alignment. There are two kinds of alignment to worry about here: - Promise alignment, which causes "internal" padding inside the frame    s

[committed] Move some CRC tests into the gcc.dg/torture directory

2024-12-03 Thread Jeff Law
Jakub noted that these tests were using dg-skip-if directives that implied the tests were expected to run under multiple optimization options, which means they probably should be in gcc.dg/torture rather than in the gcc.dg directory. This moves the relevant tests from gcc.dg to gcc.dg/torture.

Re: [PATCH v2] c++/contracts: ICE with contract assert on non-empty statement [PR 117579]

2024-12-03 Thread Jason Merrill
On 12/3/24 9:58 AM, Nina Ranns wrote: This question implies to me that the sender has commit access, which I don't think you do yet since you aren't in MAINTAINERS. But I can't think of a similar standard question for contributors without commit access; I guess just leave it out. ack For g

Re: [PATCH v3 4/7] Support for 64-bit location_t: libgdiagnostics parts

2024-12-03 Thread David Malcolm
On Mon, 2024-12-02 at 19:56 -0500, Lewis Hyatt wrote: > On Mon, Dec 02, 2024 at 07:35:12PM -0500, David Malcolm wrote: > > On Sun, 2024-12-01 at 19:44 -0500, Lewis Hyatt wrote: > > > This patch is new in v3 and is a small change to libgdiagnostics > > > similar to > > > other changes required by 64

Re: [PATCH 2/2] maintainer-scripts: build the libgdiagnostics docs for the website [PR117883]

2024-12-03 Thread Joseph Myers
On Tue, 3 Dec 2024, David Malcolm wrote: > Tested locally. > > OK for trunk? > > maintainer-scripts/ChangeLog: > PR web/117883 > * update_web_docs_git: Introduce SPHINX_VENV to make > it easier to test the script. Add the libgdiagnostics docs > and testsuite to the files

Re: [PATCH 1/2] maintainer-scripts: fix jit docs on website

2024-12-03 Thread Joseph Myers
On Tue, 3 Dec 2024, David Malcolm wrote: > I noticed whilst working on the libgdiagnostics docs > that some errors like this were occurring in the jit docs: > > /tmp/gcc-doc-update.3782849/gcc/gcc/jit/docs/cp/topics/asm.rst:63: WARNING: > Include file > '/tmp/gcc-doc-update.3782849/gcc/gcc/test

Re: [PATCH 2/2] c++/coroutines: handle (new-)extended alignment [PR104177]

2024-12-03 Thread Jason Merrill
On 9/18/24 4:36 PM, Arsen Arsenović wrote: This patch implements support for frames and promises with new-extended alignment. There are two kinds of alignment to worry about here: - Promise alignment, which causes "internal" padding inside the frame struct. The reason this is a problem is be

Re: [patch, libgfortran] PR117820

2024-12-03 Thread Harald Anlauf
Hi Jerry, regarding the testcase, these variants are both standard-conforming and silent under -pedantic: x = ibset (0_8, 63) x = ibset (0_8, bit_size(x)-1) No trickery needed. Cheers, Harald Am 03.12.24 um 05:13 schrieb Jerry D: Hi all, Attached patch adds a test for zero that is neede

[Committed] RISC-V: Fix test target selector

2024-12-03 Thread Edwin Lu
The previous target selector was not properly gating the tests to rv32 and rv64 targets. This was triggering an excess failure on rv32 targets where it would try to run the zbc64 tests. Fix selector Committed as obvious. gcc/testsuite/ChangeLog: * gcc.target/riscv/crc-builtin-zbc32.c: Fi

Re: [PATCH] arm: Fix LDRD register overlap [PR117675]

2024-12-03 Thread Richard Earnshaw (lists)
On 03/12/2024 16:09, Wilco Dijkstra wrote: The register indexed variants of LDRD have complex register overlap constraints which makes them hard to use without using output_move_double (which can't be used for atomics as it doesn't guarantee to emit atomic LDRD/STRD when required). Add a new pr

Re: [PATCH] AIX Build failure with default -std=gnu23.

2024-12-03 Thread swamy sangamesh
Hi Eric, Thanks for the review. I too think removing the define is a better approach and seems these won't be needed. >From the comment it looks like that these were added long back and conflicting declarations were their until C23 standard uncovered it. If removing define is fine then i can sen

[PATCH] c++: Don't reject pointer to virtual method during constant evaluation [PR117615]

2024-12-03 Thread Simon Martin
We currently reject the following valid code: === cut here === struct Base { virtual void doit (int v) const {} }; struct Derived : Base { void doit (int v) const {} }; using fn_t = void (Base::*)(int) const; struct Helper { fn_t mFn; constexpr Helper (auto && fn) : mFn(static_cast

[PATCH 1/2] maintainer-scripts: fix jit docs on website

2024-12-03 Thread David Malcolm
I noticed whilst working on the libgdiagnostics docs that some errors like this were occurring in the jit docs: /tmp/gcc-doc-update.3782849/gcc/gcc/jit/docs/cp/topics/asm.rst:63: WARNING: Include file '/tmp/gcc-doc-update.3782849/gcc/gcc/testsuite/jit.dg/test-asm.cc' not found or reading it fail

[PATCH 2/2] maintainer-scripts: build the libgdiagnostics docs for the website [PR117883]

2024-12-03 Thread David Malcolm
Tested locally. OK for trunk? maintainer-scripts/ChangeLog: PR web/117883 * update_web_docs_git: Introduce SPHINX_VENV to make it easier to test the script. Add the libgdiagnostics docs and testsuite to the files to be preserved. Use sphinx to build the l

[pushed] libgdiagnostics: fix docs metadata

2024-12-03 Thread David Malcolm
Pushed to trunk as r15-5898-g2b93d71b068b2f. gcc/ChangeLog: * doc/libgdiagnostics/conf.py: Remove "author". Change "copyright" field to the FSF. Signed-off-by: David Malcolm --- gcc/doc/libgdiagnostics/conf.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 2/2] tree-optimization/116083 - SLP discovery slowness

2024-12-03 Thread Richard Biener
One large constant factor of SLP discovery is figuring the vector type for each individual lane of each node. That should be redundant since the structual comparison of stmts should ensure they end up the same so the following computes them only once per node rather than for each lane. This cuts

[PATCH 1/2] middle-end/116083 - vectorizer slowness

2024-12-03 Thread Richard Biener
Turns out SLP discovery can end up doing a lot of vector type builds from scalar types. Those are all ultimatively cached but end up built and layouted first. The latter is particularly expensive because it does tree node arithmetic to compute TYPE_SIZE and TYPE_SIZE_UNIT. The following replaces

Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Jonathan Wakely
On Tue, 3 Dec 2024 at 16:56, Jonathan Wakely wrote: > > On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo > wrote: > > > > Hello, > > > > The attached patch changes std::weak_ptr "converting move > > constructor/assignment" -- that is, from a rvalue weak_ptr to a > > weak_ptr. > > > > In the general

[wwwdocs] cxx-status.html: Update C++26 proposals to new revisions

2024-12-03 Thread Tobias Burnus
I noticed that https://gcc.gnu.org/projects/cxx-status.html did not list newer revisions of three proposals. (I have on idea whether still newer exists or others should be updated as well, but at least that's a start.) OK? Tobias cxx-status.html: Update C++26 proposals to new revisions Bum

Re: libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Jonathan Wakely
On Tue, 3 Dec 2024 at 16:19, Giuseppe D'Angelo wrote: > > Hello, > > The attached patch changes std::weak_ptr "converting move > constructor/assignment" -- that is, from a rvalue weak_ptr to a > weak_ptr. > > In the general case, such conversion requires lock()ing the weak_ptr > because the pointe

libstdc++: use is_virtual_base_of in std::weak_ptr operations

2024-12-03 Thread Giuseppe D'Angelo
Hello, The attached patch changes std::weak_ptr "converting move constructor/assignment" -- that is, from a rvalue weak_ptr to a weak_ptr. In the general case, such conversion requires lock()ing the weak_ptr because the pointed-to object might have already been destroyed, and a Derived->Bas

[PATCH] arm: Fix LDRD register overlap [PR117675]

2024-12-03 Thread Wilco Dijkstra
The register indexed variants of LDRD have complex register overlap constraints which makes them hard to use without using output_move_double (which can't be used for atomics as it doesn't guarantee to emit atomic LDRD/STRD when required). Add a new predicate and constraint for plain LDRD/STRD wi

Re: [Patch, fortran] PR102689 revisited - Segfault with RESHAPE of CLASS as actual argument

2024-12-03 Thread Paul Richard Thomas
Hi Harald, > > Reviewing it properly is beyond me, but if nobody else volunteers, > I am not so sure that is right but your review is mightily helpful. I worry that the logic in the handling of the gfc_ss's is not clear enough. Some time, when feeling bored, I might try to refactor it. > I'll j

[PATCH] libstdc++: add initializer_list constructor to std::span (P2447)

2024-12-03 Thread Giuseppe D'Angelo
Hello, The attached patch adds the span(initializer_list) constructor, added by P2447R6 for C++26. It seems that GCC is somewhat aggressive with its -Winit-list-lifetime warning, which actively interferes with this feature. The idea of the new constructor is to allow calls like: void f(s

Re: [PATCH v2] libstdc++: constrain std::atomic's default constructor

2024-12-03 Thread Giuseppe D'Angelo
Hello, Following the outcome of the previous discussion, the attached revised patch implements the proposed resolution to LWG 4169, moved to WP in Wrocław. https://cplusplus.github.io/LWG/issue4169 Thanks, -- Giuseppe D'Angelo From 3dc64d830c61a16c2c4c0722a3983054aad1b04e Mon Sep 17 00:00:0

Re: [PATCH 2/2] RISC-V: Support RISC-V Profiles RVA/B23.

2024-12-03 Thread Palmer Dabbelt
On Tue, 03 Dec 2024 03:02:47 PST (-0800), jia...@iscas.ac.cn wrote: This patch introduces support for RISC-V Profiles RV23A and RV23B [1], enabling developers to utilize these profiles through the -march option. [1] https://github.com/riscv/riscv-profiles/releases/tag/rva23-rvb23-v0.7-ratificat

Re: [patch,avr] Improve location of late diagnostics

2024-12-03 Thread Denis Chertykov
вт, 3 дек. 2024 г. в 17:32, Georg-Johann Lay : > > Some diagnostics are issues late, e.g. in avr_print_operand(). > This patch uses the insn's location as a proxy for the operand > location. Without the patch, the location is usually input_location, > which points to the closing } of the function

Re: [PATCH v2] RISC-V: Add --with-cmodel configure option

2024-12-03 Thread Kito Cheng
Let you know I am working on that and will send the v3 patch soon, also I have tested that on aarch64 from cfram. On Mon, Aug 26, 2024 at 12:40 AM Jeff Law wrote: > > > > On 8/4/24 8:24 PM, Hau Hsu wrote: > > Oh the Palmer's patch is here > > [PATCH] RISC-V: Add --with-cmodel configure-time argum

Re: Should -fsanitize=bounds support counted-by attribute for pointers inside a structure?

2024-12-03 Thread Qing Zhao
> On Dec 3, 2024, at 10:07, Martin Uecker wrote: > > Am Dienstag, dem 03.12.2024 um 14:31 + schrieb Qing Zhao: >> >>> On Dec 3, 2024, at 01:33, Martin Uecker wrote: >>> >>> Am Montag, dem 02.12.2024 um 22:58 + schrieb Qing Zhao: > On Dec 2, 2024, at 16:13, Martin Uecker wr

[patch, avr, applied] ad PR117726: Also split logic shifts of bitsize - 1

2024-12-03 Thread Georg-Johann Lay
Applied the patch below which also splits logic shifts with an offset of bitsize - 1 into byte operations. Johann -- AVR: ad target/117726 - Also split logic shifts of bitsize - 1. When -msplit-bit-shift is on, also split logic shifts of bitsize(mode) - 1. gcc/ PR target/117726

[PATCH v2] c++/contracts: ICE with contract assert on non-empty statement [PR 117579]

2024-12-03 Thread Nina Ranns
>This question implies to me that the sender has commit access, which I >don't think you do yet since you aren't in MAINTAINERS. But I can't >think of a similar standard question for contributors without commit >access; I guess just leave it out. ack >For git-am this line should contain scisso

Re: Should -fsanitize=bounds support counted-by attribute for pointers inside a structure?

2024-12-03 Thread Martin Uecker
Am Dienstag, dem 03.12.2024 um 14:31 + schrieb Qing Zhao: > > > On Dec 3, 2024, at 01:33, Martin Uecker wrote: > > > > Am Montag, dem 02.12.2024 um 22:58 + schrieb Qing Zhao: > > > > > > > On Dec 2, 2024, at 16:13, Martin Uecker wrote: > > > > > > > > Am Montag, dem 02.12.2024 um 20:1

Re: [patch,avr] Skip some tests that don't work on avr

2024-12-03 Thread Georg-Johann Lay
Am 03.12.24 um 15:36 schrieb Jeff Law: On 12/3/24 3:57 AM, Georg-Johann Lay wrote: This patch skips some tests that don't work on avr. Ok for trunk? Johann -- AVR: Skip some test cases that don't work for it. gcc/testsuite/  * gcc.c-torture/execute/ieee/cdivchkd.x: New file.  * gcc

Re: [PATCH 1/2] c++: Implement a coroutine language debug dump

2024-12-03 Thread Jason Merrill
On 9/18/24 4:36 PM, Arsen Arsenović wrote: This provides to people working on coroutines, as well as writing tests for coroutines, a way to have insight into the results and inputs of the coroutine transformation passes, which is quite essential to understanding what happens in the coroutine tran

Re: Fix type compatibility for types with flexible array member [PR113688,PR114014,PR117724]

2024-12-03 Thread Qing Zhao
> On Dec 3, 2024, at 01:25, Martin Uecker wrote: > > Am Montag, dem 02.12.2024 um 22:33 + schrieb Qing Zhao: > > > diff --git a/gcc/testsuite/gcc.dg/pr114014.c b/gcc/testsuite/gcc.dg/pr114014.c new file mode 100644 index 000..ab783f4f85d --- /d

Re: [patch,avr] Skip some tests that don't work on avr

2024-12-03 Thread Jeff Law
On 12/3/24 3:57 AM, Georg-Johann Lay wrote: This patch skips some tests that don't work on avr. Ok for trunk? Johann -- AVR: Skip some test cases that don't work for it. gcc/testsuite/ * gcc.c-torture/execute/ieee/cdivchkd.x: New file. * gcc.c-torture/execute/ieee/cdivchkf.x: Ne

Re: [PATCH 1/1] aarch64: remove extra XTN in vector concatenation

2024-12-03 Thread Akram Ahmad
Hi Kyrill, thanks for the very quick response! On 02/12/2024 15:09, Kyrylo Tkachov wrote: Thanks for the patch. As this is sent after the end of stage1 and is not finishing support for an architecture feature perhaps we should stage this for GCC 16. But if it fixes a performance problem in a r

Re: Should -fsanitize=bounds support counted-by attribute for pointers inside a structure?

2024-12-03 Thread Qing Zhao
> On Dec 3, 2024, at 01:33, Martin Uecker wrote: > > Am Montag, dem 02.12.2024 um 22:58 + schrieb Qing Zhao: >> >>> On Dec 2, 2024, at 16:13, Martin Uecker wrote: >>> >>> Am Montag, dem 02.12.2024 um 20:15 + schrieb Qing Zhao: > On Nov 30, 2024, at 07:22, Martin Uecker wro

RE: [PATCH 2/2] libstdc++: Implement for C++26 (P3370R1)

2024-12-03 Thread Maciej Cencora
Hi, two issues: 1) #include is missing in std.compat.cc.in 2) does the updated std.compat module actually work? When I experimented with implementing the std module in gcc, I couldn't #include standard headers, after they were imported via std module (since GMF merging isn't implemented yet), i.

[PATCH] AArch64: Cleanup alignment macros

2024-12-03 Thread Wilco Dijkstra
Change the AARCH64_EXPAND_ALIGNMENT macro into proper function calls to make future changes easier. Use the existing alignment settings, however avoid overaligning small array's or structs to 64 bits when there is no benefit. This gives a small reduction in data and stack size. Passes regress & b

Re: [PATCH] c++: Allow overloaded builtins to be used in SFINAE context

2024-12-03 Thread Matthew Malcomson
Attempting to resend my response differently since my last email seems to have had problems with email permissions. Apologies for the duplication. On 12/2/24 16:48, Jason Merrill wrote: External email: Use caution opening links or attachments On 10/21/24 6:43 AM, Matthew Malcomson wrote: Pin

Re: [PATCH v3 1/7] middle-end: Handle resized PHI nodes in loop_version()

2024-12-03 Thread Richard Biener
On Tue, Dec 3, 2024 at 2:07 PM Lewis Hyatt wrote: > > On Tue, Dec 03, 2024 at 01:28:28PM +0100, Richard Biener wrote: > > On Mon, Dec 2, 2024 at 1:55 AM Lewis Hyatt wrote: > > > > > > This patch is my new way to handle what was previously done in v2 patch > > > 04/14, discussed at: > > > https://

[patch,avr] Improve location of late diagnostics

2024-12-03 Thread Georg-Johann Lay
Some diagnostics are issues late, e.g. in avr_print_operand(). This patch uses the insn's location as a proxy for the operand location. Without the patch, the location is usually input_location, which points to the closing } of the function body. Ok for trunk? Johan -- AVR: Improve location o

Re: [PATCH] gcc: download_prerequisites: add --verbose and --no-verbose

2024-12-03 Thread Eric Gallager
On Tue, Dec 3, 2024 at 7:09 AM Tiezhu Yang wrote: > > When executing the script download_prerequisites, the download speed may > be extremely slow and there is no any output, the users do not know what > happened. > > Given the command wget and curl have options --verbose and --no-verbose, > add t

Re: [PATCH v3 1/7] middle-end: Handle resized PHI nodes in loop_version()

2024-12-03 Thread Lewis Hyatt
On Tue, Dec 03, 2024 at 01:28:28PM +0100, Richard Biener wrote: > On Mon, Dec 2, 2024 at 1:55 AM Lewis Hyatt wrote: > > > > This patch is my new way to handle what was previously done in v2 patch > > 04/14, discussed at: > > https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669527.html > > >

Re: [PATCH v3 5/7] Support for 64-bit location_t: Activate 64-bit location_t

2024-12-03 Thread Richard Biener
On Mon, Dec 2, 2024 at 1:50 AM Lewis Hyatt wrote: > > With the codebase having already been prepared to handle it, change > location_t to be a 64-bit integer instead of a 32-bit integer. OK if there's no comments from others within 48h. Thanks, Richard. > libcpp/ChangeLog: > > * include

[PATCH] aarch64: Update cpuinfo strings for some arch features

2024-12-03 Thread Kyrylo Tkachov
Hi all, The entries for some recently-added arch features were missing the cpuinfo string used in -march=native detection. Presumably the Linux kernel had not specified such a string at the time the GCC support was added. But I see that current versions of Linux do have strings for these features

Re: [PATCH v3 6/7] Support for 64-bit location_t: gimple parts

2024-12-03 Thread Richard Biener
On Mon, Dec 2, 2024 at 2:01 AM Lewis Hyatt wrote: > > This patch was previously discussed here: > https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669437.html > > This version addresses that feedback, and I have also moved it in the patch > ordering to be after the change to 64-bit location

Re: [PATCH v3 2/7] final: Fix call to INSN_LOCATION on a NOTE rtl

2024-12-03 Thread Richard Biener
On Mon, Dec 2, 2024 at 1:51 AM Lewis Hyatt wrote: > > This patch was previously discussed at: > https://gcc.gnu.org/pipermail/gcc-patches/2024-November/670354.html > > I have attempted to fix it per the feedback in the above thread. Note that > this version is a change in behavior. In my v2 patch,

Re: [PATCH v3 1/7] middle-end: Handle resized PHI nodes in loop_version()

2024-12-03 Thread Richard Biener
On Mon, Dec 2, 2024 at 1:55 AM Lewis Hyatt wrote: > > This patch is my new way to handle what was previously done in v2 patch > 04/14, discussed at: > https://gcc.gnu.org/pipermail/gcc-patches/2024-November/669527.html > > The only places I have found running into trouble with reallocated PHI node

  1   2   >