Re: [r12-3321 Regression] FAIL: gfortran.dg/PR100914.f90 -Os (test for excess errors) on Linux/x86_64

2021-09-02 Thread Sandra Loosemore
On 9/2/21 10:18 PM, sunil.k.pandey wrote: On Linux/x86_64, 93b6b2f614eb692d1d8126ec6cb946984a9d01d7 is the first bad commit commit 93b6b2f614eb692d1d8126ec6cb946984a9d01d7 Author: Sandra Loosemore Date: Wed Aug 18 07:22:03 2021 -0700 libgfortran: Further fixes for GFC/CFI descriptor con

[PATCH] Fix some GC issues in the aarch64 back-end.

2021-09-02 Thread apinski--- via Gcc-patches
From: Andrew Pinski I got some ICEs in my latest testsing while running the libstdc++ testsuite. I had noticed the problem was connected to types and had just touched the builtins code but nothing which could have caused this and I looked for some types/variables that were not being marked with G

[r12-3321 Regression] FAIL: gfortran.dg/PR100914.f90 -Os (test for excess errors) on Linux/x86_64

2021-09-02 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, 93b6b2f614eb692d1d8126ec6cb946984a9d01d7 is the first bad commit commit 93b6b2f614eb692d1d8126ec6cb946984a9d01d7 Author: Sandra Loosemore Date: Wed Aug 18 07:22:03 2021 -0700 libgfortran: Further fixes for GFC/CFI descriptor conversions. caused FAIL: gfortran.dg/PR100914

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Kewen.Lin via Gcc-patches
Hi Segher, Thanks for the comments! on 2021/9/3 上午1:44, Segher Boessenkool wrote: > Hi! > > On Wed, Sep 01, 2021 at 03:02:22PM +0800, Kewen.Lin wrote: >> It introduces two target hooks need_ipa_fn_target_info and >> update_ipa_fn_target_info. The former allows target to do >> some previous chec

Re: Ping ^ 2: [PATCH] rs6000: Expand fmod and remainder when built with fast-math [PR97142]

2021-09-02 Thread Xionghu Luo via Gcc-patches
Resend the patch that addressed Will's comments. fmod/fmodf and remainder/remainderf could be expanded instead of library call when fast-math build, which is much faster. fmodf: fdivs f0,f1,f2 frizf0,f0 fnmsubs f1,f2,f0,f1 remainderf: fdivs f0,f1,f2 frinf0,f

PING Re: [PATCH, Fortran] Revert to non-multilib-specific ISO_Fortran_binding.h

2021-09-02 Thread Sandra Loosemore
On 8/18/21 8:57 PM, Sandra Loosemore wrote: This is a follow-up to commit fef67987cf502fe322e92ddce22eea7ac46b4d75: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=fef67987cf502fe322e92ddce22eea7ac46b4d75 I realized last week that having multilib-specific versions of ISO_Fortran_binding.h (g

Re: [PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

2021-09-02 Thread YunQiang Su
YunQiang Su 于2021年9月3日周五 上午9:53写道: > > Maciej W. Rozycki 于2021年9月3日周五 上午9:48写道: > > > > On Thu, 2 Sep 2021, YunQiang Su wrote: > > > > > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c > > > index 493d3de48..743a1d0fe 100644 > > > --- a/gcc/config/mips/mips.c > > > +++ b/gcc/config/m

Re: [PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

2021-09-02 Thread YunQiang Su
Maciej W. Rozycki 于2021年9月3日周五 上午9:48写道: > > On Thu, 2 Sep 2021, YunQiang Su wrote: > > > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c > > index 493d3de48..743a1d0fe 100644 > > --- a/gcc/config/mips/mips.c > > +++ b/gcc/config/mips/mips.c > > @@ -9896,6 +9896,12 @@ mips_file_start

[PATCH] [aarch64] Fix target/95969: __builtin_aarch64_im_lane_boundsi interferes with gimple

2021-09-02 Thread apinski--- via Gcc-patches
From: Andrew Pinski This patch adds simple folding of __builtin_aarch64_im_lane_boundsi where we are not going to error out. It fixes the problem by the removal of the function from the IR. OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions. gcc/ChangeLog: * config/aa

Re: [PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

2021-09-02 Thread Maciej W. Rozycki
On Thu, 2 Sep 2021, YunQiang Su wrote: > diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c > index 493d3de48..743a1d0fe 100644 > --- a/gcc/config/mips/mips.c > +++ b/gcc/config/mips/mips.c > @@ -9896,6 +9896,12 @@ mips_file_start (void) >else > fputs ("\t.module\tnooddspreg\n",

[PATCH v3] MIPS: add .module mipsREV/.set arch= to all output asm file

2021-09-02 Thread YunQiang Su
Currently, the asm output file for MIPS has no rev info. It can make some trouble, for example: assembler is mips1 by default, gcc is fpxx by default. To assemble the output of gcc -S, we have to pass -mips2 to assembler. The same situation is for some CPU has extension insn. Octeon is an ex

[PATCH v2] c++: Fix cp_tree_equal for template value args using dependent sizeof/alignof/noexcept expressions

2021-09-02 Thread Barrett Adair via Gcc-patches
Thanks for the feedback, Jason. Coming back to this today, The problem appears much deeper than I realized. I've attached another WIP version of the patch, including a couple of new test cases based on your feedback (for now, please excuse any misformatted dg-error comments). The dependent-name16.

Re: [PATCH] warn for more impossible null pointer tests [PR102103]

2021-09-02 Thread Martin Sebor via Gcc-patches
Attached is an updated patch with Jason's suggested change to use handled_component_p(), retested on x86_64-linux and with Glibc. Adding more tests led to more changes but hopefully also a better end result. I've changed the warning suppression from a cast to void* to one to intptr_t, in part bec

Re: [PATCH] Jit, testsuite: Amend expect processing to tolerate more platforms.

2021-09-02 Thread Iain Sandoe
Hi David, > On 2 Sep 2021, at 15:47, David Malcolm wrote: > > On Thu, 2021-08-19 at 19:59 +0100, Iain Sandoe wrote: >> OK for master? > > Did you try this with RUN_UNDER_VALGRIND set? Assuming that that still > works, yes, looks good to me. For what configuration parameters is this expected

Sv: Sv: [PATCH] jit : Generate debug info for variables

2021-09-02 Thread Petter Tomner via Gcc-patches
Thanks for the review. I will post a revision to the mailing list. I have not filed a copyright assignment with the FSF, but if DCO is enough I'll add it. I also read the mail about the testcase of this patch. Regards, Petter -Ursprungligt meddelande- Från: David Malcolm Skickat: den 2

Re: [PATCH 2/8] coroutines: Add a helper for creating local vars.

2021-09-02 Thread Jason Merrill via Gcc-patches
On 9/1/21 6:53 AM, Iain Sandoe wrote: This is primarily code factoring, but we take this opportunity to rename some of the implementation variables (which we intend to expose to debugging) so that they are in the implementation namespace. Signed-off-by: Iain Sandoe gcc/cp/ChangeLog:

Re: [PATCH 1/8] coroutines : Use DECL_VALUE_EXPR instead of rewriting vars.

2021-09-02 Thread Jason Merrill via Gcc-patches
On 9/1/21 6:52 AM, Iain Sandoe wrote: Hi, Variables that need to persist over suspension expressions must be preserved by being copied into the coroutine frame. The initial implementations do this manually in the transform code. However, that has various disadvantages - including that the debu

Re: [PATCH] libstdc++: Define macro before it is first checked

2021-09-02 Thread Jonathan Wakely via Gcc-patches
On Thu, 2 Sept 2021 at 19:00, Jonathan Wakely wrote: > > * include/bits/atomic_wait.h (_GLIBCXX_HAVE_PLATFORM_WAIT): > Define before first attempt to check it. > > Tested x86_64-linux and powerpc64-linux, not committed yet. Actually ignore that ... I tested the wrong patch. This on

[PATCH] Fix target/102173 ICE after error recovery

2021-09-02 Thread apinski--- via Gcc-patches
From: Andrew Pinski After the recent r12-3278-823685221de986a change, the testcase gcc.target/aarch64/sve/acle/general-c/type_redef_1.c started to ICE as the code was not ready for error_mark_node in the type. This fixes that and the testcase now passes. gcc/ChangeLog: * config/aarch64

Re: [PATCH] c++: parameter pack inside constexpr if [PR101764]

2021-09-02 Thread Jason Merrill via Gcc-patches
On 8/30/21 10:05 PM, Patrick Palka wrote: Here when partially substituting into the pack expansion, substitution into the constexpr if yields a still-dependent tree, so tsubst_expr returns an IF_STMT with an unsubstituted IF_COND and with IF_STMT_EXTRA_ARGS added to. Hence after partial substitu

Re: [PATCH V3 0/6] Initial support for AVX512FP16

2021-09-02 Thread Joseph Myers
On Thu, 2 Sep 2021, Iain Sandoe via Gcc-patches wrote: > diff --git a/libgcc/soft-fp/eqdf2.c b/libgcc/soft-fp/eqdf2.c > index 2a44ee377ce..a3bb664f5f1 100644 > --- a/libgcc/soft-fp/eqdf2.c > +++ b/libgcc/soft-fp/eqdf2.c > @@ -28,6 +28,7 @@ > License along with the GNU C Library; if not, see >

Re: [PATCH V3 0/6] Initial support for AVX512FP16

2021-09-02 Thread Joseph Myers
One of the committed changes breaks the build of libgcc for 32-bit x86 configurations without SSE2 enabled by default: In file included from /scratch/jmyers/glibc-bot/src/gcc/libgcc/soft-fp/extendhfsf2.c:31: /scratch/jmyers/glibc-bot/src/gcc/libgcc/soft-fp/half.h:62:1: error: unable to emulate

[r12-3310 Regression] FAIL: gcc.dg/torture/fp-int-convert-float16-timode.c -Os execution test on Linux/x86_64

2021-09-02 Thread sunil.k.pandey via Gcc-patches
On Linux/x86_64, b387e664cfa4e9dd010a3f64d446308d6d84a5d2 is the first bad commit commit b387e664cfa4e9dd010a3f64d446308d6d84a5d2 Author: liuhongt Date: Mon Jul 5 17:31:46 2021 +0800 libgcc: Enable hfmode soft-sf/df/xf/tf extensions and truncations. caused FAIL: gcc.dg/torture/fp-int-con

Re: [PATCH, V2 2/3] targhooks: New target hook for CTF/BTF debug info emission

2021-09-02 Thread Indu Bhagat via Gcc-patches
On 8/26/21 11:12 PM, Richard Biener wrote: On Thu, Aug 26, 2021 at 8:55 PM Indu Bhagat wrote: On 8/26/21 3:03 AM, Richard Biener wrote: On Tue, Aug 24, 2021 at 7:07 PM Indu Bhagat wrote: On 8/18/21 12:00 AM, Richard Biener wrote: On Tue, Aug 17, 2021 at 7:26 PM Indu Bhagat wrote: On 8/

Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-02 Thread Thomas Schwinge
Hi! On 2021-09-02T15:59:14+0200, I wrote: > On 2016-08-05T14:16:58-0400, David Malcolm wrote: >> Committed to trunk as r239175; I'm attaching the final version of the >> patch for reference. > > David, you've added here 'gcc/input.h:struct location_hash' (see quoted > below), which will be useful

Re: [PATCH] c++: shortcut bad convs during overload resolution [PR101904]

2021-09-02 Thread Jason Merrill via Gcc-patches
On 8/31/21 3:15 PM, Patrick Palka wrote: On Mon, 30 Aug 2021, Patrick Palka wrote: In the context of overload resolution we have the notion of a "bad" argument conversion, which is a conversion that "would be a permitted with a bending of the language standards", and we handle such bad conversi

Re: [PATCH] Generate XXSPLTIDP on power10.

2021-09-02 Thread Segher Boessenkool
On Wed, Sep 01, 2021 at 04:22:13PM -0400, Michael Meissner wrote: > On Tue, Aug 31, 2021 at 06:41:30PM -0500, Segher Boessenkool wrote: > > Hi! > > > > Please do two separate patches. The first that adds the instruction > > (with a bit pattern, i.e. integer, input), and perhaps a second pattern >

Re: [PATCH] PR fortran/93834 - [9/10/11/12 Regression] ICE in trans_caf_is_present, at fortran/trans-intrinsic.c:8469

2021-09-02 Thread Harald Anlauf via Gcc-patches
Hi Tobias, > Consider: > > type t >integer, allocatable :: a > end type t > > type(t) :: var[*] > print *, allocated(var%a) > print *, allocated(var[1]%a) > end what is the problem here? Can you elaborate? BTW: Intel accepts it, we (currently) accept it, my patch does not change anything

Re: [PATCH] libstdc++: Define macro before it is first checked

2021-09-02 Thread Thomas Rodgers via Gcc-patches
Agreed. On Thu, Sep 2, 2021 at 10:58 AM Jonathan Wakely wrote: > Signed-off-by: Jonathan Wakely > > libstdc++-v3/ChangeLog: > > * include/bits/atomic_wait.h (_GLIBCXX_HAVE_PLATFORM_WAIT): > Define before first attempt to check it. > > Tested x86_64-linux and powerpc64-linux, not

[PATCH] libstdc++: Define macro before it is first checked

2021-09-02 Thread Jonathan Wakely via Gcc-patches
Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: * include/bits/atomic_wait.h (_GLIBCXX_HAVE_PLATFORM_WAIT): Define before first attempt to check it. Tested x86_64-linux and powerpc64-linux, not committed yet. I think we need this, otherwise __platform_wait_uses_type is f

Re: [PATCH 2/2] Get rid of all float-int special cases in validate_subreg.

2021-09-02 Thread Segher Boessenkool
On Tue, Aug 31, 2021 at 07:17:49PM +0800, liuhongt via Gcc-patches wrote: > * emit-rtl.c (validate_subreg): Get rid of all float-int > special cases. This caused various regressions on powerpc. Please revert this until this can be done safely (the comment this patch deletes says why i

Re: [PATCH] Check the type of mask while generating cond_op in gimple simplication.

2021-09-02 Thread Richard Sandiford via Gcc-patches
Hongtao Liu via Gcc-patches writes: > On Wed, Sep 1, 2021 at 8:52 PM Richard Sandiford > wrote: >> >> Richard Biener writes: >> > On Wed, Sep 1, 2021 at 8:28 AM Hongtao Liu wrote: >> >> >> >> On Tue, Aug 31, 2021 at 7:56 PM Richard Biener >> >> wrote: >> >> > >> >> > On Tue, Aug 31, 2021 at 12

[committed] libstdc++: Implement std::atomic::compare_exchange_weak

2021-09-02 Thread Jonathan Wakely via Gcc-patches
For some reason r170217 didn't add compare_exchange_weak to the __atomic_base partial specialization, and so weak compare exchange operations on pointers use compare_exchange_strong instead. This adds __atomic_base::compare_exchange_weak and then uses it in std::atomic::compare_exchange_weak. Sig

[committed] libstdc++: Tweak whitespace in

2021-09-02 Thread Jonathan Wakely via Gcc-patches
Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: * include/std/atomic: Tweak whitespace. Tested x86_64-linux. Committed to trunk. commit 892400f1f21ccee98dddcd90677038ce266248c8 Author: Jonathan Wakely Date: Thu Sep 2 16:08:25 2021 libstdc++: Tweak whitespace in

[committed] libstdc++: Remove "no stronger" assertion in compare exchange [PR102177]

2021-09-02 Thread Jonathan Wakely via Gcc-patches
P0418R2 removed some preconditions from std::atomic::compare_exchange_* but we still enforce them via __glibcxx_assert. This removes those assertions. Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: PR c++/102177 * include/bits/atomic_base.h (__is_valid_cmpexch_failure_or

[committed] libstdc++: Define std::invoke_r for C++23 (P2136R3)

2021-09-02 Thread Jonathan Wakely via Gcc-patches
We already supported this feature as std::__invoke, for internal use. This just adds a public version of it to . Internal uses should continue to include and use std::__invoke so that they don't need to include all of . Signed-off-by: Jonathan Wakely libstdc++-v3/ChangeLog: * include/

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Segher Boessenkool
Hi! On Wed, Sep 01, 2021 at 03:02:22PM +0800, Kewen.Lin wrote: > It introduces two target hooks need_ipa_fn_target_info and > update_ipa_fn_target_info. The former allows target to do > some previous check and decides to collect target specific > information for this function or not. For some sp

Re: [patch][version 6] add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-09-02 Thread Qing Zhao via Gcc-patches
Sorry for my late reply (I just came back from vacation last night). > On Aug 23, 2021, at 8:55 AM, Richard Biener wrote: > Looks like for the following code: 3026 if (!reg_lhs) 3027 { 3028 /* If this is a VLA or the variable is not in register, >>

Re: [PATCH] tree-optimization/102176 - locally compute participating SLP stmts

2021-09-02 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > This performs local re-computation of participating scalar stmts > in BB vectorization subgraphs to allow precise computation of > liveness of scalar stmts after vectorization and thus precise > costing. This treats all extern defs as live but continues > to optimisticall

Re: [PATCH v2] [MIPS]: add .module mipsREV to all output asm file

2021-09-02 Thread Jeff Law via Gcc-patches
On 8/28/2021 1:08 AM, Xi Ruoyao wrote: On Fri, 2021-08-27 at 15:36 -0600, Jeff Law wrote: It's easier when someone has to debug the code later. enums show up in debug output by default, while #defines do not. switch (mips_isa)    { case MIPS_ISA_MIPS1: return "mips1"; // ...  

Re: [PATCH V3 0/6] Initial support for AVX512FP16

2021-09-02 Thread Iain Sandoe via Gcc-patches
Patch below fixes bootstrap, OK if it passes testing on x86_64 darwin/linux? (if !OK .. then suggestions welcome) thanks Iain > On 2 Sep 2021, at 16:18, Hongtao Liu wrote: > > > > On Thursday, September 2, 2021, Iain Sandoe wrote: > Hi Hongtao. > > > On 2 Sep 2021, at 07:06, Hongtao Liu vi

Re: [PATCH] introduce predicate analysis class

2021-09-02 Thread Jeff Law via Gcc-patches
On 8/30/2021 2:03 PM, Martin Sebor via Gcc-patches wrote: The predicate analysis subset of the tree-ssa-uninit pass isn't necessarily specific to the detection of uninitialized reads. Suitably parameterized, the same core logic could be used in other warning passes to improve their S/N ratio,

[PATCH v2 0/4] libffi: Sync with upstream

2021-09-02 Thread H.J. Lu via Gcc-patches
Change in the v2 patch: 1. Disable static trampolines by default. GCC maintained a copy of libffi snapshot from 2009 and cherry-picked fixes from upstream over the last 10+ years. In the meantime, libffi upstream has been changed significantly with new features, bug fixes and new target suppor

[PATCH v2 2/4] libffi: Sync with libffi 3.4.2

2021-09-02 Thread H.J. Lu via Gcc-patches
Merged commit: f9ea41683444ebe11cfa45b05223899764df28fb --- libffi/.gitattributes | 4 + libffi/ChangeLog.libffi | 7743 +- libffi/LICENSE| 2 +- libffi/LICENSE-BUILDTOOLS | 353 + libf

[PATCH v2 3/4] libffi: Integrate build with GCC

2021-09-02 Thread H.J. Lu via Gcc-patches
1. Integrate with GCC build. 2. Disable static trampolines by default. 3. Support multilib. * Makefile.am (AUTOMAKE_OPTIONS): Add info-in-builddir. (ACLOCAL_AMFLAGS): Set to -I .. -I ../config. (SUBDIRS): Don't add doc. (TEXINFO_TEX): New. (MAKEINFOFLAGS): L

[PATCH v2 1/4] libffi: Add HOWTO_MERGE, autogen.sh and merge.sh

2021-09-02 Thread H.J. Lu via Gcc-patches
Add scripts for syncing with libffi upstream: 1. Clone libffi repo. 2. Checkout the specific commit. 3. Remove the unused files. 4. Add new files and remove old files if needed. * HOWTO_MERGE: New file. * autogen.sh: Likewise. * merge.sh: Likewise. --- libffi/HOWTO_MERGE

[PATCH v2 4/4] libffi: Integrate testsuite with GCC testsuite

2021-09-02 Thread H.J. Lu via Gcc-patches
* testsuite/lib/libffi.exp (load_gcc_lib): Load library from GCC testsuite. Load target-supports.exp and target-supports-dg.exp. (libffi-init): Use libraries in GCC build tree. (libffi_target_compile): Link with -lstdc++ for C++ sources. --- libffi/testsuite

Re: [PATCH V3 0/6] Initial support for AVX512FP16

2021-09-02 Thread Hongtao Liu via Gcc-patches
On Thursday, September 2, 2021, H.J. Lu wrote: > On Wed, Sep 1, 2021 at 11:00 PM Hongtao Liu wrote: > > > > I'm going to check in the first 3 patches which are already approved. > > > > Update hf soft-fp from glibc. > > [i386] Enable _Float16 type for TARGET_SSE2 and above. > > [i386] libg

Re: [PATCH] c++, abi: Set DECL_FIELD_ABI_IGNORED on C++ zero width bitfields [PR102024]

2021-09-02 Thread Jason Merrill via Gcc-patches
On 9/2/21 4:49 AM, Jakub Jelinek wrote: On Thu, Sep 02, 2021 at 12:19:03AM +0200, Jakub Jelinek via Gcc-patches wrote: Ah, thanks for the archeology. So it indeed seems like in theory an ABI change between GCC 3.4 and 4.0 for C then on some of the targets like x86_64 which already existed in 3.

Re: [PATCH] Run pass_sink_code once more before store_mergin

2021-09-02 Thread Martin Jambor
Hi, On Tue, May 18 2021, Xionghu Luo via Gcc-patches wrote: > [...] > From 7fcc6ca9ef3b6acbfbcbd3da4be1d1c0eef4be80 Mon Sep 17 00:00:00 2001 > From: Xiong Hu Luo > Date: Mon, 17 May 2021 20:46:15 -0500 > Subject: [PATCH] Run pass_sink_code once more before store_merging > > Gimple sink code pas

Re: [PATCH V3 0/6] Initial support for AVX512FP16

2021-09-02 Thread H.J. Lu via Gcc-patches
On Wed, Sep 1, 2021 at 11:00 PM Hongtao Liu wrote: > > I'm going to check in the first 3 patches which are already approved. > > Update hf soft-fp from glibc. > [i386] Enable _Float16 type for TARGET_SSE2 and above. > [i386] libgcc: Enable hfmode soft-sf/df/xf/tf extensions and > truncat

Re: [PATCH] improve note location and refactor warn_uninit

2021-09-02 Thread Martin Sebor via Gcc-patches
On 8/27/21 5:23 PM, Jeff Law wrote: On 8/26/2021 1:30 PM, Martin Sebor via Gcc-patches wrote: On 8/26/21 10:38 AM, Martin Sebor wrote: On 8/26/21 1:00 AM, Richard Biener wrote: On Wed, Aug 25, 2021 at 10:03 PM Martin Sebor wrote: Richard, some time ago you mentioned you'd had trouble gett

Re: Sv: [PATCH] jit : Generate debug info for variables

2021-09-02 Thread David Malcolm via Gcc-patches
On Tue, 2021-08-31 at 00:23 +, Petter Tomner via Gcc-patches wrote: > Well I seemed to have attached the wrong testcase. Here is the proper > one attached. > > Regards, > > -Ursprungligt meddelande- > Från: Petter Tomner > Skickat: den 31 augusti 2021 02:14 > Till: gcc-patches@gcc.gn

[PATCH V3 0/6] Initial support for AVX512FP16

2021-09-02 Thread Hongtao Liu via Gcc-patches
On Thursday, September 2, 2021, Iain Sandoe wrote: > Hi Hongtao. > > > On 2 Sep 2021, at 07:06, Hongtao Liu via Gcc-patches < > gcc-patches@gcc.gnu.org> wrote: > > > > I'm going to check in the first 3 patches which are already approved. > > > > Update hf soft-fp from glibc. > > [i386] Enable _

Re: [PATCH] jit : Generate debug info for variables

2021-09-02 Thread David Malcolm via Gcc-patches
On Tue, 2021-08-31 at 00:13 +, Petter Tomner via Gcc-patches wrote: > Hi, > > This is a patch to generate debug info for local variables as well as > globals. > With this, "ptype foo", "info variables", "info locals" etc works > when debugging in GDB. > > Finalizing of global variable declar

Re: [PATCH] Jit, testsuite: Amend expect processing to tolerate more platforms.

2021-09-02 Thread David Malcolm via Gcc-patches
On Thu, 2021-08-19 at 19:59 +0100, Iain Sandoe wrote: > Hi, > > Preface: > > this is the last patch for now in my series - with this applied > Darwin > reports the same results as Linux (at least, for modern x86_64 > platform versions). > > Note > a)  that the expect expression in {fixed}host_ex

Re: [PATCH RFA] tree: Change error_operand_p to an inline function

2021-09-02 Thread Marek Polacek via Gcc-patches
On Thu, Sep 02, 2021 at 10:41:52AM -0400, Jason Merrill via Gcc-patches wrote: > I've thought for a while that many of the macros in tree.h and such should > become inline functions. This one in particular was confusing Coverity; the > null check in the macro made it think that all code guarded by

[PATCH RFA] tree: Change error_operand_p to an inline function

2021-09-02 Thread Jason Merrill via Gcc-patches
I've thought for a while that many of the macros in tree.h and such should become inline functions. This one in particular was confusing Coverity; the null check in the macro made it think that all code guarded by error_operand_p would also need null checks. Tested x86_64-pc-linux-gnu. OK for tr

Re: [PATCH] warn for more impossible null pointer tests

2021-09-02 Thread Martin Sebor via Gcc-patches
On 9/2/21 7:43 AM, Jason Merrill wrote: On 9/1/21 6:27 PM, Martin Sebor wrote: On 9/1/21 3:39 PM, Jason Merrill wrote: On 9/1/21 4:33 PM, Martin Sebor wrote: On 9/1/21 1:21 PM, Jason Merrill wrote: On 8/31/21 10:08 PM, Martin Sebor wrote: A Coverity run recently uncovered a latent bug in GCC

Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-02 Thread Thomas Schwinge
Hi! On 2016-08-05T14:16:58-0400, David Malcolm wrote: > Committed to trunk as r239175; I'm attaching the final version of the > patch for reference. David, you've added here 'gcc/input.h:struct location_hash' (see quoted below), which will be useful elsewhere, so: > --- a/gcc/input.c > +++ b/gc

Re: [PATCH] warn for more impossible null pointer tests

2021-09-02 Thread Jason Merrill via Gcc-patches
On 9/1/21 6:27 PM, Martin Sebor wrote: On 9/1/21 3:39 PM, Jason Merrill wrote: On 9/1/21 4:33 PM, Martin Sebor wrote: On 9/1/21 1:21 PM, Jason Merrill wrote: On 8/31/21 10:08 PM, Martin Sebor wrote: A Coverity run recently uncovered a latent bug in GCC that GCC should be able to detect itself

[PATCH] tree-optimization/102176 - locally compute participating SLP stmts

2021-09-02 Thread Richard Biener via Gcc-patches
This performs local re-computation of participating scalar stmts in BB vectorization subgraphs to allow precise computation of liveness of scalar stmts after vectorization and thus precise costing. This treats all extern defs as live but continues to optimistically handle scalar defs that we think

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, Sep 2, 2021 at 3:11 PM Kewen.Lin wrote: > > on 2021/9/2 下午7:51, Richard Biener wrote: > > On Thu, Sep 2, 2021 at 1:13 PM Kewen.Lin wrote: > >> > >> Hi Richi, > >> > >> Thanks for the comments! > >> > >> on 2021/9/2 下午5:25, Richard Biener wrote: > >>> On Wed, Sep 1, 2021 at 9:02 AM Kewen.L

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Kewen.Lin via Gcc-patches
on 2021/9/2 下午7:51, Richard Biener wrote: > On Thu, Sep 2, 2021 at 1:13 PM Kewen.Lin wrote: >> >> Hi Richi, >> >> Thanks for the comments! >> >> on 2021/9/2 下午5:25, Richard Biener wrote: >>> On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: Hi! Power ISA 2.07 (Power8) introduces

[PATCH V2] Set bound/cmp/control for until wrap loop.

2021-09-02 Thread Jiufu Guo via Gcc-patches
Changes on V1: * Add more test case * Add comment for exit-condition transform * Removing duplicate setting on niter->control This patch reset niter->control, niter->bound and niter->cmp in number_of_iterations_until_wrap. Bootstrap and test pass on ppc64 and x86, and pass the test cases in PR.

Re: [PATCH]AArch64 RFC: Don't cost all scalar operations during vectorization if scalar will fuse

2021-09-02 Thread Richard Biener via Gcc-patches
On Wed, Sep 1, 2021 at 3:47 PM Richard Biener wrote: > > On Tue, Aug 31, 2021 at 4:50 PM Richard Sandiford via Gcc-patches > wrote: > > > > Tamar Christina writes: > > > Hi All, > > > > > > As the vectorizer has improved over time in capabilities it has started > > > over-vectorizing. This has

Re: [Patch v2] C, C++, Fortran, OpenMP: Add support for device-modifiers for 'omp target device'

2021-09-02 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 02, 2021 at 02:09:25PM +0200, Marcel Vollweiler wrote: > gcc/testsuite/ChangeLog: > > * gfortran.dg/gomp/target-device-ancestor-4.f90: Comment out dg-final > to avoid >UNRESOLVED. Ok, thanks. > > diff --git a/gcc/testsuite/gfortran.dg/gomp/target-device-ancestor-4.f90

Re: [Patch v2] C, C++, Fortran, OpenMP: Add support for device-modifiers for 'omp target device'

2021-09-02 Thread Marcel Vollweiler
Am 01.09.2021 um 11:02 schrieb Jakub Jelinek: On Wed, Sep 01, 2021 at 09:06:31AM +0200, Christophe Lyon wrote: * gfortran.dg/gomp/target-device-ancestor-4.f90: New test. The last new test fails on aarch64: /gcc/testsuite/gfortran.dg/gomp/target-device-ancestor-4.f90:7:15: Error: S

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, Sep 2, 2021 at 1:13 PM Kewen.Lin wrote: > > Hi Richi, > > Thanks for the comments! > > on 2021/9/2 下午5:25, Richard Biener wrote: > > On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: > >> > >> Hi! > >> > >> Power ISA 2.07 (Power8) introduces transactional memory feature > >> but ISA3.1 (Pow

Re: [PATCH] avoid transform at run until wrap comparesion

2021-09-02 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Thu, 2 Sep 2021, Jiufu Guo wrote: > >> When transform >> {iv0.base, iv0.step} LT/LE {iv1.base, iv1.step} >> to >> {iv0.base, iv0.step - iv1.step} LT/LE {iv1.base, 0} >> >> There would be error if 'iv0.step - iv1.step' in negative, >> for which means run until wrap

Re: [PATCH V3 0/6] Initial support for AVX512FP16

2021-09-02 Thread Iain Sandoe via Gcc-patches
Hi Hongtao. > On 2 Sep 2021, at 07:06, Hongtao Liu via Gcc-patches > wrote: > > I'm going to check in the first 3 patches which are already approved. > > Update hf soft-fp from glibc. > [i386] Enable _Float16 type for TARGET_SSE2 and above. > [i386] libgcc: Enable hfmode soft-sf/df/xf/tf ex

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Kewen.Lin via Gcc-patches
Hi Richi, Thanks for the comments! on 2021/9/2 下午5:25, Richard Biener wrote: > On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: >> >> Hi! >> >> Power ISA 2.07 (Power8) introduces transactional memory feature >> but ISA3.1 (Power10) removes it. It exposes one troublesome >> issue as PR102059 show

Re: [PATCH] avoid transform at run until wrap comparesion

2021-09-02 Thread Bin.Cheng via Gcc-patches
On Thu, Sep 2, 2021 at 6:18 PM Richard Biener wrote: > > On Thu, 2 Sep 2021, Jiufu Guo wrote: > > > When transform > > {iv0.base, iv0.step} LT/LE {iv1.base, iv1.step} > > to > > {iv0.base, iv0.step - iv1.step} LT/LE {iv1.base, 0} > > > > There would be error if 'iv0.step - iv1.step' in negativ

Re: [PATCH] tree-optimization/102155 - fix LIM fill_always_executed_in CFG walk

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, 2 Sep 2021, Xionghu Luo wrote: > > > On 2021/9/2 16:50, Richard Biener wrote: > > On Thu, 2 Sep 2021, Richard Biener wrote: > > > >> On Thu, 2 Sep 2021, Xionghu Luo wrote: > >> > >>> > >>> > >>> On 2021/9/1 17:58, Richard Biener wrote: > This fixes the CFG walk order of fill_always

Re: [PATCH] PR fortran/93834 - [9/10/11/12 Regression] ICE in trans_caf_is_present, at fortran/trans-intrinsic.c:8469

2021-09-02 Thread Tobias Burnus
Hi Harald, On 24.08.21 22:36, Harald Anlauf via Fortran wrote: here's a pretty obvious one: we didn't properly check the arguments for intrinsics when these had to be ALLOCATABLE and in the case that argument was a coarray object. Simple solution: just reuse a check that was used for pointer et

Re: [PATCH] avoid transform at run until wrap comparesion

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, 2 Sep 2021, Jiufu Guo wrote: > When transform > {iv0.base, iv0.step} LT/LE {iv1.base, iv1.step} > to > {iv0.base, iv0.step - iv1.step} LT/LE {iv1.base, 0} > > There would be error if 'iv0.step - iv1.step' in negative, > for which means run until wrap/overflow. > > For example: >{

Re: [PATCH] tree-optimization/102155 - fix LIM fill_always_executed_in CFG walk

2021-09-02 Thread Xionghu Luo via Gcc-patches
On 2021/9/2 16:50, Richard Biener wrote: > On Thu, 2 Sep 2021, Richard Biener wrote: > >> On Thu, 2 Sep 2021, Xionghu Luo wrote: >> >>> >>> >>> On 2021/9/1 17:58, Richard Biener wrote: This fixes the CFG walk order of fill_always_executed_in to use RPO oder rather than the dominator b

[PATCH] avoid transform at run until wrap comparesion

2021-09-02 Thread Jiufu Guo via Gcc-patches
When transform {iv0.base, iv0.step} LT/LE {iv1.base, iv1.step} to {iv0.base, iv0.step - iv1.step} LT/LE {iv1.base, 0} There would be error if 'iv0.step - iv1.step' in negative, for which means run until wrap/overflow. For example: {1, +, 1} <= {4, +, 3} => {1, +, -2} <= {4, +, 0} This pat

[PATCH] Refine fix for PR78185, improve LIM for code after inner loops

2021-09-02 Thread Richard Biener via Gcc-patches
This refines the fix for PR78185 after understanding that the code regarding to the comment 'In a loop that is always entered we may proceed anyway. But record that we entered it and stop once we leave it.' was supposed to protect us from leaving possibly infinite inner loops. The simpler fix of

Re: [RFC/PATCH] ipa-inline: Add target info into fn summary [PR102059]

2021-09-02 Thread Richard Biener via Gcc-patches
On Wed, Sep 1, 2021 at 9:02 AM Kewen.Lin wrote: > > Hi! > > Power ISA 2.07 (Power8) introduces transactional memory feature > but ISA3.1 (Power10) removes it. It exposes one troublesome > issue as PR102059 shows. Users define some function with > target pragma cpu=power10 then it calls one funct

Re: [PATCH] Set bound/cmp/control for until wrap loop.

2021-09-02 Thread Jiufu Guo via Gcc-patches
Richard Biener writes: > On Tue, 31 Aug 2021, guojiufu wrote: > >> On 2021-08-30 20:02, Richard Biener wrote: >> > On Mon, 30 Aug 2021, guojiufu wrote: >> > >> >> On 2021-08-30 14:15, Jiufu Guo wrote: >> >> > Hi, >> >> > >> >> > In patch r12-3136, niter->control, niter->bound and niter->cmp are

Re: [ARM] PR66791: Replace builtins for vdup_n and vmov_n intrinsics

2021-09-02 Thread Christophe Lyon via Gcc-patches
On Tue, Aug 24, 2021 at 10:17 AM Kyrylo Tkachov wrote: > > > > -Original Message- > > From: Prathamesh Kulkarni > > Sent: 24 August 2021 09:01 > > To: Christophe Lyon > > Cc: Kyrylo Tkachov ; gcc Patches > patc...@gcc.gnu.org> > > Subject: Re: [ARM] PR66791: Replace builtins for vdup_n

Re: [PATCH] tree-optimization/102155 - fix LIM fill_always_executed_in CFG walk

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, 2 Sep 2021, Richard Biener wrote: > On Thu, 2 Sep 2021, Xionghu Luo wrote: > > > > > > > On 2021/9/1 17:58, Richard Biener wrote: > > > This fixes the CFG walk order of fill_always_executed_in to use > > > RPO oder rather than the dominator based order computed by > > > get_loop_body_in

Re: [PATCH] c++, abi: Set DECL_FIELD_ABI_IGNORED on C++ zero width bitfields [PR102024]

2021-09-02 Thread Jakub Jelinek via Gcc-patches
On Thu, Sep 02, 2021 at 12:19:03AM +0200, Jakub Jelinek via Gcc-patches wrote: > Ah, thanks for the archeology. So it indeed seems like in theory an ABI > change > between GCC 3.4 and 4.0 for C then on some of the targets like x86_64 which > already existed in 3.2-ish era. I actually couldn't se

Re: [PATCH v3] md/define_c_enum: support value assignation

2021-09-02 Thread YunQiang Su
Andrew Pinski via Gcc-patches 于2021年9月2日周四 上午5:28写道: > > On Tue, Aug 31, 2021 at 4:22 AM YunQiang Su wrote: > > > > Currently, the enums from define_c_enum and define_enum can only > > has values one by one from 0. > > > > In fact we can support the behaviour just like C, aka like > > (define_e

Re: [PATCH] tree-optimization/102155 - fix LIM fill_always_executed_in CFG walk

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, 2 Sep 2021, Xionghu Luo wrote: > > > On 2021/9/1 17:58, Richard Biener wrote: > > This fixes the CFG walk order of fill_always_executed_in to use > > RPO oder rather than the dominator based order computed by > > get_loop_body_in_dom_order. That fixes correctness issues with > > unorder

Re: [PATCH] match.pd: Demote IFN_{ADD,SUB,MUL}_OVERFLOW operands [PR99591]

2021-09-02 Thread Richard Biener via Gcc-patches
On Thu, 2 Sep 2021, Jakub Jelinek wrote: > Hi! > > The overflow builtins work on infinite precision integers and then convert > to the result type's precision, so any argument promotions are useless. > The expand_arith_overflow expansion is able to demote the arguments itself > through get_range_

[PATCH] match.pd: Demote IFN_{ADD,SUB,MUL}_OVERFLOW operands [PR99591]

2021-09-02 Thread Jakub Jelinek via Gcc-patches
Hi! The overflow builtins work on infinite precision integers and then convert to the result type's precision, so any argument promotions are useless. The expand_arith_overflow expansion is able to demote the arguments itself through get_range_pos_neg and get_min_precision calls and if needed prom

Re: DWARF for extern variable

2021-09-02 Thread Richard Biener via Gcc-patches
On Wed, Sep 1, 2021 at 7:25 PM Indu Bhagat wrote: > > On 8/24/21 12:55 AM, Richard Biener wrote: > > On Mon, Aug 23, 2021 at 11:18 PM Indu Bhagat via Gcc-patches > > wrote: > >> > >> Hello, > >> > >> What is the expected DWARF for extern variable in the following cases? I > >> am seeing that the